summaryrefslogtreecommitdiffstats
path: root/sandbox
Commit message (Collapse)AuthorAgeFilesLines
* Linux sandbox: Deprecate compatibility APIjln@chromium.org2013-12-102-13/+0
| | | | | | | | | | | | Now that all BPF policies are migrated, remove stubs of old API. BUG=325535 NOTRY=true R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/108563007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239909 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Sandbox: check no threads before fork().jln@chromium.org2013-12-102-0/+6
| | | | | | | | | | | Always check that no threads are running before fork(). BUG=327241 NOTRY=true Review URL: https://codereview.chromium.org/108173008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239894 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: cleanup sandbox-bpf naming.jln@chromium.org2013-12-1032-314/+299
| | | | | | | | | | | | | | | | | 1. Rename playground2 namespace to sandbox. The playground2 namespace is confusing and against the style guide. We rename it to sandbox, like the rest of sandbox/linux/. 2. Rename the "Sandbox" class to "SandboxBPF". BUG=325535 R=rsesek@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/101773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239865 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Sandbox: move NaCl to new BPF policy format.jln@chromium.org2013-12-103-28/+3
| | | | | | | | | | | Migrate NaCl to the new BPF policies format. BUG=325535, 267179 R=mseaborn@chromium.org, piman@chromium.org, rsesek@chromium.org Review URL: https://codereview.chromium.org/110833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239650 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: migrate policies to new format.jln@chromium.org2013-12-095-138/+382
| | | | | | | | | | | | | | | | | | | | | | | | | | | seccomp-bpf policies are now the implementation of the interface that lives in sandbox/linux/seccomp-bpf/sandbox_bpf_policy.h Sandbox policies inside content/ will all derive from the SandboxBpfBasePolicy (sandbox_bpf_base_policy.h) class. We can now rely on real C++ inheritance to implement our policy hierarchy. This is a first CL, part of a larger refactor. It should help minmize the risk of error and facilitate review by keeping the general layout of the code similar. In upcoming changes, we will: 1. Migrate NaCl and get rid of the compatibility / deprecated interfaces. 2. Extend the interface of SandboxBpfBasePolicy to be compatible with starting a GPU sandbox and reflect all the steps. 3. Move all the policies to directories such as renderer/ and gpu/ and each policy class will be able to live in its own file. BUG=325535 R=creis@chromium.org, jorgelo@chromium.org, mseaborn@chromium.org, rsesek@chromium.org Review URL: https://codereview.chromium.org/105673005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239550 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://chromiumcodereview.appspot.com/103293003/jln@chromium.org2013-12-064-5/+23
| | | | | | | | | | | | Reason for revert: http://goo.gl/3ufXOJ TBR=rsesek@chromium.org,willchan@chromium.org,darin@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/108013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239153 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239102 "Move build/build_config_functions.h to sandbox/"rlarocque@chromium.org2013-12-063-89/+3
| | | | | | | | | | | | | | | | | > Move build/build_config_functions.h to sandbox/ > > There is not much support for build/build_config_functions.h, > as highlighted in http://goo.gl/3ufXOJ. Move it away. > > R=jww@chromium.org > > Review URL: https://codereview.chromium.org/106163008 TBR=jln@chromium.org Review URL: https://codereview.chromium.org/107643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239105 0039d316-1c4b-4281-b951-d872f2087c98
* Move build/build_config_functions.h to sandbox/jln@chromium.org2013-12-063-3/+89
| | | | | | | | | | | There is not much support for build/build_config_functions.h, as highlighted in http://goo.gl/3ufXOJ. Move it away. R=jww@chromium.org Review URL: https://codereview.chromium.org/106163008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239102 0039d316-1c4b-4281-b951-d872f2087c98
* Add build_config_functions.h to avoid #ifdefjln@chromium.org2013-12-064-23/+5
| | | | | | | | | | | | | | | | | | An "#ifdef" statement is more confusing than using C++ syntax and "if (XXX)". They should be used only when strictly necessary (i.e. when code cannot compile). For the cases where #ifdef are not strictly necessary, these new helpers can be used. Thanks to compiler optimization, the final compiled code will be the same when these helpers are used instead of #ifdef. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/103293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239079 0039d316-1c4b-4281-b951-d872f2087c98
* Move more helpers to seccomp-bpf-helpers.jln@chromium.org2013-12-056-3/+477
| | | | | | | | | | | | | Extract more code from content/common/sandbox_seccomp_bpf_linux.cc and move it to sandbox/linux/seccomp-bpf-helpers/ BUG=325535 NOTRY=true R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/98373007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238994 0039d316-1c4b-4281-b951-d872f2087c98
* Add "cc" to inline asm clobber list.eugenis@chromium.org2013-12-051-3/+3
| | | | | | | | | | | | SyscallAsm() clobbers the flags register. BUG=325707 TEST=sandbox_linux_unittests on Android with AddressSanitizer R=markus@chromium.org Review URL: https://codereview.chromium.org/104613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238944 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: move system call sets to sandbox/jln@chromium.org2013-12-053-0/+1094
| | | | | | | | | | | | | Extract system call sets from content/ and move them to sandbox. This is a re-land of https://codereview.chromium.org/103323003/. BUG=325535 TBR=jorgelo@chromium.org Review URL: https://codereview.chromium.org/105913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238842 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/103323003/robliao@chromium.org2013-12-043-1092/+0
| | | | | | | | | | | | Reason for revert: Breaking ChromiumOS Build TBR=jorgelo@chromium.org,jln@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/105503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238781 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: move system call sets to sandbox/jln@chromium.org2013-12-043-0/+1092
| | | | | | | | | | | Extract system call sets from content/ and move them to sandbox. BUG=325535 R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/103323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238742 0039d316-1c4b-4281-b951-d872f2087c98
* Restructure sandbox code to reduce dependencies pulled in by intercept code.robertshield@chromium.org2013-12-0415-36/+101
| | | | | | | | | BUG=322710 TEST=NONE Review URL: https://codereview.chromium.org/84063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238538 0039d316-1c4b-4281-b951-d872f2087c98
* Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.mark@chromium.org2013-12-037-27/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is generally undefined on Mac, but as of r223369, it is incorrect in Chrome on Mac. To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not used with close, and that IGNORE_EINTR is only used with close. Unnecessary #includes of eintr_wrapper.h are also removed. base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc contain non-mechanical changes. Variable naming within the latter is updated per r178174. Missing #includes for <errno.h> in content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were manually added. Mechanical changes were generated by running: sed -E -i '' \ -e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \ -e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \ -e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \ $(git grep -El 'HANDLE_EINTR.*close') sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \ $(grep -EL '(HANDLE|IGNORE)_EINTR' \ $(git grep -El '#include.*eintr_wrapper\.h"')) BUG=269623 R=agl@chromium.org, jln@chromium.org TBR=OWNERS Review URL: https://codereview.chromium.org/100253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
* DPCHECK known conditions when we guess false in CurrentProcessHasOpenDirectoriesmostynb@opera.com2013-11-281-2/+8
| | | | | | | | | | | | | | | openat(AT_FDCWD, "/proc/self/fd", ...) can fail if we have been chrooted (eg into /proc/self/fdinfo) without directory listing permissions on the new root dir (hence EACCES). And even if we did have this permission, /proc wouldn't exist (hence ENOENT). TEST=Make a debug build or a release build with dcheck_always_on=1 and verify that this DPCHECK does not fail. BUG=314985 Review URL: https://codereview.chromium.org/59763014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237766 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: init_process_reaper comment cleanup.jln@chromium.org2013-11-281-7/+5
| | | | | | | | | | Cleanup a few comments in init_process_reaper.cc BUG=312380 Review URL: https://codereview.chromium.org/92963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237723 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Remove Receive() from ScopedHandle.rvargas@chromium.org2013-11-286-23/+37
| | | | | | | | | | | | | | | | | | In general, the OS API contract doesn't guarantee that output variables are not modified on failure, so a Reeceive pattern is fundamentally insecure. BUG=318531 TEST=current tests tbr'ing owners for the consumers. TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237459 Review URL: https://codereview.chromium.org/71013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237675 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/71013004/hashimoto@chromium.org2013-11-276-37/+23
| | | | | | | | | | | | Reason for revert: Causing compile failure in chrome_util.cc on "Google Chrome Win" http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/21803 TBR=cpu@chromium.org,jvoung@chromium.org,thakis@chromium.org,sergeyu@chromium.org,grt@chromium.org,gene@chromium.org,youngki@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/90963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237541 0039d316-1c4b-4281-b951-d872f2087c98
* Extract CreateInitProcessReaper() from the Zygote.jln@chromium.org2013-11-275-0/+141
| | | | | | | | | | | | | | | CreateInitProcessReaper() is useful for the CLONE_NEWUSER-based sandbox as well as for the current Zygote. Extract it so that it can be used independantly of content/. CreateInitProcessReaper() is now exposed to content through the setuid sandbox client. BUG=312380 Review URL: https://codereview.chromium.org/90243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237518 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Remove Receive() from ScopedHandle.rvargas@chromium.org2013-11-276-23/+37
| | | | | | | | | | | | | | | | In general, the OS API contract doesn't guarantee that output variables are not modified on failure, so a Reeceive pattern is fundamentally insecure. BUG=318531 TEST=current tests tbr'ing owners for the consumers. TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org Review URL: https://codereview.chromium.org/71013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237459 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: move CurrentProcessHasOpenDirectoriesjln@chromium.org2013-11-263-3/+121
| | | | | | | | | | | | | | | Move CurrentProcessHasOpenDirectories() to the Credentials class and rename it to HasOpenDirectory(). Also add some unittests. This is a re-land of https://codereview.chromium.org/85403011/. BUG=312380 R=jorgelo@chromium.org, mmoss@google.com Review URL: https://codereview.chromium.org/88243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 237242 "Linux sandbox: move CurrentProcessHasOpenDirectories"jln@chromium.org2013-11-263-121/+3
| | | | | | | | | | | | | | | | | | | > Linux sandbox: move CurrentProcessHasOpenDirectories > > Move CurrentProcessHasOpenDirectories() to the Credentials class and rename > it to HasOpenDirectory(). > Also add some unittests. > > BUG=312380 > R=jorgelo@chromium.org > > Review URL: https://codereview.chromium.org/85403011 TBR=jln@chromium.org Review URL: https://codereview.chromium.org/85343005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237251 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: move CurrentProcessHasOpenDirectoriesjln@chromium.org2013-11-263-3/+121
| | | | | | | | | | | | | Move CurrentProcessHasOpenDirectories() to the Credentials class and rename it to HasOpenDirectory(). Also add some unittests. BUG=312380 R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/85403011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237242 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: cleanup BrokerProcess class.jln@chromium.org2013-11-233-33/+36
| | | | | | | | | | | A few style guide cleanups and more usage of scopers. BUG=316486 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/84183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236883 0039d316-1c4b-4281-b951-d872f2087c98
* Add jorgelo as a Linux sandbox OWNERjschuh@chromium.org2013-11-211-0/+1
| | | | | | | | | R=jln@chromium.org TBR=jln@chromium.org Review URL: https://codereview.chromium.org/77733010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236442 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: fix demo.cc usage of system call numbersjln@chromium.org2013-11-202-6/+18
| | | | | | | | | | | | | | | Include sandbox/linux/services/linux_syscalls.h to make sure that all system calls are defined. Also only build demo.cc for x86 which is the only platform it has been built for. BUG=321363 TBR=markus Review URL: https://codereview.chromium.org/63943007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236123 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SECCOMP_BPF_STANDALONE and port the demo target to gyp.rsesek@chromium.org2013-11-1416-102/+46
| | | | | | | | | BUG=316486 R=jln@chromium.org, markus@chromium.org Review URL: https://codereview.chromium.org/67173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235180 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for -Wunused-function on Linux, Android and ChromeOShans@chromium.org2013-11-121-12/+3
| | | | | | | | | BUG=315884, 78045 TBR=owners Review URL: https://codereview.chromium.org/67923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234373 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment identifying Windows ownersjschuh@chromium.org2013-11-091-0/+1
| | | | | | | | | R=jln@chromium.org TBR=jln@chromium.org Review URL: https://codereview.chromium.org/67253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234103 0039d316-1c4b-4281-b951-d872f2087c98
* Make sandbox/linux/seccomp-bpf/ follow the style guide.jln@chromium.org2013-11-0827-1344/+1439
| | | | | | | | | | | | This CL has mostly be generated with clang-format and should not introduce any code change other than reformatting. BUG=316486 R=markus@chromium.org, rsesek@chromium.org Review URL: https://codereview.chromium.org/66723007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234013 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: make BPF policies an implementation of an interface.jln@chromium.org2013-11-088-94/+151
| | | | | | | | | | | | | | | | | | | | This is the first pass. We renamed SetSandboxPolicy() to SetSandboxPolicyDeprecated(). The new SetSandboxPolicy() takes a pointer to an instance of a class that implements a simple interface. This will improve flexibility by removing the need to pass static pointers for policies. In particular, this will allow us to greatly improve readability of the content/ policies and to use C++ inheritance to implement our policy hierarchy. BUG=316486 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/62953011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233967 0039d316-1c4b-4281-b951-d872f2087c98
* Linux sandbox: print kernel support in credentials unittests.jln@chromium.org2013-11-051-4/+7
| | | | | | | | | | | Make sure that we flush stdout after printing status. BUG=312380 R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/59843005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233097 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add basic unprivileged namespace support.jln@chromium.org2013-11-054-10/+303
| | | | | | | | | | | The Credentials class now has basic support for unprivileged namespaces. BUG=312380 R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/54643010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233041 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add a Credentials class to handle Linux capabilities.jln@chromium.org2013-11-055-0/+168
| | | | | | | | | | | (This is a re-land of https://chromiumcodereview.appspot.com/51113009/) BUG=312380, 312572 TBR=jorgelo@chromium.org Review URL: https://codereview.chromium.org/60513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233027 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 232852 "Linux: add a Credentials class to handle Linux ca..."ilevy@chromium.org2013-11-055-168/+0
| | | | | | | | | | | | | | | | | | | Causing 30-50% rate failure in slave* trybots. I'm sorry Julien. :-\ > Linux: add a Credentials class to handle Linux capabilities. > > (This is a re-land of https://chromiumcodereview.appspot.com/51113009/) > > BUG=312380 > TBR=jorgelo@chromium.org > > Review URL: https://codereview.chromium.org/58693002 TBR=jln@chromium.org Review URL: https://codereview.chromium.org/59073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232927 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add a Credentials class to handle Linux capabilities.jln@chromium.org2013-11-055-0/+168
| | | | | | | | | | | (This is a re-land of https://chromiumcodereview.appspot.com/51113009/) BUG=312380 TBR=jorgelo@chromium.org Review URL: https://codereview.chromium.org/58693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232852 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 232837 "Linux: add a Credentials class to handle Linux ca..."jln@chromium.org2013-11-055-168/+0
| | | | | | | | | | | | | | | | | > Linux: add a Credentials class to handle Linux capabilities. > > (This is a re-land of https://chromiumcodereview.appspot.com/51113009/) > > BUG=312380 > TBR=jorgelo@chromium.org > > Review URL: https://codereview.chromium.org/55603003 TBR=jln@chromium.org Review URL: https://codereview.chromium.org/45923006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232842 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add a Credentials class to handle Linux capabilities.jln@chromium.org2013-11-045-0/+168
| | | | | | | | | | | (This is a re-land of https://chromiumcodereview.appspot.com/51113009/) BUG=312380 TBR=jorgelo@chromium.org Review URL: https://codereview.chromium.org/55603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232837 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 232280 "Linux: add a Credentials class to handle Linux ca..."jln@chromium.org2013-11-015-168/+0
| | | | | | | | | | | | | | | > Linux: add a Credentials class to handle Linux capabilities. > > BUG=312380 > R=jorgelo@chromium.org > > Review URL: https://codereview.chromium.org/51113009 TBR=jln@chromium.org Review URL: https://codereview.chromium.org/54463008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232281 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add a Credentials class to handle Linux capabilities.jln@chromium.org2013-11-015-0/+168
| | | | | | | | | BUG=312380 R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/51113009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232280 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Remove unused low memory margin code from sandbox and zygotejamescook@chromium.org2013-10-293-44/+0
| | | | | | | | | | | | | | | This code is unused - it was probably added long ago when we were trying to figure out the correct value for the memory margin. Removing it will make it easier to remove the setuid sandbox. BUG=312388 TEST=compiles, usual browser_tests R=jln@chromium.org TBR=joi@chromium.org for removing an unused method from content/public/browser/zygote_host_linux.h Review URL: https://codereview.chromium.org/49843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231611 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the TestEvent and TestEventReadOnly tests while I figure out why ↵ananta@chromium.org2013-10-251-2/+2
| | | | | | | | | | | they are failing with the Nt event patches. BUG=305815 TBR=rvargas Review URL: https://codereview.chromium.org/45623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231121 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt3 at landing this. The previous attempt failed on Windows XP because ↵ananta@chromium.org2013-10-2510-273/+350
| | | | | | | | | | | | | | | | | | | | | | | | | | | the \Sessions\Session id\BaseNamedObjects path does not always exist on Windows XP. It only exists for terminal server sessions. Relanding this with fixes for the SyncPolicyTest.TestEvent and SyncPolicyTest.TestEventReadOnly tests. Replace the CreateEvent/OpenEvent patches with their Nt counterparts like NtOpenEvent and NtCreateEvent. Reason being :- We patch these APIS via the Export table patch which does not work with bound imports. This results in our patched functions never getting called. This should fix the GPU process hang with the XP presentation path. The change from the previous patch is to resolve the BaseNamedObjects path via the \Sessions\BNOLinks directory which contains the BaseNamedObjects symbolic links for the running sessions BUG=305815 R=cpu@chromium.org, rvargas@chromium.org, cpu, rvargas Review URL: https://codereview.chromium.org/41193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231063 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 230660 "Relanding this with fixes for the SyncPolicyTest...."falken@chromium.org2013-10-2410-259/+273
| | | | | | | | | | | | | | | | | | | | | | | | | | | After the reland XP dbg failed again: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/40676 > Relanding this with fixes for the SyncPolicyTest.TestEvent and SyncPolicyTest.TestEventReadOnly tests. > > Replace the CreateEvent/OpenEvent patches with their Nt counterparts like > NtOpenEvent and NtCreateEvent. > > Reason being :- We patch these APIS via the Export table patch which does not > work with bound imports. This results in our > patched functions never getting called. > > This should fix the GPU process hang with the XP presentation path. > > BUG=305815 > TBR=cpu,rvargas,thakis > > Review URL: https://codereview.chromium.org/39473002 TBR=ananta@chromium.org Review URL: https://codereview.chromium.org/39583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230670 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this with fixes for the SyncPolicyTest.TestEvent and ↵ananta@chromium.org2013-10-2410-273/+259
| | | | | | | | | | | | | | | | | | | | SyncPolicyTest.TestEventReadOnly tests. Replace the CreateEvent/OpenEvent patches with their Nt counterparts like NtOpenEvent and NtCreateEvent. Reason being :- We patch these APIS via the Export table patch which does not work with bound imports. This results in our patched functions never getting called. This should fix the GPU process hang with the XP presentation path. BUG=305815 TBR=cpu,rvargas,thakis Review URL: https://codereview.chromium.org/39473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230660 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 230512 "Replace the CreateEvent/OpenEvent patches with th..."thakis@chromium.org2013-10-2410-255/+273
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke sbox_integration_tests on xp, vista, win7 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%283%29/builds/22841 http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/41417 http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/28655 Failing tests: SyncPolicyTest.TestEvent SyncPolicyTest.TestEventReadOnly > Replace the CreateEvent/OpenEvent patches with their Nt counterparts like NtOpenEvent and NtCreateEvent. > > Reason being :- We patch these APIS via the Export table patch which does not work with bound imports. This results in our > patched functions never getting called. > > This should fix the GPU process hang with the XP presentation path. > > BUG=305815 > R=cpu@chromium.org, rvargas@chromium.org, cpu > > Review URL: https://codereview.chromium.org/31933005 TBR=ananta@chromium.org Review URL: https://codereview.chromium.org/39303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230629 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the CreateEvent/OpenEvent patches with their Nt counterparts like ↵ananta@chromium.org2013-10-2310-273/+255
| | | | | | | | | | | | | | | | NtOpenEvent and NtCreateEvent. Reason being :- We patch these APIS via the Export table patch which does not work with bound imports. This results in our patched functions never getting called. This should fix the GPU process hang with the XP presentation path. BUG=305815 R=cpu@chromium.org, rvargas@chromium.org, cpu Review URL: https://codereview.chromium.org/31933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230512 0039d316-1c4b-4281-b951-d872f2087c98
* This patch addresses two issues:zturner@chromium.org2013-10-219-32/+42
| | | | | | | | | | | | | | | | | | 1) Some functions were using the wrong signatures, which only happened to work by coincidence since the wrong signatures had the same number of arguments as the right signatures. 2) Don't use imported functions from system libraries in patched functions until after TargetServices::InitCalled() has been called, which guarantees that our IAT has been initialized. BUG=305815 Review URL: https://codereview.chromium.org/29573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229943 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-31 19:23:10 +0000