| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It still brakes sbox_unittests.
This reverts commit 147165
(2f575e44d375c7324571f58b9888a72fc77abd7e).
It has been tested on a local XP machine and works fine.
BUG=137791
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10805016
TBR=jln@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10810033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 147165
(2f575e44d375c7324571f58b9888a72fc77abd7e).
It has been tested on a local XP machine and works fine.
BUG=137791
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10805016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it symmetrical with the Windows version.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10808003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10792027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IPCTest.ClientFastServer inexplicably fails on XP after
we moved the Windows sandbox to sandbox/win.
Disable the part that fails for now.
BUG=
TEST=
NOTRY=true
TBR=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10806003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a rather large refactor to move the Windows sandbox to the right place.
BUG=
TEST=
NOTRY=true
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10689170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=137652
Review URL: https://chromiumcodereview.appspot.com/10793027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With some version of the Seccomp BPF kernel patch, an old glibc
and a kernel using vsyscall=emulate would cause a SIGKILL under a
seccomp BPF policy.
We now detect this condition in supportsSeccompSandbox().
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10703183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
- Move Windows sandbox to sandbox/win
- Update sandbox_win.gypi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow ChromeOS's version of NSS to initialize inside of nacl_helper
without killing the process, which in turn allows validation caching to be
enabled on ChromeOS.
BUG= https://code.google.com/p/chromium/issues/detail?id=134538
TEST= none
Review URL: https://chromiumcodereview.appspot.com/10736017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HandleCloserAgent.
Dereferncing an invalid handle generates the STATUS_INVALID_HANDLE exception when handle tracing is enabled (by AppVerifier for example). HandleCloserAgent is expected to probe invalid handles, so this CL suppresses STATUS_INVALID_HANDLE exceptions triggered by HandleCloserAgent to make debugging easier.
BUG=131699
Review URL: https://chromiumcodereview.appspot.com/10689081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Non 7-bit ASCII characters confused the hell out of try bots and scripts
and led to hard to track bugs.
BUG=
TEST=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10696187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a synthetic but slightly more complex unittest for the BPF compiler.
BUG=130662
TEST=
Review URL: https://chromiumcodereview.appspot.com/10693019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add Chris Evans as OWNER of sandbox/
Set noparent in sandbox/
BUG=
TEST=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10686007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is mostly a NOP, except for the initialization of
ui_exceptions_.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10697013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of scoped handles (r144571), because they were not part of
the original (backed out) CL.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10703012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a partial reland of 130716 - Use
ScopedProcessInformation and other RAII types in sandbox -
minus the bugs introduced by that cl.
BUG=127931
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10605002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So we can move the metro bits to \src
THREAD_INFORMATION_CLASS is now defined with unrelated values
as follows:
typedef enum _THREAD_INFORMATION_CLASS {
ThreadMemoryPriority,
ThreadAbsoluteCpuPriority,
ThreadInformationClassMax
} THREAD_INFORMATION_CLASS;
BUG=127799
TEST= it builds, current test suffice
Review URL: https://chromiumcodereview.appspot.com/10669027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10666032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10666018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10663011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10649004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We add our first basic unittests:
- Calling Sandbox::supportsSeccompSandbox twice should work fine
- We install and test a basic policy that forbids nanosleep()
BUG=None
TEST=None
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10641015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- On Linux, support a new sandbox_linux_unittests target
- Add a new seccomp_bpf_unittests target as a dependency of the global
sandbox_linux_unittests target.
- Integrate globally as a chromium_builder_tests dependency
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10635006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The Sandbox Class is not supposed to be instantiated for now,
so we disallow construction
- Move friends declaration to the private part
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10629009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10628012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Have Windows and Linux sandbox GYP in their own .gypi files
- Cleanup things:
* Get rid of the sandbox_windows_target variable
* Merge all Linux targets into one Linux section
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10536228
TBR=jln@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10633012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
stub on 64 bit systems.
BUG=133633
TEST=current sbox tests.
Review URL: https://chromiumcodereview.appspot.com/10581031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Have Windows and Linux sandbox GYP in their own .gypi files
- Cleanup things:
* Get rid of the sandbox_windows_target variable
* Merge all Linux targets into one Linux section
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10536228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Verified that this change list makes the code build with 4.8.0 20120615
BUG=n/a
TEST=build with gcc 4.7 or more recent
Review URL: https://chromiumcodereview.appspot.com/10556028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=130662
TEST=make && ./demo32 && ./demo64
Review URL: https://chromiumcodereview.appspot.com/10538075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When setting a sandbox policy, the user has to write a system call evaluator
function. This function is passed a system call number and returns a suitable
ErrorCode (e.g. an "errno" value).
This change list extends ErrorCode, so that in addition to static "errno" values,
the system call evaluator can also request that a callback gets called. This allows
the sandbox to handle system calls in user space.
BUG=130662
TEST=make && ./demo32 && ./demo64
Review URL: https://chromiumcodereview.appspot.com/10533076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
all system calls that are supposed to be treated identically.
This change list depends on https://chromiumcodereview.appspot.com/10546041/
These changes should address the immediate concerns about inefficient
BPF evaluation of system calls. But they are only the first step in
the process of us generating an optimal BPF program. We are still
missing the compilation of the binary search tree. That is going to be
the next change list in this series.
But for the benefit of better reviewability, I split the changes into
two parts.
BUG=130662
TEST=make && demo32 && demo64
Review URL: https://chromiumcodereview.appspot.com/10536048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class ensures that the generated BPF program does in fact represent the
filters that we were asked to compile. Having a verifier will allow us to make
more aggressive optimizations in the future without having to worry that we
generate invalid code.
BUG=130662
TEST=make && demo32 && demo64
Review URL: https://chromiumcodereview.appspot.com/10546041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not necessary to break out of the parent process' job on Windows 8, as nested jobs are supported.
Under Metro, breaking sub-processes out of the parent process' job prevents them from being suspended with the application.
R=rvargas@chromium.org
BUG=129697
TEST=Sub-processes are suspended with browser on Metro.
Review URL: https://chromiumcodereview.appspot.com/10535167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
checking all return values from HANDLE_EINTR().
Original CL: https://chromiumcodereview.appspot.com/10545100/
TEST=make && ./demo32 && ./demo64
BUG=130662
Review URL: https://chromiumcodereview.appspot.com/10542149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
executing supportsSeccompSandbox(). Previously, we would just report that the sandbox is unavailable. That's undesirable behavior, because it would lead the caller to think that they should continue without the sandbox. A simple bug in the sandbox compiler could thus result in us inadvertently disabling sandboxing for all users -- without necessarily noticing this issue for a while.
BUG=130662
TEST=make && ./demo32 && ./demo64
Review URL: https://chromiumcodereview.appspot.com/10545100
TBR=markus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10540145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
supportsSeccompSandbox(). Previously, we would just report that the sandbox is unavailable. That's undesirable behavior, because it would lead the caller to think that they should continue without the sandbox. A simple bug in the sandbox compiler could thus result in us inadvertently disabling sandboxing for all users -- without necessarily noticing this issue for a while.
BUG=130662
TEST=make && ./demo32 && ./demo64
Review URL: https://chromiumcodereview.appspot.com/10545100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sandbox.
This ensures that the sandbox doesn't surprisingly fail, if the user instantiated
a particularly strick policy.
BUG=130662
TEST=make && ./demo32 && ./demo64
Review URL: https://chromiumcodereview.appspot.com/10535089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new x32 API and older Intel APIs.
Also, extend the system call range from 0..512 to 0..1024. This covers the extra system calls added with x32.
As x32 isn't widely available yet, we don't add any other code to support it (e.g. we don't build a version of
demo.cc that runs in x32). But by explicitly blocking it for i386 and x86-64 we ensure that a "default allow"
policy is going to do the right thing.
TEST=make && demo32 && demo64
BUG=130662
Review URL: https://chromiumcodereview.appspot.com/10542028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of blacklisting ARM, we whitelist IA32 and X86_64
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10533055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10537048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140985 0039d316-1c4b-4281-b951-d872f2087c98
|