summaryrefslogtreecommitdiffstats
path: root/sandbox
Commit message (Collapse)AuthorAgeFilesLines
* Fixed a bogus compiler warning.markus@chromium.org2012-01-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119752 0039d316-1c4b-4281-b951-d872f2087c98
* Calling clone(CLONE_NEWPID) results in the new pid namespace getting a new ↵markus@chromium.org2012-01-304-48/+346
| | | | | | | | | | | | | | | | | | | | | "init" process. This process is now resposible for reaping all child processes that no longer have a direct parent process. Often, failure to do this goes unnoticed, because our sandbox'd processes don't often fork other processes that then continue to turn into daemon processes. But there is no reason, why they couldn't occasionally do so. And in fact, the seccomp sandbox does do so for its trusted process. In the past, this would result in us having lots of uncollected zombie processes that only disappeared when the browser terminated. BUG=109944 TEST=Run Chrome with both the suid sandbox and the seccomp sandbox, open and close a few tabs, verify that we don't produce any zombie processes Review URL: https://chromiumcodereview.appspot.com/9295005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119746 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminated memory growth issue by removing null objects from a list that was ↵erikghill@gmail.com2012-01-262-22/+18
| | | | | | | | accumulating them. Now, the objects are removed from the list when they are no longer needed, instead of being set to null.BUG=110459TEST=1. Go to any webpage 2. Go to a different webpage 3. Go back to step 1 and repeat many times. Before the fix pool_objects_ in win2k_threadpool grows with each new webpage visited. After the fix pool_objects_.size() is bounded even as new webpages are visited. Review URL: http://codereview.chromium.org/9243014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119287 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory dealocatiom mismatch by using scoped_ptr_malloccpu@chromium.org2012-01-122-8/+9
| | | | | | | | | | | - Flagged by almost all tools BUG=101717 TEST= sandbox tests in the waterfall are green. Review URL: http://codereview.chromium.org/9107029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117476 0039d316-1c4b-4281-b951-d872f2087c98
* ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > ↵pkasting@chromium.org2011-11-294-34/+6
| | | | | | | | | | | | 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all. Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds. BUG=none TEST=none Review URL: http://codereview.chromium.org/8418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all usages of FRIEND_TEST() with FRIEND_TEST_ALL_PREFIXES()robertshield@chromium.org2011-11-292-11/+11
| | | | | | | | BUG=105287 TEST=NONE Review URL: http://codereview.chromium.org/8678017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111935 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded forward declarations in printing, sandbox, and skia.thestig@chromium.org2011-11-144-12/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8538001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109961 0039d316-1c4b-4281-b951-d872f2087c98
* Expose the sandbox related code through the content API. I did a bit of ↵jam@chromium.org2011-10-291-7/+2
| | | | | | | | | | | | | cleanup while I was doing this. -got rid of SandboxInitWrapper, since I didn't see a need to expose given that we can just expose sandbox::SandboxInterfaceInfo -got rid of the duplicated code to initialize the broker -since I made MainFunctionParams only have the sandbox struct on Windows, I also made the mac specific auto release pool behind an ifdef as well. It seemed odd to make something so mac specific compile on all platforms to save some #ifdefs. BUG=98716 Review URL: http://codereview.chromium.org/8414020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107863 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'settings' type from gyp filesevan@chromium.org2011-09-221-1/+1
| | | | | | | | | | | It is not actually supported by gyp; the fact that it works is a bug that I am working on fixing. BUG=96629 Review URL: http://codereview.chromium.org/7889051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102306 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100328 - Prevent the renderer from dying if launched under ↵jschuh@chromium.org2011-09-221-6/+2
| | | | | | | | | | | | | | App-V/SoftGrid. We found a better workaround, so removing this one. BUG=95888 Review URL: http://codereview.chromium.org/7857022 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/7988006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102289 0039d316-1c4b-4281-b951-d872f2087c98
* These unit tests are flaky and the code is exercised in the integration tests.jschuh@chromium.org2011-09-122-67/+0
| | | | | | | | BUG=89325 TEST=None Review URL: http://codereview.chromium.org/7870006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100712 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent the renderer from dying if launched under App-V/SoftGrid.nsylvain@chromium.org2011-09-091-2/+6
| | | | | | | | | | | | | A version of Microsoft Office launches chrome under a virtual environment, and this virtual environment does not allow us to reduce the integrity level on the renderer. Since it returns a fake error (ERROR_INVALID_HANDLE), we can trap it and continue execution anyway... until we find a better fix. BUG=95888 Review URL: http://codereview.chromium.org/7857022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100328 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify chrome_exe_main_*.cc, moving as much of the code out as possible. ↵jam@chromium.org2011-08-313-12/+0
| | | | | | | | This is in preparation for moving the code in ChromeMain (and associated platform files) to a common place that can be used by both chrome and other embedders of content (i.e. content_shell). Included is a change to make the sandbox code not need an AtExitManager. This is necessary because content_shell would be just one exe, and we'd need to initialize the sandbox before calling ChromeMain, which is what would creat AtExitManager.I removed the code that printed the tcmalloc stacks in the OOM handler (i.e. r33993) under Windows. The issue is I wanted to move the OOM handling code to base to match the other platforms (in a long string of changes to make the startup code more sane, so I can share it with a browser built over content). When I tried moving the tcmalloc code to base, then I ran into a bunch of linker errors because a bunch of targets that depend on base don't depend on allocator. When I tried to add that to base, I ran into strange gyp errors (see patchset 2). I asked Jim/Eric and they said they don't use this data from dumps, and that most of the OOM minimdumps are in v8 heap anyways. When James get back, if he still uses this I can figure out how to put this back.BUG=90445 Review URL: http://codereview.chromium.org/7810005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99032 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash on a NULL type-name from ObjectTypeInformation.jschuh@chromium.org2011-08-231-1/+1
| | | | | | | | BUG=93449 TEST=None. Review URL: http://codereview.chromium.org/7714003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97934 0039d316-1c4b-4281-b951-d872f2087c98
* Trying again to land OOM priority manager changes.gspencer@google.com2011-08-233-13/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | First landing failed because of an obscure problem with building linux_shared. This change passes the linux_shared trybot (and linux and linux_chromeos trybots). Changing OOM range to 0, 1000 and tweaking OOM algorithm. With this change, we now use the newer oom_score_adj file (with fallback to oom_adj when on a system that doesn't support it) so that we can take advantage of a finer range ([0, 1000] instead of [0, 15]). Also tweaked the OOM priority manager to prioritize things in a slightly different order, preferring (even more) not to kill tabs that the user has currently selected. Original review: http://codereview.chromium.org/7671033/ BUG=chromium-os:18421, chromium:65009 TEST=Ran on device, observed OOM adj values, forced OOM conditions to watch kills. Review URL: http://codereview.chromium.org/7708020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97888 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 97724 - Changing OOM range to 0, 1000 and tweaking OOM algorithm.mattm@chromium.org2011-08-223-33/+13
| | | | | | | | | | | | | | | | | | | | | With this change, we now use the newer oom_score_adj file (with fallback to oom_adj when on a system that doesn't support it) so that we can take advantage of a finer range ([0, 1000] instead of [0, 15]). Also tweaked the OOM priority manager to prioritize things in a slightly different order, preferring (even more) not to kill tabs that the user has currently selected. BUG=chromium-os:18421, chromium:65009 TEST=Ran on device, observed OOM adj values, forced OOM conditions to watch kills. Review URL: http://codereview.chromium.org/7671033 TBR=gspencer@google.com Review URL: http://codereview.chromium.org/7685030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97728 0039d316-1c4b-4281-b951-d872f2087c98
* Changing OOM range to 0, 1000 and tweaking OOM algorithm.gspencer@google.com2011-08-223-13/+33
| | | | | | | | | | | | | | | | | | With this change, we now use the newer oom_score_adj file (with fallback to oom_adj when on a system that doesn't support it) so that we can take advantage of a finer range ([0, 1000] instead of [0, 15]). Also tweaked the OOM priority manager to prioritize things in a slightly different order, preferring (even more) not to kill tabs that the user has currently selected. BUG=chromium-os:18421, chromium:65009 TEST=Ran on device, observed OOM adj values, forced OOM conditions to watch kills. Review URL: http://codereview.chromium.org/7671033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97724 0039d316-1c4b-4281-b951-d872f2087c98
* Don't switch to RtlCreateUserThread until after lockdown.jschuh@chromium.org2011-08-121-0/+11
| | | | | | | | BUG=91413 TEST=None. Review URL: http://codereview.chromium.org/7552014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96558 0039d316-1c4b-4281-b951-d872f2087c98
* Handle STATUS_BUFFER_OVERFLOW return value from NtQueryObject().jschuh@chromium.org2011-08-112-2/+4
| | | | | | | | BUG=91386 TEST=None Review URL: http://codereview.chromium.org/7542026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96478 0039d316-1c4b-4281-b951-d872f2087c98
* Make sandbox target a settings target type to fix a linker error.craig.schlenter@chromium.org2011-08-111-1/+1
| | | | | | | | | BUG=92164 TEST=Clobber build compiles, trybots Review URL: http://codereview.chromium.org/7602016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96425 0039d316-1c4b-4281-b951-d872f2087c98
* Fixup bad include and usage of BASE_API, which should be BASE_EXPORT.darin@chromium.org2011-08-051-2/+2
| | | | | | | TBR=rvargas@chromium.org Review URL: http://codereview.chromium.org/7582007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95619 0039d316-1c4b-4281-b951-d872f2087c98
* Hook GetUserDefaultLCID () to prevent crashes on attempting to connect to ↵jschuh@chromium.org2011-08-027-10/+36
| | | | | | | | | | CSRSS after lockdown. BUG=91216 TEST=None. Review URL: http://codereview.chromium.org/7541034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95144 0039d316-1c4b-4281-b951-d872f2087c98
* Sandbox: Fix a style nit. No actual code change.rvargas@google.com2011-08-021-3/+4
| | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7546001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95102 0039d316-1c4b-4281-b951-d872f2087c98
* seccomp: simplify enable/disable logicevan@chromium.org2011-07-291-23/+11
| | | | | | | | | | | | | | 1) Only compile in seccomp code at all if it's on a platform we intend to support (non-ChromeOS non-ARM non-Views Linux). 2) Move usage of seccomp code behind a define and usage of seccomp flags into a function call. The former helps catch bugs in the latter: it will be a link error if I accidentally break the enable/disable logic in code. Review URL: http://codereview.chromium.org/7519016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94784 0039d316-1c4b-4281-b951-d872f2087c98
* Disable UnloadDllTest.BaselineAvicapDllsergeyu@chromium.org2011-07-271-1/+1
| | | | | | | | | | BUG=80569 TEST=None TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/7520004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94333 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabling chrome-sandbox for Clang builds.glotov@google.com2011-07-271-2/+2
| | | | | | | | | | | As Clang now (since #13349 -- hans) supports asm .common directive, we may re-enable chrome-sandbox for Clang builds. BUG=chromium-os:16717, chromium:70871, chromium-os:88578 TEST=none Review URL: http://codereview.chromium.org/7233011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94271 0039d316-1c4b-4281-b951-d872f2087c98
* Warm up GetUserDefaultLangID before closing client ALPC connections.jschuh@chromium.org2011-07-261-0/+7
| | | | | | | | BUG=90492 TEST=Run Chrome on 32-bit Windows 7 or Vista Review URL: http://codereview.chromium.org/7461092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94169 0039d316-1c4b-4281-b951-d872f2087c98
* Remove explicit keyword from multi-argument (w/o default values) constructorsdilmah@chromium.org2011-07-261-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7477008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
* Close all open ALPC client ports at lockdown.jschuh@chromium.org2011-07-2412-6/+154
| | | | | | | | | | Close out the CSRSS and LSASS ALPC client ports that are opened during initialization. BUG=58069 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.RunThreadPool Review URL: http://codereview.chromium.org/7490002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93827 0039d316-1c4b-4281-b951-d872f2087c98
* Add a sandbox API to allow closing open handles at lockdown. jschuh@chromium.org2011-07-2111-9/+613
| | | | | | | | | | | BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93274 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93308 Review URL: http://codereview.chromium.org/7253054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93321 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 93308 - Add a sandbox API to allow closing open handles at lockdown. jschuh@chromium.org2011-07-2111-602/+9
| | | | | | | | | | | | | BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93274 Review URL: http://codereview.chromium.org/7253054 TBR=jschuh@chromium.org Review URL: http://codereview.chromium.org/7473022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93315 0039d316-1c4b-4281-b951-d872f2087c98
* Add a sandbox API to allow closing open handles at lockdown. jschuh@chromium.org2011-07-2111-9/+602
| | | | | | | | | | BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93274 Review URL: http://codereview.chromium.org/7253054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 93274 - Add a sandbox API to allow closing open handles at lockdown. jschuh@chromium.org2011-07-2011-605/+9
| | | | | | | | | | | | BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Review URL: http://codereview.chromium.org/7253054 TBR=jschuh@chromium.org Review URL: http://codereview.chromium.org/7471021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93284 0039d316-1c4b-4281-b951-d872f2087c98
* Add a sandbox API to allow closing open handles at lockdown. jschuh@chromium.org2011-07-2011-9/+605
| | | | | | | | | BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Review URL: http://codereview.chromium.org/7253054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93274 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 93113 - Add a sandbox API to allow closing open handles at lockdown.jschuh@chromium.org2011-07-1911-582/+9
| | | | | | | | | | | | | | Reverting on suspicion that it's related to NaCl test breakage. BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Review URL: http://codereview.chromium.org/7253054 TBR=jschuh@chromium.org Review URL: http://codereview.chromium.org/7462003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93128 0039d316-1c4b-4281-b951-d872f2087c98
* Add a sandbox API to allow closing open handles at lockdown.jschuh@chromium.org2011-07-1911-9/+582
| | | | | | | | | BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Review URL: http://codereview.chromium.org/7253054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93113 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 92887 - Add a sandbox API to allow closing open handles at lockdown.jschuh@chromium.org2011-07-1811-552/+9
| | | | | | | | | | | | BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Review URL: http://codereview.chromium.org/7253054 TBR=jschuh@chromium.org Review URL: http://codereview.chromium.org/7398035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92906 0039d316-1c4b-4281-b951-d872f2087c98
* Add a sandbox API to allow closing open handles at lockdown.jschuh@chromium.org2011-07-1811-9/+552
| | | | | | | | | BUG=58069 BUG=74242 TEST=sbox_integration_tests --gtest_filter=HandleCloserTests.* Review URL: http://codereview.chromium.org/7253054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92887 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 92563 - Had a bug in the handle table unit test. Added GetHandleName ↵jschuh@chromium.org2011-07-143-63/+23
| | | | | | | | | | | | | to fix the bug and make handle management easier. TEST=sbox_unittests --gtest_filter=HandleTable.* BUG=89325 Review URL: http://codereview.chromium.org/7346027 TBR=jschuh@chromium.org Review URL: http://codereview.chromium.org/7379001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92568 0039d316-1c4b-4281-b951-d872f2087c98
* Had a bug in the handle table unit test. Added GetHandleName to fix the bug ↵jschuh@chromium.org2011-07-143-23/+63
| | | | | | | | | | and make handle management easier. TEST=sbox_unittests --gtest_filter=HandleTable.* BUG=89325 Review URL: http://codereview.chromium.org/7346027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92563 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Had a bug in the handle table unit test. Added GetHandleName to fix ↵evan@chromium.org2011-07-133-32/+14
| | | | | | | | the bug and make handle management easier." This reverts commit r92403. Failed on Windows. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92412 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPONENT_BUILD global define. darin@chromium.org2011-07-131-0/+1
| | | | | | | | | | | | | | | | | | | | | This avoids the need to define FOO_DLL macros for each project that we wish to optionally build as a DLL (when component=="shared_library"). This in turn means that we do not need direct_dependent_settings to define FOO_DLL, and that means that we don't need to update projects to convert transitive dependencies into explicit dependencies. This makes the component build more consistent with the static build. An alternative would be to use all_dependent_settings, but I feel that the global approach is simpler as it creates less repetition in each target definition for components. A side-effect of this change is that I needed to make base_nacl_win64 be a shared_library in the component build. R=rvargas,bradnelson,evan Review URL: http://codereview.chromium.org/7344022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92409 0039d316-1c4b-4281-b951-d872f2087c98
* Had a bug in the handle table unit test. Added GetHandleName to fix the bug ↵jschuh@chromium.org2011-07-133-14/+32
| | | | | | | | | | | | and make handle management easier. TEST=sbox_unittests --gtest_filter=HandleTable.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91270 Review URL: http://codereview.chromium.org/7218066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92403 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add COMPONENT_BUILD global define. "yurys@chromium.org2011-07-131-1/+0
| | | | | | | | | | | | | The change broke compilation on Linux Builder (dbg)(shared): http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio TBR=darin BUG=None TEST=None Review URL: http://codereview.chromium.org/7352014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92329 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPONENT_BUILD global define. darin@chromium.org2011-07-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | This avoids the need to define FOO_DLL macros for each project that we wish to optionally build as a DLL (when component=="shared_library"). This in turn means that we do not need direct_dependent_settings to define FOO_DLL, and that means that we don't need to update projects to convert transitive dependencies into explicit dependencies. This makes the component build more consistent with the static build. An alternative would be to use all_dependent_settings, but I feel that the global approach is simpler as it creates less repetition in each target definition for components. A side-effect of this change is that I needed to make base_nacl_win64 be a shared_library in the component build. R=rvargas,bradnelson Review URL: http://codereview.chromium.org/7344022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92325 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-111-6/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 91270 - sbox_unittests HandleTable.FindTable failing on Win XP & Vistarsleevi@chromium.org2011-07-013-32/+14
| | | | | | | | | | | | | | Had a bug in the handle table unit test. Added GetHandleName to fix the bug and make handle management easier. TEST=sbox_unittests --gtest_filter=HandleTable.* Review URL: http://codereview.chromium.org/7218066 TBR=jschuh@chromium.org Review URL: http://codereview.chromium.org/7292028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91271 0039d316-1c4b-4281-b951-d872f2087c98
* Had a bug in the handle table unit test. Added GetHandleName to fix the bug ↵jschuh@chromium.org2011-07-013-14/+32
| | | | | | | | | | | and make handle management easier. TEST=sbox_unittests --gtest_filter=HandleTable.* Review URL: http://codereview.chromium.org/7218066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91270 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid an extra if() which is not required and is wrongtimurrrr@chromium.org2011-06-281-13/+11
| | | | | | | | | | | | | | | | Info: a) args[i] is uninitialized for (i >= ipc_params->GetParamsCount()) and sometimes for smaller (i) as well (see GetArgs()). Hence, if() is wrong. b) However, when args[i] is uninitialized the ipc_params->args[i] holds INVALID_TYPE. Hence, the if() is redundant. BUG=87078 TEST=no more uninit reports under Dr. Memory Review URL: http://codereview.chromium.org/7234009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90742 0039d316-1c4b-4281-b951-d872f2087c98
* Minor change to use ResolveNTFunctionPtr rather than calling GetProcAddress ↵jschuh@chromium.org2011-06-272-22/+7
| | | | | | | | | | directly. BUG=None. TEST=None. Review URL: http://codereview.chromium.org/7276003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90638 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 20:59:34 +0000