| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=brettw@chromium.org
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1237953003
Cr-Commit-Position: refs/heads/master@{#339357}
|
|
|
|
|
|
|
|
|
|
|
| |
This also changes all the references to http://code.google.com/p/open-vcdiff
to point to https://github.com/google/open-vcdiff
BUG=510860
Review URL: https://codereview.chromium.org/1242533003
Cr-Commit-Position: refs/heads/master@{#339282}
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org,mark@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/1214423002
Cr-Commit-Position: refs/heads/master@{#337460}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Application of https://codereview.chromium.org/962003002/.
TBR=keybuk@chromium.org
R=brettw@chromium.org
BUG=456014
Review URL: https://codereview.chromium.org/960413003
Cr-Commit-Position: refs/heads/master@{#318574}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other misc fixes including:
Add "data_deps" to the templates in BUILDCONFIG. This was renamed from "datadeps" a while ago but both are still supported.
extension_management_test_util.cc includes a generated file policy_constants. GYP generates this with an extra "policy" directory but GN doesn't. The way GYP has the dirs set up, though, using only one "policy" works (and this is what other files do) so I just changed the include.
TBR=dpranke
Review URL: https://codereview.chromium.org/824373003
Cr-Commit-Position: refs/heads/master@{#310276}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excluded mojo because I think that needs to happen on the other side.
At gn --version = 306668 for which roll is in CQ.
R=brettw@chromium.org
TBR=scherkus@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/774353003
Cr-Commit-Position: refs/heads/master@{#306708}
|
|
|
|
|
|
|
|
|
| |
BUG=321833
TBR=brettw
Review URL: https://codereview.chromium.org/722513003
Cr-Commit-Position: refs/heads/master@{#303892}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added some end-to-end browser tests, and added a bit of extra checking
for the filter.
The extra files for encoding dictionaries from sdch/open-vcdiff were
added so that the tests could create an SDCH dictionary when run.
IMO, this is more flexible for future tests and clearer to read and
maintain than just hard-coding a dictionary inline in the tests.
BUG=None
R=mef@chromium.org
Review URL: https://codereview.chromium.org/380003002
Cr-Commit-Position: refs/heads/master@{#290638}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
TBR=wtc@chromium.org
BUG=354261
Review URL: https://codereview.chromium.org/419073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's no longer needed.
BUG=308740
R=scottmg@chromium.org
TBR=cpu
Review URL: https://codereview.chromium.org/404443003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=mark@chromium.org
Review URL: https://codereview.chromium.org/308123006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is also needed for c++11 mode in gcc 4.8, not just clang.
BUG=324299
NOTRY=true
Review URL: https://codereview.chromium.org/205963004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from joaodasilva.
BUG=308740
R=scottmg@chromium.org
TBR=wtc@chromium.org
Review URL: https://codereview.chromium.org/136083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We force-include our own logging.h, which includes basictypes.h, which
now includes stdint.h. Without this change, this ends up being
minimal/hacky stdint.h (from sdch/open-vcdiff/vsprojects), which isn't
sufficient for the needs of the rest of basictypes.h.
R=brettw@chromium.org, jar@chromium.org
BUG=138542
Review URL: https://codereview.chromium.org/110273004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It uses auto_ptr
BUG=324299
R=bauerb@chromium.org
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/95063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I wanted to change open-vcdiff's logging.h directly, put we pull it directly
from google code, not through deps, so we can't have downstream diffs.
Maybe that's enough to eliminate all static initializers added by open-vcdiff.
BUG=94925
Review URL: https://codereview.chromium.org/68253006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10803053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Avoid redefining HAVE_MALLOC_H, which is already defined in Android's AndroidConfig.h.
Review URL: https://chromiumcodereview.appspot.com/10332074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Roll open-vcdiff from 40 to 42 to include the changes about zlib files (http://code.google.com/p/open-vcdiff/source/detail?r=41)
Exclude zlib files when building open-vcdiff for Chromium to avoid link warning due to name conflict with zlib.
BUG=116308
Review URL: http://codereview.chromium.org/9555002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the changes to make sure all directories have proper lists of owners, I'm adding one here ...
R=jar@chromium.org
BUG=88315
Review URL: https://chromiumcodereview.appspot.com/9665022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this patch also adds a comment that describes why
EAI_NODATA is disabled on FreeBSD
BUG=
TEST=
TBR=wtc
Review URL: http://codereview.chromium.org/8598010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7835026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
libevent configuration.
BUG=30101
TEST=compiles
Review URL: http://codereview.chromium.org/7238021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sdch, skia, and testing.
BUG=28727
Review URL: http://codereview.chromium.org/7165009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We provided <(library) as a variable to support a peculiar
build configuration on Linux. We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.
Review URL: http://codereview.chromium.org/7051014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
open-vcdiff 0.7.
Linux: Ubuntu Lucid 10.04
Mac: Mac OS X 10.5 with Xcode 3.1.4
It seems that the original linux/config.h was incorrectly generated.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6732031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/565043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
references to each other) anywhere in the Chromium code base.
BUG=none
TEST=rebuild
Review URL: http://codereview.chromium.org/159523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
parameterize the 'type' setting of the various library targets, with a
default of 'static_library'.
(Hat tip to Craig Schlenter.)
Review URL: http://codereview.chromium.org/62127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(as was done for mac) and add the include directory
to the .gyp file.
Review URL: http://codereview.chromium.org/40101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Convert the Mac build to the new GYP-based Xcode build, and remove the old
Xcode projects.
Review URL: http://codereview.chromium.org/28305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
we don't have to worry about messy generator steps in the gyp-based build.
Review URL: http://codereview.chromium.org/23008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This fixes the SHARED=1 build on Linux. sdch/SConscript last changed in r8644/issue 18717.
Review URL: http://codereview.chromium.org/18816
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also updates the .vcproj files themselves to fix minor stylistic
incompatibilities with the rest. Affected .vcproj files:
* No change (byte-for-byte identical):
media\build\media.vcproj
media\build\media_player.vcproj
media\build\media_unittests.vcproj
google_update\ondemand_updates.vcproj
* Remove .\ prefix where inconsistent with the rest of a filelist:
rlz\rlz.vcproj
breakpad\breakpad_handler.vcproj
* Add empty <ToolFiles>, <References> and <Globals> sections:
breakpad\breakpad_sender.vcproj
* Add explicit RootNamespace attribute:
sdch\sdch.vcproj
* Use Windows-canonical \ separators:
sdch\sdch.vcproj
* Remove unnecessary Filter and UniqueIdentifier attributes from
<Filter> declarations:
sdch\sdch.vcproj
Additional cleanups along for the ride:
* Split breakpad\SConscript logic into separate
breakpad_{handler,sender}.scons files.
* Add a media\media_player.scons configuration.
Review URL: http://codereview.chromium.org/18717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
updated ICU dep that uses it as well.
Add a SHARED scons command-line flag to build shared libraries.
Review URL: http://codereview.chromium.org/16477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(project files still to come). To wit:
* Solution file configuration is in *_sln.scons files (base\base_sln.scons,
chrome\chrome_sln.scons).
* Individual Project file configuration is in the the .scons file for
the relevant target (base\base_unittests.scons,
third_party\libxml\libxml.scons, etc.)--that is, where their file
lists will live.
* MSVSProject() calls are currently placeholders that establish
the existence of Project Nodes (and Project dependencies) but don't yet
have actual Project configuration information (file lists, .vsprops, etc.).
* Configuraiton is very manual. In particular, the entries in the .sln
file will be written out in exactly the order specified in the
configuration(s). The current ordering is taken from our existing
.sln files, so we can generate virtually the same configurations
on output.
* Generated solution files are nearly byte-for-byte identical
with our existing .sln files, modulo:
* net\dump_cache has a WebsiteProperties sections (making that
configurable per project isn't important right now);
* sandbox\sandbox.sln was missing a dependency of base.vcproj on
on debug_message.vcproj (present in other .sln files)
* webkit\webkit.sln was missing dependencies of WebCore.vcproj on
libxml_config.vcproj and libxslt_config.vcproj (present in
chrome.sln);
* add a handful of other miscellaneous missing dependencies on various
.vcproj definitions in chrome.sln (present in other .sln files).
* remove stats_viewer.csproj from chrome.sln (sorry, mbelshe),
which was complicating the solution configuration with unnecessary
(for us) "Mixed Platform" types;
* All MSVSFolder(), MSVSProject() and MSVSSolution() calls have
hard-wired guid= values taken from our existing configuration,
so we can: 1) verify generation of working configs; 2) minimize
diffs when checking in generated .sln files. We can remove
these in the future in favor of extracting them from existing
.sln files if we wish.
* Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution()
wrappers to chromium_builders.py, that gate the underlying call to
the env.MSVS*() builders based on whether env.Bit('msvs') is set
(i.e., we're in --mode=msvs).
* Remove platform-specific gating of to-be-ported .scons files that we
now need to load on any platform to generate coheren MSVS files.
Move the env.Bit('windows') tests for actually building their
executables into the individual .scons files.
Review URL: http://codereview.chromium.org/14472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and better-thought-out Hammer env.Bits() idioms:
* env['PLATFORM'] == 'win32' => env.Bit('windows')
* env['PLATFORM'] == 'posix' => env.Bit('linux')
* env['PLATFORM'] == 'darwin' => env.Bit('mac')
New idioms:
* env.Bit('posix') => really does mean "any POSIX platform"
* env.AnyBits('mac', 'linux') => specifically mac or linux, excluding
other POSIX platforms
Where we were using compound conditionals (e.g., "env['PLATFORM'] in
('posix', 'darwin')") I tried to take my best shot at translating
the intent (i.e., "env.Bits('posix')" for something POSIX, "not
env.Bits('mac')" for something not yet ported to Mac, etc.)
Review URL: http://codereview.chromium.org/15051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Patch fails otherwise on non-Windows platforms.
Review URL: http://codereview.chromium.org/14478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98
|