summaryrefslogtreecommitdiffstats
path: root/skia/ext
Commit message (Collapse)AuthorAgeFilesLines
* Roll Skia to 3866.bsalomon@google.com2012-05-081-2/+1
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10383063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135872 0039d316-1c4b-4281-b951-d872f2087c98
* Fix win32 error checking in platform_canvas_skia.cc by moving code into ↵reveman@chromium.org2012-04-173-84/+69
| | | | | | | | | | | bitmap_platform_device_win.cc. BUG=119555 TEST=manual Review URL: http://codereview.chromium.org/10093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132550 0039d316-1c4b-4281-b951-d872f2087c98
* remove call to getTotalClip, which is being deprecated. Use save/restore patternreed@google.com2012-04-121-3/+2
| | | | | | | to affec the same logic. Review URL: https://chromiumcodereview.appspot.com/10008080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132021 0039d316-1c4b-4281-b951-d872f2087c98
* Create a local bitmap to capture CoreGraphics renderingcaryclark@google.com2012-04-113-17/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when the canvas is not backed by a bitmap. During normal desktop drawing, CoreGraphics calls that image theme elements like checkboxes and buttons draw into the device bitmap owned by Skia's canvas. When a PDF is created as part of a print preview, no bitmap is allocated. In the latter case, associate a local array of pixels with the CGContext to capture the theme rendering, then draw it with Skia once the theme rendering is complete. This fix over-allocates memory. It creates a pixel map as large as the device. The bounds of the CG drawing is not visible to Skia, and the clip may not be set. The PDF may be larger than need be for the same reason. In a subsequent change, the theme element's bounds can reduce the size of the bitmap allocation. This could be done by setting the clip or by passing the rectangle to the graphics context. This would require a sizeable edit to RenderThemeMac.mm. Also, change the unit test to test both paths, when the device is backed by a bitmap, and when it is not. This requires the unit test to call the destructor and reset the clip before comparing the results. BUG=121752 TEST=http://stmarksparish.com/printtest.aspx, print to PDF TEST=SkiaUtilsMacTest.BitLocker_* Review URL: https://chromiumcodereview.appspot.com/10031005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131795 0039d316-1c4b-4281-b951-d872f2087c98
* Remove log-spam from Convolver.SIMDVerification.fischman@chromium.org2012-04-101-6/+6
| | | | | | Review URL: http://codereview.chromium.org/10031040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131650 0039d316-1c4b-4281-b951-d872f2087c98
* Don't get screen dc when creating BitmapPlatformDevicejbauman@chromium.org2012-04-102-22/+4
| | | | | | | | | | | | We were only using the screen dc for CreateDIBSection, which is unnecessary, and it was grabbing a lock preventing us from creating a BitmapPlatformDevice while something else was presenting to the screen. BUG=122103 TEST= Review URL: http://codereview.chromium.org/10009022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131574 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WAYLAND portoshima@chromium.org2012-04-073-238/+3
| | | | | | | | | | | Also removed skia/ext/canvas_paint_x.h which is not in use. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10009024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131219 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TOOLKIT_USES_GTK and consolidate it into TOOLKIT_GTKoshima@chromium.org2012-04-051-1/+1
| | | | | | | | | | | Add gtk dependency to base.gyp for android host_os="linux" case BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9969080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130784 0039d316-1c4b-4281-b951-d872f2087c98
* Adding build-time option to enable the tracing of skia events in junov@chromium.org2012-04-031-0/+18
| | | | | | | | | | | chrome://tracing BUG=121208 TEST=None Review URL: http://codereview.chromium.org/9965037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130469 0039d316-1c4b-4281-b951-d872f2087c98
* BitmapPlatformDevice multiply-inherits from PlatformDevice and SkDevice, insenorblanco@chromium.org2012-03-296-6/+6
| | | | | | | | | | | | | | | | | | | | that order. However, a newly-created BitmapPlatformDevice is often upcast to an SkDevice, and owning pointers are stored to it as an SkDevice. All the relevant destructors are virtual, so it can safely be deleted polymorphically. However, valgrind doesn't know that, and at program exit some BitmapPlatformDevices are still reachable only as SkDevices, pointing to the middle of the BitmapPlatformDevice. The real solution would be to get rid of the MI, but for now just switching the base classes around causes valgrind to shut up, since we're now owning the object through the same pointer that we got from new. This moves the memory in valgrind from "possibly lost" to "still reachable". BUG=105744 TEST=see valgrind output, check that errors go away Review URL: https://chromiumcodereview.appspot.com/9900001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129616 0039d316-1c4b-4281-b951-d872f2087c98
* Default initialize CanvasPaintT<T> bitmaps to 0, 0, 0, 0.twiz@chromium.org2012-03-235-0/+13
| | | | | | | | | | | | | | PlatformCanvas objects are constructed uninitialized. (Since change http://src.chromium.org/viewvc/chrome?view=rev&revision=127196). This change had propagated uninitialized semantics to CanvasPaint<..>, and CanvasPaintSkia, which introduced the regressions mentioned in the bug below. This change re-introduces the initilized memory behaviour, but at the CanvasPaint<T> level. This preserves the performance boost from rev 127196, and prevents regressions in displayed UI elements. Change also removes a now-unnecessary clear in browser_action_button.mm introduced by http://codereview.chromium.org/9839012. BUG=118755 TEST=None Review URL: https://chromiumcodereview.appspot.com/9837043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128574 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Use platform independent canvas by default.reveman@chromium.org2012-03-231-0/+121
| | | | | | | | | | | | BUG=111587 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128039 Review URL: http://codereview.chromium.org/9722032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128354 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 128039 - aura: Use platform independent canvas by default.wez@chromium.org2012-03-211-41/+0
| | | | | | | | | | | | | | | This CL cause Win Aura to fail, unable to find a PlatformCanvas::initialize() with the necessary signature. BUG=111587 TEST=none Review URL: http://codereview.chromium.org/9722032 TBR=reveman@chromium.org Review URL: https://chromiumcodereview.appspot.com/9815022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128042 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Use platform independent canvas by default.reveman@chromium.org2012-03-211-0/+41
| | | | | | | | | | BUG=111587 TEST=none Review URL: http://codereview.chromium.org/9722032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128039 0039d316-1c4b-4281-b951-d872f2087c98
* use getTopLayer(now with updatematrixclip) instead of (should be private) ↵reed@google.com2012-03-201-2/+1
| | | | | | | | LayerIter Review URL: https://chromiumcodereview.appspot.com/9753008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127753 0039d316-1c4b-4281-b951-d872f2087c98
* Implement input type=color UIkeishi@chromium.org2012-03-202-0/+25
| | | | | | | | | | | BUG=92608 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126889 Review URL: https://chromiumcodereview.appspot.com/9203001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127656 0039d316-1c4b-4281-b951-d872f2087c98
* ui/gfx: Do not use the deprecated SkBitmap::getConfig() function.tfarina@chromium.org2012-03-191-1/+1
| | | | | | | | | | | Instead this patch uses SkBitmap::config() which is the preferred way. R=asvitkine@chromium.org TBR=brettw@chromium.org,thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/9720040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127468 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant memory clears when constructing BitmapPlatformDevice ↵twiz@chromium.org2012-03-1615-78/+121
| | | | | | | | | | | | | | | instances on Mac and Windows. PlatformCanvas construction is showing up as a performance bottleneck due to unnecessary initialization. The change moves the clear to the call sites where it is necessary. Note: On Linux, cairo always allocates an initialized surface, so there is no way to bypass the performance penalty. BUG=112009 TEST=All of them Review URL: http://codereview.chromium.org/9416017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127196 0039d316-1c4b-4281-b951-d872f2087c98
* skia/ext: Add SK_API to a function used from a testthakis@chromium.org2012-03-161-2/+2
| | | | | | | | | BUG=90078 TEST=none Review URL: http://codereview.chromium.org/9699078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127068 0039d316-1c4b-4281-b951-d872f2087c98
* remoting: Move CGRectToSkIRect() to the only file where it's calledthakis@chromium.org2012-03-152-11/+0
| | | | | | | | | | | The alternative would be to add SK_API to that function. BUG=90078 TEST=none Review URL: http://codereview.chromium.org/9705064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127036 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 126889 - Implement input type=color UImarkusheintz@chromium.org2012-03-152-25/+0
| | | | | | | | | | | | BUG=92608 TEST= Review URL: http://codereview.chromium.org/9203001 TBR=keishi@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126899 0039d316-1c4b-4281-b951-d872f2087c98
* Implement input type=color UIkeishi@chromium.org2012-03-152-0/+25
| | | | | | | | | | BUG=92608 TEST= Review URL: http://codereview.chromium.org/9203001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126889 0039d316-1c4b-4281-b951-d872f2087c98
* Remove static initializers in Skia.pliard@chromium.org2012-03-132-21/+25
| | | | | | | | | | | | | | | | | | This patch does the following things: - Add missing SK_USE_POSIX_THREADS in skia.gyp. This enables the patch sent by David Turner making SkMutex POD in order to remove static initializers (on Android, Linux and Mac). - Remove static initializers in SkFontHost_fontconfig.cpp and SkMemory_new_handler.cpp. Note that the global_fc_typefaces map was populated but never read therefore I removed it. Let me know if I'm wrong. BUG=94925 Review URL: http://codereview.chromium.org/9668002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126385 0039d316-1c4b-4281-b951-d872f2087c98
* Add _EXPORT macros to skia/ext.thakis@chromium.org2012-03-091-3/+3
| | | | | | | | | | | SkMatrixToCGAffineTransform and SkiaBitLocker are both used by WebKit. BUG=90078 TEST=none Review URL: http://codereview.chromium.org/9648024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125892 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 125473 - skia: Change MakeOpaque() function to take a gfx::Rect ↵akalin@chromium.org2012-03-073-23/+19
| | | | | | | | | | | | | | | parameter. BUG=100898 R=pkasting@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9581040 TBR=tfarina@chromium.org Review URL: https://chromiumcodereview.appspot.com/9621019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125478 0039d316-1c4b-4281-b951-d872f2087c98
* skia: Change MakeOpaque() function to take a gfx::Rect parameter.tfarina@chromium.org2012-03-073-19/+23
| | | | | | | | | | BUG=100898 R=pkasting@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9581040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125473 0039d316-1c4b-4281-b951-d872f2087c98
* Remove implicit dependency from 'skia' on 'ui'.thakis@chromium.org2012-03-051-2/+6
| | | | | | | | | | | This is needed for the components build. Just adding an explicit dependency from skia to ui doesn't work because ui already depends on skia. BUG=90078 TEST=No linker errors when linking libskia.dylib Review URL: http://codereview.chromium.org/9578010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125009 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on Chromium base libraries and libicu for ↵reed@google.com2012-02-242-16/+7
| | | | | | | | SkFontHost_fontconfig in preparation for inclusion into Skia Review URL: https://chromiumcodereview.appspot.com/9456020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123469 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some gcc 4.6 compiler warnings in skia/ext.tony@chromium.org2012-02-242-3/+6
| | | | | | | | | BUG=None Review URL: http://codereview.chromium.org/9456022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123431 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ValidFontID.bungeman@google.com2012-02-231-13/+0
| | | | | | Review URL: http://codereview.chromium.org/9347043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123282 0039d316-1c4b-4281-b951-d872f2087c98
* Skia DEPS roll to 3147epoger@chromium.org2012-02-104-4/+6
| | | | | | Review URL: https://chromiumcodereview.appspot.com/9346023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121451 0039d316-1c4b-4281-b951-d872f2087c98
* Intoroducing Motoya font for ChromeOSkochi@chromium.org2012-02-091-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | This is a retry of r120926, which was reverted. The error was due to duplicate entry in the translation resource file, which only happens on 'Official' build. We will introduce Motoya fonts (MotoyaG04Gothic, MotoyaG04Mincho) as the default Japanese font for ChromeOS. This CL is for preparing resource to define default font and Skia to check the font family is compatible with their counterparts of MS Windows fonts. Note that GTK font specification in the resource does not handle multiple fonts (e.g. "MotoyaG04Gothic 10, IPAPGothic 10") and I left it as is (see crosbug.com/17382 for details). Fontconfig should cover the compatibility check (IPAPGothic => MotoyaG04Gothic) and display the proper font. BUG=chromium-os:16690 TEST=build, run and see Japanese fonts are properly displayed in both web contents and Chrome UI. Review URL: http://codereview.chromium.org/9365012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121170 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 120926 - Intoroducing Motoya font for ChromeOSkochi@google.com2012-02-081-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | We will introduce Motoya fonts (MotoyaG04Gothic, MotoyaG04Mincho) as the default Japanese font for ChromeOS. This CL is for preparing resource to define default font and Skia to check the font family is compatible with their counterparts of MS Windows fonts. Note that GTK font specification in the resource does not handle multiple fonts (e.g. "MotoyaG04Gothic 10, IPAPGothic 10") and I left it as is (see crosbug.com/17382 for details). Fontconfig should cover the compatibility check (IPAPGothic => MotoyaG04Gothic) and display the proper font. BUG=chromium-os:16690 TEST=build, run and see Japanese fonts are properly displayed in both web contents and Chrome UI. Review URL: http://codereview.chromium.org/9309048 TBR=kochi@chromium.org Review URL: https://chromiumcodereview.appspot.com/9363017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120949 0039d316-1c4b-4281-b951-d872f2087c98
* Intoroducing Motoya font for ChromeOSkochi@chromium.org2012-02-081-0/+4
| | | | | | | | | | | | | | | | | | | | | We will introduce Motoya fonts (MotoyaG04Gothic, MotoyaG04Mincho) as the default Japanese font for ChromeOS. This CL is for preparing resource to define default font and Skia to check the font family is compatible with their counterparts of MS Windows fonts. Note that GTK font specification in the resource does not handle multiple fonts (e.g. "MotoyaG04Gothic 10, IPAPGothic 10") and I left it as is (see crosbug.com/17382 for details). Fontconfig should cover the compatibility check (IPAPGothic => MotoyaG04Gothic) and display the proper font. BUG=chromium-os:16690 TEST=build, run and see Japanese fonts are properly displayed in both web contents and Chrome UI. Review URL: http://codereview.chromium.org/9309048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120926 0039d316-1c4b-4281-b951-d872f2087c98
* Set CG clip to empty explicitlycaryclark@chromium.org2012-01-311-1/+9
| | | | | | | | | | | | | | | Skia draws Mac user elements by creating a CoreGraphics context that mirrors Skia's SkCanvas' context. CoreGraphics does not consider a newly created path to be empty. Explicitly set it to empty so the subsequent drawing is clipped out. BUG: 111642 TEST: http://jsfiddle.net/kenjibaheux/UN3Dt/3/ Review URL: http://codereview.chromium.org/9104010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119962 0039d316-1c4b-4281-b951-d872f2087c98
* roll skia to 3035reed@google.com2012-01-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/9199012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117659 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the CoreGraphics context for offscreen layers.caryclark@google.com2012-01-111-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | UI elements like buttons are drawn on Mac by pointing the CoreGraphics context at the Skia bitmap associated with the current device. If the elements are drawn in a transparent context, Skia creates an offscreen layer to capture the draw, then applies the transparency. CoreGraphics does not know that it is drawing to an offscreen, so the clip and matrix need to be adjusted by the offscreen's origin, which is its position on the device. Also, use getTopDevice() instead of getDevice() to obtain the bitmap. Normally, they will return the same SkDevice (and in that case, getOrigin() will return (0,0)) but if there's a layer present, getDevice() will return the actual device instead of the tempoary offscreen. BUG:108767 TEST:http://jsfiddle.net/casaschi/JWkfA/ Review URL: http://codereview.chromium.org/9129001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117217 0039d316-1c4b-4281-b951-d872f2087c98
* Beef up and reenable memory diagnostics for skia canvascpu@chromium.org2012-01-061-39/+38
| | | | | | | | | | We got a big crash spike in canary. See bug below. BUG=7913 TEST=see bug Review URL: http://codereview.chromium.org/9112026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116646 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity defects in skia/ext:vandebo@chromium.org2012-01-037-25/+20
| | | | | | | | | | | | | - Three uninit ctors, two dead codes, and a misuse of var args. CID=100083, 101537, 17746, 9369, 9279, 9278 BUG=none TEST=none Review URL: http://codereview.chromium.org/8965060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116189 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize |SkTypeface| creation on Linux.asvitkine@chromium.org2011-12-222-16/+67
| | | | | | | | | | | | | | | | | | Add a map to cache the results of FontConfig lookup to avoid making excessive FontConfig queries. This improves the speed of |gfx::Font| creation under Linux, which is backed by a |SkTypeface|, as well as |RenderTextLinux| drawing code. BUG=107394 TEST=In Linux Aura, launch about:tracing and notice that "RenderTextLinux::DrawVisualText SetFont" times have gone way down. Review URL: http://codereview.chromium.org/9028001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115619 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor some parts of |FontConfigDirect::Match()| into helper functions.asvitkine@chromium.org2011-12-221-107/+114
| | | | | | | | | | | | | | | No functional changes. I'm looking to make some changes to this class to optimize SkTypeface creation on Linux. This refactoring makes the code a little bit less unwieldy to work with. BUG=none TEST=none Review URL: http://codereview.chromium.org/9021035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115454 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new ctor to CanvasSkia that takes a const SkBitmap&.tfarina@chromium.org2011-12-211-3/+3
| | | | | | | | | | BUG=100898 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/9006001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115384 0039d316-1c4b-4281-b951-d872f2087c98
* Change SkFileDescriptorStream to handle failure to open the file descriptorreed@google.com2011-12-061-11/+8
| | | | | | | | (by initializing its length_ to 0), and to return the number of bytes skipped if buffer==null, rather than returning the offset. Review URL: http://codereview.chromium.org/8800017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113197 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to skia/.avi@chromium.org2011-11-232-11/+20
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8681014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111413 0039d316-1c4b-4281-b951-d872f2087c98
* Implement skia sandbox callbackarthurhsu@chromium.org2011-11-232-0/+41
| | | | | | | | | | BUG=103032 TEST=none Review URL: http://codereview.chromium.org/8566026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111400 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to skia/.avi@chromium.org2011-11-211-3/+4
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8595024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110915 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to skia/.avi@chromium.org2011-11-161-1/+1
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8539046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110318 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 109461 - twiz@chromium.org2011-11-142-58/+4
| | | | | | | | | | | | | | | | | | | Re-introduction of release mode checks to determine the cause of CreateDIBSection failures. The crash is happening outside of the expected conditions in which CreateDIBSection would fail (large bitmap size, GDI and virtual memory pressure). To track the cause, this CL attempts to capture the last system error on bitmap allocation failure. See previous checks here: http://codereview.chromium.org/8341090 BUG=101934, 104063 TEST=NONE Review URL: http://codereview.chromium.org/8509030 TBR=twiz@chromium.org Review URL: http://codereview.chromium.org/8565027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109978 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded forward declarations in printing, sandbox, and skia.thestig@chromium.org2011-11-142-9/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8538001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109961 0039d316-1c4b-4281-b951-d872f2087c98
* Re-introduction of release mode checks to determine the cause of ↵twiz@chromium.org2011-11-102-4/+58
| | | | | | | | | | | | | | | CreateDIBSection failures. The crash is happening outside of the expected conditions in which CreateDIBSection would fail (large bitmap size, GDI and virtual memory pressure). To track the cause, this CL attempts to capture the last system error on bitmap allocation failure. See previous checks here: http://codereview.chromium.org/8341090 BUG=101934 TEST=NONE Review URL: http://codereview.chromium.org/8509030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109461 0039d316-1c4b-4281-b951-d872f2087c98