| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instances on Mac and Windows. PlatformCanvas construction is showing up as a performance bottleneck due to unnecessary initialization.
The change moves the clear to the call sites where it is necessary.
Note: On Linux, cairo always allocates an initialized surface, so there is no way to bypass the performance penalty.
BUG=112009
TEST=All of them
Review URL: http://codereview.chromium.org/9416017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90078
TEST=none
Review URL: http://codereview.chromium.org/9699078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The alternative would be to add SK_API to that function.
BUG=90078
TEST=none
Review URL: http://codereview.chromium.org/9705064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=92608
TEST=
Review URL: http://codereview.chromium.org/9203001
TBR=keishi@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=92608
TEST=
Review URL: http://codereview.chromium.org/9203001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch does the following things:
- Add missing SK_USE_POSIX_THREADS in skia.gyp.
This enables the patch sent by David Turner making SkMutex POD in order to
remove static initializers (on Android, Linux and Mac).
- Remove static initializers in SkFontHost_fontconfig.cpp and
SkMemory_new_handler.cpp. Note that the global_fc_typefaces map was
populated but never read therefore I removed it. Let me know if I'm wrong.
BUG=94925
Review URL: http://codereview.chromium.org/9668002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SkMatrixToCGAffineTransform and SkiaBitLocker are both used by WebKit.
BUG=90078
TEST=none
Review URL: http://codereview.chromium.org/9648024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parameter.
BUG=100898
R=pkasting@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9581040
TBR=tfarina@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9621019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9581040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for the components build. Just adding an explicit dependency from skia to ui doesn't work because ui already depends on skia.
BUG=90078
TEST=No linker errors when linking libskia.dylib
Review URL: http://codereview.chromium.org/9578010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
SkFontHost_fontconfig in preparation for inclusion into Skia
Review URL: https://chromiumcodereview.appspot.com/9456020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: http://codereview.chromium.org/9456022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9347043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9346023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a retry of r120926, which was reverted. The error was due to
duplicate entry in the translation resource file, which only happens
on 'Official' build.
We will introduce Motoya fonts (MotoyaG04Gothic, MotoyaG04Mincho)
as the default Japanese font for ChromeOS. This CL is for preparing
resource to define default font and Skia to check the font family
is compatible with their counterparts of MS Windows fonts.
Note that GTK font specification in the resource does not
handle multiple fonts (e.g. "MotoyaG04Gothic 10, IPAPGothic 10")
and I left it as is (see crosbug.com/17382 for details).
Fontconfig should cover the compatibility check
(IPAPGothic => MotoyaG04Gothic) and display the proper font.
BUG=chromium-os:16690
TEST=build, run and see Japanese fonts are properly displayed in both web contents and Chrome UI.
Review URL: http://codereview.chromium.org/9365012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will introduce Motoya fonts (MotoyaG04Gothic, MotoyaG04Mincho)
as the default Japanese font for ChromeOS. This CL is for preparing
resource to define default font and Skia to check the font family
is compatible with their counterparts of MS Windows fonts.
Note that GTK font specification in the resource does not
handle multiple fonts (e.g. "MotoyaG04Gothic 10, IPAPGothic 10")
and I left it as is (see crosbug.com/17382 for details).
Fontconfig should cover the compatibility check
(IPAPGothic => MotoyaG04Gothic) and display the proper font.
BUG=chromium-os:16690
TEST=build, run and see Japanese fonts are properly displayed in both web contents and Chrome UI.
Review URL: http://codereview.chromium.org/9309048
TBR=kochi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9363017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will introduce Motoya fonts (MotoyaG04Gothic, MotoyaG04Mincho)
as the default Japanese font for ChromeOS. This CL is for preparing
resource to define default font and Skia to check the font family
is compatible with their counterparts of MS Windows fonts.
Note that GTK font specification in the resource does not
handle multiple fonts (e.g. "MotoyaG04Gothic 10, IPAPGothic 10")
and I left it as is (see crosbug.com/17382 for details).
Fontconfig should cover the compatibility check
(IPAPGothic => MotoyaG04Gothic) and display the proper font.
BUG=chromium-os:16690
TEST=build, run and see Japanese fonts are properly displayed in both web contents and Chrome UI.
Review URL: http://codereview.chromium.org/9309048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia draws Mac user elements by creating a CoreGraphics context
that mirrors Skia's SkCanvas' context.
CoreGraphics does not consider a newly created path to be empty.
Explicitly set it to empty so the subsequent drawing is clipped out.
BUG: 111642
TEST: http://jsfiddle.net/kenjibaheux/UN3Dt/3/
Review URL: http://codereview.chromium.org/9104010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9199012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI elements like buttons are drawn on Mac by pointing
the CoreGraphics context at the Skia bitmap associated
with the current device. If the elements are drawn
in a transparent context, Skia creates an offscreen
layer to capture the draw, then applies the transparency.
CoreGraphics does not know that it is drawing to an
offscreen, so the clip and matrix need to be adjusted
by the offscreen's origin, which is its position on
the device.
Also, use getTopDevice() instead of getDevice() to
obtain the bitmap. Normally, they will return the same
SkDevice (and in that case, getOrigin() will return
(0,0)) but if there's a layer present, getDevice()
will return the actual device instead of the tempoary
offscreen.
BUG:108767
TEST:http://jsfiddle.net/casaschi/JWkfA/
Review URL: http://codereview.chromium.org/9129001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We got a big crash spike in canary. See bug below.
BUG=7913
TEST=see bug
Review URL: http://codereview.chromium.org/9112026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Three uninit ctors, two dead codes, and a misuse of var args.
CID=100083, 101537, 17746, 9369, 9279, 9278
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8965060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a map to cache the results of FontConfig
lookup to avoid making excessive FontConfig
queries.
This improves the speed of |gfx::Font| creation
under Linux, which is backed by a |SkTypeface|,
as well as |RenderTextLinux| drawing code.
BUG=107394
TEST=In Linux Aura, launch about:tracing and notice that
"RenderTextLinux::DrawVisualText SetFont" times have gone way down.
Review URL: http://codereview.chromium.org/9028001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No functional changes.
I'm looking to make some changes to this class to optimize SkTypeface
creation on Linux. This refactoring makes the code a little bit less
unwieldy to work with.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9021035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100898
R=pkasting@chromium.org
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/9006001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(by initializing its length_ to 0), and to return the number of bytes skipped
if buffer==null, rather than returning the offset.
Review URL: http://codereview.chromium.org/8800017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8681014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103032
TEST=none
Review URL: http://codereview.chromium.org/8566026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8595024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8539046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-introduction of release mode checks to determine the cause of CreateDIBSection failures.
The crash is happening outside of the expected conditions in which CreateDIBSection would fail (large bitmap size, GDI and virtual memory pressure). To track the cause, this CL attempts to capture the last system error on bitmap allocation failure.
See previous checks here: http://codereview.chromium.org/8341090
BUG=101934, 104063
TEST=NONE
Review URL: http://codereview.chromium.org/8509030
TBR=twiz@chromium.org
Review URL: http://codereview.chromium.org/8565027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateDIBSection failures.
The crash is happening outside of the expected conditions in which CreateDIBSection would fail (large bitmap size, GDI and virtual memory pressure). To track the cause, this CL attempts to capture the last system error on bitmap allocation failure.
See previous checks here: http://codereview.chromium.org/8341090
BUG=101934
TEST=NONE
Review URL: http://codereview.chromium.org/8509030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8499024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bitmap_platform_device_linux.cc:
- according to pkg-config cairo include dir is
/usr/local/include/cairo (even on linux),
so we have to include cairo.h and not cairo/cairo.h
- Define DrawToNativeContext on OpenBSD too
BUG=
TEST=
Review URL: http://codereview.chromium.org/8339020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CanvasT<>::initialize crash
BUG=101934,102740
TEST=none
Review URL: http://codereview.chromium.org/8341090
TBR=groby@chromium.org, vandebo@chromium.org
Review URL: http://codereview.chromium.org/8437105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8440008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101934
TEST=none
Review URL: http://codereview.chromium.org/8341090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=69149
describes a situation where running webkit tests
sporadically crashes in the Debug build.
The context returned by CGContextForData is NULL,
so an early return prevents the BitmapPlatformDevice
constructor from firing an assert in this case.
The callers already anticipate a NULL result, and
will propogate the error correctly.
BUG=WK69149
TEST=run webkit tests in a Debug build repeatedly
Review URL: http://codereview.chromium.org/8118014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8122013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* To mark@, sky@
** base/win/scoped_hdc.h
** base/win/scoped_select_object.h
2 Fix leak in printing
* To kmadhusu@
** Play object creation command in metafile once
** Fix trivial leaks
3 Fix leak in SKIA
* To twiz@
** Fix font leak
BUG=98523
TEST=Manual on Win7
Review URL: http://codereview.chromium.org/8084018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
last page of the PDF
BUG=93145
TEST=Please refer to bug report.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103021
Original review URL: codereview.chromium.org/7719014
Please refer to trybot results in the last patch of original review url.
Review URL: http://codereview.chromium.org/8059034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only previews the last page of the PDF
BUG=93145
TEST=Please refer to bug report.
Review URL: http://codereview.chromium.org/7719014
TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/8052020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
last page of the PDF
BUG=93145
TEST=Please refer to bug report.
Review URL: http://codereview.chromium.org/7719014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no conversion from Double in Skia.
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8038033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removed default_plugin from aura build
- Added new canvas_paint_x and renamed canvas_paint_linux to canvas_paint_gtk
BUG=97131
TEST=none
Review URL: http://codereview.chromium.org/8015012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add some files and fix some code to make skia build on Android.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7920020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=No visible changes.
Review URL: http://codereview.chromium.org/7847002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7799023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PlatformDevice is now a base interface, which is implemented by the various flavours of BitmapPlatformDevice, and VectorPlatformDevice. The BitmapPlatformDevice and VectorPlatformDevice classes now inherit directly from SkDevice, or SkPDFDevice, as appropriate.
PlatformDevice helper functions access the PlatformDevice interface attached to a SkDevice via meta-data on the SkDevice.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98230
Review URL: http://codereview.chromium.org/7633040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98585 0039d316-1c4b-4281-b951-d872f2087c98
|