| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
memcheck reported errors which need to be investigated
> Call version of SkFontHost_fontconfig in Skia (cloned from here).
> Retool the direct/remove plumbing to use SkFontConfigInterface.
>
> This change allows Skia to interate on the details of SkFontHost w/o having
> to synchromize with chrome on each change. It also means Skia's internal testing
> can exercise exactly the same config that Chrome does.
> Review URL: https://codereview.chromium.org/12391070
TBR=reed@google.com
Review URL: https://codereview.chromium.org/12771003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Retool the direct/remove plumbing to use SkFontConfigInterface.
This change allows Skia to interate on the details of SkFontHost w/o having
to synchromize with chrome on each change. It also means Skia's internal testing
can exercise exactly the same config that Chrome does.
Review URL: https://codereview.chromium.org/12391070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Set proper definitions to choose proper gamma for Android.
BUG=180101
TBR=tomhudson,reed,bungeman
Review URL: https://chromiumcodereview.appspot.com/12579004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12546005/
Review URL: https://codereview.chromium.org/12543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've now switched to Skia from CoreGraphics entirely. See
http://crbug.com/110881 for details.
This change removes the vestigal "use_skia" variable. I'll send follow-up
patches to remove uses of USE_SKIA from Chromium source.
BUG=110881
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/12379030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12335104/
Review URL: https://codereview.chromium.org/12319120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 184402 due to .DEPS.git SNAFU
>
> > Roll Skia DEPS to r7840
> >
> > control: https://codereview.chromium.org/12326095/
> > Review URL: https://codereview.chromium.org/12315072
>
> TBR=robertphillips@google.com
> Review URL: https://codereview.chromium.org/12317099
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/12314098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Roll Skia DEPS to r7840
>
> control: https://codereview.chromium.org/12326095/
> Review URL: https://codereview.chromium.org/12315072
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/12317099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12326095/
Review URL: https://codereview.chromium.org/12315072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12326051/
Review URL: https://codereview.chromium.org/12314051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of try run with flag enabled as warning:
On linux_clang, there's false positives from a bunch of assert usage that does !"string" or "string" for a true or false value. It's only in third_party (Mesa, skia, libjingle, etc.) so it probably wouldn't be too hard to disable the warnings in those subtrees.
It diagnoses 4 useful locations:
1.
../../base/debug/trace_event_unittest.cc:70:41: warning: implicit conversion turns string literal into bool: 'const char [2]' to 'bool' [-Wstring-conversion]
TraceLog::GetInstance()->SetEnabled("*");
~~~~~~~~ ^~~
2.
../../sync/syncable/entry_kernel.cc:77:38: warning: implicit conversion turns string literal into bool: 'const char [5]' to 'bool' [-Wstring-conversion]
value->SetBoolean("encrypted", "true");
~~~~~ ^~~~~~
3.
../../chrome/browser/webdata/web_data_service.cc:334:17: warning: implicit conversion turns string literal into bool: 'const char [44]' to 'bool' [-Wstring-conversion]
DLOG_ASSERT("WebDataService dtor called without Shutdown");
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:595:43: note: expanded from macro 'DLOG_ASSERT'
4.
../../chrome/browser/renderer_host/web_cache_manager_unittest.cc:259:20: warning: implicit conversion turns string literal into bool: 'const char [29]' to 'bool' [-Wstring-conversion]
EXPECT_FALSE("Unexpected entry in strategy");
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Finding #1 is what made me look into this, #3 and #4 are not doing what they're supposed to, and #2 is kind of funny so not all is lost.
So, 3 bugs and 1 very-close-to-a-bug: seems worth enabling.
R=thakis@chromium.org
TBR=darin@chromium.org, dhollowa@chromium.org, brettw@chromium.org, zea@chromium.org
BUG=177306
Review URL: https://chromiumcodereview.appspot.com/12258039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12321027/
Review URL: https://codereview.chromium.org/12321026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12296041/
Review URL: https://codereview.chromium.org/12282050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
skia::PaintSimplifier subclasses SkDrawFilter to reduce the quality of draws. The intent is to be able to place less of a burden on the rasterizer during Android flings or other situations where we need a lot of pixels but they won't spend long on screen.
This CL does not actually invoke the PaintSimplifier. The code is extracted from https://codereview.chromium.org/12210081/; deciding when to simplify will be a separate CL.
BUG=174945
TBR=reed
Review URL: https://chromiumcodereview.appspot.com/12207157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Minimal implementation for cc::Picture::IsCheapInRect() with new
classes skia::AnalysisCanvas and skia::AnalysisDevice.
Supercedes http://codereview.chromium.org/12184010/.
Based on GatherPixelRefs.
Not a good implementation yet, but it does seem to count draw calls
and is right more often than a stopped clock. I'm not happy with
clipping/culling; something is going very wrong there.
TBR=nduca,junov,tomhudson
CC=skyostil
BUG=173426
Review URL: https://chromiumcodereview.appspot.com/12213018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12209049/
Review URL: https://codereview.chromium.org/12207053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12226009/
Review URL: https://codereview.chromium.org/12221016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Impl-side painting uses special implementation of SkPixelRef which
allows (un)locking on multiple threads. The check in SkCanvas
is thus too strict and causes assertion to fail on debug build.
Use SK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK to disable suck
checks.
BUG=171776
TESTED=Ran it with impl-side painting
Review URL: https://chromiumcodereview.appspot.com/12092094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12087123/
Review URL: https://codereview.chromium.org/12096101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Please see: https://codereview.chromium.org/12094033/
Review URL: https://codereview.chromium.org/12091041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12052054/
Review URL: https://codereview.chromium.org/12035066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/12045012/
Review URL: https://codereview.chromium.org/12036018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/11966002/
Review URL: https://codereview.chromium.org/11958003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This is a second upload of https://codereview.chromium.org/11786010/
Review URL: https://codereview.chromium.org/11783098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11782027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 175328
>
> > Roll Skia DEPS to r7044 & add SK_IGNORE_TRANS_CLAMP_FIX and SK_IGNORE_FAST_SCALEMATRIX_INVERT
> >
> > control: https://codereview.chromium.org/11791014/
> > Review URL: https://codereview.chromium.org/11779016
>
> TBR=robertphillips@google.com
> Review URL: https://codereview.chromium.org/11784021
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11779021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Roll Skia DEPS to r7044 & add SK_IGNORE_TRANS_CLAMP_FIX and SK_IGNORE_FAST_SCALEMATRIX_INVERT
>
> control: https://codereview.chromium.org/11791014/
> Review URL: https://codereview.chromium.org/11779016
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11784021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
SK_IGNORE_FAST_SCALEMATRIX_INVERT
control: https://codereview.chromium.org/11791014/
Review URL: https://codereview.chromium.org/11779016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/11743030/
Review URL: https://codereview.chromium.org/11747018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/11566039/
Review URL: https://codereview.chromium.org/11572050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"SkTileGrid.cpp(77): error C3861: 'alloca': identifier not found"
> Roll Skia DEPS to r6819 & update skia.gyp
>
> control: https://codereview.chromium.org/11564035/
> Review URL: https://codereview.chromium.org/11566030
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11565039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/11564035/
Review URL: https://codereview.chromium.org/11566030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68551
Review URL: https://chromiumcodereview.appspot.com/11568023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=163980
Review URL: https://chromiumcodereview.appspot.com/11453014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The old harfbuzz is not used at all.
BUG=68551
Review URL: https://codereview.chromium.org/11554013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11447015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The offending code was fixed in Skia r6641, which we have now rolled past.
BUG=163104
TBR=thakis
Review URL: https://chromiumcodereview.appspot.com/11438014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=163104
Review URL: https://chromiumcodereview.appspot.com/11412302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
SK_DISABLE_SEPARABLE_MASK_BLUR flag from skia.gyp, and suppress the resulting failures until they are rebaselined.
Review URL: https://codereview.chromium.org/11411361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/11348377/
Review URL: https://codereview.chromium.org/11414309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class behaves like scoped_refptr and wraps the raw SkRefCnt subclass
so that we don't have to call ref() and unref() directly on the pointers.
Tested by:
unit_tests:RefPtrTest.ReferenceCounting
unit_tests:RefPtrTest.Construct
unit_tests:RefPtrTest.DeclareAndAssign
unit_tests:RefPtrTest.Assign
unit_tests:RefPtrTest.Upcast
BUG=163454
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11418217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke bunch of layout tests on Mac:
canvas/philip/tests/2d.text.draw.align.center.html,canvas/philip/tests/2d.text.draw.align.end.ltr.html,canvas/philip/tests/2d.text.draw.align.end.rtl.html,canvas/philip/tests/2d.text.draw.align.left.html,canvas/philip/tests/2d.text.draw.align.right.html,canvas/philip/tests/2d.text.draw.align.start.ltr.html,canvas/philip/tests/2d.text.draw.align.start.rtl.html,canvas/philip/tests/2d.text.draw.baseline.alphabetic.html,canvas/philip/tests/2d.text.draw.baseline.ideographic.html,canvas/philip/tests/2d.text.draw.fill.maxWidth.bound.html,canvas/philip/tests/2d.text.draw.fontface.html,canvas/philip/tests/2d.text.draw.fontface.repeat.html,canvas/philip/tests/2d.text.draw.space.basic.html,canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.center.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.end.ltr.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.end.rtl.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.left.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.right.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.start.ltr.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.start.rtl.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.alphabetic.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.ideographic.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fill.maxWidth.bound.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.repeat.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.space.basic.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html
> Roll Skia DEPS to r6641 & add suppressions
>
> control: https://codereview.chromium.org/11418289/
> Review URL: https://codereview.chromium.org/11412301
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11428143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/11418289/
Review URL: https://codereview.chromium.org/11412301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
revert)
Revert 170460 - Revert 170448 - Roll Skia DEPS to r6630
Getting FATAL:image_skia.cc(388)] Check failed: CanRead() in EnableAppModeTest
control: https://codereview.chromium.org/11419241/
Review URL: https://codereview.chromium.org/11416276
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11416284
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11418258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Getting FATAL:image_skia.cc(388)] Check failed: CanRead() in EnableAppModeTest
control: https://codereview.chromium.org/11419241/
Review URL: https://codereview.chromium.org/11416276
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/11416284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
control: https://codereview.chromium.org/11419241/
Review URL: https://codereview.chromium.org/11416276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently if you set profiling=1 content_shell will load,
it will just load to a white screen (and attempts to sample
the binary with perf will not get proper stacks).
This adds -mapcs and -marm per the AndroidPerf wiki docs.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11316228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11421143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
can later rebaseline.
Review URL: https://codereview.chromium.org/11430002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11414115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169091 0039d316-1c4b-4281-b951-d872f2087c98
|