| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
performance problems, so it would be nice to see what average users are seeing.
Review URL: http://codereview.chromium.org/113604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=brettw
Review URL: http://codereview.chromium.org/115414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Committed on behalf of craig.schlenter@gmail.com.
Original review URL=http://codereview.chromium.org/115303
Review URL: http://codereview.chromium.org/115310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tests failing.
TBR=brettw
Review URL: http://codereview.chromium.org/113342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
placed in third_party. All relevant skia changes (for all 3 platforms) have
been upstreamed.
Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp
(now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia
now requires C99 integer types, which MSVC doesn't support natively. I have put
typedefs in config/win/stdint.h.
Note that the new version of skia appears to render rects whose coordinates
are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There
were a couple obvious instances of this in the code which I fixed, but there may
be more.
There were ~35 layout test failures due to minor pixel differences which I
rebaselined on Windows and Linux, and 8 genuine failures related to masks and
stroked text, which I have put in text_expectations.txt and assigned to
myself. (There was another change which broke ~1700 tests on each platform,
but I put that change behind an #ifdef for now).
R=brettw
Review URL: http://codereview.chromium.org/65012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(No code change.)
git ls-tree -r HEAD | grep '^100755' | cut -f2 |
egrep '\.(png|txt|mm|cc|h|checksum|asm|js|html|c|css|xml|grd|json)$' |
xargs chmod a-x
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is paired with http://codereview.chromium.org/67284
This CL (for commit purposes) includes http://codereview.chromium.org/67284
BUG=4463,11232,11233,11234,11235
Review URL: http://codereview.chromium.org/99030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. The platform paint was allocating at a size bigger than necessary.
. ChromeCanvas::DrawStringInt was not taking into account the matrix on
the canvas, which means the text could be drawn at the wrong
location.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/99279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a cherry-pick of the following change:
http://code.google.com/p/skia/source/detail?r=159
We introduce this change for the 'lighter' composite operation. We need kAdd_Mode, which is introduced in this change for the operation.
Patch by Shinichiro Hamaji.
BUG=1619
Review URL: http://codereview.chromium.org/93093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on large <canvas> elements. We disable the __debugbreak
only when skia tells us it is prepared to correctly
handle a failed (NULL) malloc(). It does this
by calling sk_malloc_flags() without SK_MALLOC_THROW.
Note that, since the switch to tcmalloc, the new_handler
was not getting called at all (since tcmalloc doesn't
support it yet), so this crash is currently unreproducible
in trunk. In order to test this change, I reverted the
tcmalloc change in my client. This is not the case in the
stable branch, since it doesn't use tcmalloc, so this change
is still needed there. (It will also be needed in trunk
again once mbelshe's re-implementation of the new_handler
is in).
BUG=http://www.crbug.com/2044
Review URL: http://codereview.chromium.org/100163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/100097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
HSLToSkColor premultiplies its output, should this instead live in the ImageOperations bitmap munging code?
Review URL: http://codereview.chromium.org/79082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/100046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
BUG=10736
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My previous checkin was wrong, because the backing bitmap was just the damaged rect, not the entire window.
Since the translation will be ignored for the cairo surface, allocate from the origin to the edge of the damage rect.
Patch from Vincent Zanotti.
Review URL: http://codereview.chromium.org/62149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Applying this patch locally to check that it doesn't break any layout
tests etc:
http://codereview.appspot.com/41081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Set $RPATH to $LIB_DIR in the SCons configuration.
* Add missing dependencies:
* net/net.gyp:net
=> testing/gtest.gyp:gtest
* third_party/libxml/libxml.gyp:xmlcatalog
=> third_party/icu38/icu38.gyp:icuuc
* chrome/chrome.gyp:perf_tests
=> renderer
=> views
=> webkit/webkit.gyp:glue
* Add files:
* third_party/WebKit/WebCore/loader/icon/IconRecord.cpp
* third_party/WebKit/WebCore/page/Coordinates.cpp
* skia/sgl/SkUnPreMultiply.cpp
* Exclude on Linux:
* chrome/views/controls/scroll_view.cc
* chrome/views/focus/external_focus_tracker.cc
* media/filter/ffmpeg_demuxer.{cc,h}
* Remove files:
* third_party/WebKit/WebCore/Configurations/Version.xcconfig
* Sort the chrome.gyp:views linux exclusion list.
* DEPS roll for $SHLINKFLAGS settings in gyp.
Review URL: http://codereview.chromium.org/88058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awalker
Review URL: http://codereview.chromium.org/77033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awalker
BUG=9904
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9904
R=brettw
Review URL: http://codereview.chromium.org/75020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a renderer CrashForBitmapAllocationFailure does not crash in any of the 4 CHECKS(), it
crashes calling GetProcessMemoryInfo()
- Because GetProcessMemoryInfo() tries to load PSAPI.dll and the sandbox blocks it.
- Now it gives a better dump by disabling the iniling of the function
- Adds a check for the shared memory, which I suspect is the real cause for some of the crashes
BUG=10585
Review URL: http://codereview.chromium.org/75027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to unfork our Skia, VDMX parsing has been moved into WebKit
in r42548.
The Harfbuzz stuff should have been functional, but noone on the
WebKit side wants to review a bidi patch so that side never actually
landed. At this point it's probably better to remove the current
Harfbuzz support in Skia with a view to jumping straight to the
version agreed with Mike Reed at some point in the future.
http://codereview.chromium.org/75011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is the Chromium side of:
https://bugs.webkit.org/show_bug.cgi?id=25116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
without GTK.
I had to recreate this patch as my workspace for various
resonds. UGH!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/67024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/63048
(by Craig Schlenter)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This brings in support for reading TrueType tables via Skia. This
should allow us to move some of our metrics changes into our WebKit
port and out of Skia.
http://codereview.chromium.org/63133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
parameterize the 'type' setting of the various library targets, with a
default of 'static_library'.
(Hat tip to Craig Schlenter.)
Review URL: http://codereview.chromium.org/62127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Don't triple buffer, we are already effectively double buffering by drawing
onto a ChromeCanvas (bitmap), and then blitting. We don't need the extra
GDK double buffering.
- Don't translate the origin, and just blit the dirty rectangle.
Review URL: http://codereview.chromium.org/63057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I need another round trip land a patch in WebKit to fix it correctly, but
noones's around now and I probably won't get a chance before the merge tomorrow
morning
TBR=evanm
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia was previously calculating the leading value incorrectly, leading
us to add fHeight to get the height of a line of text. Now that Skia
is calculating fLeading correctly, we can remove fHeight.
http://codereview.chromium.org/62123
https://bugs.webkit.org/show_bug.cgi?id=25083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts r13300 and r13299. Something clearly went wrong with the
layout tests that I didn't notice.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia was previously calculating the leading value incorrectly, leading
us to add fHeight to get the height of a line of text. Now that Skia
is calculating fLeading correctly, we can remove fHeight.
http://codereview.chromium.org/62123
https://bugs.webkit.org/show_bug.cgi?id=25083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is one of Mike Reed's requests for upstreaming this work since he
has a use for the XMin value.
(also pulls in the WebKit side of this change)
http://codereview.chromium.org/62118
https://bugs.webkit.org/show_bug.cgi?id=25081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
part of the {direct,export}_dependent_settings in skia.
Review URL: http://codereview.chromium.org/63067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Harfbuzz is an open source library which is a unification of the Qt
and Pango shaping engines. We'll be using it on Chromium Linux to
perform complex text shaping.
Additionally, we add support for Harfbuzz into Skia, guarded by
SKIA_HARFBUZZ.
http://codereview.chromium.org/63035/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Our Kanji fonts have 1bpp bitmaps rather than outlines and, currently,
we assume that all bitmaps from Freetype are 8-bit grayscale. This
leads to some glyphs being 8x too thin.
http://codereview.chromium.org/63017/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove pangoft2, we don't use it anywhere.
- Add gdk, fontconfig and freetype2 as dependencies of skia. Gdk is
used in platform_canvas_linux.
- X11, Xrender and Xext are used by the IPC system, so everything that
depends on common, needs to link in those libs. By moving the
link_settings line into the libcommon.a target, all projects
inherit these.
Review URL: http://codereview.chromium.org/60070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I want to bring us closer to upstream Skia. This patch consists of
hunks pulled from code.google.com/p/skia. I'll also be pushing changes
the other way.
Review URL: http://codereview.chromium.org/57018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r12868. I used the wrong commit and messed up the message.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
negative, eg., when a negative translation is applied in the shader
matrix. This causes the rasterizer to blow up, since it accesses
memory outside the pattern bitmap.
Since the integer modulus operator for C++ has unspecified behaviour with
negative arguments, its value may go negative. In this case, we must offset
by the modulus to make it positive again. I decided to do this at a low level
in skia, since it seems better to make skia robust than to pray that you get
strictly non-negative translations.
(There is a fix for this in src/skia/tile_patch.diff, but it's wrong.)
This patch should be upstreamed to skia.
Review URL: http://codereview.chromium.org/55044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't trigger locally for me. I think it's safe to enable.
(Although the try servers are down for me, so I guess we'll find out.)
BUG=6291
Review URL: http://codereview.chromium.org/55036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was a mismatch between my understanding of that the FontHost was
supposed to do and the reality. It caused a small memory leak.
BUG=8789
Review URL: http://codereview.chromium.org/56017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=brettw
Review URL: http://codereview.chromium.org/52019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add Linux settings to target_defaults in common.gypi so
gyp-generated SConscript files no longer depend on
build/SConscript.main or the Hammer infrastructure.
* Copy the FilterOut() function from Hammer to the chromium_builders.py
Tool module.
* Add a ChromiumLoadableModule() builder to chromium_builders.py.
* Add dependencies on the 'views' library to the chrome link (target 'app').
* Add missing views/*/*_unittest.cc modules to the 'unit_tests' target.
Exclude all but the one that builds on Linux from the non-Windows builds.
* Crib a list of chrome/views files to exclude from the Linux build
from the old SCons configuration.
* Add a new build/linux/system.gyp file with new 'settings' targets
to encapsulate the pkg-config checks for gtk+-2.0, nss and pangoft2.
* Add depenedencies in the other targets on the new gtk, nss and
pangoft2 'settings' targets from build/linux/system.gyp.
* Add a pkg_config_wrapper.py script that keeps gyp happy by
simply exiting 0 if the package isn't found.
* DEPS roll for latest gyp changes to support the above.
Review URL: http://codereview.chromium.org/42340
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I don't know if it'll draw the border correctly).
Now with fixes to compile under Windows.
Review URL: http://codereview.chromium.org/42427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12172 0039d316-1c4b-4281-b951-d872f2087c98
|