| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux, and 1883 layout tests on Windows, due to Skia r366.
The good news is, these are minor pixel differences, and will be rebaselined once the new Skia version has passed the slow bots (purify, valgrind, reliability).
Since I have to rebaseline these tests anyway, I'm also turning off SK_USE_OLD_255_TO_256 in this CL, a stopgap measure I put to avoid rebaselining a bunch of tests due to an upstream change.
BUG=9993
TEST=How green was my valley (of layout builders)?
Review URL: http://codereview.chromium.org/260013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rectangle. This is needed as gtk/gdk may set complex clips, so that if
we paint everything we can end up painting on top of other widgets.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into the gfx namespace.
Combine the PNGEncoder and PNGDecoder. There were separate when we had
different executables for the browser and renderer, and linked the encoder only
in one of them (which saved us some space used by libpng). This hasn't been the
case for years, so combining them (again) makes sense.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/243076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/22792
Review URL: http://codereview.chromium.org/245027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and image_operations.* can be moved because they are not used by WebKit code.
This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights.
This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/222011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and image_operations.* can be moved because they are not used by WebKit code.
This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/207059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First pass at adding ChromeOS settings
- a mock wifi selector combobox
- touchpad settings that makes calls to synclient
- on startup, touchpad settings are initialized to what's stored in
preferences
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/203073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=9847
TEST=printing on linux should have right font in pdf
Patch contributed by Min-Yu Huang <minyu.huang@gmail.com>
Review URL: http://codereview.chromium.org/196071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the following case:
requested family: A
post_config_family: B
post_match_family: A
BUG=12530
TEST=none
Review URL: http://codereview.chromium.org/192062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The resulting PDF file will now be passed to the browser and be saved as "chromium_printing_test.pdf" under current directory.
BUG=9847
TEST=printing on linux should now generate chromium_printing_test.pdf in download directory. Printing on Windows should still work.
Patch contributed by minyu.huang@gmail.com
Review URL: http://codereview.chromium.org/172115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/183008
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not OS_WIN.
Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set.
Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX,
OS_LINUX or OS_FREEBSD.
Added USE_NSS for ... nss (for crypto). Windows and MacOS use
platform-specific libraries.
All of the above cause slightly odd formulations like:
#if defined(OS_WIN)
...
#elif defined(USE_BASE_DATA_PACK)
...
#endif
Possibly should also define USE_DLL_FOR_DATA, etc? Or something?
Wrapped various references to struct stat64 and stat64() to use struct
stat and stat() for FreeBSD - but a "man stat64" on Linux suggests
that we could do the same thing for at least Linux, too, and perhaps
eliminate the wrapper?
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
especially when define changes.
TEST=none
BUG=20889
Review URL: http://codereview.chromium.org/171118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19951,20552
TEST=compare pages rendered in Chromium and Safari. They should appear the same.
mark: review
jrg/brettw: FYI
Review URL: http://codereview.chromium.org/194013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(First landed in r24790, reverted in r24802.)
I'm landing this patch because it breaks page_cycler_intl2 on Linux and I don't
know why. I want to watch the bots when they fail.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
See original review:
http://codereview.chromium.org/179048/show
Review URL: http://codereview.chromium.org/177053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r24790. page_cycler_intl2 went red, although it's
not clear why. This is a speculative revert.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FreeType makes a lot of seek calls when we give it fonts as a stream.
To avoid the seeks (which hurt the SUID sandbox), we mmap the fonts.
Will need to pay attention to the perf bots after this lands.
http://codereview.chromium.org/180026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
skia/ext/skia_utils_mac.h includes CoreGraphics/CGColor.h so we have to relay the framework include path so someone can include the header without errors.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173363
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17569
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/173257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Build fix).
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SK_DEBUG for release builds. This will be reverted after a
few reliability runs.
BUG=http://crbug.com/17569
TEST=None
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not done.
BUG=18902
TEST=download something, note that a green disk appears, and disappears after some flashing after the download is done.
Review URL: http://codereview.chromium.org/174048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stack traces from the reliability bots, which will hopefully let us narrow down
this bug some more.
BUG=none
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/173004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to get more useful stack traces from the reliability bots. This CL will
be reverted after a few reliability runs.
BUG=http://crbug.com/17569
TEST=none
Review URL: http://codereview.chromium.org/172094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes it possible to use skia to paint something into a bitmap and then blit that bitmap to screen. I need this so that I can call download_util::PaintDownloadProgress(), which needs an SkCanvas.
To be used like this:
{
gfx::CanvasPaint canvas(myRect);
canvas.set_composite_alpha(true);
download_util::PaintDownloadprogres(&canvas, ...);
}
BUG=18902
TEST=none
Review URL: http://codereview.chromium.org/172046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Please NOTE that this is just a quick hack.
Instead of using fonts in Cairo, we draw texts' paths from the given paint.
pros:
1. Can be easily run within the sandbox.
2. Paths give us many things for free.
(complex text, different font family, outlined text, etc.)
cons:
1. It's slow and takes more memory since we cannot reuse glyph information.
(We have to store paths for the same glyph shown at differnt places.)
Patch written by Min-yu Huang <minyu.huang@gmail.com> in http://codereview.chromium.org/164025 .
Review URL: http://codereview.chromium.org/165281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/6372, which has since been fixed. Some existing asserts were
failing due to having been untested, and were fixed in this CL.
BUG=http://crbug.com/6373.
TEST=unit tests, layout tests, etc do not assert
Review URL: http://codereview.chromium.org/165223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
necessary in order to support @font-face on Linux.
Changes on WebCore side: https://bugs.webkit.org/show_bug.cgi?id=28015
BUG=18490
TEST=please see the bug descripion.
Review URL: http://codereview.chromium.org/160635
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/160347
This is the very preliminary implementation to support printing on Linux and it
has not been finished yet. For each page to be printed, we convert rendering
actions on canvas into cairo APIs and generate a PS/PDF file.
chrome/chrome.gyp:
Include our newly added and renamed files.
chrome/browser/browser.h:
chrome/browser/browser.cc:
Allow the user print the web page by hitting ctrl-p.
chrome/browser/gtk/standard_menus.cc:
Show "Print" in the menu.
chrome/renderer/print_web_view_helper.cc:
chrome/renderer/print_web_view_helper.h:
chrome/renderer/print_web_view_helper_mac.cc
chrome/renderer/print_web_view_helper_win.cc
Move the class PrepareFrameAndViewForPrint to the header file and move
platform dependent parts to their corresponding files.
chrome/renderer/print_web_view_helper_linux.cc:
Hard-coded parameters for printing. Only print the first page now.
skia/ext/vector_canvas.cc:
skia/ext/vector_canvas.h:
skia/ext/vector_canvas_linux.cc:
skia/ext/vector_canvas_win.cc:
Move platform dependent parts to their corresponding files.
skia/ext/vector_platform_device.h:
skia/ext/vector_platform_device_linux.cc:
skia/ext/vector_platform_device_linux.h
We translate skia APIs into Cairo APIs here. A PDF file is also created and
saved to the disk at this moment for testing purpose (you have to run chrome
without the sandbox to save the file). There are still lots of bugs.
skia/skia.gyp:
Include our newly added files when compiling skia package on Linux.
BUG=9847
Review URL: http://codereview.chromium.org/160673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
land Min-Yu's changes in http://codereview.chromium.org/160347 .
TBR=evan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actually trying to save it for later use.
TEST=Set download items to auto open a specific file type (eg .gz) and
repeatedly download items of that type, noticing that we no longer
crash.
BUG=17571 (http://crbug.com/17571)
Review URL: http://codereview.chromium.org/160602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'll revert this change after a chromebot run.
TBR=huanr
Review URL: http://codereview.chromium.org/160521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unittest code in line with the other tests in image_operations_unittest. My half-educated suspicion is that alpha wasn't getting initted correctly, as a new UMR appeared in the "SkColor alpha_pixel = " line. (Can't verify as all my machines are in boxes).
(This is TBR because the build is red).
TBR=tony
BUG=15762
TEST=Run valgrind/purify as in bug
Review URL: http://codereview.chromium.org/159381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17568
TEST=none
Review URL: http://codereview.chromium.org/160034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dan Erat has been working down, plumbing the user's font settings from
XSETTINGS in the UI thread of the browser to RendererPreferences in
the renderer. At the same time, I've been working upwards:
implementing subpixel rendering support in Skia and adding an
interface to it in WebCore.
This patch joins the two together. It adds an API surface to the
WebKit API for configuring the font preferences and adds code to
translate from RendererPreferences to that API. It's a little
unfortunate that we need four sets of enums around the code base for
things like the hinting level, but each is supposed to be self
contained and adding a dependancy would much more grevious.
BUG=12179
http://codereview.chromium.org/159152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Crash/kill a plugin process on the Mac; sad tab should draw in the right place.
Review URL: http://codereview.chromium.org/155958
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit r21332.
REVERT=21332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fonts. This patch should fix CHECK failures like this:
yusukes@yusukes-desktop:~/chromium2/src/build$ ../sconsbuild/Release/chrome
[20666:20666:544922424350:FATAL:/home/yusukes/chromium2/src/app/gfx/font_skia.cc(90)]
Check failed: tf. Could not find font: IPA モナー Pゴシック
Since some fonts have multiple font family names, the FontConfigDirect::Match()
function should try to compare post_config_family with _all_ family names in the
font, rather than with only the first (usually English) family name. For
example, a popular Japanese font called ipagpmona.ttf has two family names, an
English name and an internationalized (Japanese) one, and post_config_family for
the font can be either the English name or the Japanese name depending on the
situation.
$ showttf /usr/share/fonts/truetype/ttf-ipamonafont/ipagp-mona.ttf | egrep -A 1
-e
"platform=1 .* Family"
platform=1 plat spec encoding=0 language=0 name=1 Family
strlen=14 stroff=288 IPAMonaPGothic
--
platform=1 plat spec encoding=1 language=b name=1 Family
strlen=20 stroff=871 IPA <83><82><83>i<81>[ P<83>S<83>V<83>b<83>N
Original review URL: http://codereview.chromium.org/155751
BUG=12530
TEST=none
Review URL: http://codereview.chromium.org/159061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep the cairo clipping region in sync with the Skia one.
The PlatformCanvas now tracks this, so we don't need to have the similar code
in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the
cairo_t has a transform and clip but the surface does not.
Review URL: http://codereview.chromium.org/149409
Review URL: http://codereview.chromium.org/155700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155702
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also clean up a bunch of PMColor code - skia_utils should operate on SkColors and PMColors should only ever be used by SkBitmaps and ImageOperations.
BUG=16687
Review URL: http://codereview.chromium.org/149663
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20788 0039d316-1c4b-4281-b951-d872f2087c98
|