summaryrefslogtreecommitdiffstats
path: root/skia
Commit message (Collapse)AuthorAgeFilesLines
* remove obsolete (commented) flagsreed2015-07-161-35/+0
| | | | | | | | | BUG= TBR= Review URL: https://codereview.chromium.org/854393002 Cr-Commit-Position: refs/heads/master@{#339017}
* add SK_SUPPORT_LEGACY_DRAWBITMAPRECTFLAGS_TYPE flag for skia api changereed2015-07-161-0/+4
| | | | | | | | | | | see skia change https://codereview.chromium.org/1235393003# BUG= TBR=fmalita@chromium.org Review URL: https://codereview.chromium.org/1234503003 Cr-Commit-Position: refs/heads/master@{#338988}
* transition to new Constraints for drawBitmap/ImageRectreed2015-07-166-17/+16
| | | | | | | | | | will need https://codereview.chromium.org/1233333002/# to land first BUG= Review URL: https://codereview.chromium.org/1241923004 Cr-Commit-Position: refs/heads/master@{#338984}
* mac: Fix SkiaUtilsMacTest.NSImageRepToSkBitmap.erikchen2015-07-151-24/+42
| | | | | | | | | | | | | | | | | This test used the function CreateNSImage(), which first created an NSImage, and then attached a NSBitmapImageRep to the NSImage. The problem is that the NSBitmapImageRep was implicitly created, and its colorspace depended on the linked version of OSX and hardware on the machine. I changed the implementation of CreateNSImage() to use an explicitly created NSBitmapImageRep. I also changed the colorspace of the function CreateNSImage() and the unit test to always be +[NSColorSpace genericRGBColorSpace], to avoid potential wacky scenarios that could arise with +[NSColorSpace deviceRGBColorSpace]. BUG=463170 Review URL: https://codereview.chromium.org/1225233004 Cr-Commit-Position: refs/heads/master@{#338909}
* Use Skia's default HQ image resampler (Mitchell) for all buildsfmalita2015-07-142-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | We are currently using the default/Mitchell resampler for Android builds, and the legacy/Lanczos resampler for desktop builds. Lanczos may produce sharper results for some high-detail images, but it also introduces edge ringing artifacts for abrupt color transitions (Mitchell vs. Lanczos is a choice between smooth edge transitions vs. higher detail sharpness). Using Skia's default HQ resampler for all builds yields 1) more "correct" results: while Lanczos' increased sharpness is only noticeable when comparing images side-by-side, its ringing artifacts are obvious on their own (see linked bug) 2) improved test coverage: Skia's tests no longer cover Lanczos resampling (compile-time option) 3) more consistent results across platforms (Android vs. Lin/Win/Mac desktop) BUG=421914 R=senorblanco@chromium.org,pkasting@chromium.org,reed@google.com Review URL: https://codereview.chromium.org/1232563004 Cr-Commit-Position: refs/heads/master@{#338679}
* Added suppression for virtual/gpu/fast/canvas/canvas-incremental-repaint.htmlethannicholas2015-07-141-0/+3
| | | | | | | | | NOTRY=true BUG=509750 Review URL: https://codereview.chromium.org/1237823002 Cr-Commit-Position: refs/heads/master@{#338675}
* Add SK_LEGACY_IMAGE_FILTER_CROP_RECT_EDGES to skia config.senorblanco2015-07-131-0/+4
| | | | | | | | | | Required for an upcoming Skia change. BUG=240827 Review URL: https://codereview.chromium.org/1227943005 Cr-Commit-Position: refs/heads/master@{#338511}
* add SK_SUPPORT_LEGACY_ONDRAWIMAGERECTreed2015-07-101-0/+4
| | | | | | | | | Needed so we can land this skia CL https://codereview.chromium.org/1228083004# Review URL: https://codereview.chromium.org/1232633003 Cr-Commit-Position: refs/heads/master@{#338329}
* Replace base::str[n]casecmp with helper functions.brettw2015-07-101-1/+1
| | | | | | | | | | | | | | | | | | | | Adds CompareCaseInsensitiveASCII and EqualsCaseInsensitiveASCII helper functions and removes base::strcasecmp and base::strncasecmp. This avoids the dangerous locale-sensitive behavior. ClientIsAdvertisingSdchEncoding in sdch_browsertest had the condition inverted, but because it returned true any time the given line wasn't found, the test didn't notice. cups_helper changed most significantly. I redid the loop to use StringPieces which saves a lot of copies. On line 82 cups_helper used to do a prefix match which I'm pretty sure it wanted a regular compare. I changed this. render_text_harfbuzz set "<" operator was also doing a prefix comparison only, when it looks like it really just wanted to compare the strings. file_path passed string pieces into strcasecmp which could then read off the end if they're not null terminated. This patch fixes the bug and calls the native strcasecmp which is probably the best we can do for Posix file names. Removed additional version of the same function in net. Adds a backwards-compat hack for crashpad which improperly uses base from a DEPS-ed in repo. Review URL: https://codereview.chromium.org/1224553010 Cr-Commit-Position: refs/heads/master@{#338324}
* Define SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONSscroggo2015-07-081-0/+4
| | | | | | | | | | This will allow us to stage the change that will remove legacy features from SkImageGenerator (see https://codereview.chromium.org/1226023003/ in Skia). Review URL: https://codereview.chromium.org/1227113002 Cr-Commit-Position: refs/heads/master@{#337909}
* Remove a few friend lines referring to nonexistent classes.thakis2015-07-071-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I noticed these while looking at -Wmicrosoft warnings: ..\..\components/history/core/browser/history_service.h(547,16) : warning(clang): unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft] friend class PageUsageRequest; ^ :: If you have class A; namespace N { class B { friend class A; }; } then the "friend class A" declares a class A in namespace N and marks it a friend of B (i.e. N::A is a friend of N::B). The first line also declares a class A at global scope. cl.exe (and clang-cl) don't follow the behavior that the standard asks for: They see that there's a global class A, and interpret the line "friend class A" to mean "global A is a friend of N::B". (The "correct" way to write this is "friend class ::A"; A needs to be declared at global scope for this to work.) clang-cl can warn when it uses cl.exe's interpretation. When it warns, it means that the friend line isn't needed (else things wouldn't compile on non-Windows). (In some cases, the classes referred to by the friend lines didn't even exist.) No intended behavior change. BUG=505296 Review URL: https://codereview.chromium.org/1217703003 Cr-Commit-Position: refs/heads/master@{#337665}
* Clean up SkMemory_new_handler.mtklein2015-07-071-9/+6
| | | | | | | | | | | | Removes some dead code, and updates the comments. Crucially for me, this removes the only reference to SkThread.h in Chrome. BUG= Review URL: https://codereview.chromium.org/1213613015 Cr-Commit-Position: refs/heads/master@{#337643}
* Remove Skia layout test suppressionsrobertphillips2015-07-071-3/+0
| | | | | | | | | | These were rebaselined in (and cannot land before) https://codereview.chromium.org/1224573004/ BUG=504837 Review URL: https://codereview.chromium.org/1220283006 Cr-Commit-Position: refs/heads/master@{#337590}
* Unblock Skia's rollrobertphillips2015-07-061-0/+3
| | | | | | | | | | | These two feTile layout tests only show minor differences after the revert of https://codereview.chromium.org/1219193002/ BUG=504837 Review URL: https://codereview.chromium.org/1223843006 Cr-Commit-Position: refs/heads/master@{#337392}
* Include skia_common.gypi first such that the exclusion rules are firstdnicoara2015-07-021-3/+6
| | | | | | | | | | | | The default file name exclusion rules should be first such that any custom rules can re-include the files affected by these rules. BUG=none TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1219043002 Cr-Commit-Position: refs/heads/master@{#337221}
* Remove all .h files from Skia build lists.mtklein2015-07-015-165/+7
| | | | | | | | | | | | | | | | | Listing headers in GN or GYP files has no effect on the build and only serves to make moving headers around more difficult, e.g. ERROR at //skia/BUILD.gn:395:5: Item not found "//third_party/skia/src/utils/SkTLogic.h", ^---------------------------------------- You were trying to remove "//third_party/skia/src/utils/SkTLogic.h" from the list but it wasn't there. BUG= Review URL: https://codereview.chromium.org/1220063002 Cr-Commit-Position: refs/heads/master@{#337080}
* Add include/private to build path when building Skia.mtklein2015-07-012-1/+2
| | | | | | | | | | | | This stages https://codereview.chromium.org/1217293004/ Tested by patching the above CL, then doing GYP- and GN-based builds. Seems okay. BUG= Review URL: https://codereview.chromium.org/1217693003 Cr-Commit-Position: refs/heads/master@{#337015}
* Write skia_unittests.isolate and enable swarming for skia_unittests.jbroman2015-06-302-0/+61
| | | | | | | | BUG=98637 Review URL: https://codereview.chromium.org/1212893004 Cr-Commit-Position: refs/heads/master@{#336828}
* Remove existing Skia suppressionsfmalita2015-06-271-9/+0
| | | | | | | | | | | | Marked for rebaseline in Blink. BUG=504837 TBR=robertphillips@google.com NOTRY=true Review URL: https://codereview.chromium.org/1213853004 Cr-Commit-Position: refs/heads/master@{#336499}
* remove SK_SUPPORT_LEGACY_INT_COLORMATRIXreed2015-06-271-4/+0
| | | | | | | | | | suppression for blink: https://codereview.chromium.org/1214783003/# BUG=504972 Review URL: https://codereview.chromium.org/1205733003 Cr-Commit-Position: refs/heads/master@{#336498}
* Additional Skia suppressionsfmalita2015-06-261-0/+2
| | | | | | | | | | | | To unblock the roll. BUG=504837 TBR=robertphillips@google.com NOTRY=true Review URL: https://codereview.chromium.org/1216733002 Cr-Commit-Position: refs/heads/master@{#336448}
* remove obsolete flagsreed2015-06-261-8/+0
| | | | | | | | | | requires this to land first: https://codereview.chromium.org/1205413003 BUG= Review URL: https://codereview.chromium.org/1203163005 Cr-Commit-Position: refs/heads/master@{#336384}
* Roll src/third_party/skia b402296:f9ad558fmalita2015-06-261-0/+7
| | | | | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/skia/+log/b402296..f9ad558 Manual roll (rebaselines needed after https://codereview.chromium.org/1180903006). TBR=bsalomon@chromium.org,robertphillips@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1212373002 Cr-Commit-Position: refs/heads/master@{#336366}
* Add ComputeDefaultPixelGeometry helper to skia/extrobertphillips2015-06-252-0/+29
| | | | | | | | BUG=skia:3934 Review URL: https://codereview.chromium.org/1199543002 Cr-Commit-Position: refs/heads/master@{#336174}
* define SK_SUPPORT_LEGACY_XFERMODESmtklein2015-06-241-0/+4
| | | | | | | | | | | | Prevents https://codereview.chromium.org/1196713004/# from having any affect. TBR=reed@google.com BUG= Review URL: https://codereview.chromium.org/1203803006 Cr-Commit-Position: refs/heads/master@{#336004}
* Roll src/third_party/skia b607767:74f681dbungeman2015-06-243-3/+4
| | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/skia/+log/b607767..74f681d CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=fmalita@google.com Review URL: https://codereview.chromium.org/1200413002 Cr-Commit-Position: refs/heads/master@{#335854}
* remove legacy SK_SUPPORT_LEGACY_OPTIONLESS_GET_PIXELS flagreed2015-06-221-4/+0
| | | | | | | | | | | | This allows us to upgrade to new API signature for virtual onGetPixels. BUG= NOTRY=True cq bots seem horked, so bypassing as these failures are unrelated to this cl Review URL: https://codereview.chromium.org/1198913002 Cr-Commit-Position: refs/heads/master@{#335557}
* add SK_SUPPORT_LEGACY_OPTIONLESS_GET_PIXELS (already in gypi)reed2015-06-201-0/+4
| | | | | | | | | | | ... so it can be removed from skia_for_chromium_defines.gypi BUG= TBR=robertphilips Review URL: https://codereview.chromium.org/1196843002 Cr-Commit-Position: refs/heads/master@{#335423}
* remove flag enabling new SkData proc signaturereed2015-06-181-4/+0
| | | | | | | | | | | no functionality change BUG= TBR= Review URL: https://codereview.chromium.org/1184483004 Cr-Commit-Position: refs/heads/master@{#334992}
* Roll src/third_party/skia 0b1de26:77f85adBen Wagner2015-06-173-0/+7
| | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/skia/+log/0b1de26..77f85ad CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=borenet@google.com Review URL: https://codereview.chromium.org/1178403007. Cr-Commit-Position: refs/heads/master@{#334935}
* add SK_SUPPORT_LEGACY_DATARELEASEPROC_PARAMS flagreed2015-06-171-0/+4
| | | | | | | | | | | | in support of https://codereview.chromium.org/1193553002/ BUG=501376 NOTRY=True just adding a new #define Review URL: https://codereview.chromium.org/1184953005 Cr-Commit-Position: refs/heads/master@{#334855}
* Remove existing Skia suppressionsfmalita2015-06-161-6/+0
| | | | | | | | | | | | Blink rebaselines have landed. BUG=500591 TBR=mtklein@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1190703004 Cr-Commit-Position: refs/heads/master@{#334627}
* Touch all memory Skia allocates to force memory allocation issues.mtklein2015-06-161-8/+25
| | | | | | | | | | | | | | | | | | We receive many bugs that amount to out-of-memory, a failure to back an allocation with physical memory. It usually looks like Skia is to blame because it's the first code to write to that allocation, forcing the OS to go find some physical memory to map it to. When we receive the bug reports, we'd like to see what stack is originally making the allocation, rather than the stack that's later faulting the memory. Clearly, this would not be performant or sane in Release mode. I'm not entirely sure it's performant enough or sane in Debug mode. BUG=many Review URL: https://codereview.chromium.org/1190553003 Cr-Commit-Position: refs/heads/master@{#334607}
* Revert of simplify bitlocker, stop calling deprecated accessBitmap() ↵reed2015-06-152-7/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1178543003/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=499727 need to investigate more Original issue's description: > simplify bitlocker, stop calling deprecated accessBitmap() > > BUG=499001 > > Committed: https://crrev.com/090cd9e360792d1ea07841ef0e13518c36a3f29b > Cr-Commit-Position: refs/heads/master@{#333937} TBR=fmalita@chromium.org,schenney@chromium.org,kochi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=499001 Review URL: https://codereview.chromium.org/1188613003 Cr-Commit-Position: refs/heads/master@{#334450}
* Remove SK_NO_SPECIALIZED_AA_XFERMODESfmalita2015-06-152-4/+6
| | | | | | | | | BUG=500591 R=mtklein@google.com,reed@google.com Review URL: https://codereview.chromium.org/1149853004 Cr-Commit-Position: refs/heads/master@{#334401}
* Use SkPaintFilterCanvas for paint filteringfmalita2015-06-126-64/+82
| | | | | | | | | | | | | SkDrawFilter is deprecated - convert its only Chromium client to SkPaintFilterCanvas. BUG=skia:3587 R=reed@google.com,robertphillips@google.com,enne@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1176393003 Cr-Commit-Position: refs/heads/master@{#334166}
* simplify bitlocker, stop calling deprecated accessBitmap()reed2015-06-112-40/+7
| | | | | | | | BUG=499001 Review URL: https://codereview.chromium.org/1178543003 Cr-Commit-Position: refs/heads/master@{#333937}
* gn: Don't build sse3 code in skia with -msse4.1.thakis2015-06-051-14/+43
| | | | | | | | | | | | | | | | Else the compiler can create SSE4.1 instructions for the SSE3 files, but we only check for SSE3 when running that code. So the code might crash with "unknown instruction" when running on a processor that has SSE3 but not SSE4. This matches what the gyp build does. Depends on https://codereview.chromium.org/1161853008/ BUG=496512 Review URL: https://codereview.chromium.org/1160253011 Cr-Commit-Position: refs/heads/master@{#333171}
* skia: Simplify SSE2 logic a bit.thakis2015-06-054-71/+34
| | | | | | | | | | | | | | Chrome builds with -msse2 globally these days, so remove the skia_chrome_opts target and fold it into skia_chrome. Keep skia_opts but simplify the comments there a bit. No intended behavior change. BUG=496512,348761 Review URL: https://codereview.chromium.org/1161853008 Cr-Commit-Position: refs/heads/master@{#333129}
* clang/win/gn: Pass -msse flags to clang-cl.exe for skiathakis2015-06-051-2/+4
| | | | | | | | | | | | | This is a port of https://codereview.chromium.org/475273002 to gn. Also add a comment that explains that the skia_opts target in the GN build isn't correct. BUG=491209,82385,496512 Review URL: https://codereview.chromium.org/1155243010 Cr-Commit-Position: refs/heads/master@{#333091}
* Move third_party/freetype DEPS to third_party/freetype-android/srcbungeman2015-06-032-2/+2
| | | | | | | | | | This allows the build files to live in the chromium repo but the source to live in the freetype repo, similar to other third_party DEPS. Review URL: https://codereview.chromium.org/1155743013 Cr-Commit-Position: refs/heads/master@{#332616}
* Add a Mojo interface for SkBitmap and appropriate type converters.amistry2015-06-036-0/+256
| | | | | | Review URL: https://codereview.chromium.org/1150083005 Cr-Commit-Position: refs/heads/master@{#332585}
* Change most uses of Pickle to base::Picklebrettw2015-06-031-4/+4
| | | | | | | | | | There should be no behavior change. TBR=jschuh (IPC messages) Review URL: https://codereview.chromium.org/1154283003 Cr-Commit-Position: refs/heads/master@{#332552}
* Remove existing Skia suppressionsfmalita2015-06-021-5/+0
| | | | | | | | | | | | All Blink rebaselines have landed. BUG=493745 TBR=caryclark@google.com NOTRY=true Review URL: https://codereview.chromium.org/1160253003 Cr-Commit-Position: refs/heads/master@{#332399}
* Move Pickle to base namespace.brettw2015-06-021-4/+4
| | | | | | | | | | Updates forward-declares and headers, but keeps a using statement in to avoid updating all users atomically. TBR=jschuh for IPC stuff Review URL: https://codereview.chromium.org/1149113006 Cr-Commit-Position: refs/heads/master@{#332352}
* Blink layout test suppressions for Skiafmalita2015-06-011-0/+5
| | | | | | | | | | | | | Minor rebaselines needed for three tests. Suppressing to unblock the Skia roll. BUG=skia:3877 TBR=caryclark@google.com NOTRY=true Review URL: https://codereview.chromium.org/1161313005 Cr-Commit-Position: refs/heads/master@{#332262}
* Remove existing Skia suppressionsfmalita2015-05-221-976/+0
| | | | | | | | | | | | Blink rebaseline after SK_LEGACY_STROKE_CURVES removal has landed. BUG=490269 TBR=reed@google.com,caryclark@google.com NOTRY=true Review URL: https://codereview.chromium.org/1154853002 Cr-Commit-Position: refs/heads/master@{#331099}
* Remove SK_LEGACY_STROKE_CURVESfmalita2015-05-222-4/+976
| | | | | | | | | BUG=490269 TBR=caryclark@google.com,reed@google.com Review URL: https://codereview.chromium.org/954943005 Cr-Commit-Position: refs/heads/master@{#331038}
* Add SK_NO_SPECIALIZED_AA_XFERMODES guardfmalita2015-05-211-0/+4
| | | | | | | | | | | | For https://codereview.chromium.org/1156453002/ BUG=skia:3852 TBR=reed@google.com,mtklein@google.com NOTRY=true Review URL: https://codereview.chromium.org/1155663002 Cr-Commit-Position: refs/heads/master@{#330993}
* add flag for skia assert changereed2015-05-211-0/+4
| | | | | | | | | | BUG= TBR=fmalita@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/1144423003 Cr-Commit-Position: refs/heads/master@{#330936}
generated by cgit v1.1 at 2025-02-08 12:55:37 +0000