summaryrefslogtreecommitdiffstats
path: root/skia
Commit message (Collapse)AuthorAgeFilesLines
* Returns an error immediately without sending IPC message when a font family ↵yusukes@google.com2009-12-183-1/+10
| | | | | | | | | | | | | | | | | | | | | | name to resolve is too long. This change is important when a site has @font-face rule like: // http://paulirish.com/webkit-fontface-hang.html @font-face{font-family:testfont;src:url('data:font/ttf;base64,AA.....<<looooooooooong base64 data>>.....aQ==')} In such a case, WebCore first calls SkFontHost::CreateTypeface() with the (possibly very long) data-uri string itself, then calls SkFontHost::CreateTypefaceFromStream() with decoded byte stream. Since render_sandbox_host_linux.cc just ignores too long IPC message, the renderer process could block indefinitely waiting for a reply inside recvmsg() system call called from SkFontHost::CreateTypeface(). I'm not sure if the WebCore behavior (i.e. calling CreateTypeface with data-uris) is reasonable, but I believe the Skia part is better to be fixed anyway. Non data-uri font family names could be very long too: @font-face{font-family:testfont;src:local('AA........AA');} BUG=29861 TEST=First, set up your Linux SUID Sandbox binary: http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment. Then start Chromium and visit http://paulirish.com/webkit-fontface-hang.html or http://typekit.com/. Verify that the renderer does not freeze. Review URL: http://codereview.chromium.org/507037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34915 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for skia 451:457. USE_NEW_BUILDER was removed, since it's now ↵senorblanco@chromium.org2009-12-171-3/+0
| | | | | | | | | | | enabled by default in Skia. BUG=none TEST=none Review URL: http://codereview.chromium.org/502057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34865 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 450:451. Enable USE_NEW_BUILDER in Skia. Mark as failingsenorblanco@chromium.org2009-12-044-21/+12
| | | | | | | | | | | | the ~85 layout tests that now need rebaselining (due to slight pixel coverage change). Refactor SkUserConfig.h a tad. Rebaseline unit test VectorCanvasTest.ClippingIntersect. BUG=24646 TEST=none Review URL: http://codereview.chromium.org/464044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33863 0039d316-1c4b-4281-b951-d872f2087c98
* Preserve optimized scrolling in the presence of multiple animating rects.darin@chromium.org2009-12-044-21/+27
| | | | | | | | | | | | | | Change PlatformCanvas so that it only fills with "sea foam green" when bitmap data is not externally supplied. Modifying the interface to make this an option bloated the CL too much. I may do this as a follow-up. Adds a new --show-paint-rects command line flag that will render a border around paint rects to help debug and study WebKit painting issues. R=brettw BUG=25905 TEST=none Review URL: http://codereview.chromium.org/414016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33861 0039d316-1c4b-4281-b951-d872f2087c98
* arm: Add thumb target and associated fixesjoel@chromium.org2009-12-041-6/+3
| | | | | | | | | | Add arm_thumb=1 to GYP_DEFINES to enable BUG=29203 Review URL: http://codereview.chromium.org/463027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33799 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 447:449.senorblanco@chromium.org2009-12-011-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/457026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33488 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 435:447. Some tests need rebaselines due to change in ↵senorblanco@chromium.org2009-12-011-0/+1
| | | | | | | | | | | line clipping algorithm. BUG=none TEST=none Review URL: http://codereview.chromium.org/450017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33386 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 424:428, and enable Skia SSE2 optimizations for Linux and ↵senorblanco@chromium.org2009-11-171-8/+50
| | | | | | | | | | | | | Mac. Due to unfortunate limitations in gcc and gyp, this required creating a new static library target, skia_sse2 (see skia.gyp for the gory details). I did a search-and-replace in all .gyp files in the tree, but if there are other projects outside this tree which refer to skia.gyp, they will have to be modified as well. This also required rolling DEPS for O3D Skia 376:428, since O3D uses chrome's skia.gyp file. Since this update brings ~25M of HTML docs, I pared the DEPS file down to just src/ and include/ (as we do in Chrome). I built O3D on 32bit Linux to test; hopefully other platforms will be ok. BUG=none TEST=green bots Review URL: http://codereview.chromium.org/402016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32206 0039d316-1c4b-4281-b951-d872f2087c98
* Fix thumb buildjoel@chromium.org2009-11-171-0/+5
| | | | | | | | | | | | | This fixes the following error seen when attempting to build with -mthumb on gcc-4.4: CXX(target) out/Release/obj.target/skia/third_party/skia/src/opts/SkBlitRow_opts_arm.o /tmp/ccINCRGl.s: Assembler messages: /tmp/ccINCRGl.s:105: Error: thumb conditional instruction should be in IT block -- `moveq ip,#8' make: *** [out/Release/obj.target/skia/third_party/skia/src/opts/SkBlitRow_opts_arm.o] Error 1 Review URL: http://codereview.chromium.org/399023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32161 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Skia SSE2 optimizations for Windows build. Linux build will require ↵senorblanco@chromium.org2009-11-111-0/+4
| | | | | | | | | | | | | some further handholding, due to gcc lameness. TEST=all layout tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31629 Review URL: http://codereview.chromium.org/385025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31662 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31629.senorblanco@chromium.org2009-11-111-8/+0
| | | | | | Review URL: http://codereview.chromium.org/385028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31634 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Skia SSE2 optimizations.senorblanco@chromium.org2009-11-111-0/+8
| | | | | | | | | TEST=all layout tests BUG=none Review URL: http://codereview.chromium.org/385025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31629 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31228.senorblanco@chromium.org2009-11-061-6/+0
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/377007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31230 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling DEPS to Skia 418 and enabling SSE2 optimizations to gather perf and ↵senorblanco@chromium.org2009-11-061-0/+6
| | | | | | | | | | | | | stability data. This will be rolled back after a few runs. BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31228 0039d316-1c4b-4281-b951-d872f2087c98
* First patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-4/+5
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31136 0039d316-1c4b-4281-b951-d872f2087c98
* This change was supposed to go into my Skia 367 merge, but somehow I missed it.senorblanco@chromium.org2009-11-051-4/+0
| | | | | | | | | | | | This will break yet more layout tests, which have been added to test_expectations.txt. They will be rebaselined after a few runs. BUG=9333 TEST=green bots Review URL: http://codereview.chromium.org/258036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31092 0039d316-1c4b-4281-b951-d872f2087c98
* Restoring r29827. The skia file is new to this attempt, and may be what was ↵pamg@google.com2009-11-041-0/+1
| | | | | | | | | | | | | | | causing a unit test to crash last time. Refactor security-icon code to a more general form, also more consistent with the Windows implementation, in preparation for implementing page actions. Review URL: http://codereview.chromium.org/264037 BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/348069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31023 0039d316-1c4b-4281-b951-d872f2087c98
* arm: more NEON optspiman@chromium.org2009-11-031-0/+9
| | | | | | Review URL: http://codereview.chromium.org/354021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30800 0039d316-1c4b-4281-b951-d872f2087c98
* Enable NEON support in skia when building for armv7piman@chromium.org2009-11-031-0/+5
| | | | | | Review URL: http://codereview.chromium.org/353016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30795 0039d316-1c4b-4281-b951-d872f2087c98
* [Landing for Jonathon Dixon] Tiny code simplification/optimization: remove ↵senorblanco@chromium.org2009-10-161-3/+2
| | | | | | | | | | | | unecessay temporary copy of SkMatrix. BUG=none TEST=none Review URL: http://codereview.chromium.org/267112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29332 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-151-63/+64
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-151-64/+63
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-151-63/+64
| | | | | | | | | | | death to the wstring TEST=trybots BUG=none Review URL: http://codereview.chromium.org/276016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix early font free during printing.estade@chromium.org2009-10-092-49/+59
| | | | | | | | | | The ownership model for this stuff (fonts, cairo canvas, etc.) is a bit brittle. Don't know how to improve it though. BUG=23372 Review URL: http://codereview.chromium.org/270048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28619 0039d316-1c4b-4281-b951-d872f2087c98
* Move classes depending on Skia out of base/gfx and into app/gfx. Renamebrettw@chromium.org2009-10-072-10/+41
| | | | | | | | | | native_theme to native_theme_win since its Windows-specific. BUG=none TEST=none Review URL: http://codereview.chromium.org/259047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28300 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 364:376. The bad news is, this breaks 1854 layout tests ↵senorblanco@chromium.org2009-10-061-0/+1
| | | | | | | | | | | | | | | on Linux, and 1883 layout tests on Windows, due to Skia r366. The good news is, these are minor pixel differences, and will be rebaselined once the new Skia version has passed the slow bots (purify, valgrind, reliability). Since I have to rebaseline these tests anyway, I'm also turning off SK_USE_OLD_255_TO_256 in this CL, a stopgap measure I put to avoid rebaselining a bunch of tests due to an upstream change. BUG=9993 TEST=How green was my valley (of layout builders)? Review URL: http://codereview.chromium.org/260013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28109 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments setting emacs and vim tab width and expansion variables.sgk@google.com2009-10-061-0/+6
| | | | | | | | BUG=none TEST=successful builds Review URL: http://codereview.chromium.org/256059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
* Makes canvas_paint_linux use the event region, not the eventsky@chromium.org2009-10-051-11/+16
| | | | | | | | | | | | rectangle. This is needed as gtk/gdk may set complex clips, so that if we paint everything we can end up painting on top of other widgets. BUG=none TEST=none Review URL: http://codereview.chromium.org/242134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27995 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-031-8/+8
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Move cairo font handling from printing to skia to avoid circular dependency.mmoss@chromium.org2009-09-282-4/+150
| | | | | | | | | http://crbug.com/22792 Review URL: http://codereview.chromium.org/245027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27395 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-249-1089/+81
| | | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26975.pkasting@chromium.org2009-09-239-81/+1089
| | | | | | Review URL: http://codereview.chromium.org/222011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26979 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-239-1089/+81
| | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. BUG=none TEST=none Review URL: http://codereview.chromium.org/207059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26975 0039d316-1c4b-4281-b951-d872f2087c98
* Force inclusion of build/common.gypi for all chromium gyp files.yaar@chromium.org2009-09-151-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Why: Simpler build code. If everybody includes it, it should be included automatically. Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi. What was done: 1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi 2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi. 3. lots of gyp files were fixed to not refer to build/common.gypi any more. 4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 5. build/common.gypi was left empty, because there are some external projects that still refer to it. Things that are left to do after this patch is in: 1. The following external files (in other repositories) need to stop include common.gypi ./third_party/hunspell/hunspell.gyp ./third_party/icu/icu.gyp ./v8/tools/gyp/v8.gyp 2. Once nobody refers to common.gypi anymore, delete common.gypi -or- Delete gyp_chromium.gypi and move its content back to common.gypi Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify. Review URL: http://codereview.chromium.org/206006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/193032 for Charlie:sky@chromium.org2009-09-151-1/+6
| | | | | | | | | | | | | | | First pass at adding ChromeOS settings - a mock wifi selector combobox - touchpad settings that makes calls to synclient - on startup, touchpad settings are initialized to what's stored in preferences TEST=none BUG=none Review URL: http://codereview.chromium.org/203073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26259 0039d316-1c4b-4281-b951-d872f2087c98
* Embed fonts information into resulting PDF file for printing.maruel@chromium.org2009-09-111-17/+43
| | | | | | | | | | BUG=9847 TEST=printing on linux should have right font in pdf Patch contributed by Min-Yu Huang <minyu.huang@gmail.com> Review URL: http://codereview.chromium.org/196071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25974 0039d316-1c4b-4281-b951-d872f2087c98
* Second fix for the Issue 12530. Modified Match() function so that it allows ↵yusukes@google.com2009-09-111-2/+9
| | | | | | | | | | | | | | | the following case: requested family: A post_config_family: B post_match_family: A BUG=12530 TEST=none Review URL: http://codereview.chromium.org/192062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25959 0039d316-1c4b-4281-b951-d872f2087c98
* Pass printing result to the browser.maruel@chromium.org2009-09-084-48/+51
| | | | | | | | | | | | The resulting PDF file will now be passed to the browser and be saved as "chromium_printing_test.pdf" under current directory. BUG=9847 TEST=printing on linux should now generate chromium_printing_test.pdf in download directory. Printing on Windows should still work. Patch contributed by minyu.huang@gmail.com Review URL: http://codereview.chromium.org/172115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25615 0039d316-1c4b-4281-b951-d872f2087c98
* Avoids the use of "namespace using-directives" in a few places.thakis@chromium.org2009-09-072-10/+6
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/183008 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25607 0039d316-1c4b-4281-b951-d872f2087c98
* Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set butbenl@chromium.org2009-09-073-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | not OS_WIN. Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set. Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX, OS_LINUX or OS_FREEBSD. Added USE_NSS for ... nss (for crypto). Windows and MacOS use platform-specific libraries. All of the above cause slightly odd formulations like: #if defined(OS_WIN) ... #elif defined(USE_BASE_DATA_PACK) ... #endif Possibly should also define USE_DLL_FOR_DATA, etc? Or something? Wrapped various references to struct stat64 and stat64() to use struct stat and stat() for FreeBSD - but a "man stat64" on Linux suggests that we could do the same thing for at least Linux, too, and perhaps eliminate the wrapper? git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25599 0039d316-1c4b-4281-b951-d872f2087c98
* Delete all precompiled support. It is causing more harm than good, ↵maruel@chromium.org2009-09-042-15/+0
| | | | | | | | | | | | especially when define changes. TEST=none BUG=20889 Review URL: http://codereview.chromium.org/171118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25511 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust color spaces so that Mac Chrome renders colors properly.amanda@chromium.org2009-09-031-4/+2
| | | | | | | | | | | BUG=19951,20552 TEST=compare pages rendered in Chromium and Safari. They should appear the same. mark: review jrg/brettw: FYI Review URL: http://codereview.chromium.org/194013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25380 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix fd leak added in r25083agl@chromium.org2009-09-021-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25132 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use mmap fonts.agl@chromium.org2009-09-011-24/+37
| | | | | | | | | | (First landed in r24790, reverted in r24802.) I'm landing this patch because it breaks page_cycler_intl2 on Linux and I don't know why. I want to watch the bots when they fail. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25083 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a skia utils for Gtk.jcampan@chromium.org2009-09-013-1/+52
| | | | | | | | | | | | BUG=None TEST=None See original review: http://codereview.chromium.org/179048/show Review URL: http://codereview.chromium.org/177053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25042 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: use mmap fonts."agl@chromium.org2009-08-281-37/+24
| | | | | | | | This reverts commit r24790. page_cycler_intl2 went red, although it's not clear why. This is a speculative revert. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24802 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use mmap fonts.agl@chromium.org2009-08-281-24/+37
| | | | | | | | | | | | FreeType makes a lot of seek calls when we give it fonts as a stream. To avoid the seeks (which hurt the SUID sandbox), we mmap the fonts. Will need to pay attention to the perf bots after this lands. http://codereview.chromium.org/180026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24790 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper to resource bundle to get an NSImage back.thomasvl@chromium.org2009-08-261-0/+3
| | | | | | | | | | skia/ext/skia_utils_mac.h includes CoreGraphics/CGColor.h so we have to relay the framework include path so someone can include the header without errors. BUG=none TEST=none Review URL: http://codereview.chromium.org/173363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24453 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24085 and r24086, restoring skia asserts to debug-only (test complete).senorblanco@chromium.org2009-08-231-5/+2
| | | | | | | | | | BUG=http://crbug.com/17569 TEST=none TBR=maruel Review URL: http://codereview.chromium.org/173257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24087 0039d316-1c4b-4281-b951-d872f2087c98
* Captain Ahab seems to have capsized his boat. What a bonehead.senorblanco@chromium.org2009-08-231-1/+1
| | | | | | | | | | (Build fix). BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24086 0039d316-1c4b-4281-b951-d872f2087c98