| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/18031009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=rmistry@google.com
Review URL: https://codereview.chromium.org/18122006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When WCS is enabled, the sRGB color space is the default color space for
Windows [1] and for CSS3 rgb values [2]. Using
SkColorToCalibratedNSColor results in a different (typically ligher)
color when used in Quartz drawing versus a web page, or for color
constants from designers.
This adds SkColorToSRGBNSColor to convert an SkColor value specified in
the sRGB color space to an NSColor.
[1] http://msdn.microsoft.com/en-us/library/windows/hardware/gg487409.aspx
[2] http://www.w3.org/TR/css3-color/#rgb-color
BUG=138633, 254361
Review URL: https://chromiumcodereview.appspot.com/17834003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Prequisite to merging https://codereview.chromium.org/17113004 in Skia.
Review URL: https://chromiumcodereview.appspot.com/17850003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/18105002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=robertphillips
BUG=
Review URL: https://codereview.chromium.org/17993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=250525
TBR=robertphillips,senorblanco
Review URL: https://chromiumcodereview.appspot.com/17927002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
expressed as a single color matrix, apply it directly in the compositor and skip the intermediate FBO. This is similar to an optimization that has already been applied for the SkImageFilter DAG path.
R=epenner,jamesr
BUG=233101
Review URL: https://chromiumcodereview.appspot.com/17693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Given a JSON-encoded Picture, the new function returns an array of Skia draw commands + info.
Depends on https://codereview.chromium.org/16638014/.
Re-landing after Skia SkDebugCanvas static initializer fix (https://code.google.com/p/skia/source/detail?r=9723).
R=nduca@chromium.org, piman@chromium.org, senorblanco@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207676
Review URL: https://codereview.chromium.org/15967010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Baseline images have been updated, most suppressions are now green.
BUG=243726,247306,250525
TBR=robertphillips
Review URL: https://chromiumcodereview.appspot.com/17640014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.) The header is now in base/mac instead of base/memory
2.) The class is now in namespace base.
This CL was created programmatically by running:
1.)
git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g'
for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done
git commit -a -m headers
# manually undo changes to gypi file
git cl upload # patch set 1
2.)
git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g'
# manually undo comment changes in scoped_nsobject.h, tracking_area.h
git commit -a -m format
git cl upload # patch set 2
# Manually audit all files, file bugs and clean up bad clang-format decisions
git cl upload # patch set 3
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/17593006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created fully mechanically by running
git grep -l base::mac::ScopedCFTypeRef | xargs sed -i -e 's/base::mac::ScopedCFTypeRef/base::ScopedCFTypeRef/g'
git commit -a -m.
git clang-format HEAD^ --style=Chromium
git commit -a -m.
git cl upload -t $TITLE
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/16917011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blink currently uses TEXTMETRICS for font metrics on windows,
regardless of the font type. Skia currently does not.
Set the SK_GDI_ALWAYS_USE_TEXTMETRICS_FOR_FONT_METRICS flag for
windows which will instruct Skia to use the same font metrics for the
GDI backend as our current GDI implementation.
BUG=252705
R=reed@google.com, thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17068009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r207892 - build failure on Linux x64.
TBR=kbr@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/16915005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Try again w/ gyp fix.
TBR=kbr@chromium.org, mymax@amazon.com
BUG=238755
Review URL: https://codereview.chromium.org/17115014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=robertphillips
BUG=250525
Review URL: https://codereview.chromium.org/17231005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused linux x64 sizes regression due to static initializers in SkDebugCanvas.
> Add skiaBenchmarking.getOps()
>
> Given a JSON-encoded Picture, the new function returns an array of Skia draw commands + info.
>
> Depends on https://codereview.chromium.org/16638014/.
>
> R=nduca@chromium.org, piman@chromium.org, senorblanco@chromium.org
>
> Review URL: https://codereview.chromium.org/15967010
TBR=fmalita@google.com
Review URL: https://codereview.chromium.org/17514008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Given a JSON-encoded Picture, the new function returns an array of Skia draw commands + info.
Depends on https://codereview.chromium.org/16638014/.
R=nduca@chromium.org, piman@chromium.org, senorblanco@chromium.org
Review URL: https://codereview.chromium.org/15967010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Compile failure on Linux ... not sure why this wasn't caught before.
TBR=kbr@chromium.org
BUG=238755
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch landed on behalf of mymax@amazon.com. OWNERS approvals are in
https://chromiumcodereview.appspot.com/17005007/ . Try jobs (w/o binaries)
are in https://chromiumcodereview.appspot.com/17422003/ .
TBR=kbr@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/17341003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=reed@google.com
Review URL: https://codereview.chromium.org/17484003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous attempt to commit this was reverted because ui_unittests stopped working on windows. Since I don't have a windows box, I can't fix the test, so in this CL I am disabling the tests and notifying the people who can fix it.
This log shows what happened when the test was not disabled:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%281%29/builds/36957/steps/ui_unittests/logs/stdio
BUG=247081
Review URL: https://chromiumcodereview.appspot.com/17100002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on https://crrev.com/16432002.
Activates cheaper test of whether or not an image is decoded,
for a savings of 50-70% of CPU time and near-complete elimination of
lock contention in ManageTiles() when loading the cnn.com homepage
on an Android device.
BUG=239632
R=bsalomon,reveman
Review URL: https://chromiumcodereview.appspot.com/16332004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, theses code paths were not compiled anymore when
using the Chromium-specific skia/ gyp files. Upstream gyp files under
third_party/skia/gyp/ are ok, but not used when building for
Chromium (see bug for more details).
This patch reactivates the build of "dynamic NEON support" in the Android ARM skia build.
BUG=249304
Review URL: https://chromiumcodereview.appspot.com/16944005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative fix for DCHECK failure in ui_unittests on win debug bots.
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%281%29/builds/36957
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/19757
> Make sure skia doesn't try to scale images with less than 32 bits per pixel.
>
> BUG=247081
>
> Review URL: https://chromiumcodereview.appspot.com/16843004
TBR=hubbe@chromium.org
Review URL: https://codereview.chromium.org/16855019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=247081
Review URL: https://chromiumcodereview.appspot.com/16843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=robertphillips
Review URL: https://codereview.chromium.org/16848015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16358024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes lazy_pixel_ref_utils* style consistent with
Chromium style.
BUG=245787
Review URL: https://chromiumcodereview.appspot.com/15981008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Changed the style of skia/ext to be Chromium style.
BUG=245787
Review URL: https://chromiumcodereview.appspot.com/16647003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/.
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15995038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=reed@google.com
Review URL: https://codereview.chromium.org/16321006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=reed@google.com
Review URL: https://codereview.chromium.org/16010010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part 1 of reducing the number of picture walks
during GatherPixelRefs in picture.cc. This adds a utility
similar to SkPictureUtils except it gathers all lazy refs
in a picture along with their positions. Also adds tests.
BUG=242703
Review URL: https://chromiumcodereview.appspot.com/15732015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows Skia's core.gypi to include SkImage implementation files
without requiring chromium to build Skia's images project.
See https://codereview.chromium.org/15806010/ for the related
Skia changes.
Review URL: https://chromiumcodereview.appspot.com/15960015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=rmistry@google.com
Review URL: https://codereview.chromium.org/15703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/15824004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
at https://codereview.chromium.org/14929006/).
Added MIPS DSPr2 optimization for BGRAConvolve2D routine.
The following routines are optimized:
- ConvolveVertically
- ConvolveHorizontally
Performance gain measured on Malta 74Kc board:
- our standalone test/bench application ~45%
- chromium unit_test ~20%
R=hubbe@chromium.org, senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15742005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/16013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a tile has text drawn into it, we can be pessimistic
and say that the tile will not be solid color, and it will
keep this text. Hence, we can early out as soon as we see
any text.
BUG=238021
Review URL: https://chromiumcodereview.appspot.com/15497002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/15882003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Roll Skia DEPS to r9231 (take 2)
>
> R=reed@google.com
>
> Review URL: https://codereview.chromium.org/15486010
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/15745005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=reed@google.com
Review URL: https://codereview.chromium.org/15486010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The --force-direct-layer-drawing flag causes any layer that could be
drawn direct to the backbuffer to be drawn to the backbuffer using
Ganesh. This flag also requires both the --enable-threaded-compositing
flag and the --enable-impl-side-painting flag to have any effect.
This patch also turns on testing for PictureDrawQuad using Ganesh in the
cc pixeltests.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/13863015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For consistency and sanity in Chromium, only use skia::RefPtr in Chromium to
ref count skia classes. SkRefPtr is unsafe to use for newly created objects
because it refs the object that is passed to its constructor. skia::RefPtr
makes this adoption explicit it via skia::AdoptRef and so is much clearer.
This patch also adds a skia::ShareRef function which makes it explicit that the
callsite is adopting a ref which is already owned somewhere else. Using
AdoptRef vs. ShareRef seems much clearer than using SkRefPtr vs. skia::RefPtr.
These are the remaining code sites that use internal Skia reference counted
classes. Once these have been removed, then we can use a PRESUBMIT rule to
prevent new uses from being added.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/15004024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 7d4175c20e5c3608b9b918499aedfc4a6006932d.
TBR=
Review URL: https://codereview.chromium.org/15352002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following routines are optimized:
- ConvolveVertically
- ConvolveHorizontally
Performance gain measured on Malta 74Kc board:
- our standalone test/bench application ~45%
- chromium unit_test ~20%
R=hubbe@chromium.org, senorblanco@chromium.org
Review URL: https://codereview.chromium.org/14929006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/15296004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests turned green on http://test-results.appspot.com/dashboards/flakiness_dashboard.html,
time to clean up skia_test_expectations.txt.
TBR=robertphillips@chromium.org
BUG=237634,238630,239436
Review URL: https://chromiumcodereview.appspot.com/15080006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The fix is a one-liner, the rest is unittest-cladding.
BUG=155269
Review URL: https://chromiumcodereview.appspot.com/14969034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200334 0039d316-1c4b-4281-b951-d872f2087c98
|