summaryrefslogtreecommitdiffstats
path: root/sql
Commit message (Collapse)AuthorAgeFilesLines
* Update uses of UTF conversions in ppapi/, printing/, remoting/, rlz/, ↵avi@chromium.org2013-12-252-3/+3
| | | | | | | | | | | | sandbox/, skia/, sql/, sync/, tools/, webkit/, win8/ to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/121123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242502 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Rewrite Connection::Preload() in terms of file reading.shess@chromium.org2013-12-212-27/+51
| | | | | | | | | | | | | | | r204860 rewrote sqlite3_preload() to read the file without placing the data in the SQLite cache to improve memory footprint. No reports of performance degradation ensued. This CL rewrites Connection::Preload() to use the SQLite file handle to read the data, and backs out the preload-cache.patch from third_party/sqlite/. BUG=243949 Review URL: https://codereview.chromium.org/116443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242225 0039d316-1c4b-4281-b951-d872f2087c98
* AppCache: Run a quick integrity check on the sqlite database when opening. ↵michaeln@chromium.org2013-12-163-9/+73
| | | | | | | | | | | | If the test fails, delete the appcache directory and start afresh. NOTRY=true TBR=sky BUG=318544 Review URL: https://codereview.chromium.org/104593010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240937 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239400 "Revert 239280 "Move more file_util functions to b..."thakis@chromium.org2013-12-082-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke all bots 9_9 > Revert 239280 "Move more file_util functions to base namespace." > > dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32). > This CL is the only in the intersection of CLs in the first failing build on > the two builders, so giving a speculative revert a try (rlarocque already > tried a clobber, it didn't help). > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806 > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544 > > > > Move more file_util functions to base namespace. > > > > TBR=sky > > > > Review URL: https://codereview.chromium.org/109043002 > > TBR=brettw@chromium.org > > Review URL: https://codereview.chromium.org/105823009 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/100923007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239401 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239280 "Move more file_util functions to base namespace."thakis@chromium.org2013-12-082-5/+5
| | | | | | | | | | | | | | | | | | | | | | | dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32). This CL is the only in the intersection of CLs in the first failing build on the two builders, so giving a speculative revert a try (rlarocque already tried a clobber, it didn't help). http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806 http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544 > Move more file_util functions to base namespace. > > TBR=sky > > Review URL: https://codereview.chromium.org/109043002 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/105823009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239400 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Recovery code for "Top Sites" database.shess@chromium.org2013-12-085-86/+147
| | | | | | | | | | | | | | | | | | | | Port recovery code from thumbnail_database.cc to top_sites_database.cc. Also retry Init() in case the recovery code fixes things (a quarter to a third of databases have problems detected during open). Extend sql::Recovery::AutoRecoverTable() to handle DOUBLE columns. Abstract out sql::test::CorruptTableOrIndex() to ease writing corruption tests. IWYU pass on various files. BUG=321852 Review URL: https://codereview.chromium.org/86653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239377 0039d316-1c4b-4281-b951-d872f2087c98
* Move more file_util functions to base namespace.brettw@chromium.org2013-12-073-7/+7
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/109043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239280 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetFileSize, NormalizeFilePath to base namespacebrettw@chromium.org2013-12-042-2/+2
| | | | | | | | | BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/102873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238722 0039d316-1c4b-4281-b951-d872f2087c98
* Convert string16 to base::string16 in content.brettw@chromium.org2013-12-032-10/+10
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/102593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238447 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Annotate sql::Recovery failure cases.shess@chromium.org2013-11-281-9/+128
| | | | | | | | | | | | | | | A large number of thumbnail_database.cc recovery failures are in building the scoped recovery instance. Break down failure cases for sql::Recovery to see if there is any action to be taken. Additionally, track failure calling sql::Recovery::Recovered(). BUG=109482 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/83323005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237680 0039d316-1c4b-4281-b951-d872f2087c98
* Move Posix file utils to the base namespace.brettw@chromium.org2013-11-272-23/+23
| | | | | | | | | BUG= R=rvargas@chromium.org Review URL: https://codereview.chromium.org/89523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237642 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235595 "Revert 235492 "[sql] Recover Favicons v5 database..."kinuko@chromium.org2013-11-186-21/+636
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Revert 235492 "[sql] Recover Favicons v5 databases, with more re..." > > Speculative revert to find the cause for Mac size regression > (will revert this revert later) > > > [sql] Recover Favicons v5 databases, with more recovery automation. > > > > An entirely automated recovery system runs afoul of questions about > > whether the corrupt database's schema can be trusted. > > sql::Recovery::AutoRecoverTable() uses a schema created by the caller > > to construct the recovery virtual table and then copies the data over. > > > > sql::Recovery::SetupMeta() and GetMetaVersionNumber() simplify > > accessing meta-table info in the corrupt database. > > > > sql::test::IntegrityCheck() and CorruptSizeInHeader() helpers to > > simplify common testing operations. > > > > Rewrite ThumbnailDatabase v6 and v7 recovery code and tests using > > these changes, and add a v5 recovery path. Additionally handle > > deprecated versions. > > > > BUG=240396,109482 > > > > Review URL: https://codereview.chromium.org/50493012 > > TBR=shess@chromium.org > > Review URL: https://codereview.chromium.org/74933002 TBR=kinuko@chromium.org Review URL: https://codereview.chromium.org/74953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235604 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235492 "[sql] Recover Favicons v5 databases, with more re..."kinuko@chromium.org2013-11-186-636/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speculative revert to find the cause for Mac size regression (will revert this revert later) > [sql] Recover Favicons v5 databases, with more recovery automation. > > An entirely automated recovery system runs afoul of questions about > whether the corrupt database's schema can be trusted. > sql::Recovery::AutoRecoverTable() uses a schema created by the caller > to construct the recovery virtual table and then copies the data over. > > sql::Recovery::SetupMeta() and GetMetaVersionNumber() simplify > accessing meta-table info in the corrupt database. > > sql::test::IntegrityCheck() and CorruptSizeInHeader() helpers to > simplify common testing operations. > > Rewrite ThumbnailDatabase v6 and v7 recovery code and tests using > these changes, and add a v5 recovery path. Additionally handle > deprecated versions. > > BUG=240396,109482 > > Review URL: https://codereview.chromium.org/50493012 TBR=shess@chromium.org Review URL: https://codereview.chromium.org/74933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235595 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Recover Favicons v5 databases, with more recovery automation.shess@chromium.org2013-11-166-21/+636
| | | | | | | | | | | | | | | | | | | | | | | An entirely automated recovery system runs afoul of questions about whether the corrupt database's schema can be trusted. sql::Recovery::AutoRecoverTable() uses a schema created by the caller to construct the recovery virtual table and then copies the data over. sql::Recovery::SetupMeta() and GetMetaVersionNumber() simplify accessing meta-table info in the corrupt database. sql::test::IntegrityCheck() and CorruptSizeInHeader() helpers to simplify common testing operations. Rewrite ThumbnailDatabase v6 and v7 recovery code and tests using these changes, and add a v5 recovery path. Additionally handle deprecated versions. BUG=240396,109482 Review URL: https://codereview.chromium.org/50493012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235492 0039d316-1c4b-4281-b951-d872f2087c98
* ios: Enable -Wunused-functions.thakis@chromium.org2013-11-141-0/+2
| | | | | | | | | BUG=315884 TBR=net,sql owners Review URL: https://codereview.chromium.org/64273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235014 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Complain about statement mutations after stepping has started.shess@chromium.org2013-10-252-0/+18
| | | | | | | | | | | | | | | | | DCHECK if any Bind*() calls occur after Step() has been called. The bind cannot be implemented at that point, so most likely the calling code has an error, such as a forgotted Reset(). Also DCHECK if Run() is called after Run() or Step() without an intervening Reset(). Such a calling sequence is unlikely to be intentional, because the results of calling Run() twice aren't defined. BUG=309759 Review URL: https://codereview.chromium.org/40733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231098 0039d316-1c4b-4281-b951-d872f2087c98
* Recover version 6 Favicons, fix meta table.shess@chromium.org2013-10-161-0/+6
| | | | | | | | | | | | | | | | | | | | | Version 6 is exactly like version 7, except it has an extra trailing column on favicons which was never used. The version-7 recovery code works for it, so long as the meta table is updated correctly. In writing this change, I realized that the meta table wasn't being created for recovered databases. Instead, SQLite was resolving to the corrupt.meta table. This works so long as the version doesn't change (next open will populate meta with kCurrentVersion). This change makes the table references absolute, and fixes the meta table setup. BUG=240396 R=jar@chromium.org, pkotwicz@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228217 Review URL: https://codereview.chromium.org/25032004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228871 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate old Favicons database versions.shess@chromium.org2013-10-085-3/+166
| | | | | | | | | | | | | | | | | | Histograms show a non-zero number of users with very old databases at startup. These old databases likely result from some sort of corruption or filesystem problem, and are unlikely to spontaneously progress forward. Since the number of databases involved is very low (<.03% of users), just delete them in hopes that that allows forward progress. Arbitrarily set a 2-year deprecation deadline for this database. This is a few weeks early, as version 5 landed on 2011-10-12. BUG=240396 Review URL: https://codereview.chromium.org/24443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227433 0039d316-1c4b-4281-b951-d872f2087c98
* Disable recovery test for USE_SYSTEM_SQLITE.shess@chromium.org2013-10-072-0/+19
| | | | | | | | | | | | | Detact and short-circuit rather than using an #ifdef because the test eventually needs to be adapted to actually test this case. I'm just not confident enough about possible edge cases to start deleting data. BUG=299677 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/24989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227360 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Log tag with sqlite errors.shess@chromium.org2013-09-263-10/+23
| | | | | | | | | | | | | | | Log lines like: ERROR:connection.cc(1007)] sqlite error 266, errno 5: disk I/O error would be ever so much more useful if they indicated which database they were associated with. This logs the histogram tag, which indicates the logical database (the code which owns this connection). [As opposed to the filesystem name.] BUG=none Review URL: https://codereview.chromium.org/24638002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225518 0039d316-1c4b-4281-b951-d872f2087c98
* Recover corrupt Favicon databases.shess@chromium.org2013-09-254-4/+36
| | | | | | | | | | | | | | | | | | | | Add sql::Recovery support to ThumbnailDatabase. Rearrange the schema setup to allow sharing with the recovery code. Unit test a few corruption cases. Add sql::Recovery::Rollback() to allow transitioning code to monitor failures for diagnostic purposes. It is possible/likely that that function can be removed if failure cases are infrequent enough (in which case it with Unrecoverable()). Expose sql::Connection::ShouldIgnore() to allow the error callback to support sql::ScopedErrorIgnorer for testing. BUG=240396 Review URL: https://chromiumcodereview.appspot.com/23533038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225144 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite Thumbnail and Top Sites test with golden files.shess@chromium.org2013-09-103-0/+122
| | | | | | | | | | | | | | Previously, the tests manually changes the current schema to look like an old schema, then targetted specific implementation functions. Change to instead create the schema from a golden file, testing that Init() works correctly, and the expected data is in place. BUG=none R=pkotwicz@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/23536014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222400 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for sql::MetaTable.shess@chromium.org2013-09-074-10/+232
| | | | | | | | BUG=273203 Review URL: https://chromiumcodereview.appspot.com/23649002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221922 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most run_all_unittests.cc files to use new unit test launcher.phajdan.jr@chromium.org2013-09-052-10/+1
| | | | | | | | | | | | | Note that the new code is still behind a runtime flag (--brave-new-test-launcher), but compiling tests with support for it will make further testing possible. BUG=236893, 79359 R=akalin@chromium.org, enne@chromium.org, erikwright@chromium.org, joi@chromium.org, keybuk@chromium.org, sky@chromium.org, thestig@chromium.org, tommi@chromium.org, wtc@chromium.org, xhwang@chromium.org, yzshen@chromium.org Review URL: https://codereview.chromium.org/23442019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221464 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor clearing thumbnail history.shess@chromium.org2013-08-162-0/+28
| | | | | | | | | | | | | Previously, ThumbnailDatabase exposed much internals knowledge. Push most of that down into the class and remove the schema hacks which are no longer necessary. BUG=272519 TEST=Unit tests. Review URL: https://chromiumcodereview.appspot.com/22898003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217993 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Use recover virtual table in sql::Recovery.shess@chromium.org2013-08-064-6/+305
| | | | | | | | | | | | Load the recover virtual table as part of sql::Recovery::Begin(), and implement basic unit tests that it correctly recovers valid and corrupt tables. BUG=109482 Review URL: https://chromiumcodereview.appspot.com/20022006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215764 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Cleanup open and close error histograms.shess@chromium.org2013-07-241-12/+20
| | | | | | | | | | | | | | | | Cleanup open-time histograms to use the sparse framework so that extended histograms can be recorded - also add entries to the xml file. Add a histogram to track close-time failures. This should never fail, but if it is it probably leaks memory and file handles, and possibly locks. BUG=none Review URL: https://chromiumcodereview.appspot.com/18978012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213345 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Serialize calls to sqlite3_initialize().shess@chromium.org2013-07-222-0/+20
| | | | | | | | | | | sqlite3_initialize() uses double-check locking, and is thus prone to data races. BUG=248101 Review URL: https://chromiumcodereview.appspot.com/19000007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212984 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Scoped recovery framework.shess@chromium.org2013-07-197-9/+637
| | | | | | | | | | | | | | | | | | sql::Recovery is intended to be used within a sql::Connection error callback to either recover the database (*) or indicate that the database is unrecoverable and should be razed. The intend is that the code should either progress to a valid database which is composed of data recovered from the original (likely corrupt) database, or a valid database which is empty. This is just the framework without the SQLite-level data-recovery virtual table. BUG=109482 Review URL: https://chromiumcodereview.appspot.com/19281002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212607 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a MemoryPressureListener to sql::Connection.rmcilroy@chromium.org2013-07-182-0/+35
| | | | | | | | | | | This will allow SQLite database to reduce their page cache memory on systems which provide a MemoryPressureListener signal. BUG=243769 Review URL: https://chromiumcodereview.appspot.com/17071007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212374 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Allow restricting database to user read access.shess@chromium.org2013-07-173-6/+116
| | | | | | | | | | | | | | By default POSIX umask is generally 0644. For some databases, it makes sense to restrict access to 0600. Use new setting for password database. BUG=258771 R=gbillock@chromium.org, isherman@chromium.org, jorgelo@chromium.org Review URL: https://codereview.chromium.org/5125579611308032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212106 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Retry Open() if error handler fixed things.shess@chromium.org2013-07-173-18/+41
| | | | | | | | | | | | Since the caller cannot have existing database-derived state before the database is opened, Open() can be safely retried after the error handler has razed the database. BUG=109482 Review URL: https://chromiumcodereview.appspot.com/18641004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211936 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base::Delete to base::DeleteFilebrettw@chromium.org2013-07-161-3/+3
| | | | | | | | | | | Also renames DeleteAfterReboot to DeleteFileAfterReboot, and removes FileUtilProxy::RecursiveDelete which was never called. BUG= R=shess@chromium.org Review URL: https://codereview.chromium.org/18584011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211822 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Callback and scoped-ignore tests for sql::Statement.shess@chromium.org2013-07-127-33/+200
| | | | | | | | | | | | | | Test error callback and ScopedErrorIgnorer for running statements. Share error-callback test code between statement and connection tests. Test additional error-callback edge cases. Also fix callback use-after-free case. BUG=254584 Review URL: https://chromiumcodereview.appspot.com/17726002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211281 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathExists to base namespace.brettw@chromium.org2013-07-112-9/+9
| | | | | | | | | BUG= TBR=jam@chromium.org Review URL: https://codereview.chromium.org/18286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Additional Raze() unit tests.shess@chromium.org2013-07-102-35/+217
| | | | | | | | | | | | | | Verify that Raze() can handle: - empty databases. - non-database files. - databases overwritten with garbage. - databases which cannot be opened successfully. BUG=none Review URL: https://chromiumcodereview.appspot.com/17752002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210923 0039d316-1c4b-4281-b951-d872f2087c98
* Add REGEXP support to SQLite on iOSstuartmorgan@chromium.org2013-07-091-0/+11
| | | | | | | | | | | | | Chrome for iOS uses system SQLite, which on iOS doesn't include the ICU extensions, which includes the now-required-by-Chrome REGEXP support. This compiles that extension as a static library, and dynamically registers it on each database opened. BUG=254636 Review URL: https://chromiumcodereview.appspot.com/18312005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210572 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_util::Delete to the base namespacebrettw@chromium.org2013-07-011-3/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/16950028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209475 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in rlz/, skia/, sql/, sync/.avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18031009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209152 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Static helper to delete database and all associated files.shess@chromium.org2013-06-243-0/+53
| | | | | | | | | | | Not all of the ad-hoc file_util::Delete() cases handle -journal, and if -wal was added all of them need to be tracked down. BUG=none Review URL: https://chromiumcodereview.appspot.com/17058004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208140 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Framework for allowing tests to handle errors.shess@chromium.org2013-06-186-12/+218
| | | | | | | | | | | | | | | | sql/ throws FATAL whenever it sees inappropriate calls, which makes production code to handle errors hard to test. ScopedErrorIgnorer provides a way for tests to signal that specific errors are expected and will be handled. As a first pass, code up some additional tests for some Raze() edge cases, and modify things to pass those tests. BUG=159490 Review URL: https://chromiumcodereview.appspot.com/16664005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207096 0039d316-1c4b-4281-b951-d872f2087c98
* Remove sql::ErrorDelegate.shess@chromium.org2013-06-144-100/+20
| | | | | | | | | | API cleanup. Replaced by ErrorCallback. BUG=none Review URL: https://chromiumcodereview.appspot.com/16788002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206299 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_ptr<T>(NULL) to use the default ctor in sql/.dcheng@chromium.org2013-06-131-3/+1
| | | | | | | | | | | This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the sql/ directory. BUG=173286 Review URL: https://chromiumcodereview.appspot.com/16866008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206127 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in rlz/, sandbox/, skia/, sql/, sync/.avi@chromium.org2013-06-114-5/+5
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16358024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205458 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in google_apis/, gpu/, ↵avi@chromium.org2013-06-072-2/+2
| | | | | | | | | | | | ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15995038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
* [sql] Enable writable_schema during integrity_check.shess@chromium.org2013-06-061-10/+27
| | | | | | | | | | | | | | | | | | | | | Logging integrity_check for corruption in thumbnail_database.cc has caught one bit of info, and a bunch of empty results. I suspect that "PRAGMA integrity_check" is itself failing. writable_schema enables an internal RecoveryMode flag which allows SQLite to work through certain simple forms of corruption. More Sqlite.SizeKB.Thumbnail results have come in. 8M covers >90% of Favicon databases and seems like a reasonable bet. Tweak the chance of running the integrity check. Previously, SQLITE_CORRUPT was overwhelming the other errors, now it is around 3% of cases caught (on dev channel). This aims to get around 25%-30%. BUG=240396 Review URL: https://chromiumcodereview.appspot.com/16406002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204645 0039d316-1c4b-4281-b951-d872f2087c98
* Disable sqlite lookaside buffers by default.rmcilroy@chromium.org2013-06-061-0/+7
| | | | | | | | | | | | | | | | Sqlite by default allocates 50KB per connection for use as a lookaside buffer for small object allocation. With the malloc implementations we use, this doesn't seem to help gain us any performance advantage, while increasing memory overhead, therefore this CL disables sqlite lookaside buffers by default. BUG=chromium:243769 TEST=Ran page_cycler perf test in Linux and Android and saw no noticable degradation. Examined traceview didn't see an increase in the time spent on the history or database threads. Review URL: https://chromiumcodereview.appspot.com/16356007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204623 0039d316-1c4b-4281-b951-d872f2087c98
* Update sync/, sql/, and printing/ to use scoped_refptr<T>::get() rather than ↵rsleevi@chromium.org2013-06-031-1/+1
| | | | | | | | | | | | | implicit "operator T*" Linux fixes BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/16298002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203651 0039d316-1c4b-4281-b951-d872f2087c98
* Remove last client of sql::DiagnosticErrorDelegate.shess@chromium.org2013-05-233-62/+0
| | | | | | | | | | | In the first pass, there was a problem with histograms. I do not recall what the problem was, so removing things. BUG=none Review URL: https://chromiumcodereview.appspot.com/15104003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201895 0039d316-1c4b-4281-b951-d872f2087c98
* Post integrity_check data for corrupt thumbnail databases.shess@chromium.org2013-05-222-0/+26
| | | | | | | | | | | | | | | | | | | | | Analyzing the results from DatabaseErrorCallback() show a lot of SQLITE_CORRUPT opening the database and setting up the meta table. Add additional diagnostic information for these cases to direct future development, and also dial down the amount of data uploaded to allow finding other cases more easily. For SQLITE_CORRUPT and SQLITE_READONLY, only give the chance to report on first encounter. Cross-platform results are inconsistent. On OSX, almost all of the SQLITE_CORRUPT cases are in initialization, whereas on Windows there are more in code which updates the database. For these errors, it is reasonable to expect any future call to return the error again, so it is pointless to let it get multiple attempts. BUG=240396 Review URL: https://chromiumcodereview.appspot.com/15327004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201494 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 03:21:55 +0000