summaryrefslogtreecommitdiffstats
path: root/sql
Commit message (Collapse)AuthorAgeFilesLines
* mandoline: Start adding trace events for mandoline stuff.erg2015-10-231-0/+16
| | | | | | | | BUG=534895 Review URL: https://codereview.chromium.org/1421483003 Cr-Commit-Position: refs/heads/master@{#355915}
* [sql] Track uploads of diagnostic data to prevent duplication.shess2015-10-223-24/+407
| | | | | | | | | | | | | | | | | | The ThumbnailDatabase error handler attempts to capture generic data about the error, which is then uploaded for diagnostics with DumpWithoutCrashing(). Database with errors which are not repaired upload new dumps repeatedly. This change adds a tracking file alongside the database file, which has the dual purpose of recording whether a previous dump was attempted, and also verifying that files can be created in the profile directory. If the profile directory is too broken to create files, then diagnostic data is unlikely to inform a fix. BUG=543321,362505,526614,240396 Review URL: https://codereview.chromium.org/1393393007 Cr-Commit-Position: refs/heads/master@{#355632}
* [tracing] Add sqlite memory statistics to tracing.ssid2015-10-128-2/+187
| | | | | | | | | | | | | | | | | | The process-wide memory usage statistics of sqlite library is added to chrome://tracing. The memory usage of sqlite library is mainly through sqlite_malloc. The total usage of the process is recorded by sqlite3_memory_used() api. This CL also adds per-connection memory usage to tracing. Each connection uses memory for cache, schema and statement, and these usages are recorded. sqlit3_malloc uses malloc internally to allocate memory. So, thie memory is traced as sub-allocation from system_allocator(malloc). This CL lets us keep track of sqlite memory usage in chrome telemetry. BUG=466141 Review URL: https://codereview.chromium.org/1327063002 Cr-Commit-Position: refs/heads/master@{#353549}
* [sql] Use memory-mapped I/O for sql::Connection.shess2015-10-064-0/+203
| | | | | | | | | | | | | | | | | | sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's memory-mapped I/O. Additionally instrument to flush dirty pages from the page cache after writes. BUG=489784,533682,537681,537636 [Relands https://crrev.com/9a1948a4d6d4 (#350362), reverted at https://crrev.com/55c3216b15ce (#350386), relanded at https://crrev.com/5c2f4e50d96d (#351344), reverted at https://crrev.com/745e18c52384 (#351596). May the waterfall have mercy on my CL.] Review URL: https://codereview.chromium.org/1382283003 Cr-Commit-Position: refs/heads/master@{#352631}
* Isolate sql_unittests_apk.stip2015-10-032-0/+42
| | | | | | | | BUG=525873 Review URL: https://codereview.chromium.org/1377793004 Cr-Commit-Position: refs/heads/master@{#352237}
* Revert of [sql] Use memory-mapped I/O for sql::Connection. (patchset #3 ↵zhaoqin2015-09-304-199/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/1368533003/ ) Reason for revert: data race reported by TSan on sql/connection.cc BUG=537681 Original issue's description: > [sql] Use memory-mapped I/O for sql::Connection. > > sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's > memory-mapped I/O. Additionally instrument to flush dirty pages from > the page cache after writes. > > [Relands https://crrev.com/9a1948a4d6d4, > reverted at https://crrev.com/55c3216b15ce ] > > BUG=489784, 533682 > > Committed: https://crrev.com/5c2f4e50d96d8b2ae0ae4a5c7d319e6be3b33bca > Cr-Commit-Position: refs/heads/master@{#351344} TBR=rmcilroy@chromium.org,pavely@chromium.org,shess@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489784, 533682 Review URL: https://codereview.chromium.org/1375583003 Cr-Commit-Position: refs/heads/master@{#351596}
* [sql] Use memory-mapped I/O for sql::Connection.shess2015-09-294-0/+199
| | | | | | | | | | | | | | | sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's memory-mapped I/O. Additionally instrument to flush dirty pages from the page cache after writes. [Relands https://crrev.com/9a1948a4d6d4, reverted at https://crrev.com/55c3216b15ce ] BUG=489784, 533682 Review URL: https://codereview.chromium.org/1368533003 Cr-Commit-Position: refs/heads/master@{#351344}
* Revert of [sql] Use memory-mapped I/O for sql::Connection. (patchset #8 ↵Jeremy Roman2015-09-234-194/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:140001 of https://codereview.chromium.org/1349863003/ ) Reason for revert: mmap_enabled_ isn't initialized, causing MSAN failures: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_MSAN/5882/layout-test-results/virtual/sharedarraybuffer/fast/workers/constructor-proto-crash-log.txt STDERR: ==3138==WARNING: MemorySanitizer: use-of-uninitialized-value STDERR: #0 0x7fc8068d3a65 in ReleaseCacheMemoryIfNeeded sql/connection.cc:513:7 STDERR: #1 0x7fc8068d3a65 in sql::Connection::ExecuteAndReturnErrorCode(char const*) sql/connection.cc:943:0 STDERR: #2 0x7fc8068ca454 in sql::Connection::OpenInternal(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, sql::Connection::Retry) sql/connection.cc:1275:9 STDERR: #3 0x7fc8068c845f in sql::Connection::Open(base::FilePath const&) sql/connection.cc:367:10 STDERR: #4 0x7fc806b1b868 in storage::QuotaDatabase::LazyOpen(bool) storage/browser/quota/quota_database.cc:488:14 Original issue's description: > [sql] Use memory-mapped I/O for sql::Connection. > > sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's > memory-mapped I/O. Additionally instrument to flush dirty pages from > the page cache after writes. > > BUG=489784,533682 > > Committed: https://crrev.com/9a1948a4d6d445d5c8e209bdcd1cd050af72060b > Cr-Commit-Position: refs/heads/master@{#350362} R=shess@chromium.org TBR=pavely@chromium.org, pvalenzuela@chromium.org, rmcilroy@chromium.org, shess@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489784,533682 Review URL: https://codereview.chromium.org/1365783002 . Cr-Commit-Position: refs/heads/master@{#350386}
* [sql] Use memory-mapped I/O for sql::Connection.shess2015-09-234-0/+194
| | | | | | | | | | | | sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's memory-mapped I/O. Additionally instrument to flush dirty pages from the page cache after writes. BUG=489784,533682 Review URL: https://codereview.chromium.org/1349863003 Cr-Commit-Position: refs/heads/master@{#350362}
* [sql] sqlite3_initialize() before additional entry point.shess2015-09-161-0/+3
| | | | | | | | | | | | sqlite3_vfs_find() added an additional entry point in Delete(), which is static. BUG=84094 TBR=erg@chromium.org Review URL: https://codereview.chromium.org/1351653002 Cr-Commit-Position: refs/heads/master@{#349179}
* Fix sbox_validation_tests & Make isolate_driver.py include the executable itselfmaruel2015-09-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | This is a redo of https://codereview.chromium.org/1245873002 c6649f2e014a24a909 with fix for Official build. Further reduce the boilerplate in .isolate files and is necessary to add debug symbols, to be done in a follow up. Slightly accelerate ninja file parsing by blacklisting more extensions. sbox_validation_tests wasn't run on Windows since https://codereview.chromium.org/1212003003/ (~2 months ago). Thankfully this CL uncovered this copy-paste error. TBR=jam@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1320793004 Cr-Commit-Position: refs/heads/master@{#347912}
* Revert of Fix sbox_validation_tests & Make isolate_driver.py include the ↵stgao2015-09-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | executable itself (patchset #3 id:90001 of https://codereview.chromium.org/1245873002/ ) Reason for revert: This CL seems to break compile http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/3900/. If the revert doesn't fix it, I will re-land this CL. Original issue's description: > Fix sbox_validation_tests & Make isolate_driver.py include the executable itself > > Further reduce the boilerplate in .isolate files and is necessary to add debug > symbols, to be done in a follow up. > > Slightly accelerate ninja file parsing by blacklisting more extensions. > > sbox_validation_tests wasn't run on Windows since > https://codereview.chromium.org/1212003003/ (~2 months ago). Thankfully this CL > uncovered this copy-paste error. > > TBR=jam@chromium.org > BUG=98637 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/c6649f2e014a24a9093140a06fcadcaf2a06513c > Cr-Commit-Position: refs/heads/master@{#347027} TBR=jam@chromium.org,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Review URL: https://codereview.chromium.org/1329783003 Cr-Commit-Position: refs/heads/master@{#347071}
* Fix sbox_validation_tests & Make isolate_driver.py include the executable itselfmaruel2015-09-021-1/+0
| | | | | | | | | | | | | | | | | | | Further reduce the boilerplate in .isolate files and is necessary to add debug symbols, to be done in a follow up. Slightly accelerate ninja file parsing by blacklisting more extensions. sbox_validation_tests wasn't run on Windows since https://codereview.chromium.org/1212003003/ (~2 months ago). Thankfully this CL uncovered this copy-paste error. TBR=jam@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1245873002 Cr-Commit-Position: refs/heads/master@{#347027}
* [sql] Drop sqlite3_* proxy hacks.shess2015-09-025-78/+6
| | | | | | | | | | | | Now that sqlite is a shlib under component build, the hacks to proxy functions are not necessary. BUG=489444 TBR=michaeln@chromium.org Review URL: https://codereview.chromium.org/1303423009 Cr-Commit-Position: refs/heads/master@{#346994}
* Revert of [sqlite] Respect the gyp and gn component switch. (patchset #6 ↵phajdan.jr2015-09-015-6/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/1306863006/ ) Reason for revert: Suspected of breaking chromium.webkit Mac builders, see https://code.google.com/p/chromium/issues/detail?id=526208 Summary: Incompatible library version: httpd requires version 9.0.0 or later, but libsqlite3.dylib provides version 0.0.0 /b/build/slave/WebKit_Mac10_6__dbg_/build/src/out/Debug/libsqlite3.dylib seems to be used instead of expected/intended /usr/lib/libsqlite3.dylib Original issue's description: > [sqlite] Respect the gyp and gn component switch. > > SQLITE_API is the existing mechanism SQLite provides, and is used in > preference to inventing a new SQLITE_EXPORT symbol (like > sql/sql_export.h and other examples). > > CoreServices.framework is necessary on OSX because of the Time Machine > patch. > > Remove sql/proxy.{h,cc}, which was necessary to work around SQLite > linking statically into both component shlibs and unit test executables. > > [Relanding https://codereview.chromium.org/1322463002/ ] > > BUG=489444 > TBR=michaeln@chromium.org, thakis@chromium.org, brettw@chromium.org > > Committed: https://crrev.com/f71db5c36625ff00feb8283028631303ae5caa7c > Cr-Commit-Position: refs/heads/master@{#346536} TBR=michaeln@chromium.org,thakis@chromium.org,brettw@chromium.org,shess@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489444 Review URL: https://codereview.chromium.org/1325833003 Cr-Commit-Position: refs/heads/master@{#346615}
* [sqlite] Respect the gyp and gn component switch.shess2015-09-015-78/+6
| | | | | | | | | | | | | | | | | | | | | SQLITE_API is the existing mechanism SQLite provides, and is used in preference to inventing a new SQLITE_EXPORT symbol (like sql/sql_export.h and other examples). CoreServices.framework is necessary on OSX because of the Time Machine patch. Remove sql/proxy.{h,cc}, which was necessary to work around SQLite linking statically into both component shlibs and unit test executables. [Relanding https://codereview.chromium.org/1322463002/ ] BUG=489444 TBR=michaeln@chromium.org, thakis@chromium.org, brettw@chromium.org Review URL: https://codereview.chromium.org/1306863006 Cr-Commit-Position: refs/heads/master@{#346536}
* Revert of [sqlite] Respect the gyp and gn component switch. (patchset #2 ↵shess2015-08-285-6/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/1325513002/ ) Reason for revert: ARRGH! win8_chromium_gn_dgb is still broken. Original issue's description: > [sqlite] Respect the gyp and gn component switch. > > SQLITE_API is the existing mechanism SQLite provides, and is used in > preference to inventing a new SQLITE_EXPORT symbol (like > sql/sql_export.h and other examples). > > CoreServices.framework is necessary on OSX because of the Time Machine > patch. > > Remove sql/proxy.{h,cc}, which was necessary to work around SQLite > linking statically into both component shlibs and unit test executables. > > [Relanding https://codereview.chromium.org/1322463002/ ] > > BUG=489444 > TBR=michaeln@chromium.org, thakis@chromium.org > > Committed: https://crrev.com/02ce712af589a5b722ebbf5c2fffb3e0d4849963 > Cr-Commit-Position: refs/heads/master@{#346212} TBR=michaeln@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489444 Review URL: https://codereview.chromium.org/1307363007 Cr-Commit-Position: refs/heads/master@{#346213}
* [sqlite] Respect the gyp and gn component switch.shess2015-08-285-78/+6
| | | | | | | | | | | | | | | | | | | | | SQLITE_API is the existing mechanism SQLite provides, and is used in preference to inventing a new SQLITE_EXPORT symbol (like sql/sql_export.h and other examples). CoreServices.framework is necessary on OSX because of the Time Machine patch. Remove sql/proxy.{h,cc}, which was necessary to work around SQLite linking statically into both component shlibs and unit test executables. [Relanding https://codereview.chromium.org/1322463002/ ] BUG=489444 TBR=michaeln@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1325513002 Cr-Commit-Position: refs/heads/master@{#346212}
* Revert of [sqlite] Respect the gyp and gn component switch. (patchset #1 ↵sergeyv2015-08-285-6/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1322463002/ ) Reason for revert: Broken build on the Builder: Win x64 GN (dbg). Failure example: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/8549 Original issue's description: > [sqlite] Respect the gyp and gn component switch. > > SQLITE_API is the existing mechanism SQLite provides, and is used in > preference to inventing a new SQLITE_EXPORT symbol (like > sql/sql_export.h and other examples). > > CoreServices.framework is necessary on OSX because of the Time Machine > patch. > > Remove sql/proxy.{h,cc}, which was necessary to work around SQLite > linking statically into both component shlibs and unit test executables. > > BUG=489444 > > Committed: https://crrev.com/4ec68d9ad2d3e0c74967a17946c8bf7ed4450f73 > Cr-Commit-Position: refs/heads/master@{#346151} TBR=michaeln@chromium.org,shess@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489444 Review URL: https://codereview.chromium.org/1324523004 Cr-Commit-Position: refs/heads/master@{#346179}
* [sqlite] Respect the gyp and gn component switch.shess2015-08-285-78/+6
| | | | | | | | | | | | | | | | | | SQLITE_API is the existing mechanism SQLite provides, and is used in preference to inventing a new SQLITE_EXPORT symbol (like sql/sql_export.h and other examples). CoreServices.framework is necessary on OSX because of the Time Machine patch. Remove sql/proxy.{h,cc}, which was necessary to work around SQLite linking statically into both component shlibs and unit test executables. BUG=489444 Review URL: https://codereview.chromium.org/1322463002 Cr-Commit-Position: refs/heads/master@{#346151}
* [sql] Record SQLite memory usage after a week.shess2015-08-251-0/+8
| | | | | | | | | | | Previously landed 10-minute, 1-hour, and 1-day histograms. Based on those I expect 1-week to get around 20% worse. BUG=489784 Review URL: https://codereview.chromium.org/1316493006 Cr-Commit-Position: refs/heads/master@{#345366}
* Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598rockot2015-08-241-0/+1
| | | | | | | | | | | | | | | Re-land number two. Now with cherry-picked android test fix. BUG=None TBR=jam@chromium.org,ben@chromium.org TBR=mfoltz@chromium.org TBR=mek@chromium.org TBR=xhwang@chromium.org TBR=shess@chromium.org Review URL: https://codereview.chromium.org/1311043003 Cr-Commit-Position: refs/heads/master@{#345106}
* Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 ↵rockot2015-08-231-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1310103002/ ) Reason for revert: Looks like this breaks mojo_system_unittests on Android... http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=29595 Original issue's description: > Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 > > Re-land. Previously conflicted with another CL that landed > just before the roll. > > BUG=None > TBR=jam@chromium.org,ben@chromium.org > TBR=mfoltz@chromium.org > TBR=mek@chromium.org > TBR=xhwang@chromium.org > TBR=shess@chromium.org > > Committed: https://crrev.com/0bfe154baad9ddfb1f0c6ecc7cace36e8f430e75 > Cr-Commit-Position: refs/heads/master@{#344994} TBR=ben@chromium.org,jam@chromium.org,mek@chromium.org,mfoltz@chromium.org,shess@chromium.org,xhwang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/1309103002 Cr-Commit-Position: refs/heads/master@{#344996}
* Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598rockot2015-08-221-0/+1
| | | | | | | | | | | | | | | | Re-land. Previously conflicted with another CL that landed just before the roll. BUG=None TBR=jam@chromium.org,ben@chromium.org TBR=mfoltz@chromium.org TBR=mek@chromium.org TBR=xhwang@chromium.org TBR=shess@chromium.org Review URL: https://codereview.chromium.org/1310103002 Cr-Commit-Position: refs/heads/master@{#344994}
* Revert of Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 ↵yosin2015-08-221-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #3 id:120001 of https://codereview.chromium.org/1296453004/ ) Reason for revert: Compilation error by missing include file: ../../content/renderer/usb/web_usb_client_impl.cc -o obj/content/renderer/renderer/web_usb_client_impl.o In file included from ../../content/renderer/usb/web_usb_client_impl.cc:14: ../../content/renderer/usb/web_usb_device_impl.h:17:10: fatal error: 'third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h' file not found #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h" FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/renderer/renderer/web_usb_client_impl.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=245402-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DCONTENT_IMPLEMENTATION -DBORINGSSL_SHARED_LIBRARY -DGL_GLEXT_PROTOTYPES -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_LIBJPEG_TURBO=1 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DV8_SHARED -DUSING_V8_SHARED -DMOJO_USE_SYSTEM_IMPL -D_DEBUG -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DWEBRTC_LINUX -DWEBRTC_POSIX -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DPROTOBUF_USE_DLLS -DMESA_EGL_NO_X11_HEADERS -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -I../.. -Igen -I/usr/include/nss -I/usr/include/nspr -I../../third_party/boringssl/src/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/libwebp -I../../testing/gtest/include -I../../third_party/WebKit -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../third_party/qcms/src -I../../v8/include -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../third_party/webrtc/overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/protobuf -Igen -I../../third_party/mesa/src/include -I../../third_party/libyuv -I../../third_party/libyuv/include -I../../third_party/webrtc/overrides -I../../third_party -I../../third_party/webrtc/modules/interface -I../../third_party/webrtc/modules/audio_device/include -I../../third_party/webrtc/modules/audio_device/dummy -I../../third_party/libvpx/source/libvpx -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -m64 -march=x86-64 -funwind-tables -fPIC -pipe -pthread -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal -Wno-inconsistent-missing-override -Wno-shift-negative-value -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O0 -g2 -gsplit-dwarf -Wno-header-guard -Wno-incompatible-pointer-types -Wthread-safety -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -c ../../content/renderer/usb/web_usb_client_impl.cc -o obj/content/renderer/renderer/web_usb_client_impl.o In file included from ../../content/renderer/usb/web_usb_client_impl.cc:14: ../../content/renderer/usb/web_usb_device_impl.h:17:10: fatal error: 'third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h' file not found #include "third_party/mojo/src/mojo/public/cpp/bindings/error_handler.h" Original issue's description: > Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598 > > This updates lots of code which was missing an include of > mojo/public/cpp/bindings/binding.h (which used to be included > transitively from mojom-generated headers), and gets rid of > references to mojo::ErrorHandler. > > BUG=None > TBR=jam@chromium.org,ben@chromium.org > TBR=mfoltz@chromium.org > TBR=mek@chromium.org > TBR=xhwang@chromium.org > TBR=shess@chromium.org > > Committed: https://crrev.com/0b56a692d5c342a7093c361ff6ccb464c9d54947 > Cr-Commit-Position: refs/heads/master@{#344957} TBR=ben@chromium.org,jam@chromium.org,rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/1311613002 Cr-Commit-Position: refs/heads/master@{#344959}
* Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598rockot2015-08-221-0/+1
| | | | | | | | | | | | | | | | | | This updates lots of code which was missing an include of mojo/public/cpp/bindings/binding.h (which used to be included transitively from mojom-generated headers), and gets rid of references to mojo::ErrorHandler. BUG=None TBR=jam@chromium.org,ben@chromium.org TBR=mfoltz@chromium.org TBR=mek@chromium.org TBR=xhwang@chromium.org TBR=shess@chromium.org Review URL: https://codereview.chromium.org/1296453004 Cr-Commit-Position: refs/heads/master@{#344957}
* [sql] Record memory usage at various periods after startup.shess2015-08-121-1/+37
| | | | | | | | | | | This will be used to track improvements occuring from enabling memory-mapped I/O. BUG=489784 Review URL: https://codereview.chromium.org/1283033004 Cr-Commit-Position: refs/heads/master@{#343100}
* Remove remaining legacy SplitString calls.brettw2015-08-121-1/+2
| | | | | | | | TBR=zelidrag@chromium.org (chromeos) Review URL: https://codereview.chromium.org/1284833004 Cr-Commit-Position: refs/heads/master@{#342983}
* Convert remaining StringToLowerASCII to ToLowerASCII.brettw2015-08-111-2/+2
| | | | | | | | | | | | | | | | | | | | | Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece. http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did std::string old_header_name_lowercase(name); where it actually meant std::string old_header_name_lowercase(old_header_name); I fixed this. There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call. There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call. NOPRESUBMIT=true (for touching code with wstrings) Review URL: https://codereview.chromium.org/1282363003 Cr-Commit-Position: refs/heads/master@{#342869}
* Fix Mandoline apptests on Windows.jam2015-08-062-1/+6
| | | | | | | | BUG=516862,517175 Review URL: https://codereview.chromium.org/1272373004 Cr-Commit-Position: refs/heads/master@{#342056}
* HistogramTester::GetHistogramSamplesSinceCreation never returns nullvabr2015-08-031-5/+5
| | | | | | | | | | Currently, GetHistogramSamplesSinceCreation can return null if no histogram was generated. But that depends also on tests run prior to the current test. This CL changes this to returning empty samples instead, so that independently of previously run tests, the current test always gets the same response even if it does not generate any histograms. BUG=473689 Review URL: https://codereview.chromium.org/1264123002 Cr-Commit-Position: refs/heads/master@{#341498}
* Remove myself from OWNERS files.erikwright2015-07-311-1/+0
| | | | | | | | | BUG= TBR=robertshield, cbentzel, siggi, caitkp, jochen, shess Review URL: https://codereview.chromium.org/1256823006 Cr-Commit-Position: refs/heads/master@{#341352}
* Add GN isolate support for a bunch of unittests.dpranke2015-07-221-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | This enables the following tests to be run under swarming on a GN bot: - angle_unittests - accessibility_unittests - compositor_unittests - cc_unittests - ipc_tests - gl_unittests - sandbox_linux_unittests - gn_unittests - skia_unittests - sql_unittests - url_unittests R=brettw@chromium.org, maruel@chromium.org BUG=504079 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel Review URL: https://codereview.chromium.org/1248673005 Cr-Commit-Position: refs/heads/master@{#339973}
* mandoline filesystem: Reland "Save cookie data to the mojo:filesystem."erg2015-07-154-8/+60
| | | | | | | | | | | | | | | | | | | In addition to saving the cookies to the file system service (per the previous patch), we also modify the filesystem service to take a client. When the shell connection to the file system service is broken, instead of quitting immediately, we broadcast a shutdown notification to all of our clients, and wait for them to close the directory objects. This solves the timing problems during shutdown. BUG=493311 TBR=shess@chromium.org R=jam@chromium.org,erikwright@chromium.org First Review URL: https://codereview.chromium.org/1179413010 Review URL: https://codereview.chromium.org/1231493002 Cr-Commit-Position: refs/heads/master@{#338888}
* Move JoinString to the base namespace.brettw2015-07-151-2/+2
| | | | | | | | | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 Cr-Commit-Position: refs/heads/master@{#338762} patch from issue 1223153003 at patchset 160001 (http://crrev.com/1223153003#ps160001) BUG= Review URL: https://codereview.chromium.org/1230243005 Cr-Commit-Position: refs/heads/master@{#338819}
* Revert of Move JoinString to the base namespace (patchset #9 id:160001 of ↵hongchan2015-07-141-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1223153003/) Reason for revert: The compilation failure with the following error message: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/common.chrome_content_client.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=241602-3 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_LEGACY_SKPOINT3_CTORS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DLIBXML_STATIC -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -I../../third_party/WebKit -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../net/third_party/nss/ssl -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -Igen/ui/resources -Igen/extensions -Igen/extensions/strings -I../../third_party/re2 -Igen/policy -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wexit-time-destructors -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../chrome/common/chrome_content_client.cc -o obj/chrome/common/common.chrome_content_client.o ../../chrome/common/chrome_content_client.cc:193:34: error: no matching function for call to 'JoinString' std::string codec_string = base::JoinString( ^~~~~~~~~~~~~~~~ Original issue's description: > Move JoinString to the base namespace. > > Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. > > Update callers who pass empty separators to use a base::StringPiece() > > Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). > > TBR=zelidrag@chromium.org for chromeos > > Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 > Cr-Commit-Position: refs/heads/master@{#338762} TBR=jam@chromium.org,zelidrag@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1237873004 Cr-Commit-Position: refs/heads/master@{#338770}
* Move JoinString to the base namespace.brettw2015-07-141-2/+2
| | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Review URL: https://codereview.chromium.org/1223153003 Cr-Commit-Position: refs/heads/master@{#338762}
* sql: Cleanup to fix the header include guards.tfarina2015-07-142-6/+6
| | | | | | | | | | | | | | | | The header include guards should match the file path from root. These entries were found using a modified version of Eric's fix-include-guards.py script found attached in https://code.google.com/p/chromium/issues/detail?id=435361#c7. BUG=None TEST=sql_unittests R=erikwright@chromium.org Review URL: https://codereview.chromium.org/1238583002 Cr-Commit-Position: refs/heads/master@{#338703}
* Replace base::str[n]casecmp with helper functions.brettw2015-07-101-1/+2
| | | | | | | | | | | | | | | | | | | | Adds CompareCaseInsensitiveASCII and EqualsCaseInsensitiveASCII helper functions and removes base::strcasecmp and base::strncasecmp. This avoids the dangerous locale-sensitive behavior. ClientIsAdvertisingSdchEncoding in sdch_browsertest had the condition inverted, but because it returned true any time the given line wasn't found, the test didn't notice. cups_helper changed most significantly. I redid the loop to use StringPieces which saves a lot of copies. On line 82 cups_helper used to do a prefix match which I'm pretty sure it wanted a regular compare. I changed this. render_text_harfbuzz set "<" operator was also doing a prefix comparison only, when it looks like it really just wanted to compare the strings. file_path passed string pieces into strcasecmp which could then read off the end if they're not null terminated. This patch fixes the bug and calls the native strcasecmp which is probably the best we can do for Posix file names. Removed additional version of the same function in net. Adds a backwards-compat hack for crashpad which improperly uses base from a DEPS-ed in repo. Review URL: https://codereview.chromium.org/1224553010 Cr-Commit-Position: refs/heads/master@{#338324}
* Revert of mandoline filesystem: Save cookie data to the mojo:filesystem. ↵fsamuel2015-07-072-30/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #16 id:300001 of https://codereview.chromium.org/1179413010/) Reason for revert: I'm seeing the following crash when closing the Mandoline window on Linux: [0707/104753:FATAL:sqlite_persistent_cookie_store.cc(1135)] Check failed: false. Could not add a cookie to the DB. #0 0x00000046aef1 __interceptor_backtrace #1 0x7fec4b87954e base::debug::StackTrace::StackTrace() #2 0x7fec4b479a1d logging::LogMessage::~LogMessage() #3 0x7fec53f03c23 net::SQLitePersistentCookieStore::Backend::Commit() #4 0x7fec53f04f38 net::SQLitePersistentCookieStore::Backend::InternalBackgroundClose() #5 0x7fec53f1902b base::internal::RunnableAdapter<>::Run() Reverting this patch resolves the issue. Original issue's description: > mandoline filesystem: Save cookie data to the mojo:filesystem. > > This makes the network service use the sql vfs to proxy writing the > cookies to the filesystem service. This means mojo:network_service does > not directly write its data to the OS filesystem, which will allow us to > sandbox it. > > BUG=493311 > > Committed: https://crrev.com/bbb9e2f6486cccadde4dc2fa077af8f694105eaa > Cr-Commit-Position: refs/heads/master@{#337491} TBR=jam@chromium.org,msw@chromium.org,sky@chromium.org,shess@chromium.org,erg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493311 Review URL: https://codereview.chromium.org/1225673006 Cr-Commit-Position: refs/heads/master@{#337602}
* mandoline filesystem: Save cookie data to the mojo:filesystem.erg2015-07-062-1/+30
| | | | | | | | | | | | | This makes the network service use the sql vfs to proxy writing the cookies to the filesystem service. This means mojo:network_service does not directly write its data to the OS filesystem, which will allow us to sandbox it. BUG=493311 Review URL: https://codereview.chromium.org/1179413010 Cr-Commit-Position: refs/heads/master@{#337491}
* Convert sql_unittests to run exclusively on Swarmingmaruel2015-06-301-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0 configs already ran on Swarming 29 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert sql_unittests R=gbillock@chromium.org,dpranke@chromium.org TBR= BUG=98637 Review URL: https://codereview.chromium.org/1217173004 Cr-Commit-Position: refs/heads/master@{#336884}
* Move more string_util functions to base namespace.brettw2015-06-241-1/+1
| | | | | | | | | | | | | | Rename IsWhitespace to IsUnicodeWhitespace (to contrast it to the already-existing IsAsciiWhitespace). De-inline HexDigitToInt. This is only used in a few places and I don't think it's necessary to inline. Remove some redundant base:: qualifications in base. TBR=sky Review URL: https://codereview.chromium.org/1200053004 Cr-Commit-Position: refs/heads/master@{#335827}
* mandoline filesystem: add a sqlite3 vfs to proxy filesystem usage.erg2015-06-2021-155/+1379
| | | | | | | | | | | | | | | | | | | | | | This adds a //sql/mojo library which can be linked into preexisting sqlite3 code which adds a new VFS which transparently proxies filesystem usage to the mojo:filesystem application. We create a new sql_apptests.mojo target, which currently has all the sql connection_unittests.cc (minus 2 hard ones), all statement and transaction unit tests and refactor the sql testing stuff so that we have two implementations of an SQLTestBase class: one that uses files raw and one that proxies to the filesystem process. Notably, this patch does not implement file locking, which will have to be implemented before we can safely use this, but will be a large enough patch in and of itself that I'm punting on it for this patch. BUG=493311 Review URL: https://codereview.chromium.org/1176653002 Cr-Commit-Position: refs/heads/master@{#335415}
* [Android] Generate scripts at build time to run android tests.mikecase2015-06-032-0/+5
| | | | | | | | | | | Making changes so that at build time scripts will be generated that can be used to easily run tests. BUG=490781 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1120883002 Cr-Commit-Position: refs/heads/master@{#332518}
* [sql] Stats gathering for sql/ APIs.shess2015-06-039-23/+841
| | | | | | | | | | | | | | | | Generate stats for how many SQL statements are executed, how many results they return, and how many changes they make. Generate timing values for how long is spent doing all queries, doing updating operations, doing autocommit updates, and commiting transactions. The goal of these metrics is to quantify results of decisions like enabling write-ahead log or memory-mapped I/O. BUG=489788,489444 Review URL: https://codereview.chromium.org/1145833002 Cr-Commit-Position: refs/heads/master@{#332503}
* [sql] Don't persist data in journal files.shess2015-06-022-7/+5
| | | | | | | | | | | | | Using journal_mode=PERSIST in combination with secure_delete=ON is probably not quite right. Switch to journal_mode=TRUNCATE for now, while considering whether that combination should overwrite (or be forbidden). BUG=493008 Review URL: https://codereview.chromium.org/1159033004 Cr-Commit-Position: refs/heads/master@{#332309}
* sql: Remove basictypes.h includes.tfarina2015-05-1113-26/+27
| | | | | | | | | | | | | * Use the standard integer types from stdint.h instead. * Use macros.h for the DISALLOW_COPY_AND_ASSIGN macro. BUG=138542 TEST=sql_unittests R=shess@chromium.org Review URL: https://codereview.chromium.org/1133053004 Cr-Commit-Position: refs/heads/master@{#329256}
* [sql] Fix error in Preload size.shess2015-04-211-1/+1
| | | | | | | | | | Was using file size rather than limiting to file size. BUG=none Review URL: https://codereview.chromium.org/1096113002 Cr-Commit-Position: refs/heads/master@{#326064}
* [sql] Also call ShouldIgnoreSqliteError() in Release build.shess2015-04-101-4/+4
| | | | | | | | | | | | https://crrev.com/92a2ab1f1d0cdff39e6d506c4cb6a80038baeeb3 put the test (which has a side effect) in DLOG_IF which doesn't apply in Release builds. BUG=none Review URL: https://codereview.chromium.org/1075993003 Cr-Commit-Position: refs/heads/master@{#324697}
generated by cgit v1.1 at 2024-10-28 21:25:16 +0000