summaryrefslogtreecommitdiffstats
path: root/sync/android
Commit message (Collapse)AuthorAgeFilesLines
* [Sync] Ensure isSyncable is set when signed in.maxbogue2015-04-212-8/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a more extensive version of http://crrev.com/1075343003 for landing on trunk. Previously, if isSyncable is false, but sync is enabled for Chrome, even if you sign in, Chrome would never set syncable to true. This CL ensures that syncable is always set to true if there is an account signed in, regardless of whether chrome sync is enabled or not. Additionally, it sets syncable to false when no account is signed in, to ensure that the user does not see a non-functional switch in the Android settings. The new AccountManager setup in the test is necessary so that the test accounts can be cleaned up by the loop in updateSyncability(). BUG=475299 TEST=Regression tests added, plus: Ensure that $ adb shell dumpsys content | grep chrome should show syncable=0 and enabled=true Sign in to Chrome. Now dumpsys should say syncable=1 and enabled=true. Review URL: https://codereview.chromium.org/1062973004 Cr-Commit-Position: refs/heads/master@{#326122}
* [Sync] Fix invalidations on Android.maxbogue2015-04-161-0/+5
| | | | | | | | | | | | | | This bug was preventing Chrome from registering for GCM invalidations on Android, meaning that sync was never told to download new data. The bug was introduced by http://crrev.com/1048423005, where the ensureGcmIsInitialized line was removed from the SyncController constructor. The onFirstStart call was supposed to handle it, but from a clean start sync is disabled, so that case is not hit. This patch moves the ensureGcmIsInitialized call back to the constructor, and the test ensures that the call is made at some point during browser initialization. BUG=475299 Review URL: https://codereview.chromium.org/1081283003 Cr-Commit-Position: refs/heads/master@{#325359}
* Fix up if statement curly braces issues.aurimas2015-03-181-2/+1
| | | | | | | | | | | | Java styleguide requires curly braces for all if statements except for single line if statements without else case. BUG=None TBR=qinmin@chromium.org Review URL: https://codereview.chromium.org/1002883002 Cr-Commit-Position: refs/heads/master@{#321188}
* [Sync] Make sure to register for autofill wallet invalidation on androidzea2015-02-281-1/+5
| | | | | | | | | | | Wallet was not receiving invalidation previously because the Android side did not know to register the type. This fixes that. BUG=none Review URL: https://codereview.chromium.org/967673002 Cr-Commit-Position: refs/heads/master@{#318566}
* Initialize AndroidSyncSettings with the account on startup.maxbogue2015-02-282-0/+3
| | | | | | | | | | | | My recent refactor (http://crrev.com/879533004) modified AndroidSyncSettings to only read the account when it changed, but did not correctly initialize the account on startup. BUG=462658,462618 Review URL: https://codereview.chromium.org/965043003 Cr-Commit-Position: refs/heads/master@{#318561}
* [Sync] Remove unused deprecated methods from AndroidSyncSettings.maxbogue2015-02-271-17/+0
| | | | | | Review URL: https://codereview.chromium.org/960123004 Cr-Commit-Position: refs/heads/master@{#318359}
* Rewrite AndroidSyncSettings to be significantly simpler.maxbogue2015-02-263-512/+235
| | | | | | | | | | | | | | | | | | The public methods no longer take an Account as a parameter. Instead, when the account changes, updateAccount() is called by ChromeSigninController. This removes the need for all of the "didUpdate" logic. Instead, updateCachedSettings() is called only when the Android settings are changed or the account is changed. CachedAccountSettings has been removed entirely. A separate class is not necessary to cache three boolean values (which it was already only handling two of!) Review URL: https://codereview.chromium.org/879533004 Cr-Commit-Position: refs/heads/master@{#318196}
* Completely remove SyncStatusHelper.maxbogue2015-02-031-438/+0
| | | | | | | | It was renamed to AndroidSyncSettings in http://crrev.com/845543005. Review URL: https://codereview.chromium.org/887143002 Cr-Commit-Position: refs/heads/master@{#314427}
* Rename SyncStatusHelper to AndroidSyncSettings.maxbogue2015-01-236-58/+512
| | | | | | | | | | | Also renamed a bunch of the public methods for clarity. The old SyncStatusHelper class will be removed once downstream is updated. Review URL: https://codereview.chromium.org/845543005 Cr-Commit-Position: refs/heads/master@{#312915}
* Implement SupervisedUserWhitelistService.bauerb2014-12-261-1/+5
| | | | | | | | BUG=436459 Review URL: https://codereview.chromium.org/807183002 Cr-Commit-Position: refs/heads/master@{#309677}
* Delete SyncDecryptionPassphraseType.maxbogue2014-12-181-121/+0
| | | | | | Review URL: https://codereview.chromium.org/805983002 Cr-Commit-Position: refs/heads/master@{#309044}
* [Push] Remove unused disable-sync-gcm-in-order-to-try-push-api flagmiguelg2014-12-112-29/+0
| | | | | | | | BUG=437821 Review URL: https://codereview.chromium.org/791963002 Cr-Commit-Position: refs/heads/master@{#307898}
* Add PassphraseType to replace SyncDecryptionPassphraseType.maxbogue2014-12-082-9/+111
| | | | | | | | | PassphraseType does not have the extra INVALID and NONE values that SyncDecryptionPassphraseType does; it matches the C++ side. Review URL: https://codereview.chromium.org/779333003 Cr-Commit-Position: refs/heads/master@{#307299}
* Fix a bunch of Java Checkstyle issues.aurimas2014-11-202-7/+7
| | | | | | | | | BUG=318404 TBR=samuong@chromium.org Review URL: https://codereview.chromium.org/744453002 Cr-Commit-Position: refs/heads/master@{#305047}
* Enable separatorWrap module in CheckStyle and fix all the issues.aurimas2014-10-222-12/+12
| | | | | | | | | BUG=318404 TBR=boliu@chromium.org,mef@chromium.org,zea@chromium.org,kollas@chromium.org Review URL: https://codereview.chromium.org/672533002 Cr-Commit-Position: refs/heads/master@{#300753}
* Allow disabling the encrypt everything option.maxbogue2014-10-171-2/+17
| | | | | | | | | | | In certain cases, we don't want to allow encrypting all data (AKA, the CUSTOM_PASSPHRASE type). BUG=424187 Review URL: https://codereview.chromium.org/656333002 Cr-Commit-Position: refs/heads/master@{#300029}
* Fix Java indentation issues.aurimas2014-10-163-14/+14
| | | | | | | | | | Fix indentation issue to allow enabling Checkstyle indentation rule. BUG=318404 Review URL: https://codereview.chromium.org/654293002 Cr-Commit-Position: refs/heads/master@{#299823}
* Fix Java Checkstyle issues.Aurimas Liutikas2014-10-141-1/+1
| | | | | | | | | | | | | | After this change we are down to: - 3 redundant import warnings (due to JNI generator) - 69 JavaDoc warnings BUG=318404 R=agl@chromium.org, blundell@chromium.org, boliu@chromium.org, lambroslambrou@chromium.org, nyquist@chromium.org, qinmin@chromium.org, rmcilroy@chromium.org, tedchoc@chromium.org TBR=yfriedman@chromium.org Review URL: https://codereview.chromium.org/652603004 Cr-Commit-Position: refs/heads/master@{#299540}
* Some cleanup of AccountManagerHelper.maxbogue2014-10-141-23/+13
| | | | | | | | | | Removes the last code path that might create a pop-up dialog. BUG=302608 Review URL: https://codereview.chromium.org/648343003 Cr-Commit-Position: refs/heads/master@{#299514}
* Make chrome_shell_apk buildcjhopman2014-10-131-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This mostly just adds the chrome_shell_apk build definition and those of a whole bunch of targets. Adds a simple check that when DEPRECATED_java_in_dir is used, it actually includes the "src" at the end (GYP just assumes that you really meant that java files are in <(java_in_dir)/src). Makes the call to process_resources only generate R.java for extra packages when being run as part of the apk step (otherwise, for example, both chrome resources and content resources would contain an R.java for net resources and compilation would fail). Depends on https://codereview.chromium.org/581273004/ Adds the following targets -- and enables ~300 more (550 counting template-generated inner targets): //chrome:chrome_android_core //chrome/android:chrome_strings_grd //chrome/android:chrome_java //chrome/android:activity_type_ids_javagen //chrome/android:app_banner_metrics_ids_javagen //chrome/android:resource_id_javagen //chrome/android:profile_account_management_metrics_javagen //chrome/android:profile_sync_service_model_type_selection_javagen //chrome/android:toolbar_model_security_levels_javagen //chrome/android:tab_load_status_javagen //chrome/android:chrome_shell_base //chrome/android:chrome_shell //chrome/android:chrome_sync_shell //chrome/android:chrome_shell_resources //chrome/android:chrome_shell_java //chrome/android:chrome_shell_assets //chrome/android:chrome_shell_apk //chrome/android:chrome_sync_shell_apk //components/bookmarks:bookmarks_java //components/bookmarks:bookmarks_jni_headers //components/bookmarks:bookmark_type_javagen //components/dom_distiller/android:dom_distiller_core_java //components/dom_distiller/android:dom_distiller_core_font_family_javagen //components/dom_distiller/android:dom_distiller_core_theme_javagen //components/enhanced_bookmarks:jni_headers //components/enhanced_bookmarks/android:enhanced_bookmarks_java //components/gcm_driver:gcm_driver_java //components/gcm_driver:jni_headers //components/navigation_interception/android:navigation_interception_java //components/variations:variations_java //components/web_contents_delegate_android:web_contents_delegate_android //components/web_contents_delegate_android:web_contents_delegate_android_java //components/web_contents_delegate_android:web_contents_delegate_android_jni_headers //printing:printing_java //sync:fake_server_jni //sync:sync_java_test_support //sync:test_support_sync_fake_server_android //sync:sync_unit_tests_apk //sync/android:sync_java //sync/android:sync_javatests BUG=359249 TBR=ben Review URL: https://codereview.chromium.org/570203002 Cr-Commit-Position: refs/heads/master@{#299381}
* Make sure GetAuthenticatedAccountId() returns a canonicalized id.rogerta2014-10-092-2/+81
| | | | | | | | | | | | This CL is a prerequisite for: https://codereview.chromium.org/473153002/ BUG=341408 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/617183003 Cr-Commit-Position: refs/heads/master@{#298996}
* Make all auth requests notification-driven.maxbogue2014-10-091-13/+5
| | | | | | | | | | | | | | | | | | | | | Previously, when having authentication issues on Android (for example, if the user changed their password), Chrome would pop-up a dialog asking the user to sign in again. This was bad, because part of the auth flow has a link to a website where you can do account recovery, but that would just kick you back into the auth pop-up in an infinite loop. Also it was intrusive to the user and against Android best practices. Additionally, on dev builds of Chromium, it could result in an annoying stream of permission request pop-ups dominating the screen. Now, in both cases, the auth request is handled by generating a notification that the user must activate before losing control of the screen. BUG=302608 Review URL: https://codereview.chromium.org/627543002 Cr-Commit-Position: refs/heads/master@{#298911}
* Move passphrase dialog logic to the enum.maxbogue2014-10-091-0/+47
| | | | | | | | | | In preparation for a bug fix. BUG=419927 Review URL: https://codereview.chromium.org/642623002 Cr-Commit-Position: refs/heads/master@{#298900}
* Massive refactor of the Android invalidation code.maxbogue2014-09-293-1469/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want the invalidations code to exist as a component independent of sync (see bug). This CL seeks to move toward that for the Android invalidations codebase. Generally, things moved from //chrome/browser/invalidation to //components/invalidation, even if git didn't mark them as moves. To accomplish this, I had to unify where the JNI occurred. In Java, InvalidationService was renamed to InvalidationClientService as the class that communicates with GCM. A new InvalidationService class was introduced to handle JNI and other Java entry points to the component. Several methods from ProfileSyncService and InvalidationController moved to it. InvalidationController is now the bridge between sync and the invalidation component, and has no JNI nor C++ counterpart. InvalidationServiceFactory was added to assist in the creation and management of InvalidationService objects across the JNI boundary. BUG=259559 Review URL: https://codereview.chromium.org/459513002 Cr-Commit-Position: refs/heads/master@{#297202}
* Roll cacheinvalidation DEPS to r341nyquist2014-09-161-3/+2
| | | | | | | | | | | | | | | | This removes the last known dependency on guava_javalib. Full list of changes: r340 Removing guava dependency for the invalidation client (part of an effort to reduce method count in Android applications) r341 Fixing package name in AndroidListenerManifest.xml and ordering factory methods by corresponding proto field in AndroidService.java BUG=412673 TBR=zea@chromium.org Review URL: https://codereview.chromium.org/573733004 Cr-Commit-Position: refs/heads/master@{#295113}
* Remove most usages of guava.nyquist2014-09-127-12/+14
| | | | | | | | | | | This CL removes most usages of the guava library. TBR=thakis@chromium.org,brettw@chromium.org,yfriedman@chromium.org BUG=412673 Review URL: https://codereview.chromium.org/565743002 Cr-Commit-Position: refs/heads/master@{#294620}
* Disable FAVICON_TRACKING in addition to SESSION.maxbogue2014-09-041-1/+1
| | | | | | | | BUG=378035 Review URL: https://codereview.chromium.org/537083002 Cr-Commit-Position: refs/heads/master@{#293348}
* Roll cacheinvalidation DEPS to r339nyquist2014-09-043-4/+3
| | | | | | | | | | | | | | | | | | | Changes are needed for Chrome for Android using nano protobufs. Full list of changes: r339 Adding forwarding implementation of WakeLockManager in its original location (temporary workaround for Chromium) r338 * Updating example code to use nano protos instead of lite protos * Addressing Android lint warnings r337 Removing unused ticl.ProtoWrapper class and moving example code r336 Android cache invalidation client release August 2014 Depends on https://codereview.chromium.org/532303003/ BUG=377891 Review URL: https://codereview.chromium.org/513293002 Cr-Commit-Position: refs/heads/master@{#293340}
* Use name() instead of toString() and fix comparison order in ModelType.bauerb2014-08-281-1/+1
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/511253002 Cr-Commit-Position: refs/heads/master@{#292451}
* Use .equals() for string comparisons in ModelType.bauerb2014-08-281-1/+1
| | | | | | | | | | | This fixes a FindBugs warning. NOTRY=true BUG=none Review URL: https://codereview.chromium.org/517453003 Cr-Commit-Position: refs/heads/master@{#292364}
* Enable invalidations for supervised user settings on Android.bauerb2014-08-282-11/+29
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/493293002 Cr-Commit-Position: refs/heads/master@{#292353}
* [Checkstyle] Update class member variable names to match style guides.aurimas@chromium.org2014-08-081-8/+8
| | | | | | | | | | | | - Non-public, non-static field names start with m. http://source.android.com/source/code-style.html#follow-field-naming-conventions BUG=318404 Review URL: https://codereview.chromium.org/452613002 Cr-Commit-Position: refs/heads/master@{#288299} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288299 0039d316-1c4b-4281-b951-d872f2087c98
* Disable session invalidations on Android with a flag.maxbogue@chromium.org2014-07-161-1/+13
| | | | | | | | | | | This will allow us to roll the change out gradually using Finch. BUG=385213 Review URL: https://codereview.chromium.org/362553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283476 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GCMDriver.java using MultiplexingGcmListenerjohnme@chromium.org2014-06-122-0/+29
| | | | | | | | | | | | | | | | Known caveat: - Since GCM on Android only supports a single registration per native app, only a single web app can register at once, and even then only if they pass --disable-sync-gcm-in-order-to-try-push-api on the command line which disables Chrome Sync etc from receiving GCM messages. Depends on https://codereview.chromium.org/316963003/ BUG=350384 Review URL: https://codereview.chromium.org/314293006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276795 0039d316-1c4b-4281-b951-d872f2087c98
* Use a framework method to decrease code duplication in SyncStatusHelpercimamoglu@chromium.org2014-05-061-24/+5
| | | | | | | | | | Use StrictMode.allowThreadDiskWrites instead of temporarilyAllowDiskWritesAndDiskReads. The former method does exactly the same thing. Review URL: https://codereview.chromium.org/267453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268481 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemAccountManagerDelegate to app contextdtrainor@chromium.org2014-03-211-1/+1
| | | | | | | | | | | | Make the SystemAccountManagerDelegate pass the application Context to AccountManager.get(). This way if the Activity dies and is recreated we can be sure not to hold a reference to it. See AccountManager#get() documentation for additional details. BUG=341231 Review URL: https://codereview.chromium.org/206723004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258520 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor ActivityStatus to not store currentdtrainor@chromium.org2014-02-211-2/+2
| | | | | | | | | | | | - Refactor ActivityStatus to expose application level visibility over activity visbility. - Add a listener for the visibility of the Application (are any Activities visible?) BUG=341231 NOTRY=true Review URL: https://codereview.chromium.org/159173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252679 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Fix sync masterSyncAutomatically setting.shashishekhar@chromium.org2014-02-061-7/+18
| | | | | | | | | | | | | The sync settings notification code only fires a notification when the account level sync setting changes. When only MasterSyncAutomatically changes the code fails to fire a notification, correct the behavior. BUG=340911 R=nyquist@chromium.org Review URL: https://codereview.chromium.org/155573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249225 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Java style issues in sync/androidaurimas@chromium.org2013-12-1216-81/+81
| | | | | | | | | BUG=320711 NOTRY=true Review URL: https://codereview.chromium.org/111933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240260 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing all Java import ordering issues.aurimas@chromium.org2013-12-105-8/+4
| | | | | | | | | | BUG=320711 TBR=isherman@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/110963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239823 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix Invalidations client name crashrlarocque@chromium.org2013-11-227-29/+171
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The first attempt at setting consistent invalidator IDs, r234524, has turned out to be a failure. It was based on the assumption that the InvalidationController was the only object that would start the InvalidationService. That assumption was wrong. This CL takes a new approach. Rather than having the InvalidationController manage the ID and send it to the InvalidationService, we now managed it in the InvalidationClientNameProvider class, which is avialable to both the InvalidationController and InvalidationService. This allows both classes to synchronously request a client name as they need it. The InvalidationClientNameProvider is, by default, backed by an InvalidationClientNameGenerator that provides it with fully random IDs. This is not ideal, but it's better than the other alternatives. Once this change is fully implemented, the downstream code will invoke UniqueIdInvalidationClientNameGenerator.doInitializeAndInstallGenerator() during early init. This will initialize a UniqueIdInvalidationClientNameGenerator with a UuuidBasedUniqueIdentificationGenerator that will provide a consistent identifier across restarts, and inject this InvalidationClientNameGenerator into the InvalidationClientNameProvider. BUG=320873 Review URL: https://codereview.chromium.org/77243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236681 0039d316-1c4b-4281-b951-d872f2087c98
* Rename stale SyncContentResolverWrapper occurrences to ↵cimamoglu@chromium.org2013-11-131-24/+24
| | | | | | | | | | SyncContentResolverDelegate. The relevant CL where renaming was done: https://chromiumcodereview.appspot.com/11929040/ Review URL: https://codereview.chromium.org/59883009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234816 0039d316-1c4b-4281-b951-d872f2087c98
* Support for shared invalidator client IDsrlarocque@chromium.org2013-11-123-42/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | Allow the Java side of the Andorid invalidations implementation to share its client ID with its associated C++ classes. The InvalidationController class will prefer to use an ID from a provided UniqueIdentificationGeneratorFactory. This ID would have the advantage of persisting across restarts, which is necessary to ensure effective reflection blocking. If the UniqueIdentificationGeneratorFactory has not been provided, as may be the case in tests, the InvalidationController will generate its own temporary ID. This will effectievely disable reflection blocking, but it's better than returning a consistent ID (since that would risk blocking notifications that we actually need). This randomly generated ID is not much different from the randomly generated ID created by the InvalidationService prior to this CL. At the time of this writing, the code to set up the UniqueIDGeneratorFactory is not in place. This will be added in a later commit. Until then, reflection blocking will remain broken. BUG=172391 Review URL: https://codereview.chromium.org/54923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234524 0039d316-1c4b-4281-b951-d872f2087c98
* (2 of 2) Move InvalidationController to chrome/rlarocque@chromium.org2013-10-311-128/+0
| | | | | | | | | | | | | | | Remove InvalidationController from its old location. This completes the move that was started in r231232. The downstream code has been updated to point to the InvalidationController in its new location. Now that the class defined in the old location is completely unused, we can safely remove it. BUG=172391 Review URL: https://codereview.chromium.org/49833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231975 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed SyncStatusHelper not updating observers on changes.apiccion@chromium.org2013-10-312-33/+333
| | | | | | | | | | | * SyncStatusHelper now updates observers whenever cached contents changes, previously only updated on content resolver notifications. BUG=299123 Review URL: https://codereview.chromium.org/26116009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231960 0039d316-1c4b-4281-b951-d872f2087c98
* (1 of 2) Move InvalidationController to chrome/rlarocque@chromium.org2013-10-276-510/+185
| | | | | | | | | | | | | | | | | | | | | | | Move the InvalidationController Java class from sync/notifier to chrome/browser/invalidation. Move its IntentProtocol inner class into its own class, InvalidationIntentProtocol, and keep it in sync/notifier. In order to prevent this change from breaking the downstream build, a reduced version of InvalidationController has been left behind in the old location. The second part of this patch will remove it. An unfortunate side effect of having two InvalidationControllers is that they may be double-notified when the when the activity state changes, and this may cause the start or stop signals to be sent to the InvalidationService twice. This is wasteful, but otherwise mostly harmless. TBR=jhawkins BUG=172391 Review URL: https://codereview.chromium.org/45103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231232 0039d316-1c4b-4281-b951-d872f2087c98
* Add visibility check to [ActivityStatus]dfalcantara@chromium.org2013-10-171-8/+1
| | | | | | | | | | | | | | | | | | Some Java code checks to see whether Chrome is in the foreground when it should really be checking if the Application's top Activity is visible for scenarios where a little popup partially covers Chrome. Add a method to make the check more explicit, then change obvious places that do checks on whether Chrome is running to use the new function. Precursor to https://gerrit-int.chromium.org/#/c/45073/ BUG=308211 R=nyquist@chromium.org, tedchoc@chromium.org, yfriedman@chromium.org Review URL: https://codereview.chromium.org/27509007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229172 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup for refactored ActivityStatus.tedchoc@chromium.org2013-10-161-1/+1
| | | | | | | | | R=yfriedman BUG= Review URL: https://codereview.chromium.org/24795004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228834 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated methods.shashishekhar@chromium.org2013-10-161-18/+0
| | | | | | | | | | These methods are no longer used. TBR=nyquist Review URL: https://codereview.chromium.org/26155005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228811 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue with sync status observer for testshell.nyquist@chromium.org2013-10-111-2/+20
| | | | | | | | | | | | Also adds a test to ensure the sync status observer behaves correctly. Depends on: https://codereview.chromium.org/23686014/ BUG=272584 Review URL: https://codereview.chromium.org/23450036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228237 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 10:11:04 +0000