summaryrefslogtreecommitdiffstats
path: root/sync
Commit message (Collapse)AuthorAgeFilesLines
* Add originator_* fields to mock connection testsrlarocque@chromium.org2013-02-213-301/+583
| | | | | | | | | | | | | | | | | | | | | | | The upcoming UniquePositions patch will rely on the originator_cache_guid and originator_client_item_id fields which are sent down on the GetUpdate response. This commit updates many of the tests that use the MockServerConnectionManager to provide mock values of those fields. Their values will be ignored for now, but committing this early will make the UniquePositions patch smaller. A few of the tests involved nodes that were bookmarks and also had non-NULL unique_client_tag values. Such items do not exist outside of tests, and much of the code doesn't know how to handle them properly. To avoid having to assign origiantor_client_item_ids and originator_cache_guid values to these items (which would make them even more unrealistic), the tests were modified to use preference nodes instead of bookmarks. BUG=145412 Review URL: https://chromiumcodereview.appspot.com/12326018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183732 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit tests for SyncManager change handlingrlarocque@chromium.org2013-02-211-0/+299
| | | | | | | | | | | | | | | During the code review for UniquePositions [1], we found a fairly serious issue in code that was only tested by the integration tests. This set of unit tests attempts to close that hole in our unit test coverage. [1] See https://codereview.chromium.org/11885024/. BUG=145412 Review URL: https://chromiumcodereview.appspot.com/12294043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183692 0039d316-1c4b-4281-b951-d872f2087c98
* Use _target_name instead of package_name for java*.gypicjhopman@chromium.org2013-02-202-2/+0
| | | | | | | | | | | | | | | We were using package_name as a unique name for naming output files and directories. package_name was typically the same as _target_name or a variation of it (like dropping _apk). Using _target_name instead means we need to specify one less thing and it is (maybe?) guaranteed to be unique. TBR=brettw,joi,jar,fischman,zea,sky BUG= Review URL: https://chromiumcodereview.appspot.com/11308030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183639 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Extract Android-specific prod Java GYP-target to a separate file.nyquist@chromium.org2013-02-204-17/+33
| | | | | | | | | | | | | Currently, both Android Java-targets live within sync_tests.gypi. This CL moves the prod target sync_java out to a separate file, and also adds per-file OWNERS entries for that file, using the same owners as in sync/android/OWNERS. BUG=None Review URL: https://chromiumcodereview.appspot.com/12303034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183498 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add boilerplate for favicons typezea@chromium.org2013-02-207-13/+80
| | | | | | | | | | | | There are actually two types, the type for the images, and the type for the tracking data. BUG=154886 Review URL: https://chromiumcodereview.appspot.com/12181003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183443 0039d316-1c4b-4281-b951-d872f2087c98
* sync_manager: Remove UserShare's name member.lazyboy@chromium.org2013-02-203-23/+9
| | | | | | | | | | BUG=150938 TEST=./out/Debug/sync_unit_tests Review URL: https://chromiumcodereview.appspot.com/12295029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183343 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove deprecated base::Value methods from sync. Use base::Value too.thestig@chromium.org2013-02-1611-273/+282
| | | | | | Review URL: https://chromiumcodereview.appspot.com/12262057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182922 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add favicon datatype proto support zea@chromium.org2013-02-167-2/+119
| | | | | | | | | | | Introduces support for syncing favicons in their own datatype. BUG=154886 Review URL: https://chromiumcodereview.appspot.com/12089103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182869 0039d316-1c4b-4281-b951-d872f2087c98
* Remove routing_info and workers from SyncSessionrlarocque@chromium.org2013-02-1523-464/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For all outward appearances, the SyncSession's workers and routing info will always precisely mirror those found in the SyncSessionContext. It is equivalent, and much simpler, to grab the latest routing info from the context wherever it's needed. Any SyncSession that makes it to a sync cycle will either have been initialized with the SyncSessionContext's routing info and workers, or Coalesced (set union) and Rebased (set intersection) with the SyncSessionContext's routing info and workers to the point where it's effectively equivalent to copying the context's data. Much of the logic to implement this book-keeping has been simplified in this patch. Configure mode is an important exception. While configuring, we would attempt to keep all currently enabled types enabled in the SyncSessionContext, while passing a restricted amount of routing info the the SyncSession. It turns out that it's not necessary to allow the SyncSessionContext and SyncSession routing info diverge in this case; it's OK to set the context's routing info to the restricted routes. In addition to trimming the session's routing info and workers list, RebaseRoutingInfoWithLatest was also responsible for trimming the list of notification hints to match the set of currently enabled types. This is redundant because the code in DownloadUpdatesCommand performs the same filtering using the same routing info. RebaseRoutingInfoWithLatest had no remaining useful features, so it was removed entirely. The Coalesce function still exists in a reduced form to handle merge sources between sessions. Its name and signature have been changed to reflect its new responsibilities. Without its own copy of the workers and routing info, the SyncSessionContext can no longer easily calculate the set of enabled groups. Fortunately, that information is only accessed by a single test case. The relevant code was moved into this test case. BUG=175024 Review URL: https://chromiumcodereview.appspot.com/12225091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182756 0039d316-1c4b-4281-b951-d872f2087c98
* Add retry function to getNewAuthTokenclamy@chromium.org2013-02-152-7/+32
| | | | | | | | | | | | Created a new method for the AccountManagerHelper in Android, that fetches a new token asynchronously, and will retry on network failures. BUG=165687 Review URL: https://chromiumcodereview.appspot.com/12207112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182749 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 182527isherman@chromium.org2013-02-146-41/+6
| | | | | | | | | | | | | | | | | | | | | | | | | Caused compile failure on Win Aura > [Sync] Make SESSIONS an implicit type > > We add TABS as a new local type, which is now what is enabled via the user > settings. It implicitly enables SESSIONS. > > Similarly, History now corresponds with Typed URLs, which implicitly enables > history delete directives if the proper command line flag is passed. > > Finally, History delete directives implicitly enables SESSIONS, which we can do > because Sessions is no longer a user selectable type. > > BUG=170162 > TBR=jhawkins@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/11961030 TBR=zea@chromium.org Review URL: https://codereview.chromium.org/12271002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182529 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Make SESSIONS an implicit typezea@chromium.org2013-02-146-6/+41
| | | | | | | | | | | | | | | | | | We add TABS as a new local type, which is now what is enabled via the user settings. It implicitly enables SESSIONS. Similarly, History now corresponds with Typed URLs, which implicitly enables history delete directives if the proper command line flag is passed. Finally, History delete directives implicitly enables SESSIONS, which we can do because Sessions is no longer a user selectable type. BUG=170162 TBR=jhawkins@chromium.org Review URL: https://chromiumcodereview.appspot.com/11961030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182527 0039d316-1c4b-4281-b951-d872f2087c98
* Synced Notification Sync Change Processorpetewil@chromium.org2013-02-124-1/+156
| | | | | | | | | | | | | | This change is the first of several to process changes from sync of the "Synced Notifications" data type. It defines the SyncedNotification type more fully in synced_notification_specifics.proto, and implements the incoming interfaces needed to handle the data. This change handles notifications coming in from the sync channel. These notifications will eventually call into the C++ backend supporting the Desktop Notification API (doc here: https://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/proposed-changes/apis-under-development/desktop-notification-api ) It is based closely on the change list for history delete directives: https://chromiumcodereview.appspot.com/10855037 BUG=168212 Review URL: https://chromiumcodereview.appspot.com/11745024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181825 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Add ModelTypeResolver and control typesnyquist@chromium.org2013-02-116-8/+301
| | | | | | | | | | | | | | Adds a few new things: * Some control ModelTypes (NIGORI, EXPERIMENTS). * Now we always register control types through setRegisteredTypes() * Add support for ModelType groups (for AUTOFILL / AUTOFILL_PROFILES) * Support for refreshing the cacheinvalidation registration. BUG=113164 Review URL: https://codereview.chromium.org/12217027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181730 0039d316-1c4b-4281-b951-d872f2087c98
* Replace FilePath with base::FilePath in some more top level directories.brettw@chromium.org2013-02-1020-44/+48
| | | | | | Review URL: https://codereview.chromium.org/12217101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181640 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add support for proxy typeszea@chromium.org2013-02-0814-47/+99
| | | | | | | | | | | | | Proxy types are those that have no sync representation, and are used as placeholder to implicitly enable other types. They are never communicated to the server, and have no presence in the local sync directory. BUG=170162,139726 TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/11958029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181534 0039d316-1c4b-4281-b951-d872f2087c98
* sync: fix sync / xmpp auth error notification plumbingtim@chromium.org2013-02-084-10/+33
| | | | | | | | | | | | | When forging a sync auth error from an xmpp auth error, we need to also set the ServerConnectionManager's server_status code to SYNC_AUTH_ERROR so that it realizes it needs to handle a credential update later on by trying to sync again. BUG=159628,127397,171975 Review URL: https://codereview.chromium.org/12208073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181413 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/ChromeOS Chromium style checker cleanup, sync/ edition.rsleevi@chromium.org2013-02-077-16/+18
| | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Review URL: https://chromiumcodereview.appspot.com/12209033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181373 0039d316-1c4b-4281-b951-d872f2087c98
* Add retry function to AccountManagerHelper when called from foregroundclamy@chromium.org2013-02-063-49/+112
| | | | | | | | | | | | | On Android, after encountering an IO exception, the AccountManagerHelper method to get the authentication token from foreground now retries when the network is back. BUG=165687 Review URL: https://chromiumcodereview.appspot.com/12091069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180961 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate invalidator client IDs out of syncrlarocque@chromium.org2013-02-067-0/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | We want to store invalidator client IDs somewhere other than the sync DB. Unfortunately, changing in the ID would require us to clear any existing client state, which is something we'd prefer to avoid. This commit makes the SyncInvalidationListener copy its sync-assigned client ID to the InvalidationStateTracker when it is initialized. When we decide to fully separate the sync and notifier IDs, the clients that have run through this code path will find that their notifier client ID has already been initialized correctly. This allows us to avoid clearing their client state. It's impossible to guarantee that all clients will hit this code path. Fortunately, we don't have to. The goal of this patch is to avoid deleting the state of too many clients all at once. It's not a big problem if we have to clear the state of a few stragglers that haven't hit the migration path yet. BUG=124142 Review URL: https://chromiumcodereview.appspot.com/12094113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180907 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add more encryption histogramszea@chromium.org2013-02-061-0/+50
| | | | | | | | | | | | | | | We introduce histograms for the following variables: - Whether the cryptographer is ready or not - Whether the cryptographer has pending keys - The nigori's keystore migration state - Whether a keystore decryption failed while having a valid keystore key. BUG=163744 Review URL: https://chromiumcodereview.appspot.com/12209027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180876 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Remove unecessary DCHECK in Directory::PurgeEntriesWithTypeInnyquist@chromium.org2013-02-051-2/+0
| | | | | | | | | | | | | There is currently a DCHECK in Directory::PurgeEntriesWithTypeIn that is not needed and not necessarily correct. It triggers if there are multiple datatypes being disabled at different times. BUG=113164 Review URL: https://chromiumcodereview.appspot.com/12226014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180786 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fix memory leak in TrafficRecorderTest.ToValueTimestampTestmgist@chromium.org2013-02-051-1/+4
| | | | | | | | | | | | Manage result of TrafficRecorder.ToValue() with scoped_ptr() so memory is released when out of scope. BUG=174209 Review URL: https://chromiumcodereview.appspot.com/12221006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180753 0039d316-1c4b-4281-b951-d872f2087c98
* Register autofill sync types on mobilecjhopman@chromium.org2013-02-051-0/+8
| | | | | | | | | | | | | | This change registers the autofill and autofillProfile sync types on Android (in addition to desktop platforms). Also add an AUTOFILL type to ModelTypes. BUG=174232 Review URL: https://chromiumcodereview.appspot.com/12089025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180629 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Rename timestamp to timestamp_msec to make the unit obvious.albertb@chromium.org2013-02-052-2/+2
| | | | | | | | | | R=zea,sky BUG= Review URL: https://chromiumcodereview.appspot.com/12088117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180569 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add timestamp to TrafficRecorder records (reland)mgist@chromium.org2013-02-043-5/+101
| | | | | | | | | | | | | | | Relanding after revert. Original codereview at https://chromiumcodereview.appspot.com/12088080. Fixed issue requiring GG_INT64_C wrapper for large ints in unit test cases. BUG=161922 Review URL: https://chromiumcodereview.appspot.com/12087139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180489 0039d316-1c4b-4281-b951-d872f2087c98
* Add time range to GlobalIdDirective for deleting additional local navigations haitaol@chromium.org2013-02-042-0/+8
| | | | | | | | | | | to URLs that has at least one visit that match with global ID. BUG=141245 Review URL: https://chromiumcodereview.appspot.com/12088074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180471 0039d316-1c4b-4281-b951-d872f2087c98
* Remove syncer::IncomingInvalidationSourcerlarocque@chromium.org2013-02-0224-160/+68
| | | | | | | | | | | | | | | | | | Since we separated local and remote invalidations in r179546, we no longer need to differentiate between the two sources with an enum. The IncomingInvalidationSource is always REMOTE_INVALIDATION. This commit removes the IncomingInvalidationSource enum and the 'source' parameter that was part of the invalidator callback API. The callees can now safely assume that all invalidations have a 'remote' source. BUG=124143 Review URL: https://chromiumcodereview.appspot.com/12114012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180213 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 180073koz@chromium.org2013-02-013-101/+5
| | | | | | | | | | | | | | | | | | | | | > [Sync] Add timestamp to TrafficRecorder records > > All client server traffic records have a timestamp field to > indicate creation time of each record. Timestamps are > dumped with the traffic serializations. > > BUG=161922 > > > Review URL: https://chromiumcodereview.appspot.com/12088080 This broke the compile for Linux Builder (dbg) http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/42048/steps/compile/logs/stdio TBR=mgist@chromium.org Review URL: https://codereview.chromium.org/12090113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180081 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add timestamp to TrafficRecorder recordsmgist@chromium.org2013-02-013-5/+101
| | | | | | | | | | | | | All client server traffic records have a timestamp field to indicate creation time of each record. Timestamps are dumped with the traffic serializations. BUG=161922 Review URL: https://chromiumcodereview.appspot.com/12088080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180073 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add full history sync experimentzea@chromium.org2013-02-012-2/+19
| | | | | | | | | | | | | Turning the experiment on will enable the full history sync flag, which both updates the history UI to use full history, but also enables the history delete directives sync datatype. BUG=141245 Review URL: https://chromiumcodereview.appspot.com/12091081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180037 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Componentize sync: Part Final: Target 'sync' is now its own componentrsimha@chromium.org2013-02-0116-1066/+1166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the long term goals of the sync team has been to pull sync out of chrome_dll and into its own component. This should result in faster link times for component builds, and cleaner demarcation between sync code and the rest of chrome. This patch does the following: - Splits off sync.gyp into gypi files for sync_core, sync_api, sync_internal_api, sync_notifier and sync_proto. - Audits the dependencies of various targets in sync.gyp, sync_tests.gyp, and other chrome gyp files, and makes sure all dependencies are explicitly declared. - Makes targets declared in gyp files outside sync.gyp directly depend on sync.gyp:sync instead of inner sync targets. - Implements two versions of the target 'sync.gyp:sync': 1) In static mode, the public 'sync' target has a target type of 'none', and is composed of the static library targets 'sync_api', 'sync_core', 'sync_internal_api', 'sync_notifier', and 'sync_proto'. 2) In component mode, we build the public 'sync' target into a single shared library, which includes the contents of sync_api.gypi, sync_core.gypi, sync_internal_api.gypi, sync_notifier.gypi, and sync_proto.gypi. TBR=akalin,robertshield,thakis BUG=136928 TEST=Set GYP_DEFINES="component=shared_library" and build the 'all' target on all platforms. Review URL: https://codereview.chromium.org/11412211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180034 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fix histogram labelling for keystore rotationzea@chromium.org2013-01-311-3/+3
| | | | | | | | | | | | Default (only one keystore key) and nondefault (more than one keystore key) were swapped in the histogram labelling. BUG=none Review URL: https://chromiumcodereview.appspot.com/12087092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179800 0039d316-1c4b-4281-b951-d872f2087c98
* Add password type to model types.yfriedman@chromium.org2013-01-301-0/+4
| | | | | | | | | | | | https://codereview.chromium.org/11946058/ added it to syncable types, but the constant is needed on the java side. BUG=113164 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/12092034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179676 0039d316-1c4b-4281-b951-d872f2087c98
* Added a funtion to translate net errors in a ServerConnectionCode in sync.clamy@chromium.org2013-01-303-4/+24
| | | | | | | | | | | | | | | | | | | Presently, only the ERR_ABORTED is being translated into a CONNECTION_UNAVAILABLE error. However, on certain Android devices, the error received when having no connectivity is ERR_NAME_NOT_RESOLVED. It is classified as an IO_ERROR. The rest of sync treats CONNECTION_UNAVAILABLE and IO_ERRORS differently, with having to wait 1s before retry in one case and 750 in the other case. This can cause sync startup to fail and not retry for more than 10mn, even when the network is back. This fix allows a better translation of net errors into ServerConnectionCodes, which allows for sync to start when the network is back in a more reliable way. BUG=169790 Review URL: https://chromiumcodereview.appspot.com/11953072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179593 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an NPE in InvalidationService.dsmyers@chromium.org2013-01-302-8/+22
| | | | | | | | | | | | Fix a NullPointerException in InvalidationService when handling invalidations without payloads. BUG=159221 Review URL: https://chromiumcodereview.appspot.com/12086050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179564 0039d316-1c4b-4281-b951-d872f2087c98
* Separate local and remote sync invalidationsrlarocque@chromium.org2013-01-306-11/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old design used ChromeSyncNotificationsBridge to register for both NOTIFICATION_SYNC_REFRESH_LOCAL and NOTIFICATION_SYNC_REFRESH_REMOTE. The first of these is issued when some component decides that the syncer ought to perform an unsolicited GetUpdates for some type, while the second is an Android-specific mechanism for receiving remote invalidations. In either case, the ChromeSyncNotificationsBridge would forward the invalidations to the SyncManager through the BridgedInvalidator as though they had come from any other invalidator. In this new design, the local and remote invalidations sources are kept distinct. The SyncBackendHost is now responsible for listening to and forwarding NOTIFICATION_SYNC_REFRESH_LOCAL. Note that there is no longer any type-specific filtering performed as we receive notifications; it will be up to the SyncManager to ignore notifications for disbaled types. The successor to ChromeSyncNotificationsBridge, AndroidInvalidatorBridge, is responsible only for forwarding NOTIFICATION_SYNC_REFRESH_REMOTE notificaitons. It is passed to the SyncManager only if OS_ANDROID is defined. Since there is only one source of remote invalidations, the BridgedInvalidator would seem to be no longer necessary. Unfortunately, this is not the case. The BridgedInvalidator was useful in part because it wrapped the UI-thread-owned ChromeSyncNotificationsBridge without owning it, so the SyncManager's destruction would not affect it. This wrapping functionality is still needed by the AndroidInvalidatorBridge. The BridgedInvalidator has been modified to only wrap a single AndroidInvalidatorBridge, and renamed to AndroidInvalidatorBridgeProxy. BUG=124143 Review URL: https://chromiumcodereview.appspot.com/12022041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179546 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Add DEPS file for java code under sync/androidrsimha@chromium.org2013-01-301-0/+3
| | | | | | | | | | | | | | | The java code in sync/android imports a bunch of files from cacheinvalidation, which is causing errors in checkdeps on the chromium trybots. This patch adds a DEPS file under sync/android to fix the errors. BUG=173035 TEST=No checkdeps errors under sync/android. Review URL: https://codereview.chromium.org/12088065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179544 0039d316-1c4b-4281-b951-d872f2087c98
* Record client id in ready(), not reissueRegs().dsmyers@chromium.org2013-01-292-6/+39
| | | | | | | | | BUG=172390 Review URL: https://chromiumcodereview.appspot.com/12096011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179454 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to read notifications state from sync DBrlarocque@chromium.org2013-01-2920-197/+18
| | | | | | | | | | | | | | | | | | | | We no longer want to store notifications data in the sync DB. Previous patches have implemented a new storage system, but left in place some code to ensure backwards compatibility. That was almost a year ago. It's now safe to remove the barckwards compatibility code. This commit removes all support for reading notifications state from the sync DB. It also removes some tests and related functions. This commit does not remove any data from the DB itself. That would require a migration, which we will implement in a different commit. We'll also need one more commit to deprecate the histograms. BUG=124140 Review URL: https://chromiumcodereview.appspot.com/12087010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179247 0039d316-1c4b-4281-b951-d872f2087c98
* Fix InvalidationService build errornyquist@chromium.org2013-01-261-0/+4
| | | | | | | | | TBR=jln@chromium.org BUG=159221 Review URL: https://codereview.chromium.org/12094007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179052 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a client for v2 of the notification library.dsmyers@chromium.org2013-01-2610-16/+1195
| | | | | | | | BUG=159221 Review URL: https://chromiumcodereview.appspot.com/12051074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179048 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fix various model type mistakes for new typeszea@chromium.org2013-01-261-0/+7
| | | | | | | | | | | | Experiments, SyncedNotifications, Delete directives, and priority preferences all had various bugs in their notification code. BUG=none Review URL: https://chromiumcodereview.appspot.com/12086005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179039 0039d316-1c4b-4281-b951-d872f2087c98
* sync: fix scheduler unthrottling when there is a valid nudge canarytim@chromium.org2013-01-262-8/+80
| | | | | | | | | BUG=165561, 154216 Review URL: https://chromiumcodereview.appspot.com/12033091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179004 0039d316-1c4b-4281-b951-d872f2087c98
* Copy entries of broken (having unrecoverable error) data types to delete ↵haitaol@chromium.org2013-01-2611-21/+103
| | | | | | | | | | | journals before purging. BUG=121928 Review URL: https://chromiumcodereview.appspot.com/11578017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179003 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Add logging for network error codeszea@chromium.org2013-01-251-1/+2
| | | | | | | | | | | See bug. BUG=170239 Review URL: https://chromiumcodereview.appspot.com/12047086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178803 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreams SyncStatusHelper and dependencies.dsmyers@chromium.org2013-01-247-0/+849
| | | | | | | | | | | | | Upstreams SyncStatusHelper, AccountManagerHelper, SharedPreferencesUtil, and files on which they depened. These changes are required to ultimately upstream the sync notification client. BUG=159221 Review URL: https://chromiumcodereview.appspot.com/11929040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178670 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the necessary changes to sync.gyp as well as its dependencies (most ↵blundell@chromium.org2013-01-242-30/+7
| | | | | | | | | | notably jingle) in order to bring up the complete sync_notifier target on iOS. TBR=thakis Review URL: https://chromiumcodereview.appspot.com/12041016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178650 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Componentize sync: Part 7: Eliminate more filename collisions in sync.gyprsimha@chromium.org2013-01-245-12/+11
| | | | | | | | | | | | | | | | | | | | In order to move src/sync into its own compoent, all the static_library targets in sync.gyp need to be converted to targets of type 'none' and rolled into one sync target of type component. This is currently blocked by duplicate .cc filenames in syncable and internal_api, which flags an error while running gyp. The offending files are {internal_api|syncable}/delete_journal.cc. This patch renames syncable/delete_journal.{h|cc} to syncable/syncable_delete_journal.{h|cc}. This is a continuation of https://codereview.chromium.org/11638018. BUG=136928 Review URL: https://codereview.chromium.org/12033084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178639 0039d316-1c4b-4281-b951-d872f2087c98
* Sync user's custom spellcheck dictionaryrouslan@chromium.org2013-01-2312-5/+85
| | | | | | | | | | | | | | This CL is initial work for for syncing user dictionary across multiple computers. The sync is hidden behind --enable-sync-dictionary flag for now. Do not flip this flag unless your are connected to a sync server that supports dictionary sync. If you don't know whether your sync server supports dictionary sync, then most likely it does not. BUG=51636 Review URL: https://chromiumcodereview.appspot.com/11445002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178178 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 07:34:59 +0000