| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this change we are down to:
- 3 redundant import warnings (due to JNI generator)
- 69 JavaDoc warnings
BUG=318404
R=agl@chromium.org, blundell@chromium.org, boliu@chromium.org, lambroslambrou@chromium.org, nyquist@chromium.org, qinmin@chromium.org, rmcilroy@chromium.org, tedchoc@chromium.org
TBR=yfriedman@chromium.org
Review URL: https://codereview.chromium.org/652603004
Cr-Commit-Position: refs/heads/master@{#299540}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that invalidations over GCM are enabled for all users it is time to
make that default. With this change Chrome will use GCM for
invalidations and only switch to XMPP explicitly as a result of sync
experiment setting.
BUG=422374
R=zea@chromium.org
Review URL: https://codereview.chromium.org/654643004
Cr-Commit-Position: refs/heads/master@{#299525}
|
|
|
|
|
|
|
|
|
|
| |
Removes the last code path that might create a pop-up dialog.
BUG=302608
Review URL: https://codereview.chromium.org/648343003
Cr-Commit-Position: refs/heads/master@{#299514}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mostly just adds the chrome_shell_apk build definition and those of
a whole bunch of targets.
Adds a simple check that when DEPRECATED_java_in_dir is used, it
actually includes the "src" at the end (GYP just assumes that you really
meant that java files are in <(java_in_dir)/src).
Makes the call to process_resources only generate R.java for extra
packages when being run as part of the apk step (otherwise, for
example, both chrome resources and content resources would contain
an R.java for net resources and compilation would fail).
Depends on https://codereview.chromium.org/581273004/
Adds the following targets -- and enables ~300 more (550 counting
template-generated inner targets):
//chrome:chrome_android_core
//chrome/android:chrome_strings_grd
//chrome/android:chrome_java
//chrome/android:activity_type_ids_javagen
//chrome/android:app_banner_metrics_ids_javagen
//chrome/android:resource_id_javagen
//chrome/android:profile_account_management_metrics_javagen
//chrome/android:profile_sync_service_model_type_selection_javagen
//chrome/android:toolbar_model_security_levels_javagen
//chrome/android:tab_load_status_javagen
//chrome/android:chrome_shell_base
//chrome/android:chrome_shell
//chrome/android:chrome_sync_shell
//chrome/android:chrome_shell_resources
//chrome/android:chrome_shell_java
//chrome/android:chrome_shell_assets
//chrome/android:chrome_shell_apk
//chrome/android:chrome_sync_shell_apk
//components/bookmarks:bookmarks_java
//components/bookmarks:bookmarks_jni_headers
//components/bookmarks:bookmark_type_javagen
//components/dom_distiller/android:dom_distiller_core_java
//components/dom_distiller/android:dom_distiller_core_font_family_javagen
//components/dom_distiller/android:dom_distiller_core_theme_javagen
//components/enhanced_bookmarks:jni_headers
//components/enhanced_bookmarks/android:enhanced_bookmarks_java
//components/gcm_driver:gcm_driver_java
//components/gcm_driver:jni_headers
//components/navigation_interception/android:navigation_interception_java
//components/variations:variations_java
//components/web_contents_delegate_android:web_contents_delegate_android
//components/web_contents_delegate_android:web_contents_delegate_android_java
//components/web_contents_delegate_android:web_contents_delegate_android_jni_headers
//printing:printing_java
//sync:fake_server_jni
//sync:sync_java_test_support
//sync:test_support_sync_fake_server_android
//sync:sync_unit_tests_apk
//sync/android:sync_java
//sync/android:sync_javatests
BUG=359249
TBR=ben
Review URL: https://codereview.chromium.org/570203002
Cr-Commit-Position: refs/heads/master@{#299381}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.
This CL instruments a part of overloads of URLFetcherDelegate::OnURLFetchComplete. More overloads will be instrumented if the source of the jank is not in one of instrumented methods.
BUG=422577
TBR=mek@chromium.org, toyoshim@chromium.org, dconnelly@chromium.org, pkasting@chromium.org, mmenke@chromium.org, zea@chromium.org, dcheng@chromium.org, noelutz@google.com, thestig@chromium.org, zelidrag@chromium.org
Review URL: https://codereview.chromium.org/648873003
Cr-Commit-Position: refs/heads/master@{#299230}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For SyncExponentialBackoffTest.OfflineToOnline, methods were added to
simulate and reset a network failure. The old (Python server) way of
doing this has been deleted from SyncTest.
For SyncExponentialBackoffTest.TransientErrorTest, a TRANSIENT_ERROR
is now triggered on FakeServer. The old way of doing this,
SyncTest.TriggerTransientError(), has been deleted.
BUG=406545
Review URL: https://codereview.chromium.org/642613002
Cr-Commit-Position: refs/heads/master@{#299034}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a prerequisite for:
https://codereview.chromium.org/473153002/
BUG=341408
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/617183003
Cr-Commit-Position: refs/heads/master@{#298996}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/640093002
Cr-Commit-Position: refs/heads/master@{#298929}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when having authentication issues on Android (for example, if the
user changed their password), Chrome would pop-up a dialog asking the user
to sign in again. This was bad, because part of the auth flow has a link to a
website where you can do account recovery, but that would just kick you back
into the auth pop-up in an infinite loop. Also it was intrusive to the user and
against Android best practices.
Additionally, on dev builds of Chromium, it could result in an annoying
stream of permission request pop-ups dominating the screen.
Now, in both cases, the auth request is handled by generating a notification
that the user must activate before losing control of the screen.
BUG=302608
Review URL: https://codereview.chromium.org/627543002
Cr-Commit-Position: refs/heads/master@{#298911}
|
|
|
|
|
|
|
|
|
|
| |
Removing people no longer working on Chromium
BUG=none
Review URL: https://codereview.chromium.org/630943002
Cr-Commit-Position: refs/heads/master@{#298905}
|
|
|
|
|
|
|
|
|
|
| |
In preparation for a bug fix.
BUG=419927
Review URL: https://codereview.chromium.org/642623002
Cr-Commit-Position: refs/heads/master@{#298900}
|
|
|
|
|
|
|
|
| |
BUG=421210
Review URL: https://codereview.chromium.org/635093002
Cr-Commit-Position: refs/heads/master@{#298771}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reject downloads with an invalid hash.
This change is part of a series of changes designed to ensure end-to-end
data integrity of attachments. See referenced bug for details.
BUG=418649
Review URL: https://codereview.chromium.org/615173003
Cr-Commit-Position: refs/heads/master@{#298741}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL converts two tests in sync_errors_test.cc, ActionableErrorTest
and DisableDatatypeWhileRunning, to use FakeServer. The first required
the addition of a TriggerActionableError method to FakeServer. The
second works without any changes.
BUG=406545
Review URL: https://codereview.chromium.org/605733005
Cr-Commit-Position: refs/heads/master@{#298607}
|
|
|
|
|
|
|
|
|
|
| |
This CL deprecates a field from a sync proto because it was not being used and isn't part of the model.
BUG=372264
Review URL: https://codereview.chromium.org/597873002
Cr-Commit-Position: refs/heads/master@{#298583}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/629733002
Cr-Commit-Position: refs/heads/master@{#298300}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is one in a series of changes designed to ensure end-to-end
data integrity of attachments. See referenced bug for details.
Simplify AttachmentUploaderImplTest by moving duplicated test code into
private UploadAndRespondWith method.
Update TODO comment to reflect the fact that URLFetcher automatically
adds a Content-Length header. Update test cases accordingly.
TBR=kinuko
BUG=418649,371521
Review URL: https://codereview.chromium.org/611113002
Cr-Commit-Position: refs/heads/master@{#298274}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor FakeAttachmentStore into AttachmentStoreProxy and
InMemoryAttachmentStore backend. Break AttachmentStore interface into
AttachmentStoreBase (common interface for backends) and AttachmentStore
(referenced by datatype and AttachmentService).
BUG=
R=maniscalco@chromium.org
Review URL: https://codereview.chromium.org/616983002
Cr-Commit-Position: refs/heads/master@{#297951}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new sync datatype to handle the enhanced bookmarks
representation.
BUG=415822
R=mpearson@chromium.org, sky@chromium.org, zea@chromium.org
Review URL: https://codereview.chromium.org/583863002
Cr-Commit-Position: refs/heads/master@{#297718}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/601553004/)
Reason for revert:
Speculative revert:
looks like it causes failures on the Linux asan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/8113
Original issue's description:
> Refactor FakeAttachmentStore
>
> Refactor FakeAttachmentStore into AttachmentStoreProxy and
> InMemoryAttachmentStore backend. Break AttachmentStore interface into
> AttachmentStoreBase (common interface for backends) and AttachmentStore
> (referenced by datatype and AttachmentService).
>
> BUG=
> R=maniscalco@chromium.org
>
> Committed: https://crrev.com/6ae2b341c73909cf902078446346d6c900273409
> Cr-Commit-Position: refs/heads/master@{#297339}
TBR=maniscalco@chromium.org,pavely@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/619563002
Cr-Commit-Position: refs/heads/master@{#297379}
|
|
|
|
|
|
|
|
|
|
|
| |
Several spurious NotifyObserver calls have been removed, in addition to
removing the configuration retry code (which was not doing anything anymore).
BUG=418140
Review URL: https://codereview.chromium.org/612573005
Cr-Commit-Position: refs/heads/master@{#297345}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor FakeAttachmentStore into AttachmentStoreProxy and
InMemoryAttachmentStore backend. Break AttachmentStore interface into
AttachmentStoreBase (common interface for backends) and AttachmentStore
(referenced by datatype and AttachmentService).
BUG=
R=maniscalco@chromium.org
Review URL: https://codereview.chromium.org/601553004
Cr-Commit-Position: refs/heads/master@{#297339}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want the invalidations code to exist as a component
independent of sync (see bug). This CL seeks to move toward
that for the Android invalidations codebase.
Generally, things moved from //chrome/browser/invalidation
to //components/invalidation, even if git didn't mark them
as moves.
To accomplish this, I had to unify where the JNI occurred.
In Java, InvalidationService was renamed to
InvalidationClientService as the class that communicates
with GCM.
A new InvalidationService class was introduced to handle JNI
and other Java entry points to the component. Several
methods from ProfileSyncService and InvalidationController
moved to it.
InvalidationController is now the bridge between sync and
the invalidation component, and has no JNI nor C++
counterpart.
InvalidationServiceFactory was added to assist in the
creation and management of InvalidationService objects
across the JNI boundary.
BUG=259559
Review URL: https://codereview.chromium.org/459513002
Cr-Commit-Position: refs/heads/master@{#297202}
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncEntity protos in fake_server.cc are now populated by passing a
pointer to FakeServerEntity.SerializeAsProto. Previously,
SerializeAsProto returned a newly-created proto that was never deleted.
BUG=NONE
Review URL: https://codereview.chromium.org/600083003
Cr-Commit-Position: refs/heads/master@{#296733}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a cleanup-only/documentation change, no behavior changes.
Add comments explaining how Directory locking works.
Move protected methods to private (there was no reason for them to be
protected).
Move private data members below private method declarations.
For methods that take a ScopedKernelLock, always pass by const reference
before non-const pointer parameters.
Give ClearDirtyMetahandles a ScopedKernelLock parameter so it's clear
that the caller must be holding a lock.
BUG=
Review URL: https://codereview.chromium.org/585663002
Cr-Commit-Position: refs/heads/master@{#296045}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
part 3.
This change integrates DeviceIfoSyncService and DeviceInfoDataTypeController introduced in an early change
with the rest of the Sync code and removes the old implementation of DEVICE_INFO sync type based on SyncedDeviceTracker.
As a part of this change DEVICE_INFO stops being a specially implemented control type and becomes a priority type
with implementation that follows pattern of the majority of other sync types.
This should help to do some further refactoring including decoupling of DeviceInfo sync code from the browser and moving it to sync_driver component.
This change also adds support for syncing of local device backup timestamp to DeviceInfoSyncService. This functionality was missing when DeviceInfoSyncService was initially introduced.
BUG=395349
Review URL: https://codereview.chromium.org/566623003
Cr-Commit-Position: refs/heads/master@{#295992}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert some uses of AttachmentIdList to AttachmentIdSet.
Remove the no longer needed UploadAttachments method from
GenericChangeProcessor.
BUG=372622
Review URL: https://codereview.chromium.org/582913002
Cr-Commit-Position: refs/heads/master@{#295988}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I went through and made "gn check //ui/*" pass, and did a lot of enhancements for the bugs I found.
Fixes a big bug in the header checker where it did not consider direct private dependencies to be OK from a header include perspective. However, private deps only change things when there are intermediate targets. This patch marks direct deps OK, and changes the variable names from is_public to is_permitted (since it may not actually be public).
Allow includes to be permitted if any target allows the include, rather than all of them. This happens if multiple targets have the same file as sources.
Strip the generated file directory from the beginning of sources. Previously, this was only for outputs (since typically they're included assuming the root gen dir is on the path). This comes up when an action generates a file, and then it's put into a source set (which we do a lot). This change allows a public dependency on the source set to count for header include purposes.
Track public/private deps in the dependency path finder so the error message can show which deps are private that break the chain. This was really helpful when tracking down errors.
Add deps and public deps to the build to make check pass.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/584683002
Cr-Commit-Position: refs/heads/master@{#295783}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move PageTransition enumeration from //content/public/common to //ui/base
so that it can be used by iOS and layered components that are used on iOS.
BUG=372373
R=avi@chromium.org, ben@chromium.org, wfh@chromium.org
TBR=ben, nasko
Review URL: https://codereview.chromium.org/562603002
Cr-Commit-Position: refs/heads/master@{#295686}
|
|
|
|
|
|
|
|
|
|
|
| |
Move declaration of AttachmentServiceProxyForTest's destructor to make
it clear the WeakPtrFactory is the last data member.
BUG=303818
Review URL: https://codereview.chromium.org/575383002
Cr-Commit-Position: refs/heads/master@{#295652}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the last known dependency on guava_javalib.
Full list of changes:
r340 Removing guava dependency for the invalidation client (part of an effort to reduce method count in Android applications)
r341 Fixing package name in AndroidListenerManifest.xml and ordering factory methods by corresponding proto field in AndroidService.java
BUG=412673
TBR=zea@chromium.org
Review URL: https://codereview.chromium.org/573733004
Cr-Commit-Position: refs/heads/master@{#295113}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Datatype is responsible for writing attachments to AttachmentStore.
GenericChangeProcessor doesn't need attachment data in SyncData, only
list of attachment ids.
This change removes AttachmentList from SyncData and fixes corresponding
dependencies.
BUG=
R=maniscalco@chromium.org
Review URL: https://codereview.chromium.org/567053002
Cr-Commit-Position: refs/heads/master@{#294879}
|
|
|
|
|
|
|
|
|
|
|
| |
Upon receiving a notification that network connectivity has been
restored, ASI will clear any backoff delay for uploading attachments.
BUG=411981
Review URL: https://codereview.chromium.org/569463002
Cr-Commit-Position: refs/heads/master@{#294840}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes most usages of the guava library.
TBR=thakis@chromium.org,brettw@chromium.org,yfriedman@chromium.org
BUG=412673
Review URL: https://codereview.chromium.org/565743002
Cr-Commit-Position: refs/heads/master@{#294620}
|
|
|
|
|
|
|
|
| |
TBR=sergeyu@chromium.org,cpu@chromium.org,thakis@chromium.org,jamesr@chromium.org,zea@chromium.org,nduca@chromium.org
Review URL: https://codereview.chromium.org/560883003
Cr-Commit-Position: refs/heads/master@{#294543}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this change UploadState objects would synchronously notify
AttachmentUploaderImpl that they were done and could be deleted. This
meant they were still on the call stack when their destructor was
invoked. While it worked, it was subtle and might lead to bugs in the
future.
BUG=
Review URL: https://codereview.chromium.org/556083002
Cr-Commit-Position: refs/heads/master@{#294218}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add TaskQueue, a class that provides retry and backoff semantics for
tasks. Used by AttachmentServiceImpl.
AttachmentUploaderImpl and AttachmentDownloaderImpl now differentiate
between transient and non-transient errors. Almost all errors are
assumed to be transient. "403 Forbidden" is the exception and is
returned by the sync server if attachment are disabled for the user.
Transient errors encountered during attachment upload will be retried
with exponential backoff (using TaskQueue and BackoffEntry). The idea
is to consolidate retry logic at the AttachmentServiceImpl level.
In a future CL, changes in network connectivity will affect retry and
backoff.
BUG=372622, 380437
Review URL: https://codereview.chromium.org/554743004
Cr-Commit-Position: refs/heads/master@{#294195}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change attachment store ownership is moved to datatype. If
datatype wants to use attachments it needs to instantiate attachment
store and return it to sync via GetAttachmentStore.
GenericChangeProcessorFactory calls SyncableService::GetAttachmentStore
and passes attachment_store through GenericChangeProcessor::ctor to
AttachmentService::ctor.
GetAttachmentStore returning NULL means datatype doesn\u2019t use attachments,
therefore GenericChangeProcessor doesn\u2019t create AttachmentService.
R=maniscalco@chromium.org
BUG=412070
Review URL: https://codereview.chromium.org/548373003
Cr-Commit-Position: refs/heads/master@{#294070}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the "test" template to create a shared_library (instead of
an executable) on Android. After this, we can actually run
base_unittests with
`build/android/test_runner.py gtest -s base_unnittests`
as normal (though may need to CHROMIUM_OUT_DIR and BUILDTYPE as
appropriate).
This requires adding the following targets:
//testing/android:native_test_native_code
//testing/android:native_test_util
//testing/android:native_test_jni_headers
//tools/android/md5sum:md5sum
//tools/android/md5sum:md5sum_bin
//tools/android/md5sum:md5sum_prepare_dist
//tools/android/md5sum:md5sum_copy_host
Also, makes it so that native executables are stripped (just like shared
libraries). Adds a simple create_native_execuatable_dist template that
sets up a dist directory for the executable (see
build/android/gyp/native_app_dependencies.gyp).
BUG=359249
TBR=rlarocque
Review URL: https://codereview.chromium.org/557463002
Cr-Commit-Position: refs/heads/master@{#294032}
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the targets that depend on these to also be test-only.
BUG=http://crbug.com/412064
R=jamesr@chromium.org, tfarina@chromium.org
Review URL: https://codereview.chromium.org/551933002
Cr-Commit-Position: refs/heads/master@{#293808}
|
|
|
|
|
|
|
|
|
| |
BUG=
R=hclam@chromium.org
Review URL: https://codereview.chromium.org/547793002
Cr-Commit-Position: refs/heads/master@{#293774}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is lays groundwork for making attachment upload operations
persistent.
Make GenericChangeProcessor responsible for writing attachments to the
AttachmentStore and calling UploadAttachments. In a future CL, datatype
code will be responsible for writing attachments to the store.
Queue up attachments for upload inside of AttachmentService. In a
future CL we'll add rate limiting, retry, and back-off logic.
Expose AttachmentService's AttachmentStore via GetStore method.
(This is a reland of issue 512413003.)
BUG=
Review URL: https://codereview.chromium.org/548533003
Cr-Commit-Position: refs/heads/master@{#293741}
|
|
|
|
|
|
|
|
|
|
| |
cleanup while object is inactive.
BUG=303818
Review URL: https://codereview.chromium.org/509853003
Cr-Commit-Position: refs/heads/master@{#293678}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 5dde06853d1d5020796184c5fc749b9730ce8f07.
Broke a bunch of builds:
FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/sync/internal_api/attachments/sync_core.attachment_service_proxy.o.d -DSYNC_IMPLEMENTATION -DCHROMIUM_BUILD -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_BACKGROUND=1 -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_FULL_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS=1 -DUSE_X11=1 -DUSE_XI2_MT=2 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -I../.. -Igen -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../net/third_party/nss/ssl -I/usr/include/nss -I/usr/include/nspr -I../../third_party/zlib -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/protobuf -fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64 -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unused-function -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -fno-ident -fdata-sections -ffunction-sections -O2 -g2 -Wexit-time-destructors -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-reserved-user-defined-literal -fno-rtti -fno-exceptions -c ../../sync/internal_api/attachments/attachment_service_proxy.cc -o obj/sync/internal_api/attachments/sync_core.attachment_service_proxy.o
../../sync/internal_api/attachments/attachment_service_proxy.cc:96:3: error: invalid argument type 'scoped_refptr<base::SequencedTaskRunner>' to unary expression
DCHECK(wrapped_task_runner_);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:622:51: note: expanded from macro 'DCHECK'
LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON && !(condition)) \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
../../base/logging.h:355:5: note: expanded from macro 'LAZY_STREAM'
!(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
^
1 error generated.
ninja: build stopped: subcommand failed.
BUG=none
TBR=maniscalco
Review URL: https://codereview.chromium.org/546873003
Cr-Commit-Position: refs/heads/master@{#293542}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is lays groundwork for making attachment upload operations
persistent.
Make GenericChangeProcessor responsible for writing attachments to the
AttachmentStore and calling UploadAttachments. In a future CL, datatype
code will be responsible for writing attachments to the store.
Queue up attachments for upload inside of AttachmentService. In a
future CL we'll add rate limiting, retry, and back-off logic.
Expose AttachmentService's AttachmentStore via GetStore method.
BUG=
Review URL: https://codereview.chromium.org/512413003
Cr-Commit-Position: refs/heads/master@{#293536}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change completes the removal of package_name from
build/java_apk.gyp and removes it from all the places
which still refer to it.
'package_name' used to be how you specified the intermediate
directory when building an APK. Now we use the target name and
includers no longer need to set the intermediate directory
explicitly. However one use in java_apk for setting additional
resources files seems to have crept through the refactoring.
BUG=405963
Review URL: https://codereview.chromium.org/487223003
Cr-Commit-Position: refs/heads/master@{#293498}
|
|
|
|
|
|
|
|
|
|
|
| |
They are |display_name|, |avatar_url| and |federation_url|.
BUG=400674
TBR=isherman@chromium.org
Review URL: https://codereview.chromium.org/520583003
Cr-Commit-Position: refs/heads/master@{#293489}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
properly with invalid server's originator_cache_guid and
originator_client_item_id.
It checks UpdateBookmarkPositioning works fine.
BUG=
R=rlarocque@chromium.org
Review URL: https://codereview.chromium.org/533113002
Cr-Commit-Position: refs/heads/master@{#293473}
|
|
|
|
|
|
|
|
| |
BUG=378035
Review URL: https://codereview.chromium.org/537083002
Cr-Commit-Position: refs/heads/master@{#293348}
|