| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ActivityStatus class used to track activity state changes is too basic
for some usage scenarios.
This patch does the following:
- Augment ActivityStatus with a new StateListener type that can be
registered to listen to all activity state changes.
Also add getActivity(), getState(), registerStateListener()
and unregisterStateListener() as static method.
- Add a new ChromiumActivity class that all Chromium main activities
should sub-class, to ensure that the ActivityStatus state is updated
appropriately.
- Modify all main activities in the Chromium code base to extend
from ChromiumActivity instead of Activity.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11419287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11471030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Targets with dependencies (direct/indirect) on a java target receive the
chromium_*.jar paths in the variable input_jars_paths. Targets should
use that rather than hardcoding where they think the jar will be.
Change native_test_apk.xml to build with a list of jars in
INPUT_JARS_PATHS rather than using all jars in a specific output
directory.
Make generate_native_test.py pass the --jars argument to ant with
-DINPUT_JARS_PATHS. This supports those targets (WebKit) that are not
updated to pass the ant-arg directly.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11308351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gtest:
622: Fixes gtest-tuple.h in Visual C++ 7.1.
623: Removes obsolete debug code.
624: wiki change
625: Improves Android support (by David Turner).
626: wiki change
627: wiki change
628: combines 8 changes:
* Fixes some python shebang lines.
* Add ElementsAreArray overloads to gmock.
* Templatize MatchAndExplain to allow independent string types.
* Fix bug where the constructor of the return type of ElementsAre() saves
a reference instead of a copy of the arguments.
* Extends ElementsAre() to accept arrays whose sizes aren't known.
* Switches gTest's internal FilePath class to std::string
* Switches gTest & gMock from using testing::internal::String objects to std::string.
629: Unbreak building gtest with -std=c++11 on Mac OS X 10.6.
gmock:
406: wiki change
407: Pulls in gtest r615 (Renames internal enums to the kFoo naming style.)
408: Makes gmock's Pointee() work for optional<T> (by Jeffrey Yasskin).
409: wiki change
410: Same commit message as gtest 628.
BUG=none
Review URL: https://codereview.chromium.org/11431003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The issue is caused by the removal of the String(const char*) ctor in http://git.chromium.org/gitweb/?p=external/gtest.git;a=blobdiff;f=include/gtest/internal/gtest-string.h;h=472dd0583917c2ad786dbe4711b53fcadb772d3a;hp=967b11738ef234aa09e3879d98e77c7277e2d3c3;hb=03c314931649a999b0cf5deb0a434a1009157416;hpb=5d9f11fe81eaca3989ec7e8dbfe5b31608a75121.
TBR=rsesek
Review URL: https://codereview.chromium.org/11414027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several auxiliary tools used when building Chrome for iOS are generated via the
following two-step pattern: (1) compiling the executable with ninja, and (2)
copying the executable into a location that is shared with other projects.
Previously, these two steps were specified as actions in the same target.
However, as the ordering of multiple actions in one target is defined only by
inputs and outputs and the compilation action had no inputs/outputs set, the
copying action wasn't properly depending on the compilation action.
As it's challenging to set correct inputs for the ninja build, this CL
separates these actions into two targets in order to be able to specify that
the second action should not run until the first action finishes.
Review URL: https://chromiumcodereview.appspot.com/11301003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp files using sdk-build were already cleaned up, it is now safe
to remove this option.
Cleanup in chromium here: https://chromiumcodereview.appspot.com/11066094
Cleanup in webkit here: http://trac.webkit.org/changeset/131681
Review URL: https://chromiumcodereview.appspot.com/11185069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=154293
Review URL: https://chromiumcodereview.appspot.com/11027024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PlatformTest's destructor was set as protected, though the parent class
testing::Test declares it public.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11038058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SDK build is the default build, we do not need Android.mk based
compilation.
Review URL: https://chromiumcodereview.appspot.com/11066094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
per http://code.google.com/p/googletest/issues/detail?id=412
R=cpu@chromium.org
BUG=143646
Review URL: https://chromiumcodereview.appspot.com/11088033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=143646
Review URL: https://chromiumcodereview.appspot.com/11096005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL sets device name in <simulator_home>/Library/Preferences/com.apple.iphonesimulator.plist, which allows the caller to specify any string in the iOS Simulator's Hardware -> Device menu (e.g. iPhone (Retina 3.5-inch)), instead of just iPhone or iPad.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10978027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some devices have $EXTERNAL_STORAGE filesystems that don't support
mkfifo. Create in the internal app dir instead.
BUG=
TEST=
Review URL: https://codereview.chromium.org/10957036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android
This is necessary to properly support DumpRenderTree. Now that Chromium
also uses fifos for getting output from the device, WebKit can change to
using that.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10969010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This uses the same mechanism as webkit drt.
- It fixes the "timestamping" bug (147800), as the fifo
order is guaranteed (as opposed to logcat).
- It also removes AndroidLogPrinter which was injected in the gtest
framework.
- Downside is that we won't get inline crashstack. However, those
were normally useless as they were not symbolized anyways.
We can still get tombstones if we detect a crash.
BUG=147800
TEST=build/android/run_tests.py
Review URL: https://chromiumcodereview.appspot.com/10938014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Older clangs failed to parse tr1::tuple and used gtest's implementation
thereof. That's no longer necessary.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10907172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
keystore created with command:
keytool -genkey -v -keystore chromium-debug.keystore -alias chromiumdebugkey -keyalg RSA -keysize 2048 -validity 36525
with password "chromium" and alias password "chromium".
Android's SDK tools by default create a debug keystore in ~/.android.
This has caused all kinds of grief. Instead, this change makes us use
the new chrome-debug.keystore.
BUG=145860
Review URL: https://chromiumcodereview.appspot.com/10918149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removed android.toolchain property.
- Added android.gdbserver property.
- Changed property-location to check the both file and directory's existence.
TBR=jam
BUG=
Review URL: https://chromiumcodereview.appspot.com/10823435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/10910021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first CL to replace the ant property toolchain.dir with
android.gdbserver.
After this submitted
- Add android_gdbserver into WebKit gypis.
- Retire the toolchain.dir from ant by using android.gdbserver.
- Remove the ANDROID_TOOLCHAIN from both WebKit and chromium's gyp/gypi
- Remove the android_toolchain from envsetup_function.sh
TBR=jam
BUG=
Review URL: https://chromiumcodereview.appspot.com/10886046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Properly setup the chrome sandbox when running test_env.py, if it is required.
R=maruel@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10911014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
run_test_from_archive_smoke_test.py didn't test directory creation so this was
broken. I tested it manually and weeded out the current bug.
For the modification in test_env.py, this is concerning. Without this
modification, I was getting:
Traceback (most recent call last):
File "../testing/xvfb.py", line 133, in <module>
sys.exit(main())
File "../testing/xvfb.py", line 129, in main
return run_executable(sys.argv[2:], sys.argv[1], os.environ.copy())
File "../testing/xvfb.py", line 118, in run_executable
return test_env.run_executable(cmd, env)
AttributeError: 'module' object has no attribute 'run_executable'
Adding a print() or anything else fixed the problem. I'm not sure what's
corrupted on my system.
TBR=cmp@chromium.org,csharp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10890027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10880011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add limited support for openat() trace on strace. These are appearing on ubuntu
12.04 with strace version 4.5.20.
Fix a race condition where trace_test_cases.py could not print all the output.
R=cmp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10854252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A recent clang roll started causing the following warning:
../../../testing/iossim/iossim.mm:215:62: error: expression which evaluates to zero treated as a null pointer constant of type 'BOOL *' (aka 'signed char *') [-Werror,-Wnon-literal-null-conversion].
Just dropping the isDirectory parameter fixes the issue.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10832399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The mac_build.gypi will build the iossim executable using ninja.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10827200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android builds currently rely on the STRIP environment variable to be available
during build time, rather than just at project generation time. It shouldn't.
BUG=142642
Review URL: https://chromiumcodereview.appspot.com/10832295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
itself.
It has been superseded by --sdk-build, which has already been set for all
other Chromium and WebKit users.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10855147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10825322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
account.
This broke the WebKit Chromium Android bot.
BUG=142322
Review URL: https://chromiumcodereview.appspot.com/10829291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10826246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also includes a refactoring of the Ant xml scripts to use a common template (contributed by shashishekhar@chromium.org). As part of this, I also continued Torne's effort of removing our reliance on environment variables. Unfortunately this currently means that you have to specify 5 gyp flags:
ANDROID_SDK, ANDROID_SDK_ROOT, ANDROID_SDK_TOOLS, ANDROID_SDK_VERSION, ANDROID_TOOLCHAIN.
This'll get better as we make further use of the checked in sdk both upstream and downstream. The problem stems from the android tree and released sdk having different configurations.
Review URL: https://chromiumcodereview.appspot.com/10830012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
which one it was in logs.
Review URL: https://chromiumcodereview.appspot.com/10825199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This flag supersedes --ant-compile and takes its value from gyp's sdk_build
variable. It will tell the native test generator script to use Ant for Java
compilation (default) instead of the Android.mk file.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10821128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- When reporting errors from the simulator framework always include the error
domain and error code since some of the strings come back from the simulator
and those are localized.
- There appears to be a race condition where sometimes the simulator framework
will end with an error, but the error is that the simulated app cleanly shut
down; try to trap this error and don't fail the simulator run.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10831111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and lookup the classes by name. This allows the binary to work with multiple
versions of Xcode and doesn't tile the binary to an Xcode install location.
- Fix problem where the tool could log the wrong thing since basename()
returns an internal buffer.
Review URL: https://chromiumcodereview.appspot.com/10828070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=138115
Review URL: https://chromiumcodereview.appspot.com/10830068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
app is launched.
Review URL: https://chromiumcodereview.appspot.com/10831050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10829059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
iossim is a command line tool used to run an iOS app in the iOS Simulator.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10805004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
override of base::DIR_SOURCE_ROOT."
CR_SOURCE_ROOT is used in practice by linux user(s), plural still to be
determined, mostly for ChromeOS related development.
R=willchan@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10808048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10829023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows easily running a unit test target on multiple simulator configurations.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10832030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from downstream and strip NOTIMPLEMENTED()s from official builds."
Relanding http://codereview.chromium.org/10816039/ but removing the
clang parts and fixing x86.
This reverts commit 7fc96c8b734fc9bc8152329d99e8ee3f3de14a65.
BUG=137569
Review URL: https://chromiumcodereview.appspot.com/10809081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The rule of generating jni header is changed, need to update the related
source file.
BUG=
TEST=unittests
Review URL: https://chromiumcodereview.appspot.com/10809029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allow finer grain control over what is rebuilt.
Also, since we have approval over the generated header file name,
it greatly simplifies both the generator and also all the gyp files
as they no longer need to list the header file and keep in sync with the
java file, so the process now is as simple as adding a single java file
to the sources.
BUG=137069
TEST=build on android
Review URL: https://chromiumcodereview.appspot.com/10798010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the generated file for GetAllTests() to a public directory in the device.
Adds the necessary permission to the manifest for the test.
BUG=
TEST=run android tests in a non-rooted device.
Review URL: https://chromiumcodereview.appspot.com/10804003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10778023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use fail and condition to do check firstly before any targets
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10696189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146540 0039d316-1c4b-4281-b951-d872f2087c98
|