| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=447778
Review URL: https://codereview.chromium.org/800513007
Cr-Commit-Position: refs/heads/master@{#310928}
|
|
|
|
|
|
|
|
|
|
| |
Motivated by http://www.chromium.org/developers/coding-style#Naming
BUG=428729
Review URL: https://codereview.chromium.org/804753005
Cr-Commit-Position: refs/heads/master@{#310877}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should be a lightweight test suite that should allow a dev changing
something in skia/ext to test it much more quickly than having to build
all 'unit_tests' target just to run the tests from skia/ext.
It was reverted because it broke Mac GN with error like:
duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in:
obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o
obj/skia/ext/skia.skia_utils_mac.o
(and more similar issues).
BUG=444058
TEST=skia_unittests links and runs fine.
R=danakj@chromium.org,thakis@chromium.org,glider@chromium.org,sky@chromium.org
TBR=glider@chromium.org (already reviewed tools/valgrind - and no changes were made at that directory).
Review URL: https://codereview.chromium.org/837243002
Cr-Commit-Position: refs/heads/master@{#310688}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #12 id:220001 of https://codereview.chromium.org/815023003/)
Reason for revert:
Fails linking on the Mac GN builder:
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/2094
duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in:
obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o
obj/skia/ext/skia.skia_utils_mac.o
(and more similar issues)
Original issue's description:
> skia: Add 'skia_unittests' test suite for this directory.
>
> This should be a lightweight test suite that should allow a dev changing
> something in skia/ext to test it much more quickly than having to build
> all 'unit_tests' target just to run the tests from skia/ext.
>
> BUG=444058
> TEST=skia_unittests links and runs fine.
> R=danakj@chromium.org,thakis@chromium.org
>
> Committed: https://crrev.com/c87c3d2d949f9ba4f17627dc023b303c75b7635f
> Cr-Commit-Position: refs/heads/master@{#310310}
TBR=danakj@chromium.org,thakis@chromium.org,glider@chromium.org,sky@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=444058
Review URL: https://codereview.chromium.org/816803003
Cr-Commit-Position: refs/heads/master@{#310314}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should be a lightweight test suite that should allow a dev changing
something in skia/ext to test it much more quickly than having to build
all 'unit_tests' target just to run the tests from skia/ext.
BUG=444058
TEST=skia_unittests links and runs fine.
R=danakj@chromium.org,thakis@chromium.org
Review URL: https://codereview.chromium.org/815023003
Cr-Commit-Position: refs/heads/master@{#310310}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL disables several unit tests on the browser side navigation bot because
they are no longer applicable when browser side navigation is enabled.
BUG=439423
Review URL: https://codereview.chromium.org/815563004
Cr-Commit-Position: refs/heads/master@{#310303}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other misc fixes including:
Add "data_deps" to the templates in BUILDCONFIG. This was renamed from "datadeps" a while ago but both are still supported.
extension_management_test_util.cc includes a generated file policy_constants. GYP generates this with an extra "policy" directory but GN doesn't. The way GYP has the dirs set up, though, using only one "policy" works (and this is what other files do) so I just changed the include.
TBR=dpranke
Review URL: https://codereview.chromium.org/824373003
Cr-Commit-Position: refs/heads/master@{#310276}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and waterfall bots. (patchset #2 id:20001 of https://codereview.chromium.org/822763005/)
Reason for revert:
Mac10.9 Tests (dbg) has been burning since this landed, with consistent failures of a few dozen of the app_shell_browsertests:
failures:
AppViewTest.TestAppViewGoodDataShouldSucceed
HidApiTest.HidApp
HidApiTest.OnDeviceAdded
SystemMemoryApiTest.Memory
SystemCpuApiTest.Cpu
UsbApiTest.ListInterfaces
SystemDisplayApiTest.GetDisplay
SystemStorageEjectApiTest.EjectBadDeviceTest
UsbApiTest.TransferFailure
UsbApiTest.ResetDevice
SystemStorageApiTest.StorageAttachment
SystemStorageEjectApiTest.EjectTest
UsbApiTest.ZeroLengthTransfer
UsbApiTest.InvalidLengthTransfer
UsbApiTest.TransferEvent
UsbApiTest.DeviceHandling
DnsApiTest.DnsExtension
HidApiTest.OnDeviceRemoved
SystemNetworkApiTest.SystemNetworkExtension
SystemStorageApiTest.Storage
Original issue's description:
> Run app_shell_browsertests and app_shell_unittests on mac trybots and waterfall bots.
>
> BUG=399363
>
> Committed: https://crrev.com/527e36e0910f9336cb02ac4ce5d96f4fcf3c4d6d
> Cr-Commit-Position: refs/heads/master@{#309817}
TBR=phajdan.jr@chromium.org,dpranke@chromium.org,yoz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399363
Review URL: https://codereview.chromium.org/829093002
Cr-Commit-Position: refs/heads/master@{#309843}
|
|
|
|
|
|
|
|
|
|
| |
waterfall bots.
BUG=399363
Review URL: https://codereview.chromium.org/822763005
Cr-Commit-Position: refs/heads/master@{#309817}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/826573002/)
Reason for revert:
The tests should have failed with this. Undoing the revert.
Original issue's description:
> Revert "Update legacy Tuple-using code."
>
> This reverts commit 12f4b98357b9dedc93cb546aac0aece2c8d9e850
>
> BUG=440675, 444827
>
> Committed: https://chromium.googlesource.com/chromium/src/+/85748694f2a119a057088f77f70b97f11607473c
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=440675, 444827
Review URL: https://codereview.chromium.org/794073003
Cr-Commit-Position: refs/heads/master@{#309586}
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 12f4b98357b9dedc93cb546aac0aece2c8d9e850
BUG=440675, 444827
Review URL: https://codereview.chromium.org/826573002
Cr-Commit-Position: refs/heads/master@{#309583}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Covers testing/, tools/, ui/, and win8/.
BUG=422426
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/819223002
Cr-Commit-Position: refs/heads/master@{#309538}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=440675
TEST=no change
R=mdempsky@chromium.org, nasko@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/814403003
Cr-Commit-Position: refs/heads/master@{#309432}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/806373002
Cr-Commit-Position: refs/heads/master@{#309153}
|
|
|
|
|
|
|
|
|
| |
BUG=443613
R=sheyang@chromium.org
Review URL: https://codereview.chromium.org/796403004
Cr-Commit-Position: refs/heads/master@{#309049}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have tried running the Windows build of the Auth test
locally and on a swarming bot and it consistently passes
(both for v1 and v2 webapp). Therefore, as discussed with Anand
I will enable Auth test for Windows, for v2 webapp.
In the long-term we should extend coverage to v1 webapp,
but this requires refactoring how parameters are passed to the tests
(and is tracked by chromium issue here:
https://code.google.com/p/chromium/issues/detail?id=423581).
BUG=431488
Review URL: https://codereview.chromium.org/809803002
Cr-Commit-Position: refs/heads/master@{#308685}
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:440882
TEST=None
Review URL: https://codereview.chromium.org/789373003
Cr-Commit-Position: refs/heads/master@{#308620}
|
|
|
|
|
|
|
|
|
|
|
| |
It was added to ui/ while I isolated all other unittests in ui/
BUG=98637
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/794903004
Cr-Commit-Position: refs/heads/master@{#308618}
|
|
|
|
|
|
|
|
| |
BUG=428729
Review URL: https://codereview.chromium.org/788753002
Cr-Commit-Position: refs/heads/master@{#308441}
|
|
|
|
|
|
|
|
|
|
| |
With the NG trybots using the buildbot value, browser_tests' sharding value regressed from the original 8 to 5 shards. The bots are now seeing more delays. Bump everything up to 10.
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/805913004
Cr-Commit-Position: refs/heads/master@{#308408}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initial commit was in 42f9c67b74. The difference is:
- Left out testing/buildbot/chromium.win.json since it caused
http://crbug.com/441690 and more investigation is needed.
TBR=jochen@chromium.org
R=jam@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/797483004
Cr-Commit-Position: refs/heads/master@{#308167}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/724603004/)
Reason for revert:
Speculatively reverting due to chromium.win not triggered testers at all.
http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/5439/
succeeded in triggering testers
http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/5440/
didn't.
There was no build.git commit nor recipe change.
BUG=441690
Original issue's description:
> Isolate remaining tests under ui/
>
> BUG=98637
> R=maruel@chromium.org,jam@chromium.org
>
> Committed: https://crrev.com/4d293d79bd67b683942fd727c46f2b3173d7f03e
> Cr-Commit-Position: refs/heads/master@{#307954}
TBR=jam@chromium.org,phajdan.jr@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=98637
Review URL: https://codereview.chromium.org/802673002
Cr-Commit-Position: refs/heads/master@{#308066}
|
|
|
|
|
|
|
|
|
| |
BUG=98637
R=maruel@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/724603004
Cr-Commit-Position: refs/heads/master@{#307954}
|
|
|
|
|
|
|
|
|
|
| |
BUG=419367
TBR=phajdan.jr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/780303004
Cr-Commit-Position: refs/heads/master@{#307918}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
10.9 (patchset #1 id:1 of https://codereview.chromium.org/788263002/)
Reason for revert:
Failing test disabled in https://codereview.chromium.org/790253002/
Original issue's description:
> Revert of Revert of Revert of Enable telemetry unittests on Mac 10.9 (patchset #1 id:1 of https://codereview.chromium.org/789233002/)
>
> Reason for revert:
> Telemetry tests still fails.
>
> Original issue's description:
> > Revert of Revert of Enable telemetry unittests on Mac 10.9 (patchset #1 id:1 of https://codereview.chromium.org/792683002/)
> >
> > Reason for revert:
> > The failing test was disabled in https://codereview.chromium.org/789043003
> >
> > Original issue's description:
> > > Revert of Enable telemetry unittests on Mac 10.9 (patchset #1 id:1 of https://codereview.chromium.org/779943004/)
> > >
> > > Reason for revert:
> > > Tests fail with a different error.
> > >
> > > Original issue's description:
> > > > Enable telemetry unittests on Mac 10.9
> > > >
> > > > The tests were fixed in https://codereview.chromium.org/789853003
> > > >
> > > > BUG=423688
> > > >
> > > > Committed: https://crrev.com/e0fe19f3e05e83e820be8a8e2850853bc0434b21
> > > > Cr-Commit-Position: refs/heads/master@{#307522}
> > >
> > > TBR=tonyg@chromium.org,phajdan.jr@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=423688
> > >
> > > Committed: https://crrev.com/dbf34f1e5d36e433c9d30df974da8c5f6fa665e5
> > > Cr-Commit-Position: refs/heads/master@{#307553}
> >
> > TBR=tonyg@chromium.org,phajdan.jr@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=423688
> >
> > Committed: https://crrev.com/1e2366706b52428a3a6355864b6e9a845216ae3d
> > Cr-Commit-Position: refs/heads/master@{#307696}
>
> TBR=tonyg@chromium.org,phajdan.jr@chromium.org,sullivan@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=423688
>
> Committed: https://crrev.com/79b9048ef6ddf1278beef8fac69536798f6d3963
> Cr-Commit-Position: refs/heads/master@{#307734}
TBR=tonyg@chromium.org,phajdan.jr@chromium.org,dvh@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=423688
Review URL: https://codereview.chromium.org/775363003
Cr-Commit-Position: refs/heads/master@{#307752}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up to http://crrev.com/759433002 which introduced
ui_touch_selection_unittests.
BUG=399721
Review URL: https://codereview.chromium.org/792633002
Cr-Commit-Position: refs/heads/master@{#307749}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/785003002
Cr-Commit-Position: refs/heads/master@{#307742}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/789233002/)
Reason for revert:
Telemetry tests still fails.
Original issue's description:
> Revert of Revert of Enable telemetry unittests on Mac 10.9 (patchset #1 id:1 of https://codereview.chromium.org/792683002/)
>
> Reason for revert:
> The failing test was disabled in https://codereview.chromium.org/789043003
>
> Original issue's description:
> > Revert of Enable telemetry unittests on Mac 10.9 (patchset #1 id:1 of https://codereview.chromium.org/779943004/)
> >
> > Reason for revert:
> > Tests fail with a different error.
> >
> > Original issue's description:
> > > Enable telemetry unittests on Mac 10.9
> > >
> > > The tests were fixed in https://codereview.chromium.org/789853003
> > >
> > > BUG=423688
> > >
> > > Committed: https://crrev.com/e0fe19f3e05e83e820be8a8e2850853bc0434b21
> > > Cr-Commit-Position: refs/heads/master@{#307522}
> >
> > TBR=tonyg@chromium.org,phajdan.jr@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=423688
> >
> > Committed: https://crrev.com/dbf34f1e5d36e433c9d30df974da8c5f6fa665e5
> > Cr-Commit-Position: refs/heads/master@{#307553}
>
> TBR=tonyg@chromium.org,phajdan.jr@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=423688
>
> Committed: https://crrev.com/1e2366706b52428a3a6355864b6e9a845216ae3d
> Cr-Commit-Position: refs/heads/master@{#307696}
TBR=tonyg@chromium.org,phajdan.jr@chromium.org,sullivan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=423688
Review URL: https://codereview.chromium.org/788263002
Cr-Commit-Position: refs/heads/master@{#307734}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/792683002/)
Reason for revert:
The failing test was disabled in https://codereview.chromium.org/789043003
Original issue's description:
> Revert of Enable telemetry unittests on Mac 10.9 (patchset #1 id:1 of https://codereview.chromium.org/779943004/)
>
> Reason for revert:
> Tests fail with a different error.
>
> Original issue's description:
> > Enable telemetry unittests on Mac 10.9
> >
> > The tests were fixed in https://codereview.chromium.org/789853003
> >
> > BUG=423688
> >
> > Committed: https://crrev.com/e0fe19f3e05e83e820be8a8e2850853bc0434b21
> > Cr-Commit-Position: refs/heads/master@{#307522}
>
> TBR=tonyg@chromium.org,phajdan.jr@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=423688
>
> Committed: https://crrev.com/dbf34f1e5d36e433c9d30df974da8c5f6fa665e5
> Cr-Commit-Position: refs/heads/master@{#307553}
TBR=tonyg@chromium.org,phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=423688
Review URL: https://codereview.chromium.org/789233002
Cr-Commit-Position: refs/heads/master@{#307696}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/779943004/)
Reason for revert:
Tests fail with a different error.
Original issue's description:
> Enable telemetry unittests on Mac 10.9
>
> The tests were fixed in https://codereview.chromium.org/789853003
>
> BUG=423688
>
> Committed: https://crrev.com/e0fe19f3e05e83e820be8a8e2850853bc0434b21
> Cr-Commit-Position: refs/heads/master@{#307522}
TBR=tonyg@chromium.org,phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=423688
Review URL: https://codereview.chromium.org/792683002
Cr-Commit-Position: refs/heads/master@{#307553}
|
|
|
|
|
|
|
|
|
|
| |
The tests were fixed in https://codereview.chromium.org/789853003
BUG=423688
Review URL: https://codereview.chromium.org/779943004
Cr-Commit-Position: refs/heads/master@{#307522}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/776313002/)
Reason for revert:
Still failing, but for different reasons: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/821/steps/telemetry_unittests/logs/stdio
Original issue's description:
> Revert of Revert of Revert of Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/776663002/)
>
> Reason for revert:
> We think this was fixed by https://codereview.chromium.org/750093007
>
> Original issue's description:
> > Revert of Revert of Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/734433004/)
> >
> > Reason for revert:
> > Getting errors like this:
> > Telemetry needs to run /usr/bin/pkill under sudo. Please authenticate.
> >
> > Original issue's description:
> > > Revert of Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/751533002/)
> > >
> > > Reason for revert:
> > > Failures fixed in https://codereview.chromium.org/720413006/, these tests pass locally for me on Mac 10.9
> > >
> > > Original issue's description:
> > > > Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/744283002/)
> > > >
> > > > Reason for revert:
> > > > This re-enabling of tests has left a trail of redness on Mac 10.9 (more than one failure). If you expect tests to fail as a result of re-enabling again, then please watch the tree and disable the ones failing (assuming that is the appropriate course of action in the first place, which I'm not sure of).
> > > >
> > > > Original issue's description:
> > > > > Revert of Disable telemetry tests for Mac 10.9. (patchset #2 id:20001 of https://codereview.chromium.org/706703003/)
> > > > >
> > > > > Reason for revert:
> > > > > Second attempt to re-enable tests. I think there may still be one test failure, but we can disable that one test. If there's more than one, revert this.
> > > > >
> > > > > Original issue's description:
> > > > > > Disable telemetry tests for Mac 10.9.
> > > > > >
> > > > > > The telemetry tests are failing consistently on OSX 10.9.
> > > > > >
> > > > > > BUG=420615
> > > > > > R=tonyg@chromium.org
> > > > > >
> > > > > > Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974
> > > > > > Cr-Commit-Position: refs/heads/master@{#303114}
> > > > >
> > > > > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=420615
> > > > >
> > > > > Committed: https://crrev.com/10e58e6dfbe4d9dae5841ceb9eb0180cce1aac14
> > > > > Cr-Commit-Position: refs/heads/master@{#305096}
> > > >
> > > > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=420615
> > > >
> > > > Committed: https://crrev.com/8ef425c1d3058afabd36fd9226385c142ba5f280
> > > > Cr-Commit-Position: refs/heads/master@{#305200}
> > >
> > > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=420615
> > >
> > > Committed: https://crrev.com/2e93412cdb1175bec8bc497cf48bf35459eb35df
> > > Cr-Commit-Position: refs/heads/master@{#306430}
> >
> > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=420615
> >
> > Committed: https://crrev.com/527ed4e9b27b1fb40e7c219d3066519139910864
> > Cr-Commit-Position: refs/heads/master@{#306451}
>
> TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=420615
>
> Committed: https://crrev.com/d672d0bca59952c5b7b7ac58d6dcc68134d33ac8
> Cr-Commit-Position: refs/heads/master@{#306849}
TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420615
Review URL: https://codereview.chromium.org/780933003
Cr-Commit-Position: refs/heads/master@{#306860}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/776663002/)
Reason for revert:
We think this was fixed by https://codereview.chromium.org/750093007
Original issue's description:
> Revert of Revert of Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/734433004/)
>
> Reason for revert:
> Getting errors like this:
> Telemetry needs to run /usr/bin/pkill under sudo. Please authenticate.
>
> Original issue's description:
> > Revert of Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/751533002/)
> >
> > Reason for revert:
> > Failures fixed in https://codereview.chromium.org/720413006/, these tests pass locally for me on Mac 10.9
> >
> > Original issue's description:
> > > Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/744283002/)
> > >
> > > Reason for revert:
> > > This re-enabling of tests has left a trail of redness on Mac 10.9 (more than one failure). If you expect tests to fail as a result of re-enabling again, then please watch the tree and disable the ones failing (assuming that is the appropriate course of action in the first place, which I'm not sure of).
> > >
> > > Original issue's description:
> > > > Revert of Disable telemetry tests for Mac 10.9. (patchset #2 id:20001 of https://codereview.chromium.org/706703003/)
> > > >
> > > > Reason for revert:
> > > > Second attempt to re-enable tests. I think there may still be one test failure, but we can disable that one test. If there's more than one, revert this.
> > > >
> > > > Original issue's description:
> > > > > Disable telemetry tests for Mac 10.9.
> > > > >
> > > > > The telemetry tests are failing consistently on OSX 10.9.
> > > > >
> > > > > BUG=420615
> > > > > R=tonyg@chromium.org
> > > > >
> > > > > Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974
> > > > > Cr-Commit-Position: refs/heads/master@{#303114}
> > > >
> > > > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=420615
> > > >
> > > > Committed: https://crrev.com/10e58e6dfbe4d9dae5841ceb9eb0180cce1aac14
> > > > Cr-Commit-Position: refs/heads/master@{#305096}
> > >
> > > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=420615
> > >
> > > Committed: https://crrev.com/8ef425c1d3058afabd36fd9226385c142ba5f280
> > > Cr-Commit-Position: refs/heads/master@{#305200}
> >
> > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=420615
> >
> > Committed: https://crrev.com/2e93412cdb1175bec8bc497cf48bf35459eb35df
> > Cr-Commit-Position: refs/heads/master@{#306430}
>
> TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=420615
>
> Committed: https://crrev.com/527ed4e9b27b1fb40e7c219d3066519139910864
> Cr-Commit-Position: refs/heads/master@{#306451}
TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420615
Review URL: https://codereview.chromium.org/776313002
Cr-Commit-Position: refs/heads/master@{#306849}
|
|
|
|
|
|
|
|
|
| |
BUG=380709
R=sergiyb@chromium.org
Review URL: https://codereview.chromium.org/769593004
Cr-Commit-Position: refs/heads/master@{#306804}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excluded mojo because I think that needs to happen on the other side.
At gn --version = 306668 for which roll is in CQ.
R=brettw@chromium.org
TBR=scherkus@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/774353003
Cr-Commit-Position: refs/heads/master@{#306708}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
10.9. (patchset #1 id:1 of https://codereview.chromium.org/734433004/)
Reason for revert:
Getting errors like this:
Telemetry needs to run /usr/bin/pkill under sudo. Please authenticate.
Original issue's description:
> Revert of Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/751533002/)
>
> Reason for revert:
> Failures fixed in https://codereview.chromium.org/720413006/, these tests pass locally for me on Mac 10.9
>
> Original issue's description:
> > Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/744283002/)
> >
> > Reason for revert:
> > This re-enabling of tests has left a trail of redness on Mac 10.9 (more than one failure). If you expect tests to fail as a result of re-enabling again, then please watch the tree and disable the ones failing (assuming that is the appropriate course of action in the first place, which I'm not sure of).
> >
> > Original issue's description:
> > > Revert of Disable telemetry tests for Mac 10.9. (patchset #2 id:20001 of https://codereview.chromium.org/706703003/)
> > >
> > > Reason for revert:
> > > Second attempt to re-enable tests. I think there may still be one test failure, but we can disable that one test. If there's more than one, revert this.
> > >
> > > Original issue's description:
> > > > Disable telemetry tests for Mac 10.9.
> > > >
> > > > The telemetry tests are failing consistently on OSX 10.9.
> > > >
> > > > BUG=420615
> > > > R=tonyg@chromium.org
> > > >
> > > > Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974
> > > > Cr-Commit-Position: refs/heads/master@{#303114}
> > >
> > > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=420615
> > >
> > > Committed: https://crrev.com/10e58e6dfbe4d9dae5841ceb9eb0180cce1aac14
> > > Cr-Commit-Position: refs/heads/master@{#305096}
> >
> > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=420615
> >
> > Committed: https://crrev.com/8ef425c1d3058afabd36fd9226385c142ba5f280
> > Cr-Commit-Position: refs/heads/master@{#305200}
>
> TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=420615
>
> Committed: https://crrev.com/2e93412cdb1175bec8bc497cf48bf35459eb35df
> Cr-Commit-Position: refs/heads/master@{#306430}
TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420615
Review URL: https://codereview.chromium.org/776663002
Cr-Commit-Position: refs/heads/master@{#306451}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/751533002/)
Reason for revert:
Failures fixed in https://codereview.chromium.org/720413006/, these tests pass locally for me on Mac 10.9
Original issue's description:
> Revert of Revert of Disable telemetry tests for Mac 10.9. (patchset #1 id:1 of https://codereview.chromium.org/744283002/)
>
> Reason for revert:
> This re-enabling of tests has left a trail of redness on Mac 10.9 (more than one failure). If you expect tests to fail as a result of re-enabling again, then please watch the tree and disable the ones failing (assuming that is the appropriate course of action in the first place, which I'm not sure of).
>
> Original issue's description:
> > Revert of Disable telemetry tests for Mac 10.9. (patchset #2 id:20001 of https://codereview.chromium.org/706703003/)
> >
> > Reason for revert:
> > Second attempt to re-enable tests. I think there may still be one test failure, but we can disable that one test. If there's more than one, revert this.
> >
> > Original issue's description:
> > > Disable telemetry tests for Mac 10.9.
> > >
> > > The telemetry tests are failing consistently on OSX 10.9.
> > >
> > > BUG=420615
> > > R=tonyg@chromium.org
> > >
> > > Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974
> > > Cr-Commit-Position: refs/heads/master@{#303114}
> >
> > TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=420615
> >
> > Committed: https://crrev.com/10e58e6dfbe4d9dae5841ceb9eb0180cce1aac14
> > Cr-Commit-Position: refs/heads/master@{#305096}
>
> TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=420615
>
> Committed: https://crrev.com/8ef425c1d3058afabd36fd9226385c142ba5f280
> Cr-Commit-Position: refs/heads/master@{#305200}
TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org,finnur@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420615
Review URL: https://codereview.chromium.org/734433004
Cr-Commit-Position: refs/heads/master@{#306430}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
work on Linux bots:
1.) Get hash-id on local-machine and copy test host-config file to expected location, with hash-id in file-name.
2.) Place me2me manifest file in user-profile dir, that we'll use for running connect-to-local-host test.
In order for the above initialisation to work, include the test host-config and me2me manifest files in the Chromoting isolate for Linux.
BUG=
Review URL: https://codereview.chromium.org/736023003
Cr-Commit-Position: refs/heads/master@{#305950}
|
|
|
|
|
|
|
|
|
|
| |
chromoting_integration_tests with isolate.py.
BUG=421063, 436892
Review URL: https://codereview.chromium.org/760943002
Cr-Commit-Position: refs/heads/master@{#305945}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/752643002
Cr-Commit-Position: refs/heads/master@{#305907}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a recipe for a Brsoer Side Navigation fyi bot in the chromium fyi
waterfall.
BUG=432848
Review URL: https://codereview.chromium.org/722103003
Cr-Commit-Position: refs/heads/master@{#305204}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/744283002/)
Reason for revert:
This re-enabling of tests has left a trail of redness on Mac 10.9 (more than one failure). If you expect tests to fail as a result of re-enabling again, then please watch the tree and disable the ones failing (assuming that is the appropriate course of action in the first place, which I'm not sure of).
Original issue's description:
> Revert of Disable telemetry tests for Mac 10.9. (patchset #2 id:20001 of https://codereview.chromium.org/706703003/)
>
> Reason for revert:
> Second attempt to re-enable tests. I think there may still be one test failure, but we can disable that one test. If there's more than one, revert this.
>
> Original issue's description:
> > Disable telemetry tests for Mac 10.9.
> >
> > The telemetry tests are failing consistently on OSX 10.9.
> >
> > BUG=420615
> > R=tonyg@chromium.org
> >
> > Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974
> > Cr-Commit-Position: refs/heads/master@{#303114}
>
> TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=420615
>
> Committed: https://crrev.com/10e58e6dfbe4d9dae5841ceb9eb0180cce1aac14
> Cr-Commit-Position: refs/heads/master@{#305096}
TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org,dtu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420615
Review URL: https://codereview.chromium.org/751533002
Cr-Commit-Position: refs/heads/master@{#305200}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/706703003/)
Reason for revert:
Second attempt to re-enable tests. I think there may still be one test failure, but we can disable that one test. If there's more than one, revert this.
Original issue's description:
> Disable telemetry tests for Mac 10.9.
>
> The telemetry tests are failing consistently on OSX 10.9.
>
> BUG=420615
> R=tonyg@chromium.org
>
> Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974
> Cr-Commit-Position: refs/heads/master@{#303114}
TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420615
Review URL: https://codereview.chromium.org/744283002
Cr-Commit-Position: refs/heads/master@{#305096}
|
|
|
|
|
|
|
|
|
| |
BUG=318404
TBR=samuong@chromium.org
Review URL: https://codereview.chromium.org/744453002
Cr-Commit-Position: refs/heads/master@{#305047}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=432538
TEST=None
R=skuhne,phajdan.jr,oshima,thestig
TBR=sky (For reverting changes to ui/base added in https://codereview.chromium.org/680383008/)
Review URL: https://codereview.chromium.org/738513002
Cr-Commit-Position: refs/heads/master@{#304825}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change fixes java_library and java_prebuilt to actually construct a
classpath based on their dependents. It adds java_binary that is similar
to java_library but also creates a script in $root_build_dir/bin/ to
actually run a java jar (it builds in the classpath and main class so
that it can just be run like a normal executable).
Adds the flags "android" and "has_android_platform" to the java_library
template. An android_library can depend on a java_library only if the
java_libary has "android == true". A java_library can depend on an
android_library only if the java_libary has
"has_android_platform == true".
This merges several of the paths for compiling java between android and
non-android implementations into a single one that just takes a flag
controlling it's behavior (enabling/disabling dex, for example).
Adds a very simple java_binary target. This can be run to ensure it works,
output is printed, and exit code is propagated.
TBR=brettw
BUG=359249,383646,417843
Review URL: https://codereview.chromium.org/687633003
Cr-Commit-Position: refs/heads/master@{#304555}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like some code in runtest.py still takes values
from there as opposed to more specific runtest.py flags.
BUG=422235
R=iannucci@chromium.org
Review URL: https://codereview.chromium.org/704753004
Cr-Commit-Position: refs/heads/master@{#304406}
|
|
|
|
|
|
|
|
|
| |
The only targets using these libraries are mojo targets which are
GN-only, so we don't need to keep gyp rules around.
Review URL: https://codereview.chromium.org/730813002
Cr-Commit-Position: refs/heads/master@{#304353}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/710633003
Cr-Commit-Position: refs/heads/master@{#304326}
|
|
|
|
|
|
|
|
|
| |
BUG=380709
R=sergiyb@chromium.org
Review URL: https://codereview.chromium.org/725883004
Cr-Commit-Position: refs/heads/master@{#304201}
|