| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The removed directories are:
bar
bar/toolbar
bar/toolbar/cld
bar/toolbar/cld/i18n
gcl does not show any of them and does not even allow uploading the cl. So, I removed the empty line (last line) in README.chromium for the recording purpose.
BUG=None
TEST=CLD builds just fine.
TBR=jcivelli
Review URL: http://codereview.chromium.org/3329011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed CLD wrapper function to return the number of bytes used for language detection, and using that in the render view to ignore detection for short texts.
BUG=45156
TEST=Visit www.voila.fr, an infobar should show reporting the page is in French.
Visit http://jdvhotels.com/calendar.html?datetime=1274857200000&id=0, no translate infobar should show.
Review URL: http://codereview.chromium.org/3038018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with random text.
BUG=39217
TEST=Open pages in various languages, make sure the infobar
appears and reports the right language for the page.
Review URL: http://codereview.chromium.org/1559035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're now down to only 4 dirs that don't pass the license checker.
They will require separate changes.
Modify the license checker to only print failing dirs.
BUG=39240
Review URL: http://codereview.chromium.org/1530040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=29342
TEST=None
TBR=evan
Review URL: http://codereview.chromium.org/1611015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1559023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
detection on some pages.
This only marginally slows down the language detection.
BUG=35156
TEST=Open http://app.jackrabbitclass.com/eventcalendar.asp?orgid=250131 in Chrome English.
No translation infobar should be shown.
Review URL: http://codereview.chromium.org/626008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Remove files we don't use that come from toolbar
2. Simplify the directory structure by removing the redundant
intermediary directories bar/toolbar/cld/i18n
This will bring CLD a step closer to where it can be open-sourced separately (or along with CED for encoding detection.). It's not there yet.
In addition to the clean-up, change |LanguageCode*| return
'nb', 'he', 'fil' instead of 'no', 'iw', and 'tl'.
Also, use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN'
instead of 'zh'. This is to simplify the 3-way mapping between
Chrome's UI locale code, CLD's language code and what's accepted by
Google Translate. It's also another preparation for open-sourcing because
we'd better use the standard code rather than the obsolete code like 'iw'
when open-sourcing.
BUG=32759, 33613
TEST=third_party/cld builds on all platforms and pass the following tests:
- unit_tests: Extension*.DetectTabLanguage and CompactLangDetTest.*
- browser_tests: ExtensionBrowserTest.Toolstrip
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/565020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Reliability tests should not crash.
Review URL: http://codereview.chromium.org/551086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reverted in r36550. Now I'm relanding with the full description.
Port back CLD to Linux and Mac by replacing Windows API calls with ICU's equivalent APIs for normalization.
I also fixed bug 23553 (Traditional Chinese is not detected) by calling LanguageCode instead of LanguageCode_ISO_639_1. The latter covers only ISO 639-1, but there are languages detected by CLD not covered by ISO 639-1. In that case, ISO 639-2 is used. In case even ISO 639-2 does not cover (e.g. Traditional Chinese), another fallback is taken by LanguageCode.
The html file for CLD testing (french_sentence.html) is explicitly labelled with charset=ISO-8859-1.
Original Review: http://codereview.chromium.org/523108
BUG=25206,23553
TEST=1. CLD is built on Linux/Mac
2. The following test pass:
- unit_tests: Extension*.DetectTabLang* and CompactLangDet*.*
- browser_tests: ExtensionBrowserTest.Toolstrip
3. Install the 'cld extension' in chrome/common/extensions/docs/examples/api/i18n/cld and go to http://news.google.com.tw and 'zh-TW' shows up in the language badge at the upper right (upper-left in he/ar Chrome) corner.
TBR=jcampan
Review URL: http://codereview.chromium.org/545123
TBR=jshin@chromium.org
Review URL: http://codereview.chromium.org/551070
TBR=jshin@chromium.org
Review URL: http://codereview.chromium.org/549091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland it with the commit log for the record.
Review URL: http://codereview.chromium.org/545123
TBR=jshin@chromium.org
Review URL: http://codereview.chromium.org/551070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run the uni-tests.
Review URL: http://codereview.chromium.org/546043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed the dependency with Chrome base and fixed the include path so that files don't need to reference third_paty/cld/...
BUG=None
TEST=Make sure unit-tests still pass.
Review URL: http://codereview.chromium.org/519071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the format of many directories so they don't show up in git status anymore.
Run dos2unix on *.cc, caught many inconsistent and CRLF files.
TBR=evan
TEST=still build, git status shows nothing
BUG=none
Review URL: http://codereview.chromium.org/211010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(http://codereview.chromium.org/174631).
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
unicode text. This is required for an extension API which returns the top three languages for a web page.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not required, yet were creating compile errors when building unit_tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=gclient runhooks --force completes successfully.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/125186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Windows only currently.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/122007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18445 0039d316-1c4b-4281-b951-d872f2087c98
|