summaryrefslogtreecommitdiffstats
path: root/third_party/harfbuzz
Commit message (Collapse)AuthorAgeFilesLines
* OOB read in harfbuzz with khmer character.bashi@chromium.org2011-07-292-15/+30
| | | | | | | | | | | | | Sets face->tmpLogClusters[i] to the last valid value of |item->log_clusters| when |i| exceeds the size of the |item->log_clusters|. BUG=90134 TEST=checked with ASAN and ran webkit/tools/layout_tests/run_webkit_tests.sh Review URL: http://codereview.chromium.org/7465036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94616 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-111-6/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Globally replace <(library) with static_libraryevan@chromium.org2011-05-191-1/+1
| | | | | | | | | | | We provided <(library) as a variable to support a peculiar build configuration on Linux. We no longer support that build configuration, so we can simplify this code to no longer use a variable. Review URL: http://codereview.chromium.org/7051014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
* harfbuzz: Actually apply patch to fix Thai crashes. :-(derat@chromium.org2011-05-192-2/+12
| | | | | | | | | | | | | | | | | | This appears to prevent some renderer crashes that are fairly easy to trigger with Thai pages on Chrome OS. (http://codereview.chromium.org/7000012/ previously added this to chromium.patch, which I mistakenly assumed would get applied on top of the source during the build process. I guess it's instead just a record of our changes from upstream?) BUG=chromium:75210,chromium-os:15103 TEST=visited pungame.com/sale.html many times and checked that it no longer triggers a renderer crash Review URL: http://codereview.chromium.org/7045021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85925 0039d316-1c4b-4281-b951-d872f2087c98
* harfbuzz: Add Behdad's patch to fix Thai crashes on Linux.derat@chromium.org2011-05-101-0/+14
| | | | | | | | | | | | This appears to prevent some renderer crashes that are fairly easy to trigger with Thai pages on Chrome OS. BUG=chromium:75210,chromium-os:15103 TEST=manual: built chromeos-chrome and checked that http://www.pungame.com/sale.html and http://happy.teenee.com/game/ no longer cause crashes Review URL: http://codereview.chromium.org/7000012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84890 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up third_party readmes and adding a template for future use.cdn@chromium.org2011-03-161-1/+4
| | | | | | | | | | | The next step is a presubmit rule that will make people use the template. We are doing this so that we can better track dependancy versions. BUG=None TEST=N/A Review URL: http://codereview.chromium.org/6610030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78316 0039d316-1c4b-4281-b951-d872f2087c98
* harfbuzz: check in harfbuzz-ng, add gyp define to use itevan@chromium.org2011-01-051-40/+59
| | | | | | | | | | | | | | | This checks in harbuzz-ng b0d396aa88b3cdf8cea896bfeeba197656e1cdb1. Setting use_harfbuzz_ng to 1 in gyp will cause us to build harfbuzz-ng in place of harfbuzz. So far this currently fails to compile due to all our other code relying on the old API. BUG=68551 TEST=./build/gyp_chromium -Duse_harfbuzz_ng=1, verify build breaks Review URL: http://codereview.chromium.org/6052008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70539 0039d316-1c4b-4281-b951-d872f2087c98
* harfbuzz: merge harfbuzz and harfbuzz_interface librariesevan@chromium.org2011-01-041-21/+5
| | | | | | | | | | | | Though we build two libraries here, we always use them together, and it simplifies the gyp files to have one. BUG=68551 TEST=compiles Review URL: http://codereview.chromium.org/5986015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70448 0039d316-1c4b-4281-b951-d872f2087c98
* Pass license check script for most of the tree.evan@chromium.org2010-03-191-3/+2
| | | | | | | | | | | | | Modified license-checker script to allow pruning directories we know to be ok. Still need to do a bit of third_party/* , as well as file a bunch of bugs on pieces where the licenses aren't clear, but I'm running out of energy. Review URL: http://codereview.chromium.org/1100003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42045 0039d316-1c4b-4281-b951-d872f2087c98
* linux: hack around arabic advances in harfbuzzevan@chromium.org2010-01-153-1/+26
| | | | | | | | | | Arabic vowels in some fonts (Times New Roman, at least) have non-zero advances, when they should be zero. Pango does a hack very similar to this to work around the same problem. Review URL: http://codereview.chromium.org/543067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36418 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix multicharacter hebrew shapingevan@chromium.org2010-01-151-2/+2
| | | | | | | | | | When we have base + vowel1 + vowel2, and there's no composed version of base + vowel1, attempt to compose base + vowel2 rather than composing vowel1 + vowel2 and then giving up on it because they don't compose. Review URL: http://codereview.chromium.org/549069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36413 0039d316-1c4b-4281-b951-d872f2087c98
* linux: inherit script in the forward-order script iteratorevan@chromium.org2010-01-151-1/+0
| | | | | | | | | | This is the same change as in r29862, but in the other direction. I have a pending change that will remove the reverse-order iterator as that falls down in other circumstances. Review URL: http://codereview.chromium.org/536069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36412 0039d316-1c4b-4281-b951-d872f2087c98
* linux: sync with upstream harfbuzzevan@chromium.org2009-11-198-144/+192
| | | | | | | | | | | | | | Upstream changes are: fix a few compiler warnings and make the code more exception safe. correctly support decomposed forms of two or three part matras fix shaping of assamese ra fix bug with Malayalam Samvruthokaram. add N'Ko support to the arabic shaper Post substitutions should apply to the whole indic syllable Review URL: http://codereview.chromium.org/408013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32448 0039d316-1c4b-4281-b951-d872f2087c98
* linux: tweak combining characters slightlyevan@chromium.org2009-10-231-1/+4
| | | | | | | | | | | | This fixes Arabic and a Cyrillic test. Behdad has promised to rewrite all of this for WebKit, but for now, this new behavior is less broken than before. BUG=22872,22367 Review URL: http://codereview.chromium.org/327006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29862 0039d316-1c4b-4281-b951-d872f2087c98
* linux: restore another harfbuzz patch I dropped.evan@chromium.org2009-10-202-1/+23
| | | | | | | | Fixes LayoutTests/fast/text/drawBidiText.html on Linux. Review URL: http://codereview.chromium.org/308007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29558 0039d316-1c4b-4281-b951-d872f2087c98
* linux: merge newer upstream harfbuzzevan@chromium.org2009-10-208-66/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This merges includes the following changes. The changes by Adam Langley were previously in our tree while they were being upstreamed, but since that's now happened I've removed the changes mentioned in README.google. Adam Langley (3): Add contrib/ and initial file set Add fuzz testing tool. Make HB_ShaperItem a typedef to a named struct. Behdad Esfahbod (4): Fix typo in unused code Bug 23973 memory leak in _HB_OPEN_Load_EmptyClassDefinition Bug 23976 memory leak in Free_BaseArray Bug 24540 arabicSyriacOpenTypeShape causes read past end of string in getArabicProperties Graham Asher (1): Improved comments for HB_ShaperItem fields. BUG=20621 (But it doesn't look like this fixes it, though -- the getArabicProperties change mentioned in the diff was already available locally) Review URL: http://codereview.chromium.org/295025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29544 0039d316-1c4b-4281-b951-d872f2087c98
* Fix harfbuzz read past end of string on arabic text.mattm@chromium.org2009-10-152-4/+19
| | | | | | | | | BUG=23450 TEST=valgrind_webkit_tests.sh LayoutTests/fast/text/drawBidiText.html Review URL: http://codereview.chromium.org/271098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29080 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments setting emacs and vim tab width and expansion variables.sgk@google.com2009-10-061-0/+6
| | | | | | | | BUG=none TEST=successful builds Review URL: http://codereview.chromium.org/256059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
* Force inclusion of build/common.gypi for all chromium gyp files.yaar@chromium.org2009-09-151-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Why: Simpler build code. If everybody includes it, it should be included automatically. Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi. What was done: 1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi 2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi. 3. lots of gyp files were fixed to not refer to build/common.gypi any more. 4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 5. build/common.gypi was left empty, because there are some external projects that still refer to it. Things that are left to do after this patch is in: 1. The following external files (in other repositories) need to stop include common.gypi ./third_party/hunspell/hunspell.gyp ./third_party/icu/icu.gyp ./v8/tools/gyp/v8.gyp 2. Once nobody refers to common.gypi anymore, delete common.gypi -or- Delete gyp_chromium.gypi and move its content back to common.gypi Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify. Review URL: http://codereview.chromium.org/206006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix jump jump based on uninitialised value.agl@chromium.org2009-08-072-3/+3
| | | | | | | | | | | | | | This is causing layout test flakiness and a curious effect where text seems to twitch back and forth randomly. I'm not at all sure about this fix. I'll send it upstream for review, but I want to get it fixed locally first because it's causing problems for us. http://codereview.chromium.org/165165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22803 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: support mirrored charactorsagl@chromium.org2009-08-074-3/+1041
| | | | | | | | | | | | | | | Currently, when Harfbuzz requests a mirror charactor we just abort. This patch adds the Unicode tables required to support mirroring. (Note: I don't actually have any webpages which trigger this code, so it hasn't been tested.) BUG=17563 http://codereview.chromium.org/164123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22776 0039d316-1c4b-4281-b951-d872f2087c98
* Restore -Wall to Linux build and set up for -Werror.sgk@google.com2009-04-091-3/+0
| | | | | | | | | | | | | | | * Add -Wall to build/common.gypi (and -Werror, commented out for now). * Have build/external_code.gypi remove -Wall (and -Werror). * Remove chromium_code definition from build/all.gyp. * Remove chromium_code definitions from third_party/ *.gyp files. * Remove scons-specific -Werror removal in webkit.gyp. * Remove unused variables from: base/clipboard_linux.cc chrome/browser/gtk/download_shelf_gtk.cc chrome/browser/gtk/bookmark_bar_gtk.cc Review URL: http://codereview.chromium.org/66001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13478 0039d316-1c4b-4281-b951-d872f2087c98
* Basic underpinnings of the gyp equivalent of the Linux SHARED=1 build:sgk@google.com2009-04-081-2/+2
| | | | | | | | | parameterize the 'type' setting of the various library targets, with a default of 'static_library'. (Hat tip to Craig Schlenter.) Review URL: http://codereview.chromium.org/62127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13345 0039d316-1c4b-4281-b951-d872f2087c98
* Add Harfbuzz to third_party and Skia support for such.agl@chromium.org2009-04-0784-0/+39645
Harfbuzz is an open source library which is a unification of the Qt and Pango shaping engines. We'll be using it on Chromium Linux to perform complex text shaping. Additionally, we add support for Harfbuzz into Skia, guarded by SKIA_HARFBUZZ. http://codereview.chromium.org/63035/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13214 0039d316-1c4b-4281-b951-d872f2087c98