| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=glider@chromium.org
Review URL: https://codereview.chromium.org/1150193002
Cr-Commit-Position: refs/heads/master@{#332148}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the list of libraries which are built from source match the list of
pre-built libraries which are downloaded from GCS.
BUG=none
TBR=glider@chromium.org
Review URL: https://codereview.chromium.org/1039723002
Cr-Commit-Position: refs/heads/master@{#322592}
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=glider@chromium.org
Review URL: https://codereview.chromium.org/1038883002
Cr-Commit-Position: refs/heads/master@{#322389}
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=glider@chromium.org
Review URL: https://codereview.chromium.org/1037763002
Cr-Commit-Position: refs/heads/master@{#322181}
|
|
|
|
|
|
|
|
|
| |
BUG=462636
TBR=glider@chromium.org
Review URL: https://codereview.chromium.org/1028383003
Cr-Commit-Position: refs/heads/master@{#322060}
|
|
|
|
|
|
|
|
|
|
|
|
| |
With use_prebuilt_instrumented_libraries=1 in GYP_DEFINES, binaries are now
unpacked from archive and placed into output dir.
BUG=462636
TBR=glider@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1003273006
Cr-Commit-Position: refs/heads/master@{#321846}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:20001 of https://codereview.chromium.org/1017053003/)
Reason for revert:
Broke tree.
Original issue's description:
> Instrumented libraries: add a target for pre-built libraries.
>
> With use_prebuilt_instrumented_libraries=1 in GYP_DEFINES, binaries are now
> unpacked from archive and placed into output dir.
>
> BUG=462636
> R=glider@chromium.org
> TBR=thakis@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/744256e2f3933feaa05c967541afac36825056fa
> Cr-Commit-Position: refs/heads/master@{#321804}
TBR=glider@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462636
Review URL: https://codereview.chromium.org/1029103003
Cr-Commit-Position: refs/heads/master@{#321806}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With use_prebuilt_instrumented_libraries=1 in GYP_DEFINES, binaries are now
unpacked from archive and placed into output dir.
BUG=462636
R=glider@chromium.org
TBR=thakis@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1017053003
Cr-Commit-Position: refs/heads/master@{#321804}
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1012823003
Cr-Commit-Position: refs/heads/master@{#321171}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Should fix the "D-Bus library appears to be incorrectly set up; failed to read
machine uuid" messages.
BUG=467901
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1008873004
Cr-Commit-Position: refs/heads/master@{#320930}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleaner, no longer relying on pwd, and with 100% more OOP.
BUG=none
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1003593002
Cr-Commit-Position: refs/heads/master@{#320293}
|
|
|
|
|
|
|
|
|
|
| |
BUG=449183
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/920543003
Cr-Commit-Position: refs/heads/master@{#315990}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates a warning in the best case, a startup crash in the worst case.
BUG=456636
TBR=glider@chromim.org
NOTRY=true
Review URL: https://codereview.chromium.org/911963002
Cr-Commit-Position: refs/heads/master@{#315604}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome doesn't use overlay scrollbars. The only thing that we do with this
library is attempt to initialize it (as part of gtk2+ init) which occasionally
tries to read a missing settings schema and crashes.
BUG=456205
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/905703003
Cr-Commit-Position: refs/heads/master@{#315361}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a recently introduced dependency.
BUG=355223
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/909913002
Cr-Commit-Position: refs/heads/master@{#315326}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Only copy the lib/ dir (i.e. skip usr/ etc),
- Pass --disable-static to configure scripts to avoid
building static libs. Ideally, this flag should be in
target_defaults. However, zlib1g doesn't support it and
fails; I couldn't find a way to exclude the flag for
individual packages. Instead I add it to every other package
expiclitly.
BUG=423343
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/877283005
Cr-Commit-Position: refs/heads/master@{#314580}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Backport a fix for an issue that looks related.
BUG=440063
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/796553002
Cr-Commit-Position: refs/heads/master@{#307755}
|
|
|
|
|
|
|
|
|
|
| |
BUG=419367
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/768223002
Cr-Commit-Position: refs/heads/master@{#306251}
|
|
|
|
|
|
|
|
|
|
| |
BUG=419367
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/770013002
Cr-Commit-Position: refs/heads/master@{#306238}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) Run fix_rpaths.sh separately for each package. Previously we ran it once as
a separate build step. This was the only way when all packages were installed in
the same directory, but since we now install each package in a temporary
directory first, it makes more sense to run fix_rpaths.sh there.
(2) Also fix the one remaining package which didn't use a temp directory.
(3) As a consequence of (1), fixed an issue caused by the fix_rpaths step
sometimes failing to run (http://crbug.com/433547).
(4) Improve the DSO discovery regexp in fix_rpaths.sh. Previously it only
covered DSOs which had unversioned symlinks pointing to them.
(5) Remove an outdated RPATH entry for dependent executables
(/usr/lib/x86_64-linux-gnu/ - we don't install anything there anymore).
BUG=433547
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/723033006
Cr-Commit-Position: refs/heads/master@{#304459}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libpulsecommon has moved to <libdir>/pulseaudio/. Update RPATH so that
instrumented libpulsecommon could be picked up from the new location.
This is not ideal as RPATH in libpulsecommon itself is still wrong. If that
bites us, we'll need to either fix it separately or just move libpulsecommon to
<libdir>. The latter approach would also help with other packages that might
depend on it.
BUG=414189
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/719083002
Cr-Commit-Position: refs/heads/master@{#303830}
|
|
|
|
|
|
|
|
|
|
| |
BUG=414189
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/704073004
Cr-Commit-Position: refs/heads/master@{#303687}
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Trusty we use the system-installed HarfBuzz.
BUG=414189
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/695523003
Cr-Commit-Position: refs/heads/master@{#303683}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This time for real.
BUG=414189
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/714963002
Cr-Commit-Position: refs/heads/master@{#303678}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Explicitly list the packages for which we need to install build dependencies.
The grep-based approach no longer works since we now have packages which are
specific to a certain Ubuntu release.
BUG=414189
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/711283003
Cr-Commit-Position: refs/heads/master@{#303646}
|
|
|
|
|
|
|
|
|
|
| |
BUG=414189
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/689113002
Cr-Commit-Position: refs/heads/master@{#302268}
|
|
|
|
|
|
|
|
|
|
| |
BUG=414189
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/694583002
Cr-Commit-Position: refs/heads/master@{#302108}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not sure what was broken before, but it seems to work now. I also added the
configure flags from debian/rules.
BUG=424313
TBR=glider@chromium.org
NOTRY=true
TEST=MSan
Review URL: https://codereview.chromium.org/660863005
Cr-Commit-Position: refs/heads/master@{#299963}
|
|
|
|
|
|
|
|
|
|
| |
BUG=423410
TBR=eugenis@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/654013002
Cr-Commit-Position: refs/heads/master@{#299509}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables applying different custom patches depending on the Ubuntu
release (Precise/Trusty). It also adds two Trusty-specific patches.
BUG=414189
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/614903003
Cr-Commit-Position: refs/heads/master@{#297672}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was not working correctly in WebRTC builds.
Also, add -fno-omit-frame-pointer to CFLAGS. Both changes will cause a complete
rebuild of all instrumented libraries, so I bundled them together.
BUG=394251
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/619723006
Cr-Commit-Position: refs/heads/master@{#297652}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some cases are simple enough that a search and replace is sufficient. At the
same time, the fewer patches we have, the less time will be spent rebasing them.
BUG=414189
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/618013002
Cr-Commit-Position: refs/heads/master@{#297474}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use more generic names for some packages. The new names are valid on both
Precise and Trusty,
- for some packages, run autoreconf or ./autogen.sh before building. This is
required sometimes because the pre-generated configure script was generated
using an older autoconf version than the one used on Trusty. Some packages don't
even contain a pre-generated configure script.
BUG=414189
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/612153002
Cr-Commit-Position: refs/heads/master@{#297408}
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was inadvertently disabled in r287058.
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/528053003
Cr-Commit-Position: refs/heads/master@{#293012}
|
|
|
|
|
|
|
|
|
|
| |
BUG=404526
TBR=earthdok@chromium.org
Review URL: https://codereview.chromium.org/487213002
Cr-Commit-Position: refs/heads/master@{#290582}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/437023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They have no effect on the build process anyway. All they do is slow down the
build by making it less parallelizable.
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/433113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add flags from debian/rules, and disable assembly modules.
BUG=344505, 313751, 389216
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/393023010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we used a single blacklist file per sanitizer. The same file was used
for Chromium and for every instrumented package. This change allows choosing a
different blacklist file for each package, which means that package targets may
now depend on the blacklist files, avoiding expensive clobbers.
This CL also blacklists two known issues in instrumented libraries.
BUG=313751, 367509
R=glider@chromium.org
NOTRY=true
TEST=MSan interactive_ui_tests, ASan compile
Review URL: https://codereview.chromium.org/390093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a build failure. I also did some refactoring.
This is a re-land that fixes a build error.
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281804
Review URL: https://codereview.chromium.org/376733006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ASan. (https://codereview.chromium.org/376733006/)
Reason for revert:
http://build.chromium.org/p/chromium.lkgr/builders/MSAN%20Release%20%28no%20origins%29/builds/41/steps/compile/logs/stdio
FAILED: cd ../../third_party/instrumented_libraries; ../../third_party/instrumented_libraries/download_build_install.py "--product-directory=../../out/Release" "--package=libappindicator1" "--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libappindicator1.gen" "--sanitizer-type=msan" "--extra-configure-flags=--disable-introspection" "--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE \"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\"" "--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\"" "--patch=" "--run-before-build=" "--cc=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/MSAN_Release__no_origins_/build/src/third_party/llvm-build/Release+Asserts/bin/clang" "--cxx=/mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/MSAN_Release__no_origins_/build/src/third_party/llvm-build/Release+Asserts/bin/clang++" "--jobs=1" "--build-method=destdir" "--sanitizer-blacklist=../../out/Release/../../tools/msan/blacklist.txt"
Traceback (most recent call last):
File "../../third_party/instrumented_libraries/download_build_install.py", line 366, in <module>
main()
File "../../third_party/instrumented_libraries/download_build_install.py", line 362, in main
download_build_install(parsed_arguments)
File "../../third_party/instrumented_libraries/download_build_install.py", line 262, in download_build_install
environment = build_environment(parsed_arguments, install_prefix)
File "../../third_party/instrumented_libraries/download_build_install.py", line 232, in build_environment
product_directory,
Original issue's description:
> Instrumented libraries: turn off leak detection when building with ASan.
>
> Fixes a build failure. I also did some refactoring.
>
> BUG=313751
> TBR=glider@chromium.org
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281804
TBR=glider@chromium.org,earthdok@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=313751
Review URL: https://codereview.chromium.org/380623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a build failure. I also did some refactoring.
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/376733006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to finally ditch the PREFIX build method.
BUG=313751
TBR=glider@chromium.org
NOTRY=true
TEST=MSan Chrome
Review URL: https://codereview.chromium.org/353193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- pass the patch as a command line argument to the build script, instead of
applying it through run_before_build,
- add each patch and run_before_build script to inputs for its corresponding
library,
- move patches and scripts to their own subdirectories,
- also, fix a small error in the build configuration for libappindicator1.
BUG=313751
R=glider@chromium.org
NOTRY=true
TEST=compile
Review URL: https://codereview.chromium.org/361473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Keep both the general and package-specific CFLAGS/LDFLAGS in the GYP file, and
pass only the final flags to the script. This allows us to simplify things
somewhat, as well as easily change the build flags based on GYP defines.
- Consequently, the global msan_track_origins GYP flag now also affects
instrumented libraries.
- I also threw in a mass renaming "library" -> "package".
BUG=313751
R=glider@chromium.org
NOTRY=true
TEST=MSan
Review URL: https://codereview.chromium.org/337613008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/332223003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/325253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The version script was being ignored in non-gcc (clang) builds.
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/315563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It somehow causes unresolved symbol errors when building other packages.
Let's see if we can skip instrumenting it without breaking MSan builds.
BUG=313751
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/308683010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=313751
TBR=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/309483005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273645 0039d316-1c4b-4281-b951-d872f2087c98
|