| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
prep_toolchain is now a no-op.
BUG=456902
Review URL: https://codereview.chromium.org/1097153002
Cr-Commit-Position: refs/heads/master@{#326044}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VC++ 2015 gives the following warning when compiling jsoncpp:
json_value.cpp(480): warning C4463: overflow; assigning 1 to bit-field
that can only hold values from -1 to 0
This warning is correct. A signed one-bit value can only hold 0 and -1.
This is true on gcc and clang, but only VC++ 2015 warns about it.
The code works because the stored value is never compared against 1 or
printed, but the current code is likely to cause surprises or bugs in the
future and should be fixed.
R=cpu@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1060383002
Cr-Commit-Position: refs/heads/master@{#325330}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change should be no-op. It simply changes the sha1
for jsoncpp to match the commit in the github repo rather
than the git-svn mirror we previously used. The sha1
differs simply because the git-svn metadata was not used
when they migrated to github. The tree contents are
identical (the two commits have the same tree sha1).
BUG=472809
Review URL: https://codereview.chromium.org/1069163002
Cr-Commit-Position: refs/heads/master@{#324477}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=N/A
TBR=pthatcher@chromium.org
CC=ronghuawu@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1066233002
Cr-Commit-Position: refs/heads/master@{#324135}
|
|
|
|
|
|
|
|
| |
BUG=N/A
Review URL: https://codereview.chromium.org/1066153002
Cr-Commit-Position: refs/heads/master@{#324124}
|
|
|
|
|
|
|
|
|
|
|
| |
For this first cl, it's only checking checked in code. I've had to add DEPS files to make it pass, since some of this code legitimately uses base etc...
BUG=469692
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/1045863002
Cr-Commit-Position: refs/heads/master@{#323302}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses gn binary at head.
No intended functionality change.
R=brettw@chromium.org
TBR=scherkus@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/779473002
Cr-Commit-Position: refs/heads/master@{#306567}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes webrtc/ Debug build with libc++ which failed to link std::getline
as this is defined in <istream>. <iostream> causes static initializers
and shouldn't be necessary.
Also adds to README.chromium that the overrides are used too get rid of
static initializers and to build on libc++.
R=thakis@chromium.org
TBR=ronghuawu@chromium.org
BUG=webrtc:3739
Review URL: https://codereview.chromium.org/552013004
Cr-Commit-Position: refs/heads/master@{#293954}
|
|
|
|
|
|
|
|
|
|
| |
BUG=webrtc:3441
TEST=Successful build with WebRTC, see
https://review.webrtc.org/17669004/ for details.
Review URL: https://codereview.chromium.org/322373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/291803003/)
Reason for revert:
This adds a static initializer.
Original issue's description:
> Unconditionally include <string> and <iostream> in json_reader.cpp
> Non-PNaCl builds that use libc++ also require these headers.
>
> BUG=None
> R=mallinath@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271429
TBR=mallinath@chromium.org,ronghuawu@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/290923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Non-PNaCl builds that use libc++ also require these headers.
BUG=None
R=mallinath@chromium.org
Review URL: https://codereview.chromium.org/291803003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously NaCl targets were using _untrusted suffix which makes the
purpose of these targets hard to understand. This CL renames some targets in src/third_party.
Also removed toolsets field from modp_b64_nacl.gyp
Review URL: https://codereview.chromium.org/138673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r12489: (jfb) Build libc++/libc++abi with HAS_THREAD_LOCAL
r12490: (jvoung) PNaCl: Update LLVM test suite revision in pnacl/COMPONENT_REVISIONS
r12491: (jvoung) Add dashy repos (llvm-test-suite) to pnacl/deps_update.py
r12492: (mseaborn) Add tests for C++ exception types that use virtual base classes
r12493: (jfb) Update TOOL_REVISIONS for PNaCl 12483->12489
r12494: (mseaborn) PNaCl: Update libcxxabi revision in pnacl/COMPONENT_REVISIONS: SJLJ EH support
r12495: (jfb) Mark faultqueue test as broken on ARM.
r12496: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r12497: (mseaborn) Update PNaCl toolchain revision to r12494 to get SJLJ EH support for libc++
This pulls in libc++ as the default standard C++ library for PNaCl and allows SJLJ EH to work with libc++.
This also fixes out-of-bounds std::map access in nacl_io testing, and correspondingly broken test. All used pass because libstdc++ just happened to return the expected value when out-of-bounds, but libc++ doesn't return the same thing and the tests now appeared broken.
BUG=none
TEST=nacl_integration
R=binji@chromium.org, dschuff@chromium.org, ronghuawu@chromium.org
Review URL: https://codereview.chromium.org/98713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=316353
R=mallinath@chromium.org,ronghuawu@chromium.org
CC=bradnelson@chromium.org,dmazzoni@chromium.org,dtseng@chromium.org,aboxhall@chromium.org
Review URL: https://codereview.chromium.org/62953015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=109997,https://code.google.com/p/webrtc/issues/detail?id=1777
Review URL: https://codereview.chromium.org/24984004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=mallinath@chromium.org, parisa@chromium.org
Review URL: https://codereview.chromium.org/16691006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes use_system_foo logic completely from:
* jsoncpp.gyp
* libevent.gyp
* libpng.gyp
* libusb.gyp
* libwebp.gyp
* opus.gyp
* re2.gyp
* zlib.gyp
R=rsleevi
TBR=darin
BUG=226860
Review URL: https://codereview.chromium.org/14203006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it consistent with convention on Debian, Ubuntu,
Arch, and Gentoo (after https://bugs.gentoo.org/show_bug.cgi?id=452234
gets fixed).
R=ronghuawu
TBR=darin
BUG=none
Review URL: https://codereview.chromium.org/12294017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11737009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
initialization caused by the global variable Value::null.
BUG=109997
TEST=unittests
Review URL: http://codereview.chromium.org/9188042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The jsoncpp is needed by libjingle as part of the webrtc effort. This patch probably not be the best solution as there's already one chrome json parser in base and another jsoncpp copy in native_client. However since the libjingle can depend on neither of them, here comes this patch. We hope to take this patch as a chance to get some advices on how should we handle this case.
BUGS=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106424
Review URL: http://codereview.chromium.org/8251003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
82>svn: PROPFIND of '/svnroot/jsoncpp/trunk/jsoncpp': Server certificate verification failed: issuer is not trusted (https://jsoncpp.svn.sourceforge.net)
on most mac bots, which causes full re-checkouts of all files on every build.
- Add jsoncpp in DEPS and the gyp file to build jsoncpp in chromium.
The jsoncpp is needed by libjingle as part of the webrtc effort. This patch probably not be the best solution as there's already one chrome json parser in base and another jsoncpp copy in native_client. However since the libjingle can depend on neither of them, here comes this patch. We hope to take this patch as a chance to get some advices on how should we handle this case.
BUGS=none
TEST=none
Review URL: http://codereview.chromium.org/8251003
TBR=ronghuawu@google.com
Review URL: http://codereview.chromium.org/8353030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
The jsoncpp is needed by libjingle as part of the webrtc effort. This patch probably not be the best solution as there's already one chrome json parser in base and another jsoncpp copy in native_client. However since the libjingle can depend on neither of them, here comes this patch. We hope to take this patch as a chance to get some advices on how should we handle this case.
BUGS=none
TEST=none
Review URL: http://codereview.chromium.org/8251003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106424 0039d316-1c4b-4281-b951-d872f2087c98
|