| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The purpose of this finch experiment is to determine the proper stun request interval as it has major impact on the time taken to establish end to end connectivity. Currently, 50ms is used and it could take seconds for a call to finish connecting. The experiment is to use sockets (up to 10) which each is used to send all resolved stun server IPs (up to 3). All stun probing is scheduled sequentially with various intervals (from 5ms to 50ms at 5ms step). The observation is the overall success rate, the latency of the request/response roundtrip as well as the type of NAT observed.
Here is the high level design
1. The browser process will receive the finch experiment parameters and the first renderer will receive these parameters through command line.
2. The renderer will then use IpcPacketSocket to conduct this experiment.
3. During the experiment, the worker thread in renderer will wake up at 1ms interval and send stun request when time comes. It takes no more than (100 ms X 30 ping) = 3 second to finish the whole process.
Design Doc updated at https://docs.google.com/document/d/11zruojoNqZgZYDrSVk0O3JHqFz2cFldWYQbroZdZRBg/edit#heading=h.t7npdccia97t
This is based on ongoing webrtc CL
https://codereview.webrtc.org/1173353002
BUG=webrtc:4576
Review URL: https://codereview.chromium.org/1168443004
Cr-Commit-Position: refs/heads/master@{#335572}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 9407:9413
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/53e1dff..e0cc456
Libjingle 9404:9415
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/9b056ad..8538c30
R=tommi@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1176313004
Cr-Commit-Position: refs/heads/master@{#333916}
|
|
|
|
|
|
|
|
|
|
|
| |
This file is empty and no longer needs to be built.
BUG=webrtc:1695
R=tommi@chromium.org
Review URL: https://codereview.chromium.org/1156043004
Cr-Commit-Position: refs/heads/master@{#331771}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 9283:9297
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/0bc1079..fae9521
Libjingle 9281:9294
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/12875f4..d887df7
TBR=hbos@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1146283007
Cr-Commit-Position: refs/heads/master@{#331662}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The header file webrtcvie.h was removed with
https://webrtc-codereview.appspot.com/55379004 and the file
webrtcvideoengine.h was removed shortly after with
https://webrtc-codereview.appspot.com/48339004 . Now that these
changes have rolled into Chromium, these files should be removed
from the build.
Review URL: https://codereview.chromium.org/1157773007
Cr-Commit-Position: refs/heads/master@{#331655}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, //content/test:test_support depended directly on *_sources
targets. In component builds, this caused the browser_tests and
content_browsertests binaries to include their own copies of content as
well as depend on libcontent.so. This caused browser_tests and
content_browsertests to crash on startup. This CL changes test_support
to depend on the targets that forward to //content in component builds
and introduces such targets for gpu and ppapi_plugin.
The test_support changes also exposed underspecified dependencies in
extensions/renderer/BUILD.gn and third_party/libjingle/BUILD.gn, and
incorrect generated file dependencies in content/browser/devtools; the
generated files depend on other non-generated files so have to be
directly included in //content/browser.
BUG=432959
Review URL: https://codereview.chromium.org/1104973002
Cr-Commit-Position: refs/heads/master@{#327188}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains several fixes needed to make the ChromeOS GN debug component build link.
R=brettw@chromium.org, erg@chromium.org, garykac@chromium.org, kjellander@chromium.org
BUG=433082
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg;tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1054963007
Cr-Commit-Position: refs/heads/master@{#327164}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It breaks integration with upstream re2 library on Chromium.
Without patching re2 library, with this define, it produces the
following error:
../../third_party/re2/re2/re2.h:254:5: error: expected identifier
POSIX, // POSIX syntax, leftmost-longest match
As we define POSIX on the command line, the C preprocessor changes
RE2::POSIX to nothing and thus break the compilation. :(
See chromium-dev mailing list for this discussion in
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/UXCHnX7pV44/discussion
BUG=None
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/1096693003
Cr-Commit-Position: refs/heads/master@{#326229}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 8989:8999
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/5ffd4ec..b74b769
Libjingle 8990:8994
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/d872289..2a568fa
And remove some deleted files from build files.
TBR=
BUG=
Review URL: https://codereview.chromium.org/1057653005
Cr-Commit-Position: refs/heads/master@{#325203}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
public_configs is the non-deprecated name of direct_dependent_configs.
BUG=None
TEST=gn gen out-gn
R=kjellander@chromium.org
TBR=behdad@chromium.org
Review URL: https://codereview.chromium.org/1031243004
Cr-Commit-Position: refs/heads/master@{#323665}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 8622:8643
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/235b9ab..d6bd5e2
Libjingle 8616:8639
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3f3cd14..c9f4c13
TBR=
Review URL: https://codereview.chromium.org/980393005
Cr-Commit-Position: refs/heads/master@{#319569}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not used any longer.
Was added in https://codereview.chromium.org/551793003/ as temporary solution to use WebRTC from android service.
In following CLs we've moved to native API:
https://codereview.chromium.org/704613003
https://codereview.chromium.org/716433003
https://codereview.chromium.org/719043002
https://codereview.chromium.org/734313002
There is no plan to use Java API for DevTools bridge again.
BUG=383418
Review URL: https://codereview.chromium.org/982563002
Cr-Commit-Position: refs/heads/master@{#319106}
|
|
|
|
|
|
|
|
|
| |
TBR=tommi@chromium.org
BUG=
Review URL: https://codereview.chromium.org/978683002
Cr-Commit-Position: refs/heads/master@{#318982}
|
|
|
|
|
|
|
|
|
|
| |
R=kjellander@chromium.org, brettw@chromium.org
BUG=456815
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/912633003
Cr-Commit-Position: refs/heads/master@{#317929}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The latest GN binaries rename cpu_arch to current_cpu and/or target_cpu
as appropriate, build_cpu_arch to host_cpu, and os to current_os and target_os as appropriate.
R=brettw@chromium.org
TBR=ddorwin@chromium.org
EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
BUG=344767
Review URL: https://codereview.chromium.org/913373002
Cr-Commit-Position: refs/heads/master@{#317223}
|
|
|
|
|
|
|
|
|
|
| |
This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.
Minor updates to Win64 build, including some fixes for size_t to int conversions.
Review URL: https://codereview.chromium.org/929793006
Cr-Commit-Position: refs/heads/master@{#317162}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The target was renamed in GYP a while back
and in https://code.google.com/p/webrtc/source/detail?r=8117
for GN. This is the last reference left using the
'webrtc_base' target name.
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/868573003
Cr-Commit-Position: refs/heads/master@{#313100}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/829373002
Cr-Commit-Position: refs/heads/master@{#310251}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 7853:7864
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/6c79878..764bd22
Libjingle 7854:7860
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/8da17a9..e2d3246
R=pbos@chromium.org, tommi@chromium.org
Review URL: https://codereview.chromium.org/795583002
Cr-Commit-Position: refs/heads/master@{#307706}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses gn binary at head.
No intended functionality change.
R=brettw@chromium.org
TBR=scherkus@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/779473002
Cr-Commit-Position: refs/heads/master@{#306567}
|
|
|
|
|
|
|
|
| |
This CL can be commited when the next roll for libjingle includes an empty videoframefactory.cc. Then the real change in webrtc with the real implementation of videoframefactory.cc can be implemented and rolled without breaking Chromium.
Review URL: https://codereview.chromium.org/727243004
Cr-Commit-Position: refs/heads/master@{#304808}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webrtc::AudioProcessing in Chrome (patchset #4 id:60001 of https://codereview.chromium.org/663413002/)
Reason for revert:
This CL broke the configuration of AudioProcessing, we have to revert it to fix the echo issues it introduces.
Original issue's description:
> Reland 597923002: Fix the way how we create webrtc::AudioProcessing in Chrome.
>
> The original review thread is in https://codereview.chromium.org/588523002/
>
> Fix the way how we create webrtc::AudioProcessing in Chrome.
>
> TBR=tommi@chromium.org,maruel@chromium.org
>
> BUG=415935
> TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.
>
> Committed: https://crrev.com/79ef9085fbdbc8e09ac989ea4d5f4c28e516bba9
> Cr-Commit-Position: refs/heads/master@{#300509}
TBR=maruel@chromium.org,tommi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415935
Review URL: https://codereview.chromium.org/717203002
Cr-Commit-Position: refs/heads/master@{#303834}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=hellner@chromium.org
NOTRY=true
BUG=N/A
Committed: https://crrev.com/4e40bbe50a102784984852ca318dbcd2b03fc9fc
Cr-Commit-Position: refs/heads/master@{#301879}
Review URL: https://codereview.chromium.org/653203005
Cr-Commit-Position: refs/heads/master@{#302260}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4e40bbe50a102784984852ca318dbcd2b03fc9fc.
Appears to cause timeouts on Mac 10.6/10.7 tests.
BUG=N/A
Review URL: https://codereview.chromium.org/688723002
Cr-Commit-Position: refs/heads/master@{#301911}
|
|
|
|
|
|
|
|
|
|
| |
TBR=hellner@chromium.org
NOTRY=true
BUG=N/A
Review URL: https://codereview.chromium.org/653203005
Cr-Commit-Position: refs/heads/master@{#301879}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original review thread is in https://codereview.chromium.org/588523002/
Fix the way how we create webrtc::AudioProcessing in Chrome.
TBR=tommi@chromium.org,maruel@chromium.org
BUG=415935
TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.
Review URL: https://codereview.chromium.org/663413002
Cr-Commit-Position: refs/heads/master@{#300509}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=383418
TEST=Build target libjingle_peerconnection_javalib
Committed: https://crrev.com/e65a8cbe2e8b0634a66715b3959b418431f4d0c0
Cr-Commit-Position: refs/heads/master@{#297801}
Committed: https://crrev.com/0d8b69077ac03b7ea176d9df6f3730fe7a63a499
Cr-Commit-Position: refs/heads/master@{#298073}
Review URL: https://codereview.chromium.org/551793003
Cr-Commit-Position: refs/heads/master@{#298819}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:120001 of https://codereview.chromium.org/551793003/)
Reason for revert:
Speculative revert, breaking official win builders.
Original issue's description:
> Making WebRTC Java api avaliable in Chromium.
>
> BUG=383418
> TEST=Build target libjingle_peerconnection_javalib
>
> Committed: https://crrev.com/e65a8cbe2e8b0634a66715b3959b418431f4d0c0
> Cr-Commit-Position: refs/heads/master@{#297801}
>
> Committed: https://crrev.com/0d8b69077ac03b7ea176d9df6f3730fe7a63a499
> Cr-Commit-Position: refs/heads/master@{#298073}
TBR=hellner@chromium.org,kjellander@chromium.org,serya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418
Review URL: https://codereview.chromium.org/620373003
Cr-Commit-Position: refs/heads/master@{#298119}
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=383418
TEST=Build target libjingle_peerconnection_javalib
Committed: https://crrev.com/e65a8cbe2e8b0634a66715b3959b418431f4d0c0
Cr-Commit-Position: refs/heads/master@{#297801}
Review URL: https://codereview.chromium.org/551793003
Cr-Commit-Position: refs/heads/master@{#298073}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:100001 of https://codereview.chromium.org/551793003/)
Reason for revert:
This CL breaks official Chrome.
Original issue's description:
> Making WebRTC Java api avaliable in Chromium.
>
> BUG=383418
> TEST=Build target libjingle_peerconnection_javalib
>
> Committed: https://crrev.com/e65a8cbe2e8b0634a66715b3959b418431f4d0c0
> Cr-Commit-Position: refs/heads/master@{#297801}
TBR=hellner@chromium.org,kjellander@chromium.org,serya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418
Review URL: https://codereview.chromium.org/614263007
Cr-Commit-Position: refs/heads/master@{#297816}
|
|
|
|
|
|
|
|
|
| |
BUG=383418
TEST=Build target libjingle_peerconnection_javalib
Review URL: https://codereview.chromium.org/551793003
Cr-Commit-Position: refs/heads/master@{#297801}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webrtc::AudioProcessing in Chrome (patchset #5 id:80001 of https://codereview.chromium.org/597923002/)
Reason for revert:
It fails some aec dump content browser tests on windows, and likely it also breaks the aec dump production code, it is safer to revert it since cut happens today.
http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester/builds/9752/steps/content_browsertests/logs/stdio
Original issue's description:
> The original review thread is in https://codereview.chromium.org/588523002/
>
> Fix the way how we create webrtc::AudioProcessing in Chrome.
>
> TBR=tommi@chromium.org
>
> BUG=415935
> TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5ac9f35c3e5d9781a01769f3f0d0433026c57de7
TBR=tommi@chromium.org,jochen@chromium.org,maruel@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415935
Review URL: https://codereview.chromium.org/611493002
Cr-Commit-Position: refs/heads/master@{#296933}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the way how we create webrtc::AudioProcessing in Chrome.
TBR=tommi@chromium.org
BUG=415935
TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.
Review URL: https://codereview.chromium.org/597923002
Cr-Commit-Position: refs/heads/master@{#296709}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name. It has the same meaning but additionally with a "you can use the headers" permission.
Rename direct_dependent_configs to public_configs. This is the new name with identical meaning.
TBR=jamesr
Review URL: https://codereview.chromium.org/595073002
Cr-Commit-Position: refs/heads/master@{#296302}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #5 id:100001 of https://codereview.chromium.org/588523002/)
Reason for revert:
It broke some internal webrtc bots, revert it for now and will reland it after fixing the problems.
http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Mac%20Tester/builds/22092
Original issue's description:
> Fix the way how we create webrtc::AudioProcessing in Chrome.
>
> BUG=415935
> TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.
>
> Committed: https://crrev.com/a5e9fc62b7bf25931ffe6153cc738098d8119c28
> Cr-Commit-Position: refs/heads/master@{#295990}
TBR=tommi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415935
Review URL: https://codereview.chromium.org/594883002
Cr-Commit-Position: refs/heads/master@{#296191}
|
|
|
|
|
|
|
|
|
| |
BUG=415935
TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist.
Review URL: https://codereview.chromium.org/588523002
Cr-Commit-Position: refs/heads/master@{#295990}
|
|
|
|
|
|
|
|
|
|
| |
With some changes in libvpx and webrtc, plus this change, we should be able to enable webrtc in the GN build.
R=hclam@chromium.org
Review URL: https://codereview.chromium.org/583353002
Cr-Commit-Position: refs/heads/master@{#295784}
|
|
|
|
|
|
|
|
|
|
|
| |
Remove explicitly depending on a webrtc config now that it is correctly
exported from webrtc.
R=kjellander@chromium.org
Review URL: https://codereview.chromium.org/534813002
Cr-Commit-Position: refs/heads/master@{#294424}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add usrsctp. Make Windows version configurable for this in the build.
direct_dependent_configs for libsrtp.
R=hclam@chromium.org
Review URL: https://codereview.chromium.org/534713003
Cr-Commit-Position: refs/heads/master@{#293004}
|
|
|
|
|
|
|
|
|
|
| |
This fixes all non-RTC-related linker errors for Chrome.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/533743004
Cr-Commit-Position: refs/heads/master@{#292978}
|
|
|
|
|
|
|
|
|
|
| |
See here: https://codereview.chromium.org/516143002/
TBR=ajm
Review URL: https://codereview.chromium.org/523073003
Cr-Commit-Position: refs/heads/master@{#292792}
|
|
|
|
|
|
|
|
| |
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/498393002
Cr-Commit-Position: refs/heads/master@{#291749}
|
|
Reimplements parts of //third_party/libjingle's build in GN.
The new build is much less flexible than the original. No
configuration variables have been ported. Some windows-specific configs
have been left out and annotated with TODOs. Most signifcantly, the
entirety of the 'if (enable_webrtc)' block has been omitted, because the
GN build for webrtc isn't working yet.
Despite these limitations, it is an adequate replacement for the
'stub' libjingle target in most situations.
Note, this CL is a near direct copy of rlarocque's work at
https://codereview.chromium.org/455583002/
BUG=none
TBR=sky,pavely,rlarocque
Review URL: https://codereview.chromium.org/498603002
Cr-Commit-Position: refs/heads/master@{#291587}
|