| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also changes libphonenumber.gyp. A separate library with no metadata needs
to be built. This allows us to build a production library with production
metadata and the unit tests with testing metadata. Before that it was unclear
which metadata was used for testing.
TEST=libphonenumber_unittests
Review URL: https://chromiumcodereview.appspot.com/10412031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For more context see: https://chromiumcodereview.appspot.com/10187020/
BUG=125390
TEST=phone_number_detector_unittest.cc
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139019
Review URL: https://chromiumcodereview.appspot.com/10440021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For more context see: https://chromiumcodereview.appspot.com/10187020/
BUG=125390
TEST=phone_number_detector_unittest.cc
Review URL: https://chromiumcodereview.appspot.com/10440021
TBR=leandrogracia@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10453025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For more context see: https://chromiumcodereview.appspot.com/10187020/
BUG=125390
TEST=phone_number_detector_unittest.cc
Review URL: https://chromiumcodereview.appspot.com/10440021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make all the places that include run_all_unittests.cc manually depend
on this target instead.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9691067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=libphonenumber_unittests
Review URL: https://chromiumcodereview.appspot.com/9330002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
revision=112305
The difference is the phone library pulled is version 407 instead of 403, it includes fixes, including missing licenses.
Original description: Pull the phone library directly. Delete old version.
TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8790002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8736001
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/8762016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version.
TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8736001
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/8759004
TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/8757005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8736001
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/8759004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=unit-tests
BUG=105577
Review URL: http://codereview.chromium.org/8736001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is not a third party file.
On my machine, this speeds up a full recompile of the 'chrome' target
in Debug mode by about 18%.
BUG=none
TEST=it builds, existing tests pass
Review URL: http://codereview.chromium.org/7706011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Just a refactoring.
Retry of r97486 (which didn't work under clobber builds).
Review URL: http://codereview.chromium.org/7671054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r97486. Build failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Just a refactoring.
Review URL: http://codereview.chromium.org/7671054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=multiple built in and chrome unit-tests.
Review URL: http://codereview.chromium.org/7277030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
They would conflict with system icu include dirs if use_system_icu=1.
Should automatically use direct_dependent_settings in icu.gyp.
Also removed explicit include_dirs for protobuf.
BUG=85509
Review URL: http://codereview.chromium.org/7003081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We provided <(library) as a variable to support a peculiar
build configuration on Linux. We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.
Review URL: http://codereview.chromium.org/7051014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build:
Autofill phone number enhancements and integration of Phone Number Util Library: part 1
Temporarily the whole library is included, until the patch is upstreamed.
BUG=71443
TEST=Unit-tested
Review URL: http://codereview.chromium.org/6930013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Number Util Library: part 1
Temporarily the whole library is included, until the patch is upstreamed.
BUG=71443
TEST=Unit-tested
Review URL: http://codereview.chromium.org/6803005
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/6920006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Library: part 1
Temporarily the whole library is included, until the patch is upstreamed.
BUG=71443
TEST=Unit-tested
Review URL: http://codereview.chromium.org/6803005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84000 0039d316-1c4b-4281-b951-d872f2087c98
|