| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build 64-bit version of chrome using 64-bit chromeos sysroot
Review URL: http://codereview.chromium.org/9654001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=30339
TEST=Added new unit tests: --gtest_filter=PNGCodec.*. For a manual test, load
up the second test theme attached to the referenced bug (comment #10).
Review URL: http://codereview.chromium.org/9496004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=116162
Review URL: http://codereview.chromium.org/9546033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
component builds. On all other platforms, build it as a static_library.
BUG=none
TEST=it compiles on linux shared bots
Review URL: https://chromiumcodereview.appspot.com/9370014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for ChromeOS. It's worth noting that we also don't use the system library
for many other important components such as libxml.
BUG=112822
R=wad,abarth
Review URL: https://chromiumcodereview.appspot.com/9365007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
maintenance problems
for ChromeOS. It's worth noting that we also don't use the system library
for many other important components such as libxml.
Reverting due to compile errors on Linux:
http://chromegw.corp.google.com/i/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/17665/steps/compile/logs/stdio
BUG=112822
Review URL: http://codereview.chromium.org/9365007
TBR=cevans@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9374001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for ChromeOS. It's worth noting that we also don't use the system library
for many other important components such as libxml.
BUG=112822
Review URL: http://codereview.chromium.org/9365007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=112822
Review URL: http://codereview.chromium.org/9363013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, the default defined in libpng.gyp is to use the system's
libpng for Android, while we want to build this from source.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8486008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new webkit_support_gfx, used by DumpRenderTree and ImageDiff,
doesn't depend on most other parts of chromium. This could make building
the individual target of ImageDiff fast. It's implemented by duplicating
most code in ui/gfx/codec/png_codec.cc, after removing code related to
Skia.
This change is required to make ImageDiff for Android, and can benefit
other platforms, too. On Android, most targets are built for
toolsets:target. while ImageDiff needs to be build for toolsets:host.
Currently, building the standalone target of ImageDiff depends on about
85 other targets (try 'make ImageDiff'), which is inefficient. After the
change, ImageDiff only depends on webkit_support_gfx, libpng, and
zlib.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8226018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It is not actually supported by gyp; the fact that it works is a bug
that I am working on fixing.
BUG=96629
Review URL: http://codereview.chromium.org/7889051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the result of applying the diff from upstream's 1.2.44 -> 1.2.45. I
didn't use upstream's provided diff because it's clearly wrong.
BUG=89898
TEST=none
Review URL: http://codereview.chromium.org/7464050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28727
Review URL: http://codereview.chromium.org/7146001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
toolkit_uses_gtk, os_posix, and use_x11. For lists of source files that use a mix of POSIX and Gtk APIs, toolkit_uses_gtk was given precedence. Solaris was made to use ALSA also, as libasound has been ported to FreeBSD and Solaris as a wrapper around the native OSS.
Review URL: http://codereview.chromium.org/7055003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enables [wk_]png_get_image_width, [wk_]png_get_image_height, and
[wk_]png_get_interlace_type, required for
https://bugs.webkit.org/show_bug.cgi?id=54406.
This is needed to allow WebKit to build with libpng 1.5, which no longer allows
direct access to the underlying struct members without using the "easy access"
accessors.
BUG=webkit:54406
TEST=That patch can land without breaking Chromium
Review URL: http://codereview.chromium.org/6708113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'm going to use this to write layout test checksums to the
expected png files.
Review URL: http://codereview.chromium.org/6696085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The next step is a presubmit rule that will make people use the template.
We are doing this so that we can better track dependancy versions.
BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6610030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Defined PNG_NO_READ_SWAP, PNG_NO_WRITE_SWAP, PNG_NO_READ_oFFs, PNG_NO_WRITE_oFFs,
PNG_NO_USER_LIMITS, PNG_NO_SET_USER_LIMITS, PNG_NO_TIME_RFC1123.
Clarified that PNG_NO_INFO_IMAGE, PNG_NO_PROGRESSIVE_READ are undefined.
Used PNG_NO_SEQUENTIAL_READ instead of PNG_NO_SEQUENTIAL_READ_SUPPORTED.
Defined PNG_NO_WRITE_gAMA, PNG_NO_WRITE_sRGB.
Clarified that PNG_NO_READ_gAMA and PNG_NO_READ_sRGB are undefined
(i.e. gAMA and sRGB are retrieved by libpng, along with iCCP).
Fixed typo in the mangling of png_set_text_2.
Renamed the prefix webkit_ to wk_ in mangled names.
Restored the full function name in mangling; e.g., png_create_read_struct
is mangled as wk_png_create_read_struct instead of wk_png_cr_read_str.
Added mangling for all symbols with external linkage that are never macros.
Added explicit #undef for symbols that may sometimes be macros in png.h:
png_benign_error, png_chunk_benign_error, png_get_int_32, png_get_uint_16,
png_get_uint_32, png_info_init, png_read_init, png_write_init.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5689001
Patch from Cosmin Truta <ctruta@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pkasting
http://codereview.chromium.org/4060002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit r64079. The perf regression turned out not to be the fault
of the libpng change.
BUG=60942
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit r63744. This is a preemptive revert due to a perf
regresssion as it's easier to revert this then a WebKit roll.
BUG=60942
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r50937 updated the important bits of libpng to 1.2.44 but missed a few
files. This change reduces the diffs between the upstream 1.2.44 and
our copy to nothing (for *.c *.h).
TEST=none
BUG=none
TBR=mhm
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3053011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
According to libpng website, this will solve the vulnerability ID CVE-2010-1205.
BUG=47633
TEST=None
Review URL: http://codereview.chromium.org/2835021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1480002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Allow special cases in licenses.py for when we pull code directly
from an upstream and can't check in a README.chromium. (In particular,
we'll need this for WebKit.)
Review URL: http://codereview.chromium.org/1075015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I unpacked libpng 1.2.43 and did:
cd third_party/libpng
for x in $(ls -1) ; do cp /tmp/libpng-1.2.43/$x .; done
The diffs appear to all be safe. The Chromium specific config is in pngusr.h
and isn't touched by this change.
1.2.43 fixes http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-0205
c7013d773eb45b8ed6a864e419e544106a0dd95d /tmp/libpng-1.2.43.tar.xz
BUG=38512
TEST=none
http://codereview.chromium.org/1118002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8042
TEST=None
Review URL: http://codereview.chromium.org/567033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/486039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp files.
Retrying r34195, this time without libxslt, since we don't want to use the
system version of that if we're not also using system libxml (merged from
http://codereview.chromium.org/481011).
BUG=29738
Review URL: http://codereview.chromium.org/486012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the relevant gyp files.
BUG=29738
Review URL: http://codereview.chromium.org/479005
TBR=mmoss@google.com
Example choke:
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Perf/builds/4382/steps/compile/logs/stdio
Compiling /b/slave/chromium-rel-linux-hardy/build/src/sconsbuild/Release/obj/chrome/unit_tests/common/bzip2_unittest.o
/b/slave/chromium-rel-linux-hardy/build/src/chrome/common/bzip2_unittest.cc:6:19: error: bzlib.h: No such file or directory
Review URL: http://codereview.chromium.org/484003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
gyp files.
BUG=29738
Review URL: http://codereview.chromium.org/479005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_png_*; however, it missed one: png_write_destroy. This change adds renaming for that function.
The file _does_ rename png_read_destroy, as well as other png_write_* functions, so the omission would seem to be an oversight (presumably going back to WebKit) rather than a deliberate choice. Since browers don't generally need to write PNGs, this probably hasn't caused problems before. However, it is causing problems for me now because I am trying to write a Firefox plugin that links in (among other things) the Chromium libpng; because neither Firefox nor Chromium renames the png_write_destroy function, there is a conflict between Firefox's libpng and the one I'm trying to link in. This patch solves the issue for me.
BUG=none
TEST=none
Patch contributed by Matthew Steele
Review URL: http://codereview.chromium.org/374016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When building with use_system_libpng, the build will end up using the
png.h from third_party because I put the defines stanza in the wrong
place.
(reported by fta)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It turns out that 'settings' is the correct GYP target type for this
sort of thing. Thanks to Evan for pointing out my mistake.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since our packagers have been requesting that we support using more
system libraries, I'm starting to commit these sorts of changes.
However, please note that one MUST NOT use the system libpng on, at
least, Ubuntu 64-bit. Because Chromium on Linux is still a 32-bit
build we end up with the 32-bit compat versions of libraries and, on
Ubuntu at least, this includes a very old libpng with security issues.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the PNG library, and it turns on some functionality that O3D needs for manipulating PNG files: It removes the definition of PNG_NO_WRITE_FILLER, PNG_NO_READ_FILLER, PNG_NO_SEQUENTIAL_READ_SUPPORTED, and PNG_NO_INFO_IMAGE from pngusr.h so that the functions used by O3D to read images progressively and for filler bytes for pixel expansion (RGB -> RGBX) are available.
BUG=none
TEST=successful trybot run for all platforms.
Review URL: http://codereview.chromium.org/140074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a new version of libpng, 1.2.36 which fixes a security bug. Chrome/Chromium still runs on 1.2.35 it seems
BUG=13046
TEST=Ran tests
Review URL: http://codereview.chromium.org/112080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
parameterize the 'type' setting of the various library targets, with a
default of 'static_library'.
(Hat tip to Craig Schlenter.)
Review URL: http://codereview.chromium.org/62127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes propset changes:
Property changes on: C:\clients\chrome6\src\skia
___________________________________________________________________
Modified: svn:ignore
- skia.xcodeproj
+ skia.xcodeproj
skia.sln
Property changes on: C:\clients\chrome6\src\third_party\zlib
___________________________________________________________________
Modified: svn:ignore
- zlib.xcodeproj
+ zlib.xcodeproj
zlib.sln
Property changes on: C:\clients\chrome6\src\third_party\libpng
___________________________________________________________________
Modified: svn:ignore
- libpng.xcodeproj
+ libpng.xcodeproj
libpng.sln
Property changes on: C:\clients\chrome6\src\third_party\libjpeg
___________________________________________________________________
Modified: svn:ignore
- libjpeg.xcodeproj
+ libjpeg.xcodeproj
libjpeg.sln
Property changes on: C:\clients\chrome6\src\build
___________________________________________________________________
Modified: svn:ignore
- all.xcodeproj
+ all.xcodeproj
all.sln
All.vcproj
Property changes on: C:\clients\chrome6\src\base
___________________________________________________________________
Modified: svn:ignore
- base.xcodeproj
+ base.xcodeproj
base.vcproj
base_gfx.vcproj
base_unittests.vcproj
debug_message.vcproj
Property changes on: C:\clients\chrome6\src\testing
___________________________________________________________________
Modified: svn:ignore
- gtest
gtest.xcodeproj
+ gtest
gtest.xcodeproj
gtest.sln
Review URL: http://codereview.chromium.org/43101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke the build last time. Trying it again, this time with clobber.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Attempt to roll gyp out for base.
The gyp script is not getting called at the right time to make this work.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Convert the Mac build to the new GYP-based Xcode build, and remove the old
Xcode projects.
Review URL: http://codereview.chromium.org/28305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10693 0039d316-1c4b-4281-b951-d872f2087c98
|