| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=238755
Review URL: https://chromiumcodereview.appspot.com/18586007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android includes a fix to asm/posix_types.h inside
/ndk/toolchains/x86-4.7/prebuilt/linux-x86_64/lib/gcc/
i686-linux-android/4.7/include-fixed/asm/posix_types.h. That
file include_next's the real asm/posix_types.h, but then fixes
(redefines) the __FD_ZERO macro. However, it also includes
features.h, which unconditionally defines _GNU_SOURCE.
src/glsl/strtod.c assumes that if the _GNU_SOURCE macro is defined,
that it can use locale_t, which isn't available on Android.
BUG=238755
R=kbr@chromium.org, senorblanco@chromium.org, marcheu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18582004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL depends on
https://codereview.chromium.org/18570002/
BUG=238755
R=kbr@chromium.org, senorblanco@chromium.org, marcheu@chromium.org,
Review URL: https://chromiumcodereview.appspot.com/18125009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/18460002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=kbr@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/18459002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=238755
R=apatrick@chromium.org, nduca@chromium.org
Review URL: https://codereview.chromium.org/17005007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This target is making the Mesa upgrade (7 -> 9) difficult. It turns
out that this code isn't used in the first place
BUG=238755
R=binji@chromium.org, dmichael@chromium.org, dpranke@chromium.org, kbr@chromium.org
Review URL: https://codereview.chromium.org/16927004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r207892 - build failure on Linux x64.
TBR=kbr@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/16915005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Try again w/ gyp fix.
TBR=kbr@chromium.org, mymax@amazon.com
BUG=238755
Review URL: https://codereview.chromium.org/17115014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Compile failure on Linux ... not sure why this wasn't caught before.
TBR=kbr@chromium.org
BUG=238755
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch landed on behalf of mymax@amazon.com. OWNERS approvals are in
https://chromiumcodereview.appspot.com/17005007/ . Try jobs (w/o binaries)
are in https://chromiumcodereview.appspot.com/17422003/ .
TBR=kbr@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/17341003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=238755
Review URL: https://chromiumcodereview.appspot.com/16129008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change updates the ndk sources and toolchain to r8e
http://developer.android.com/tools/sdk/ndk/index.html
Also patching in https://chromiumcodereview.appspot.com/14840008/ to disable sincos optimization in third_party/mesa/
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14860010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=apatrick@chromium.org
BUG=143877,167187
Review URL: https://chromiumcodereview.appspot.com/14131003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was found by experimenting with a new Clang warning.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12662026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The optimized versions producd slightly different results than the un-optimized
versions (used when DEBUG is defined). This caused inconsistent
test results.
BUG=181712
Review URL: https://chromiumcodereview.appspot.com/12764015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/12736003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of try run with flag enabled as warning:
On linux_clang, there's false positives from a bunch of assert usage that does !"string" or "string" for a true or false value. It's only in third_party (Mesa, skia, libjingle, etc.) so it probably wouldn't be too hard to disable the warnings in those subtrees.
It diagnoses 4 useful locations:
1.
../../base/debug/trace_event_unittest.cc:70:41: warning: implicit conversion turns string literal into bool: 'const char [2]' to 'bool' [-Wstring-conversion]
TraceLog::GetInstance()->SetEnabled("*");
~~~~~~~~ ^~~
2.
../../sync/syncable/entry_kernel.cc:77:38: warning: implicit conversion turns string literal into bool: 'const char [5]' to 'bool' [-Wstring-conversion]
value->SetBoolean("encrypted", "true");
~~~~~ ^~~~~~
3.
../../chrome/browser/webdata/web_data_service.cc:334:17: warning: implicit conversion turns string literal into bool: 'const char [44]' to 'bool' [-Wstring-conversion]
DLOG_ASSERT("WebDataService dtor called without Shutdown");
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:595:43: note: expanded from macro 'DLOG_ASSERT'
4.
../../chrome/browser/renderer_host/web_cache_manager_unittest.cc:259:20: warning: implicit conversion turns string literal into bool: 'const char [29]' to 'bool' [-Wstring-conversion]
EXPECT_FALSE("Unexpected entry in strategy");
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Finding #1 is what made me look into this, #3 and #4 are not doing what they're supposed to, and #2 is kind of funny so not all is lost.
So, 3 bugs and 1 very-close-to-a-bug: seems worth enabling.
R=thakis@chromium.org
TBR=darin@chromium.org, dhollowa@chromium.org, brettw@chromium.org, zea@chromium.org
BUG=177306
Review URL: https://chromiumcodereview.appspot.com/12258039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=161389, 165264
Review URL: https://codereview.chromium.org/11693007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts https://chromiumcodereview.appspot.com/11416265
Using generated shim headers will be much better.
TBR=apatrick
BUG=161389
Review URL: https://codereview.chromium.org/11697002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Asan is coming on Windows soon with SyzyAsan. We should be able to use the ADDRESS_SANITIZER define. The __attribute__ flag is compiler specific.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11549005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11465018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=161389
Review URL: https://chromiumcodereview.appspot.com/11416265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I suspect that the target name collision is causing compile failures on Win (e.g. http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/4176/steps/compile/logs/stdio)
BUG=none
TBR=jochen@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/11412217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will help with avoiding merge conflicts
while I work on the switch (will proceed in small steps,
and I estimate that to take some time).
BUG=161389
Review URL: https://chromiumcodereview.appspot.com/11419047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of "hardcoding" it in gl.gyp. This is one of steps
towards use_system_mesa build option.
BUG=161389
Review URL: https://chromiumcodereview.appspot.com/11308060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bungeman@chromium.org
Review URL: https://codereview.chromium.org/11344041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GLContext to query the GPU's total video memory.
Note that this is the amount of video memory on the currently-rendering GPU, so different contexts will give different values, and the same context may give different values over time (for instance, on a Macbook Pro with graphics switching).
Of note is that on a Macbook Pro with graphics switching enabled, the contexts don't move together between GPUs -- some stay on the integrated GPU while others use the discrete GPU.
BUG=132994
Review URL: https://chromiumcodereview.appspot.com/10957009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Same as patch here: https://chromiumcodereview.appspot.com/10827429/
except that warnings as errors is off if buildtype=Official. The previous CL
was OK everywhere that's visible on build.chromium.org including "Official"
but fails on internal builds.
R=thakis@chromium.org
BUG=126483, 140121, 143877
Review URL: https://chromiumcodereview.appspot.com/10867058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows
Is causing warnings for Official build in PDF code. Boo.
-----------------
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429
TBR=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10872063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are some compile errors for mesa when trying to build gpu_tests
on Android. They were fixed in the mesa upstream.
So this patch combines 3 commits from mesa upstream. They are:
1) Commit eb0ff1a1c0 by chad@chad-versace.us: remove the use of
fpu_control.h
2) Commit 504f92c739 by olvaffe@gmail.com: android has no log2f
nor ffs
3) Commit 497baf4e4a by ian.d.romanick@intel.com: Use C-style
system headers in C++ code to avoid issues with std:: namespace
BUG=138226
TEST=
Review URL: https://chromiumcodereview.appspot.com/10825442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=142316
TBR=kbr
Review URL: https://chromiumcodereview.appspot.com/10834292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
__attribute__((no_address_safety_analysis)) to suppress a report from AddressSanitizer
BUG=142316
TBR=kbr
Review URL: https://chromiumcodereview.appspot.com/10823286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, only the LGPL v2 license from the docs/ subdirectory is mentioned.
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10837052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=139772
TBR=kbr
Review URL: https://chromiumcodereview.appspot.com/10843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is actually a merge of upstream commit a44d715d2b19dc2f8f48b01144cc38e4e2c5015a
BUG=139587,132211
Review URL: https://chromiumcodereview.appspot.com/10833067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10808045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many files used random encoding. All of them were in comments or unit test files
that were not compiled. In any case, not using unicode everywhere complexify the
tools so enforcing it makes presubmit checks much simpler.
R=joi@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10797029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1) Disable fPIC
2) Disable manpage
3) Disable conditions with linux_use_tcmalloc
Review URL: https://chromiumcodereview.appspot.com/10704208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First clang roll in a few weeks, so lots of new stuff:
* better 'unused' warnings. Now catches e.g. "AutoLock(&lock);"
* better 'uninitialized' warnings
* template type eliding in diagnostics
* TLS attribute support
* New -Wunused-private-field warning (disabled for now)
* style plugin has better warning for implicit destructors
* method_iterator interface changed back to what it was, update plugin again
* Warn on member variable self assignments
BUG=135207
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10689041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppress Wunused-value and Wconstant-conversion for the target.
BUG=none
TEST=`ninja all` output gets 43 lines shorter.
NOTRY=true
Review URL: http://codereview.chromium.org/9969116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:92568
TEST=not yet
Review URL: http://codereview.chromium.org/7523033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were added in r28089 (http://codereview.chromium.org/256059) but
are unnecessary bloat for everyone to carry around, even those that don't
use emacs or vim.
In an earlier change, I added editor config files in src/tools/emacs/
and src/tools/vim/ so users of the appropriate editor can source those
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=84134
TEST=none
Review URL: http://codereview.chromium.org/7074026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
toolkit_uses_gtk, os_posix, and use_x11. For lists of source files that use a mix of POSIX and Gtk APIs, toolkit_uses_gtk was given precedence. Solaris was made to use ALSA also, as libasound has been ported to FreeBSD and Solaris as a wrapper around the native OSS.
Review URL: http://codereview.chromium.org/7055003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The next step is a presubmit rule that will make people use the template.
We are doing this so that we can better track dependancy versions.
BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6610030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a little. Will change the behavior of wrong
calls slightly.
See http://codereview.chromium.org/5866007 for some history,
and http://codereview.chromium.org/5848004 for an alternate approach.
BUG=none
TEST=tryservers, local
Review URL: http://codereview.chromium.org/6053007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70416 0039d316-1c4b-4281-b951-d872f2087c98
|