| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up to one of my earlier patches.
TEST=none
BUG=22208, 50769
Review URL: http://codereview.chromium.org/3301019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=shess
BUG=
TEST=
Review URL: http://codereview.chromium.org/3380008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from upstream.
This is a follow-up to one of my earlier patches.
TEST=none
BUG=22208, 50769
Review URL: http://codereview.chromium.org/3301019
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3389007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up to one of my earlier patches.
TEST=none
BUG=22208, 50769
Review URL: http://codereview.chromium.org/3301019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=28291
Review URL: http://codereview.chromium.org/3245008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a compile problem when using -Duse_system_sqlite=1
TEST=none
BUG=22208
Review URL: http://codereview.chromium.org/3134039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evan
BUG=22208
Review URL: http://codereview.chromium.org/3149021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22208
TBR=evan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from our patches, READMEs, etc.
Also, add a shim header so we can use it for building
with system sqlite.
TEST=compile
BUG=22208
Review URL: http://codereview.chromium.org/3108030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings some improvements for ctype's locale-sensitive
handling of some ASCII characters, see http://crbug.com/15261.
TEST=none
BUG=50769
Review URL: http://codereview.chromium.org/2884069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See discussion: http://thread.gmane.org/gmane.comp.db.sqlite.general/58457
TEST=none
BUG=50769
Review URL: http://codereview.chromium.org/2806096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=crash doesn't seem to happen anymore
BUG=47059
Review URL: http://codereview.chromium.org/2829042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2849007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2562002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/243068 and fts2.c was patched in
http://codereview.chromium.org/216026.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1638019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1480002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Allow special cases in licenses.py for when we pull code directly
from an upstream and can't check in a README.chromium. (In particular,
we'll need this for WebKit.)
Review URL: http://codereview.chromium.org/1075015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38745
TEST="ATTACH 12345 as db"
Review URL: http://codereview.chromium.org/1108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fix was reported to sqlite upstream.
TEST=NONE
BUG=NONE
Review URL: http://codereview.chromium.org/506048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=select REGEXP('abc') from sqlite_master
BUG=30510
Review URL: http://codereview.chromium.org/501038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31888
Review URL: http://codereview.chromium.org/384075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
which is no longer present in chromium a the moment.
TBR=dumi@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/384075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and go back to the default behavior which treats BEGIN as BEGIN
DEFERRED.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/387030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
method in Chromium's custom Posix VFS implementation to correctly
implement the 'unused file descriptors' logic.
TEST=none
BUG=26041
Review URL: http://codereview.chromium.org/377039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/333034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Split out the fts2 changes a little.
BUG=NONE
TEST=Applied the patches in order to check for mistakes.
Review URL: http://codereview.chromium.org/243068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Note which sqlite version we are based off.
- Note some prerequisite packages for running the tests.
- Note that a couple of tests fail.
BUG=n/a
TEST=n/a
Review URL: http://codereview.chromium.org/257016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out-of-bounds reads and writes.
Apologies for the size of the change but once I got cranking, it was about
half a day to clean up most of the memory errors.
This should not conflict with the in-progress sqlite-3.6.18 upgrade. I diffed
sqlite-3.6.1 vs. sqlite-3.6.18 and the only changes to fts2.c were two spelling
corrections in comments.
These changes are not whimsical -- they do map to crashes we are seeing
in the wild, e.g.
1) Crash in allocator just after leafReaderStep:
http://crash/reportdetail?reportid=303de6d80936c11d
2) Crash in memcpy in leafReaderStep:
http://crash/reportdetail?reportid=6b2c65459042e67c
3) Crash in memcpy in interiorReaderStep:
http://crash/reportdetail?reportid=9f7ba5c321846302
4) Crash in loop in dlrStep trying to read past end of buffer:
http://crash/reportdetail?reportid=61b2eb58397913b2
In addition, this will give relief to users who have (for whatever root cause)
persistent corruption in their databases. Once you get into that state, Chrome
might be unlaunchable or it might crash multiple times per day.
There's a small chance this might help with our biggest crasher, as certain
types of corrupt database could corrupt memory rather than crashing immediately.
BUG=NONE
TEST=Running with tricked out build with assert()s to check for false positives.
Review URL: http://codereview.chromium.org/216026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
compiler.
BUG=22635
TEST=none
Review URL: http://codereview.chromium.org/231010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Hopefully this will help to address some valgrind issues.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- More (ordered) segments than we expect - would previously cause stack-based
buffer overflow.
- Less segments than we expect, where the missing segments are a strict
truncation rather than missing in the middle.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/209001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/205005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- If the xxx_segdir table gets corrupted, you can have non-contiguous indexes (idx).
- This causes an assertion in debug, and a crash later on on release
With this change it will return 'corrupted db'
We shall wait to get a couple more fixes to upstream to sqlite org.
BUG=21377
TEST=see bug
Review URL: http://codereview.chromium.org/203046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is meant to test to see if we can reduce SQL related crashes by
removing the pre-load optimization.
I also added a line of defensive code (initializing a pointer).
r=brettw
Review URL: http://codereview.chromium.org/203011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc
In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a).
Also updated is the test results for net_util_unittests.
This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there).
BUG=8198
TEST=On all platforms, all the targets are built fine.
Review URL: http://codereview.chromium.org/172031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/195009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash in history::TextDatabase::GetTextMatches is caused by unexpected result of tolower() in some locales such as tr_TR.UTF-8. This CL fixes this issue by using following statement to replace tolower():
(ch>='A' && ch<='Z') ? (ch-'A'+'a') : ch
which will always return expected result for ascii characters regardless of current locale.
BUG=15261 Crash in history::TextDatabase::GetTextMatches
TEST=none
Review URL: http://codereview.chromium.org/174387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out that pkgconfig produces no output if --atleast-version is
given. Thus we list the cflags twice, once to catch the version error
and then a second time to get the flags we need.
(Reported by fta.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/164450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
references to each other) anywhere in the Chromium code base.
BUG=none
TEST=rebuild
Review URL: http://codereview.chromium.org/159523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21083 0039d316-1c4b-4281-b951-d872f2087c98
|