| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
TBR=jar,antonm
Review URL: http://codereview.chromium.org/596083
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/604063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jar,antonm
Review URL: http://codereview.chromium.org/596083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
check the
performance.
TBR=antonm,jar
Review URL: http://codereview.chromium.org/597040
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/598064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
performance.
TBR=antonm,jar
Review URL: http://codereview.chromium.org/597040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This change should not affect any Chromium builds.
TBR=willchan, sgk
Review URL: http://codereview.chromium.org/570021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
600 bytes is not enough to print full symbolized stacks of the memory leaks.
TBR=willchan
Review URL: http://codereview.chromium.org/550011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also pulling in a newer nacl version.
Switching to use AdditionalOptions in list form.
BUG=None
TEST=None
TBR=mmentovai
Review URL: http://codereview.chromium.org/523027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This should allow the heapcheck bot to print all the leaks found.
Review URL: http://codereview.chromium.org/522012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=willchan
Review URL: http://codereview.chromium.org/515029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for x64 on Windows
TEST=none
BUG=29467
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012
Review URL: http://codereview.chromium.org/501127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
better support for x64 on Windows
TEST=none
BUG=29467
Review URL: http://codereview.chromium.org/501127
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/500149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for x64 on Windows
TEST=none
BUG=29467
Review URL: http://codereview.chromium.org/501127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Define a variant of the flat-map that was historically defined as
PageMap1, which allocated about 4MB in an array to map all possible
pages to their status as part of a span. This version (under Windows
only) uses VirtualAlloc to effectively reserve the space, and then
only commit the space when it is necessary to ensure it is
available.
The bulk of the code is almost directly modeled on PageMap1, which is
also defined in pagemap.h.
bug=30010
r=willchan
Review URL: http://codereview.chromium.org/460155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/tcmalloc/
Apart from annoying developers with try mail,
I think this will make some allocation-related changes better tested.
Also, this would help us check the correctness of suppressions (especially, if they are formatted incorrectly).
TEST=try a changelist in tools/valgrind/memcheck/ or third_party/tcmalloc/ and notice linux_valgrind bot
Review URL: http://codereview.chromium.org/465046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove the tcmalloc line from DEPS in favor of our vendor branch.
Remove the old jemalloc checked in underneath tcmalloc.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/457002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add +third_party\tcmalloc to webkit\DEPS.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/449016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page_heap_linux.cc, since the Linux build can't use the current
Windows-specific version of page_heap.cc.
Adds #ifdef in page_heap.h for API changes where the old API is
still used by Linux and the new API is used by windows.
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/440027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/443010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/436042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
base\allocator\allocator.gyp with merged changes from tcmalloc.gyp.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/432021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
preserve checkin history. svn cp the added config*.h files into
the local patched branch.
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
as a basis for local changes.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/436037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change also reworks the tcmalloc dependency to be added only to chrome and test_shell, instead of base. This is necessary since otherwise tcmalloc will be double initialized (by both the main executable and dlopen'd shared objects like the npapitestplugin.so).
Add valgrind suppressions. This are invalid reads on static initialization in the VDSOSupport module. I haven't investigated it yet, but I suspect they're benign.
BUG=http://crbug.com/28149, http://crbug.com/28385
Review URL: http://codereview.chromium.org/399081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/419003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TESt=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Had errors like (note, I added an exception handler to print the error):
________ running '/usr/bin/python src/build/gyp_chromium' in '/usr/local/google/chromium1'
Updating projects from gyp files...
Traceback (most recent call last):
File "src/build/gyp_chromium", line 79, in <module>
sys.exit(gyp.main(args))
File "src/tools/gyp/pylib/gyp/__init__.py", line 432, in main
generator.GenerateOutput(flat_list, targets, data, params)
File "src/tools/gyp/pylib/gyp/generator/scons.py", line 995, in GenerateOutput
GenerateSConscript(output_file, spec, build_file, data[build_file])
File "src/tools/gyp/pylib/gyp/generator/scons.py", line 328, in GenerateSConscript
GenerateConfig(fp, config, indent, src_subdir)
File "src/tools/gyp/pylib/gyp/generator/scons.py", line 207, in GenerateConfig
value = [escape_quotes(v) for v in value]
File "src/tools/gyp/pylib/gyp/generator/scons.py", line 172, in escape_quotes
foo = escape_quotes_re.sub('\\1\\"\\2\\"', s)
TypeError: expected string or buffer Input: ['NO_TCMALLOC_SAMPLES', ''].
failed to run command: /usr/bin/python src/build/gyp_chromium
Review URL: http://codereview.chromium.org/399075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not performance critical, but it allocates some
additional amount of memory on sampled allocations
which we probably do not want.
[This is really http://codereview.chromium.org/385105
written by antonm, and I'm just landing it.]
r=antonm,willchan
Review URL: http://codereview.chromium.org/401012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Account for bytes allocated for meta info when calculating
the number of committed bytes.
[This is partly CL http://codereview.chromium.org/384086
by Antonm, and I'm just landing it for him.]
Also changed mechanism of gathering commited bytes to be sure
we are under a lock (via ExtractStats) while fetching data.
r=antonm,sgk
Review URL: http://codereview.chromium.org/385098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
leak_annotations.h provides the ANNOTATE_SCOPED_MEMORY_LEAK macro
that can be used for annotating known memory leaks in the tests.
Those will be ignored by the heap leak checker.
Patch contributed by ramosian.glider@gmail.com.
Original review at http://codereview.chromium.org/346038/show
Review URL: http://codereview.chromium.org/385049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings several bugfixes needed for turning on the heap leak checker inside
tcmalloc.
Unforked malloc_hook.cc for Linux
This patch was prepared by Alexander Potapenko (cc'ed)
and originally reviewed as http://codereview.chromium.org/339065
Review URL: http://codereview.chromium.org/340065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/342041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to fix the crashes of binaries linked with tcmalloc.
The patch was prepared by Alexander Potapenko (cc'ed)
Originally reviewed as http://codereview.chromium.org/343037
Review URL: http://codereview.chromium.org/342039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
buildbots seemed to ignore the heapchecker symbols defined previously in ldflags)
This patch was prepared by Alexander Potapenko (cc'ed)
TBR=evan,mbelshe,bradn already LGTM'd at http://codereview.chromium.org/300039
Review URL: http://codereview.chromium.org/315015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The heap checker will be linked with libtcmalloc by default.
This patch was prepared by Alexander Potapenko (cc'ed) and originally reviewed as http://codereview.chromium.org/307005
TBR=evan,bradn (already LGTMed at http://codereview.chromium.org/307005)
Review URL: http://codereview.chromium.org/292043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works around webkit sensitivity to allocators that return
zero in this case.
BUG=20200
TEST=none
Review URL: http://codereview.chromium.org/302005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
heap's freelists
Keeps track of the number of reserved but not committed pages in the freelist and uses that to calculate a waste metric, which is the ratio of committed pages vs pages used by the application. This is exposed in the GetStats() call (which is used for about:tcmalloc) and through GetNumericalProperty() in MallocExtension.
BUG=none
TEST=open about:tcmalloc and monitor 'WASTE' columns while using the browser
Review URL: http://codereview.chromium.org/251065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
With TCMalloc now being more conservative about commitment, this change
will reenable it as the default allocator.
r=mbelshe,jamesr
Review URL: http://codereview.chromium.org/246089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This changes to decommitting in all paths through the
page_heap delete method (which adds spans to the free lists).
r=mbelshe,jamesr
Review URL: http://codereview.chromium.org/255067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I got this change approved to try out earlier, and landed it. I rolled
it back (to be conservative) after I got a chromebot run started. Since
that bot run didn't show any giant problems, this will re-land the
change, so we can see how users (such as on a dev channel release) do
with this allocator.
This is really experimental... but it will give us some info to make a
better decision between ongoing tuning of TCMalloc and at least
temporarilly using JEMalloc.
tbr=mbelshe
Review URL: http://codereview.chromium.org/256024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I wanted to see how the chromebot would do with JEMalloc.
I just checked it in, and after a chrome-bot run kicks off, I'll land
this effectively reverting rev 27702 back to using TCMalloc.
tbr=mbelshe
Review URL: http://codereview.chromium.org/242092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=jamesr,mbelshe
Review URL: http://codereview.chromium.org/244055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a landing of a patch provided by antonm. See:
http://codereview.chromium.org/235022
Also included change to browser_about_handler.cc to fix build, and I set
TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this
was an inadvertent rollback element).
r=antonm
Review URL: http://codereview.chromium.org/257009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/245006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prevent fragmentation
Actually on Windows VirtualAlloc'ated address might have bigger alignment than reported by SYSTEM_INFO.dwPageSize, see SYSTEM_INFO.dwAllocationGranularity.
As coalescing of spans in tcmalloc requires that those spans are physically adjacent, using smaller alignment inhibited coalescing. Additional benefit is we now
require ways less memory at least in some case.
Also adds assert()s for alignment values that would lead to pathological virtual address space waste. No current callers pass in alignment values other than kPageSize and it's unlikely anyone will.
Original patch and discussion was at http://codereview.chromium.org/235003
Patch by: antonm@chromium.org
BUG=22701
TEST=Manually checked test page that did 10m XHR. Memory use goes from >2GB and a crash to 102MB. Membuster shows the change is roughly within noise and possibly a very slight regression ( <<5% ).
Review URL: http://codereview.chromium.org/222028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22926
TEST=still builds
Review URL: http://codereview.chromium.org/231020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27112 0039d316-1c4b-4281-b951-d872f2087c98
|