| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/461903002
Cr-Commit-Position: refs/heads/master@{#289133}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, every gyp file that wanted to set clang warnings had to check
for clang==1 and then set cflags and xcode_settings.WARNING_CFLAGS. Factor
this out, so that targets only need to set clang_warning_flags for warnings
that apply to all platforms. (Per-platform flags still need to be set manually.)
This removes existing duplication from gyp files, and prevents adding more
duplication when trying to add the same warning flags for clang/win.
BUG=82385
R=hans@chromium.org, scottmg@chromium.org
TBR=various owners
Review URL: https://codereview.chromium.org/437543007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The gn Windows build says
d:\src\cr3\src\third_party\zlib\google\zip_internal.cc(62) : error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\third_party\zlib\google\zip_internal.cc(62) : warning C4701: potentially uninitialized local variable 'creation_disposition' used
This warning is disabled in the gyp build, but it seems better to keep
it on if possible, and it seems like depending on the flags passed to
ZipOpenFunc, it could indeed be passing an uninitialized value to
::CreateFile. Setting it explicitly to 0 will cause ::CreateFile to
fail, if it's left unset by the ifs.
R=satorux@chromium.org
BUG=354261
Review URL: https://codereview.chromium.org/430963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
New API which extract a zip entry into a memory buffer.
BUG=359428
Review URL: https://codereview.chromium.org/292443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A zip file carries some metadata for each archived file, including the total
uncompressed size. If that size was incorrect, therefore the compressed file
being different in size when unpacking, the minizip code would fail with a
CRC error. Every other zip utility handles these files, so should the minizip
code for safety sake.
BUG=359516
Review URL: https://codereview.chromium.org/222243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added missing <vector> told by the linter, fixed leak of a zipFile
in ZipWithFilterCallback in case of error, and corrected error in function name.
BUG=359428
Review URL: https://codereview.chromium.org/222323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a TODO about private symbols on GCC.
Moves many third party BUILD.gn files from the secondary tree to the main one.
Fixes the dependencies on Linux so "gn check" passes again.
BUG=367595
R=scottmg@chromium.org
Previous review: https://codereview.chromium.org/256153003/
Review URL: https://codereview.chromium.org/264463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> GN build improvements.
>
> Fixes a TODO about private symbols on GCC.
>
> Moves many third party BUILD.gn files from the secondary tree to the main one.
>
> Fixes the dependencies on Linux so "gn check" passes again.
>
> BUG=367595
> R=scottmg@chromium.org
>
> Review URL: https://codereview.chromium.org/256153003
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/257243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a TODO about private symbols on GCC.
Moves many third party BUILD.gn files from the secondary tree to the main one.
Fixes the dependencies on Linux so "gn check" passes again.
BUG=367595
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/256153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use base::File instead
BUG=351823
TEST=unit_tests
Review URL: https://codereview.chromium.org/204983012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org
TBR=viettrungluu
Review URL: https://codereview.chromium.org/184563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=322664
R=hshi@chromium.org
Review URL: https://codereview.chromium.org/166573007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Updates ImageWriterPrivate to use the new asynchronous functions.
BUG=324091
Review URL: https://codereview.chromium.org/92873003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=322664
R=brettw@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/101143006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/102993018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Files packaged in a zip archive now have their last modification date
and time set. When unzipping the files, the output file's last
modification time is also set (if the time in the zip file is not valid,
the output's file time is not set to prevent the original bug causing
files to have dates set to 1980).
Also fixed some cpplint issues.
BUG=326988
TEST=ZipTest.ZipTimeStamp
Review URL: https://codereview.chromium.org/99333019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The commit adds a unit test and replaces the substr with the more
stylistically adequate FilePath::AppendRelativePath.
BUG=248115
TEST=ZipTest.ZipNonASCIIDir
Review URL: https://codereview.chromium.org/106663006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit sets the 'locale' bit in global directory of a zip which
means that the file name was written in UTF-8. Chromium always writes
and reads zips as UTF-8 so it is not a problem per se but other, more
zip compliant, programs see packed files with wrong paths if this bit
is not set.
BUG=325737
Review URL: https://codereview.chromium.org/94093003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/100573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes base, ui, and net compile without the "using base::string16" directive that's currently checked in.
BUG=
Review URL: https://codereview.chromium.org/100303003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 777c940a87944192afaa28904c30145bfeb54d09.
Many Blink LayoutTests starts failing after this patch.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=canvas/philip/tests/security.dataURI.html,canvas/philip/tests/toDataURL.arguments.1.html,canvas/philip/tests/toDataURL.arguments.2.html,canvas/philip/tests/toDataURL.arguments.3.html,canvas/philip/tests/toDataURL.bogustype.html,canvas/philip/tests/toDataURL.default.html,canvas/philip/tests/toDataURL.lowercase.ascii.html,canvas/philip/tests/toDataURL.lowercase.unicode.html,canvas/philip/tests/toDataURL.nocontext.html,canvas/philip/tests/toDataURL.png.complexcolours.html,canvas/philip/tests/toDataURL.png.html,canvas/philip/tests/toDataURL.png.primarycolours.html,canvas/philip/tests/toDataURL.unrecognised.html,compositing/overflow/image-load-overflow-scrollbars.html,compositing/overflow/invisible-descendants-should-not-affect-opt-in.html,compositing/tiling/huge-layer-img.html,css2.1/20110323/inline-replaced-width-014.htm,css2.1/t0905-c414-flt-wrap-01-d-g.html,fast/backgrounds/bgCompositeCopy.html,fast/canvas/canvas-blending-color-over-image.html,fast/canvas/canvas-blending-color-over-pattern.html,fast/canvas/canvas-blending-gradient-over-image.html,fast/canvas/canvas-blending-gradient-over-pattern.html,fast/canvas/canvas-blending-image-over-color.html,fast/canvas/canvas-blending-image-over-gradient.html,fast/canvas/canvas-blending-image-over-image.html,fast/canvas/canvas-blending-image-over-pattern.html,fast/canvas/canvas-blending-pattern-over-color.html,fast/canvas/canvas-blending-pattern-over-gradient.html,fast/canvas/canvas-blending-pattern-over-image.html,fast/canvas/canvas-blending-pattern-over-pattern.html,fast/canvas/canvas-createImageBitmap-drawImage.html,fast/canvas/canvas-createImageBitmap-immutable.html,fast/canvas/canvas-createImageBitmap-invalid-args.html,fast/canvas/canvas-createImageBitmap-out-of-bounds-src.html,fast/canvas/canvas-createImageBitmap-recursive.html,fast/canvas/canvas-createPattern-fillRect-shadow.html,fast/canvas/canvas-drawImage-out-of-bounds-src.html,fast/canvas/canvas-drawImage-shadow.html,fast/canvas/canvas-scale-drawImage-shadow.html,fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html,fast/canvas/check-stale-putImageData.html,fast/canvas/toDataURL-alpha.html,fast/canvas/toDataURL-supportedTypes.html,fast/canvas/webgl/gl-teximage.html,fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html,fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html,fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html,fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html,fast/css/color-correction-on-backgrounds.html,fast/css/color-correction.html,fast/images/paint-subrect-grid.html,fast/images/png-suite/test.html,fast/images/png-with-color-profile.html,fast/images/rgb-png-with-cmyk-color-profile.html,inspector/profiler/canvas2d/canvas-get-resource-state.html,inspector/profiler/webgl/webgl-get-resource-state.html,svg/W3C-SVG-1.1/filters-blend-01-b.svg,svg/W3C-SVG-1.1/masking-path-04-b.svg,svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html,svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html,svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html,svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html,svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html,svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html,virtual/deferred/fast/images/paint-subrect-grid.html,virtual/deferred/fast/images/png-suite/test.html,virtual/deferred/fast/images/png-with-color-profile.html,virtual/deferred/fast/images/rgb-png-with-cmyk-color-profile.html,virtual/gpu/canvas/philip/tests/security.dataURI.html,virtual/gpu/canvas/philip/tests/toDataURL.arguments.1.html,virtual/gpu/canvas/philip/tests/toDataURL.arguments.2.html,virtual/gpu/canvas/philip/tests/toDataURL.arguments.3.html,virtual/gpu/canvas/philip/tests/toDataURL.bogustype.html,virtual/gpu/canvas/philip/tests/toDataURL.default.html,virtual/gpu/canvas/philip/tests/toDataURL.lowercase.ascii.html,virtual/gpu/canvas/philip/tests/toDataURL.lowercase.unicode.html,virtual/gpu/canvas/philip/tests/toDataURL.nocontext.html,virtual/gpu/canvas/philip/tests/toDataURL.png.complexcolours.html,virtual/gpu/canvas/philip/tests/toDataURL.png.html,virtual/gpu/canvas/philip/tests/toDataURL.png.primarycolours.html,virtual/gpu/canvas/philip/tests/toDataURL.unrecognised.html,virtual/gpu/compositedscrolling/overflow/image-load-overflow-scrollbars.html,virtual/gpu/compositedscrolling/overflow/invisible-descendants-should-not-affect-opt-in.html,virtual/gpu/fast/canvas/canvas-blending-color-over-image.html,virtual/gpu/fast/canvas/canvas-blending-color-over-pattern.html,virtual/gpu/fast/canvas/canvas-blending-gradient-over-image.html,virtual/gpu/fast/canvas/canvas-blending-gradient-over-pattern.html,virtual/gpu/fast/canvas/canvas-blending-image-over-color.html,virtual/gpu/fast/canvas/canvas-blending-image-over-gradient.html,virtual/gpu/fast/canvas/canvas-blending-image-over-image.html,virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html,virtual/gpu/fast/canvas/canvas-blending-pattern-over-color.html,virtual/gpu/fast/canvas/canvas-blending-pattern-over-gradient.html,virtual/gpu/fast/canvas/canvas-blending-pattern-over-image.html,virtual/gpu/fast/canvas/canvas-blending-pattern-over-pattern.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-drawImage.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-immutable.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-invalid-args.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-out-of-bounds-src.html,virtual/gpu/fast/canvas/canvas-createImageBitmap-recursive.html,virtual/gpu/fast/canvas/canvas-createPattern-fillRect-shadow.html,virtual/gpu/fast/canvas/canvas-drawImage-out-of-bounds-src.html,virtual/gpu/fast/canvas/canvas-scale-drawImage-shadow.html,virtual/gpu/fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html,virtual/gpu/fast/canvas/check-stale-putImageData.html,virtual/gpu/fast/canvas/toDataURL-alpha.html,virtual/gpu/fast/canvas/toDataURL-supportedTypes.html,virtual/gpu/fast/canvas/webgl/gl-teximage.html,virtual/gpu/fast/canvas/webgl/premultiplyalpha-test.html,virtual/gpu/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html,virtual/gpu/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html,virtual/gpu/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html,virtual/gpu/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html,virtual/softwarecompositing/overflow/image-load-overflow-scrollbars.html,virtual/softwarecompositing/overflow/invisible-descendants-should-not-affect-opt-in.html,virtual/softwarecompositing/tiling/huge-layer-img.html
BUG=none
TBR= dominikg@chromium.org, arv@chromium.org
Review URL: https://codereview.chromium.org/23494067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update libpng from version 1.2.45 to 1.6.3.
Enable NEON implementation of libpng for ARM devices running Android. libpng performs a check a runtime to see if the device actually supports NEON.
BUG=
Review URL: https://chromiumcodereview.appspot.com/23271006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/19579005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It launches batches of unit tests in a subprocess for better stability.
BUG=236893
R=maruel@chromium.org, satorux@chromium.org
Review URL: https://codereview.chromium.org/23132002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the base namespace.
TBR=sky
Review URL: https://codereview.chromium.org/19052005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/18286004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/18158003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=248115
TEST=manual testing on windows
Review URL: https://chromiumcodereview.appspot.com/16632007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15851009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
BUG=175002
Reland of 198820 and 298824
Original review = https://codereview.chromium.org/13165005
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/16392011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/.
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15995038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke both windows clobber and official builders' compile with this error:
771>Link:
771> Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and
object ..\..\..\build\Release\lib\gcp_portmon64.exp
771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86'
conflicts with target machine type 'x64'
771>
771>Build FAILED.
> Move FileEnumerator to its own file, do some refactoring.
>
> It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
>
> BUG=175002
> R=rvargas@chromium.org
>
> Review URL: https://codereview.chromium.org/13165005
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14824006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
BUG=175002
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/13165005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move components to zip as per the discussion here:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/MgbMTQCNzR0/discussion
BUG=
R=agl@chromium.org, gavinp@chromium.org, jam@chromium.org, joi@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197964
Review URL: https://codereview.chromium.org/14021015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
through trybots
BUG=
TBR=agl@chromium.org, gavinp@chromium.org, jam@chromium.org, joi@chromium.org
Review URL: https://codereview.chromium.org/14606006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
android tests.
This reverts r197964.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move components to zip as per the discussion here:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/MgbMTQCNzR0/discussion
BUG=
R=agl@chromium.org, gavinp@chromium.org, jam@chromium.org, joi@chromium.org
Review URL: https://codereview.chromium.org/14021015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes use_system_foo logic completely from:
* jsoncpp.gyp
* libevent.gyp
* libpng.gyp
* libusb.gyp
* libwebp.gyp
* opus.gyp
* re2.gyp
* zlib.gyp
R=rsleevi
TBR=darin
BUG=226860
Review URL: https://codereview.chromium.org/14203006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is upstreaming a Gentoo Linux patch.
BUG=none
Review URL: https://codereview.chromium.org/14365023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems https://codereview.chromium.org/8954009/ was a bit
overzealous. On 64 bit platforms, zlib.h attempts to use the 64 bit
API for all callers. But, we were not allowing that, making writing
portable code difficult. This CL updates our manglings in zlib.h so
that on a 64 bit platform the API defaults to the 64 bit version, as
intended.
This change is downstream of https://codereview.chromium.org/13564004/
and must land after it.
R=rsleevi@chromium.org,agl@chromium.org, brettw@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/13473020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You may think that https://codereview.chromium.org/8806004 , back in
2011, did this. However, that's not correct. That update only patched files which
were present in both our old, customized checkout and zlib 1.2.5.
In zlib 1.2.5, gzio.c was replaced with gzclose.c, gzguts.h, gzlib.c, gzread.c
and gzwrite.c. We did not add those files. We just used the gzio.c from 1.2.3
with our custom patches from Gears, together with the rest of 1.2.5.
This unholy chimera worked until I went ahead and tried to fix the broken
mangling for 64 bit API symbols. See
https://codereview.chromium.org/13473020/ . This uncovered the lack of
gzread64, which was, after that fix, referenced by libxml. Since gzio.c from
1.2.3 doesn't have gzread64, this was something of a problem. I'm thus
finishing the update.
R=agl@chromium.org,rsleevi@chromium.org,brettw@chromium.org,bradchen@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/13564004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gavinp@chromium.org found and fixed the 1.2.[35] chimera and fixed our mangling.
agl@chromium.org is responsible for the SPDY3 changes to deflate.c.
phajdan.jr@chromium.org besides being a polymath extraordinary has made many
incremental improvements esp towards distro authors.
R=brettw@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/13799006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=165264
Review URL: https://codereview.chromium.org/11632002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is helpful for Linux distros, I've tested this CL
on Gentoo Linux.
Google Chrome defaults to bundled minizip, so no change here.
BUG=29048
TEST=none
Review URL: https://codereview.chromium.org/11214002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, SPDY cookies would look like:
"FOO=BAR;BAR=BOO;WIBBLE=WOBBLE;"
With this patch they will look like:
"FOO=BAR; BAR=BOO; WIBBLE=WOBBLE"
This will hurt compression a little as cookies are only matched completely so:
Cookie: FOO=BAR
|-----|
won't match against the next Cookie header with an additional cookie:
Cookie: FOO=BAR; BAR=BOO
|------||------|
However, once the set of cookies is stable, it does fine.
BUG=151433
Review URL: https://chromiumcodereview.appspot.com/10957038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This is a reland of r151502, which was reverted in r151517 because it
broke the Linux Official build.)
This may break the Official build for a brief window while a two-sided
patch lands.
BUG=139744
Review URL: https://chromiumcodereview.appspot.com/10837057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts r151502.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=139744
Review URL: https://chromiumcodereview.appspot.com/10837057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
incompatible with Android.
For most directories, we use a regex of whitelisted licenses to parse the 'License' field from the metadata. In some case, for example, where a custom license is used, we rely on a new 'Android Compatibility' field.
This functionality will be used by the snapshot tool, which will exclude these incompatible directories from the snapshot in the Android tree.
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10829272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will simplify the addition of a tool to check licenses for the purpose of
the Android WebView build.
See also http://codereview.chromium.org/10827099
Also adds other missing fields to these README.chromium files as required by
presubmit checks and fixes a regex used to enforce this.
BUG=138921
Review URL: https://chromiumcodereview.appspot.com/10821103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149423 0039d316-1c4b-4281-b951-d872f2087c98
|