| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6714022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows from abysmal to merely poor. The vsnprintf() implementation in MSVC's libc does not conform to C99, and returns -1 if the given buffer is too small to hold the given format. Passing it NULL and a size of zero returns the number of chars required.
BUG=NONE
TEST=all GPU layout tests
R=kbr
Review URL: http://codereview.chromium.org/6711035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74589
TEST=unit tested
Review URL: http://codereview.chromium.org/6711017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
up after myself from revision 78316.
BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6665039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
Review URL: http://codereview.chromium.org/6677080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't think I want to ship this to dev or stable, but
I think it may be valuable to try on our canary
builds.
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
ALthough I haven't been able to demonstrate a
problem on the bots, I'm pretty psyched to try
to find something in the field with this change.
The perf loss is very low, and I think that the
likely cause for TCMalloc cross-linked-list
corruption (double frees) will be detected
(I can hope!)
R=mbelshe
BUG=75921
Review URL: http://codereview.chromium.org/6683029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The next step is a presubmit rule that will make people use the template.
We are doing this so that we can better track dependancy versions.
BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6610030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
read a non-existant libwebp.a file from the disk.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch originally by Pascal Massimino.
Review URL: http://codereview.chromium.org/6677038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll revert as soon as the builds kick off.
TBR=willchan
Review URL: http://codereview.chromium.org/6677037
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6693013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'll revert as soon as the builds kick off.
TBR=willchan
Review URL: http://codereview.chromium.org/6677037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add third party python library PLY. This CL contains unmodified
soruces for lex.py, yacc.py, __init__.py and README. LICENSE is a
copy of the license from the README and README.chromium describes
the changes.
BUG=74978
TEST=none
Review URL: http://codereview.chromium.org/6673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[I just wanted to kick a reliability run with it as a test]
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
I did a first landing of this patch to test perf impact
and see what corruption it surfaced in:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77941
It appears that Windows is not using TCMalloc on our bots.
TBR=mbelshe
Review URL: http://codereview.chromium.org/6683027
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6682020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
I did a first landing of this patch to test perf impact
and see what corruption it surfaced in:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77941
It appears that Windows is not using TCMalloc on our bots.
TBR=mbelshe
Review URL: http://codereview.chromium.org/6683027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll land and revert this quickly, to see what
impact it has on performance.
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
TBR=mbelshe
Review URL: http://codereview.chromium.org/6679021
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6679029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll land and revert this quickly, to see what
impact it has on performance.
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
TBR=mbelshe
Review URL: http://codereview.chromium.org/6679021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also, create new class for representing a path to a frame.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6612052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to avoid having to change a bunch of build/release configuration files
everytime ICU version is changed.
This will bring in the following two CLs in ICU and googleurl:
http://codereview.chromium.org/6625032
http://codereview.chromium.org/6623060
BUG=74076
TEST=Chrome can be built and a binary built runs fine with an accompanying Chrome CL in place.
Review URL: http://codereview.chromium.org/6624060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I did some measurements with a Release build of chrome, both manually and via the page cycler tests. It seems that a simple empty blocking event listener can add anywhere from a 1 to 30ms delay to request times, largely depending on how many requests are in the queue (when many requests come at once, the last ones to be processed by the extension are delayed the longest).
From page cycler data (on my local machine), the average increase in page load time seems to be around 6ms. This is independent of total page load time (which makes sense).
BUG=60101
TEST=covered by apitests
Review URL: http://codereview.chromium.org/6574049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(incl. the full Uyghur translations)
Review URL: http://codereview.chromium.org/6628062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6625029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Compiles, Unittests
Review URL: http://codereview.chromium.org/6626010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
For a detailed description see part #1, http://codereview.chromium.org/6478005/
BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/6532034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
scrollable pages as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6574015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73716
TEST=none
Review URL: http://codereview.chromium.org/6549014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Despite obvious warnings about not using this flag
in deployment, we are turning off sqlite sync in ChromeOS
and relying on the underlying journaling filesystem
to do error recovery properly. It's much faster.
BUG=chromium-os:12328
TEST=Build both with and without SQLITE_NO_SYNC, and measured power
usage at the SATA rail. Power reduction is about 2-3%, and light use
so far produced no data corruption.
Review URL: http://codereview.chromium.org/6544025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toggle atom.
See: http://code.google.com/p/selenium/source/detail?r=11476
Patch by jleyba@chromium.org.
Original review at http://codereview.chromium.org/6541011
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6541042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generated from the WebDriver repository at r11446.
There are several notable changes with this new version:
* The atoms are no longer defined using wchar_t
* The atoms are defined as multi-line strings instead of an array of strings,
eliminating the need for unnecessary concatenations on each use.
* The atoms constants have been moved into a new namespace (webdriver::atoms).
* Previously, each atom defined a named JS function; now each atom defines
an anonymous function, so the call pattern had to be adjusted slightly.
With this change, we can enable the element finding functional tests (there
are still some bugs with the child element finding tests that need to be
tracked down).
I've also disabled a page loading test because it is flaky in my client.
BUG=none
TEST=none
Patch by jleyba@chromium.org.
Original review at http://codereview.chromium.org/6524045
Review URL: http://codereview.chromium.org/6531003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71130
Review URL: http://codereview.chromium.org/6523009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
protected by the use_third_party_translations flag
Review URL: http://codereview.chromium.org/6485012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6486016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6474020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
client side arrays.
TEST=none
BUG=71717
Review URL: http://codereview.chromium.org/6459013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The SQLite project doesn't fix compiler warnings(!), instead
preferring automated testing.
Review URL: http://codereview.chromium.org/6456008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove diagnostic logging, as I no longer see it firing on the
waterfall.
Original revision:
http://codereview.chromium.org/3473026
http://src.chromium.org/viewvc/chrome?view=rev&revision=60938
BUG=66938,56427
TEST=none
Review URL: http://codereview.chromium.org/6410093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
project.
Review URL: http://codereview.chromium.org/6246123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6246127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6250071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's only built if use_third_part_translations=1.
Also pull in the translations from launchpad.net.
Review URL: http://codereview.chromium.org/6334090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Merge webdriver_tests into chromedriver_tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6368068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that a separate review changes the DEPS so the pdb is there.
BUG=71743
TEST=see bug
Review URL: http://codereview.chromium.org/6349066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I missed chromium_strings_sr.grd yesterday.
Review URL: http://codereview.chromium.org/6312097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
6 new languages on Linux if gyp is run with with
use_third_party_translations=1.
I also moved the translations from src/chrome/third_party to
src/third_party, since the translations cover more than chrome/.
Review URL: http://codereview.chromium.org/6410010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
incremental builds in VS2010.
BUG=71130
TEST=Check that Chrome builds.
Review URL: http://codereview.chromium.org/6386019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
work on incremental builds in VS2010.
This is breaking clobber builds with this error :
e:\b\build\slave\google-chrome-rel-win\build\src\chrome_frame\iids.cc(6) : fatal error C1083: Cannot open include file: 'chrome_tab.h': No such file or directory
BUG=71130
TEST=Check that Chrome builds.
Review URL: http://codereview.chromium.org/6307018
TBR=jeanluc@chromium.org
Review URL: http://codereview.chromium.org/6347032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
incremental builds in VS2010.
BUG=71130
TEST=Check that Chrome builds.
Review URL: http://codereview.chromium.org/6307018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71145
TEST=Run unit tests
Review URL: http://codereview.chromium.org/6240017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6353017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
worker thread will be started, but will have not have a connection to handle because another worker thread grabs it first. If no further connections arrive, the new worker thread will proceed to exit. This will crash when accessing the worker's connection's context, which has never been set.
The fix is to use the context that was given to the worker initially in this case.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6244002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because of stability issues (race conditions detected by tsan, possibly leading to crashes).
Revert "Update sqlite's README.chromium with a note to keep webkit side" (http://crrev.com/62151).
Revert "Remove our local modifications to sqlite's os_unix.c now that" (http://crrev.com/60761).
BUG=70589, 22208
TEST=none
Review URL: http://codereview.chromium.org/6330011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72673 0039d316-1c4b-4281-b951-d872f2087c98
|