| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
heap leak checker to unwind the memory allocation stacks better.
Currently, if a memory region is allocated from a library built without frame
pointers heapchecker is unable to unwind the stack and records only the top
frame. This is inconvenient, because:
-- several leaks from different places are treated as leaks from the same
source
-- it's hard to suppress such leaks, because a one-line suppression is
uninformative
linux_shadow_stacks.cc keeps the threads' IP and SP values in thread-local
stacks upon each function entry/exit using gcc function instrumentation
(-finstrument-functions).
The GetStackTrace routine from stacktrace_shadow-inl.h unwinds the stack as
usual (using frame pointers), but then updates the result with the shadow stack
frames which SP values are below the bottom frame of the unwind result.
Note that -finstrument-functions affects only Chromium code, not the libraries.
This means that we cannot get more than one library function frame at the top
of the stack.
For example, consider a libfoo library that has a public foo_do_something()
routine which allocates memory via foo_alloc(). If Chromium calls
foo_do_something() from ChromeCallFoo(), then the following call chain
effectively happens:
main -> ChromeCallFoo -> foo_do_something -> foo_alloc
If libfoo is built with -fomit-frame-pointers, heapcheck can unwind only the
last stack frame:
foo_alloc
On the other hand, the shadow stack at the allocation site contains everything
below the libfoo calls:
main -> ChromeCallFoo
As a result the following allocation stack is recorded:
main -> ChromeCallFoo -> foo_alloc
This is enough to distinguish between e.g. ChromeCallFoo1 and ChromeCallFoo2
Review URL: http://codereview.chromium.org/3120017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a compile problem when using -Duse_system_sqlite=1
TEST=none
BUG=22208
Review URL: http://codereview.chromium.org/3134039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is upstream already as part of google-perftools r97.
BUG=52114
TEST=compiles with older gcc
Review URL: http://codereview.chromium.org/3137035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The HttpNetworkTransaction refactor intercepts the client auth
handling and moves it out of DoLoop. Because HandleCertificateRequest
often switches states, this caused a DCHECK and crash in some
circumstances.
This reintegrates it and adds unit tests to catch the DCHECK. We really
want to test sending a legitimate certificate, as well as more
checking interesting errors, but we cannot import temporary keys yet.
We also add a patch for tlslite to send a non-empty certificate_types.
Apple's SSL implementation raises a protocol error otherwise.
BUG=52744,51132,52778
TEST=SSLClientSocketTest.ConnectClientAuth*,URLRequestTest.ClientAuthTest
Review URL: http://codereview.chromium.org/3141026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, tlslite only supports the caller passing in a list of CAs pre-encoded for the TLS CertificateRequest message. This CL improves that, by providing a means of extracting the DER-encoded subject name from an X509 certificate, supplying a list of such names to tlslite's server routines, and having tlslite encode the list of CAs as part of the CertificateRequest.
BUG=47656, 47658
TEST=net_unittests
Review URL: http://codereview.chromium.org/3177015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3115011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evan
BUG=22208
Review URL: http://codereview.chromium.org/3149021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22208
TBR=evan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from our patches, READMEs, etc.
Also, add a shim header so we can use it for building
with system sqlite.
TEST=compile
BUG=22208
Review URL: http://codereview.chromium.org/3108030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implement the JSON over HTTP protocol of WebDriver. It is a full
featured server with SSL capability. The maximum number of url
headers has been changed from 64 to 128 and the bindings and
tests are not included since they are not used.
BUG=none
TEST=none
Project URL: http://code.google.com/p/mongoose/
Review URL: http://codereview.chromium.org/3080002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behavior across multiple browsers. This file is generated by
them and must be checked in manually to ensure no breakage occurs
with ChromeDriver
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3180005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove the non-working methods from the os object on d8 on Windows
so you can test for their presence with if (os.system).
* Add a test (not run by default since it only works on d8).
* Fix incorrect use of wait that left defunct processes (zombies).
Committed: http://code.google.com/p/v8/source/detail?r=1650
Review URL: http://codereview.chromium.org/56107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This helps keep our patches, build files, and metadata separate.
(Note that src/ is not purely what upstream has, since it has our
patches applied.)
Review URL: http://codereview.chromium.org/3160012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The final GLEW dependency (in webkit) has been removed. Deleting unused library.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3158007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings some improvements for ctype's locale-sensitive
handling of some ASCII characters, see http://crbug.com/15261.
TEST=none
BUG=50769
Review URL: http://codereview.chromium.org/2884069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
finicky compilers (in particular, nacl-g++) complain about.
Contributed by mdsteele@google.com
BUG=none
TEST=Try to compile modp_b64 with nacl-g++
Review URL: http://codereview.chromium.org/3044045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See discussion: http://thread.gmane.org/gmane.comp.db.sqlite.general/58457
TEST=none
BUG=50769
Review URL: http://codereview.chromium.org/2806096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed CLD wrapper function to return the number of bytes used for language detection, and using that in the render view to ignore detection for short texts.
BUG=45156
TEST=Visit www.voila.fr, an infobar should show reporting the page is in French.
Visit http://jdvhotels.com/calendar.html?datetime=1274857200000&id=0, no translate infobar should show.
Review URL: http://codereview.chromium.org/3038018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Both libxml and its direct dependencies need to define
LIBXML_STATIC when libxml is a static library. Right
now it is necessary to define this macro only on Windows,
but the macro is intended to be cross-platform.
R=evan
BUG=50048
TEST=Windows build log should not contain "locally defined
symbol XXX imported" linker warings such as:
libxslt.lib(numbers.obj) : warning LNK4049: locally defined symbol _xmlFree imported
Review URL: http://codereview.chromium.org/3063009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2856063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=make sure desktopui_BrowserTest autotest works on ChromeOS
BUG=chromium-os:4828
Review URL: http://codereview.chromium.org/2881026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3053011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In my previous patch today, I moved LIBXML_STATIC into a Windows-only
block in the gyp file. It turns out I misread the #defines and it's
not needed on any OS.
libxml.h has this:
#ifndef PIC
# define LIBXML_STATIC
#endif
The PIC define mentioned there appears to be a Linuxism, which is fine
for us because we want it to be static anyway.
Review URL: http://codereview.chromium.org/2825052
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/3049004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In my previous patch today, I moved LIBXML_STATIC into a Windows-only
block in the gyp file. It turns out I misread the #defines and it's
not needed on any OS.
libxml.h has this:
#ifndef PIC
# define LIBXML_STATIC
#endif
The PIC define mentioned there appears to be a Linuxism, which is fine
for us because we want it to be static anyway.
Review URL: http://codereview.chromium.org/2825052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In doing so, I recreated all the patches and organized them under
a patches/ subdirectory.
BUG=32197
Review URL: http://codereview.chromium.org/2951008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Build Mesa with -fPIC flag on linux so it can be linked into a shared library.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2975016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Options are desktop, egl and osmesa.
- Also added support for bliting an OSMesa bask buffer to a GDK window.
TEST=trybots, manual verification that WebGL and Pepper 3D work
BUG=45898
Review URL: http://codereview.chromium.org/2825005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2921004
Patch from Ahmad Sharif <asharif@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=built on all platforms
Review URL: http://codereview.chromium.org/2970001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the WebPlugin API more like WebView.
Review URL: http://codereview.chromium.org/2827047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in order to fully support Windows screenreaders.
Note: it makes sense to check these files into third_party
directly (rather than pull from Mozilla's repository) because
(1) they're very small (under 500 lines total), and
(2) they're stable and unlikely to change frequently.
BUG=48185
TEST=none
Review URL: http://codereview.chromium.org/2802031
TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/2873043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in order to fully support Windows screenreaders.
Note: it makes sense to check these files into third_party
directly (rather than pull from Mozilla's repository) because
(1) they're very small (under 500 lines total), and
(2) they're stable and unlikely to change frequently.
BUG=48185
TEST=none
Review URL: http://codereview.chromium.org/2802031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files that were inadvertantly left out of the initial changelist.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2830037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=crash doesn't seem to happen anymore
BUG=47059
Review URL: http://codereview.chromium.org/2829042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The nvidia opengl driver uses this function. If we don't hook it
with tcmalloc, then we mix calls to tcmalloc functions (malloc,
free, etc) with the libc ones, causing our WebGL bits to hang.
BUG=44590
Review URL: http://codereview.chromium.org/2830035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=sync_listen_notifications
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51330
Review URL: http://codereview.chromium.org/2880008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
radius of the close button hover state circle a bit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2833050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
points to avoid the need to link against opengl32.lib. Added
_ATL_NO_OPENGL #define in build/common.gypi to prevent link directive
from forcibly pulling in opengl32.lib for any Chrome code using ATL.
Once upstream code in WebKit is changed to use the new wglew entry
points and remove opengl32.lib from the link line, chrome.dll will no
longer depend on opengl32.dll.
BUG=45586
TEST=ran WebGL with --in-process-webgl
Review URL: http://codereview.chromium.org/2856022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Test printing from Chrome PDF plugin on Linux.
Review URL: http://codereview.chromium.org/2807027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=compile libjingle with and without no_libjingle_loggin=1
BUG=None
Review URL: http://codereview.chromium.org/2852031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
take out the ability to access the clipboard since it's not exposed to HTML for security reasons.
Review URL: http://codereview.chromium.org/2841028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
According to libpng website, this will solve the vulnerability ID CVE-2010-1205.
BUG=47633
TEST=None
Review URL: http://codereview.chromium.org/2835021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux to follow.
BUG=None.
TEST=Test printing from Chrome PDF plugin on Windows.
Review URL: http://codereview.chromium.org/2863019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull in extra dependencies that require to run remoting_unittests
on shlib-dbg linux bot.
TEST=test runs
BUG=none
Review URL: http://codereview.chromium.org/2850025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"-pedantic" enabled.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2830024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=made sure http://codereview.chromium.org/2827014/show compiles.
Review URL: http://codereview.chromium.org/2813027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=compiled on windows, verified there were no warnings
Review URL: http://codereview.chromium.org/2854011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50285 0039d316-1c4b-4281-b951-d872f2087c98
|