| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Hopefully this will help to address some valgrind issues.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/212017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/208007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- More (ordered) segments than we expect - would previously cause stack-based
buffer overflow.
- Less segments than we expect, where the missing segments are a strict
truncation rather than missing in the middle.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/209001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the format of many directories so they don't show up in git status anymore.
Run dos2unix on *.cc, caught many inconsistent and CRLF files.
TBR=evan
TEST=still build, git status shows nothing
BUG=none
Review URL: http://codereview.chromium.org/211010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove old main(argc, argv) from syncable_unittest.
- Since the old notifier target had only one unittest,
merge it with the syncer tests.
- Remove listener_unittest.cc entirely.
- Don't compile natserver_main.cc, which has another main()
- Use a test main from the test_support_unit library. This
has the downside of pulling in a lot of deps we don't need,
but it gives us a run_all_unittests.cc.
- Fix a few compile errors in test code.
TEST=unit tests pass
BUG=none
Review URL: http://codereview.chromium.org/205021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/195103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.
What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.
Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
./third_party/hunspell/hunspell.gyp
./third_party/icu/icu.gyp
./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
-or-
Delete gyp_chromium.gypi and move its content back to common.gypi
Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.
Review URL: http://codereview.chromium.org/206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing of Anton Muhin's patch (antonm@google.com)
(Reland. First landed in r26264, reverted in r26276. This reland hopefully
doesn't build tcmalloc on Linux.)
Review URL: http://codereview.chromium.org/206017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r26264.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing of Anton Muhin's patch (antonm@google.com)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/206017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/205005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/196106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that are described in README.chromium and
a .diff file, under review separately.
I removed some of the weightier
autoconf/configure scripts. This brought the
size of the library from 3.8MB to about 2.3MB.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Libjingle depends on it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- If the xxx_segdir table gets corrupted, you can have non-contiguous indexes (idx).
- This causes an assertion in debug, and a crash later on on release
With this change it will return 'corrupted db'
We shall wait to get a couple more fixes to upstream to sqlite org.
BUG=21377
TEST=see bug
Review URL: http://codereview.chromium.org/203046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
using them for anything.
Review URL: http://codereview.chromium.org/192068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
linked with g++ instead of gcc.
BUG=none
TEST=build without warnings
Review URL: http://codereview.chromium.org/202046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libxml (as
thirdparty code) doesn't exclude _mac.cc files automatically.
BUG=none
TEST=build without warning
Review URL: http://codereview.chromium.org/194062
TBR=sgk@google.com
Review URL: http://codereview.chromium.org/201074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is meant to test to see if we can reduce SQL related crashes by
removing the pre-load optimization.
I also added a line of defensive code (initializing a pointer).
r=brettw
Review URL: http://codereview.chromium.org/203011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
third-party code) doesn't exclude _mac.cc files automatically.
BUG=none
TEST=build without warning
Review URL: http://codereview.chromium.org/194062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc
In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a).
Also updated is the test results for net_util_unittests.
This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there).
BUG=8198
TEST=On all platforms, all the targets are built fine.
Review URL: http://codereview.chromium.org/172031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the request was for realloc(ptr, 0). Calling realloc(ptr, 0)
is valid, and we should delete ptr and return NULL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The spec says that calling realloc(ptr, 0) should free ptr
and return NULL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/196041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This funciton is defined as part of tcmalloc; it shouldn't be in libcmt anymore.
BUG=none
TEST=none; we're removing code from libc. If this is a problem, it will fail to link.
Review URL: http://codereview.chromium.org/200036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not OS_WIN.
Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set.
Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX,
OS_LINUX or OS_FREEBSD.
Added USE_NSS for ... nss (for crypto). Windows and MacOS use
platform-specific libraries.
All of the above cause slightly odd formulations like:
#if defined(OS_WIN)
...
#elif defined(USE_BASE_DATA_PACK)
...
#endif
Possibly should also define USE_DLL_FOR_DATA, etc? Or something?
Wrapped various references to struct stat64 and stat64() to use struct
stat and stat() for FreeBSD - but a "man stat64" on Linux suggests
that we could do the same thing for at least Linux, too, and perhaps
eliminate the wrapper?
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/195009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(http://codereview.chromium.org/174631).
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/180021/show
Restore decommitting in IncrementalScavenge and draft Scavenge method to
be invoked periodically
to reduce amount of committed pages.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/187008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The crash in history::TextDatabase::GetTextMatches is caused by unexpected result of tolower() in some locales such as tr_TR.UTF-8. This CL fixes this issue by using following statement to replace tolower():
(ch>='A' && ch<='Z') ? (ch-'A'+'a') : ch
which will always return expected result for ascii characters regardless of current locale.
BUG=15261 Crash in history::TextDatabase::GetTextMatches
TEST=none
Review URL: http://codereview.chromium.org/174387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I managed to save 30s with this change!
I had to change the interface of the test server a bit. Now the credentials
to be used are passed (optionally) for TestPage request, not in the ctor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/182031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/175021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
didn't work in a clean client since tcmalloc.h wasn't generated.
Review URL: http://codereview.chromium.org/173387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
config.h provided (by the protobuf project) for
msvc.
Review URL: http://codereview.chromium.org/173370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL171023 by Song YeWen.
BUG=16020
TEST=test with all media types and ensure there are no memory leaks are
functional differences from previous version.
Review URL: http://codereview.chromium.org/174027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
unicode text. This is required for an extension API which returns the top three languages for a web page.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I forgot to add the cpu profiler files last time and got surprised when CPUPROFILE didn't do anything. I've added the files in now.
I also made the libcmt dependency specific to windows, since the make build doesn't like it.
Review URL: http://codereview.chromium.org/173110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly changes to tcmalloc.gyp to get tcmalloc building for linux.
Supports the full google-perftools tool suite (heapchecker, heapprofiler, cpuprofiler).
Adds in a fix for malloc_hook.cc that is not upstream yet. Forked malloc_hook.cc.
Forces linking in a symbol that is not used except by a static initializer which was getting stripped out, thereby getting heap profiler to work even when statically linked.
TODO: integrate with allocator_shim
TODO: support jemalloc
TODO: support debugallocation
Review URL: http://codereview.chromium.org/173017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
variables.
BUG=16779
TEST=none
Review URL: http://codereview.chromium.org/172060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out that pkgconfig produces no output if --atleast-version is
given. Thus we list the cflags twice, once to catch the version error
and then a second time to get the flags we need.
(Reported by fta.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recursion overflow).
I used https://bugzilla.redhat.com/attachment.cgi?id=356032 and fixed the issue with lint vs. tabs.
BUG=19158
TEST=http://cevans-app.appspot.com/static/CVE-2009-2416.xml
Review URL: http://codereview.chromium.org/172025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When building with use_system_libpng, the build will end up using the
png.h from third_party because I put the defines stanza in the wrong
place.
(reported by fta)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
lands r165517
Review URL: http://codereview.chromium.org/172034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/164450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19094
TEST=Linux Builder (ChromeOS) compile turns green
Review URL: http://codereview.chromium.org/164478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19094
TEST=Linux Builder (ChromeOS) compile turns green
Review URL: http://codereview.chromium.org/164477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23307 0039d316-1c4b-4281-b951-d872f2087c98
|