| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several parts of chrome that use protobufs depend on the static library 'protobuf_lite' in third_party/protobuf. As more parts of chrome are pulled into their own components, we end up linking duplicate copies of protobuf_lite into each of them. This causes memory corruption errors due to protobuf's use of static variables to maintain state.
Componentizing protobuf_lite isn't as simple as changing its target type to '<(component)'. This is because there is a larger, more full-fledged version of protobuf in the target 'protobuf_full_do_not_use', which cannot be dynamically linked with the component protobuf_lite. This is because several classes declared in protobuf_lite are partially defined in protobuf_full_do_not_use, due to which we run into issues with dllexport/dllimport annotations.
The target 'protobuf_lite' is used as a dependency all over chrome, while the target 'protobuf_full_do_not_use' is used only in one place, where it is statically linked into the protobuf compiler executable 'protoc'.
This patch does the following:
1) Pulls out most of the target definitions of 'protobuf_lite' into a separate gypi file.
2) Defines protobuf export macros for all platforms in protobuf/stubs/common.h.
3) For the target 'protobuf_lite':
- Changes the target type to '<(component)'.
- Includes the contents of protobuf_lite.gypi.
- Exports symbols via the LIBPROTOBUF_EXPORT macro.
- Makes sure targets that consume it can import its symbols.
4) For the target 'protobuf_full_do_not_use':
- Retains the target type of 'static_library'.
- Includes the contents of protobuf_lite.gypi instead of depending on the target 'protobuf_lite'.
BUG=172800
TEST=Enable component builds and make sure all chrome targets build, and all tests run and pass.
Review URL: https://codereview.chromium.org/12090058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Linux and Chrome OS, we implement user-land ASLR in TCMalloc
on 64 bits Intel architecture.
In this configuration, we are not constrained by the address space
and we don't mind fragmentation.
But to be on the safe side, we only ever fragment half of the
address space.
BUG=170133
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12093035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=bots and apprtc
Review URL: https://codereview.chromium.org/12092054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=172129, 166496
Review URL: https://codereview.chromium.org/12036108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Addressing comment that I missed when landing
https://codereview.chromium.org/12051049/
TBR=ronghuawu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12035096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
New version adds DTMF support and various other fixes.
Review URL: https://codereview.chromium.org/12051049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
notably jingle) in order to bring up the complete sync_notifier target on iOS.
TBR=thakis
Review URL: https://chromiumcodereview.appspot.com/12041016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=169866,169855,169851
Review URL: https://chromiumcodereview.appspot.com/12033058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=171542,171721,166496
TEST=ffmpegsumo target builds on win64 with private fix to disable ffmpeg compiler warning 4267 on win64
Review URL: https://chromiumcodereview.appspot.com/12059002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So client code of histogram will see a simpler interface. This also makes adding SparseHistogram to existing metrics framework possible.
This CL depends on https://codereview.chromium.org/11682003/
So please review that one first.
TBR=sky@chromium.org,erikwright@chromium.org
BUG=139612
Review URL: https://chromiumcodereview.appspot.com/11615008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for nacl untrusted build.
BUG=161389
Review URL: https://codereview.chromium.org/11862016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove forward-definitions of EGL types from ui/gl/gl_bindings.h, and use
the actual EGL headers instead.
* Clean up users of gl_bindings.h to not use system headers.
BUG=chromium:169433
TEST=local build, run on snow; trybots
Change-Id: Ibdf8f92574ff1a31389531fa462f05319b20a66f
Review URL: https://chromiumcodereview.appspot.com/11961032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111541
TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11871013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=165264
Review URL: https://codereview.chromium.org/11871003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes there are mostly refactorings, with some minor changes
around when the client sends presence heartbeats after coming
online.
Review URL: https://chromiumcodereview.appspot.com/11993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change is needed to add win64 support to libvpx.
BUG=166496, 170672
Review URL: https://chromiumcodereview.appspot.com/11971037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111541
TBR=thestig@chromium.org,gdk@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11961025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from ui\.
This is a cleanup after r177425 which I didn't want to do in that already large cl.
BUG=169170
Review URL: https://codereview.chromium.org/11971042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11975050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=169328
Review URL: https://chromiumcodereview.appspot.com/11970020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11956020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=161389
Review URL: https://codereview.chromium.org/11973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Especially ffmpeg may be prone to errors in this area.
Googlers: see b/1397952 for reference.
BUG=30715
Review URL: https://codereview.chromium.org/11823061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=webrtc 850,940 crbug 165326
Review URL: https://chromiumcodereview.appspot.com/11828060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For security purposes, we restrict the maximum size of memory allocations under
what can be indexed by an int.
BUG=169327
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11857007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=161389, 165264
Review URL: https://codereview.chromium.org/11693007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Uses EGL_CHROMIUM_sync_control (a subset of GLX_OML_sync_control) to calculate refresh rate and when refreshes occur. This CL factors out common code from the GLX_OML_sync_control implementation.
BUG=none
TEST=by hand on stumpy, daisy, and desktop
Review URL: https://codereview.chromium.org/11865021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=166496
BUG=167187
TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/11887007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old code misused the macros provided by histogram.h such
that a DCHECK failed on the bots. UMA_HISTOGRAM_ENUMERATION
et al use a static variable to retrieve the Histogram
objects, so a single instance of that macro can't be used to
retrieve multiple histograms. The old code tried to retrieve
both LevelDBEnv.IOError and LevelDBEnv.IDB.IOError. This CL
forgoes use of the macro and keeps a pointer to the
Histogram objects around.
http://wkb.ug/106135 will have to reland to make use of this.
BUG=164755
Review URL: https://chromiumcodereview.appspot.com/11860015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11848002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previous revision: 431bef2e16c7888ca3960f5797432d3a20903550
New revision: 34e6c3e3e452bdf6f93df565a70453a6e74d4c6e
BUG=160254
TEST=See the bug.
Review URL: https://codereview.chromium.org/11781005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=168437
R=dgrogan@chromium.org,alecflett@chromium.org,ericu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11817056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=166496
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11818046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jschuh@chromium.org
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11778103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jschuh@chromium.org
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11823056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jschuh@chromium.org
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11827052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jschuh@chromium.org
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11783096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=166496
BUG=167187
TBR=scottmg
Review URL: https://chromiumcodereview.appspot.com/11819049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=166496
BUG=167187
TBR=shess
Review URL: https://chromiumcodereview.appspot.com/11819042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jschuh@chromium.org
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11778076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jschuh@chromium.org
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11823040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly disable c4267, but a couple that seem safe to me.
R=jschuh@chromium.org
BUG=167187
Review URL: https://chromiumcodereview.appspot.com/11819038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a step toward making third_party/khronos/gl2.h and gl2ext.h
have as few modifications as possible.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11782020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=165264
Review URL: https://codereview.chromium.org/11747019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because of an optimization in Unlock(), we can't expect explicit
wake-ups and shouldn't wait for too long in SpinLockDelay.
BUG=168139
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11784009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only change applicable to chromium is a fix for a bug
that causes corruption. The corruption manifests as a missing
sst file that renders the database unopenable.
BUG=168649
Review URL: https://chromiumcodereview.appspot.com/11775018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Other LevelDB consumers will still be aggregated under LevelDBEnv.
BUG=164755
Review URL: https://chromiumcodereview.appspot.com/11776009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add "scrypt" to third_party for use in generating secure hash of user password that can later be used for off-line authentication in the case when on-line authentication is not available.
>
> The planned use for this is profile-locking where unlocking has to be possible even when not connected to a network.
>
> BUG=
>
>
> Review URL: https://chromiumcodereview.appspot.com/11637016
TBR=bcwhite@chromium.org
Review URL: https://codereview.chromium.org/11776013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that Google Chrome will continue to use bundled re2.
The option is off by default, and is intended for Linux distros.
BUG=165264
TEST=none
Review URL: https://codereview.chromium.org/11366051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The change was included by accident and possibly causing memory bots
failures.
BUG=
Review URL: https://codereview.chromium.org/11774003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175197 0039d316-1c4b-4281-b951-d872f2087c98
|