| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This works around webkit sensitivity to allocators that return
zero in this case.
BUG=20200
TEST=none
Review URL: http://codereview.chromium.org/302005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code from chrome\common.
Also added canvas support and hooked up NPAPI interface functions.
No tests have been added yet, so this is probably not fully ready.
Review URL: http://codereview.chromium.org/291001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tracking the thread id in the constructor, destructor and Start()
shows that the thread object can be started and stopped on
different threads. This means that there is a race condition
if Stop() or Join() gets called during Start(), which could cause
the thread to start with a pointer to a deleted object.
BUG=23251
TEST=none
Review URL: http://codereview.chromium.org/274079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.
BUG=23073
TEST=trybot
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29258
Review URL: http://codereview.chromium.org/279004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: nick@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major changes:
- Moved sync_setup_{flow,wizard} to sync directory.
- Made browser_with_test_window_test compile on non-Windows platform.
- Moved localized contents font util functions to app/.
BUG=23073
TEST=trybot
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255
Review URL: http://codereview.chromium.org/279004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building chrome, override the default implementation so
that we share the winsock initialization singleton with net/base.
Trigger the winsock initialization lazily in a few places.
This is intended to fix a startup perf regression that appeared
when sync (and libjingle) became linked into chrome.dll, rather
than a separate delay-loaded sync dll.
BUG=24448
TEST=Verified deferred winsock initialization via debugger. Measured before and after time of the StartupTest.PerfTest. Verified sync notification still work.
Review URL: http://codereview.chromium.org/267089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23450
TEST=valgrind_webkit_tests.sh LayoutTests/fast/text/drawBidiText.html
Review URL: http://codereview.chromium.org/271098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
interface for passing events to the module. Slightly tweaked the
definition of keyboard events from Nicholas' specification because
the characters have become wchar_t.
Review URL: http://codereview.chromium.org/266054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
description:
Numerous fixes to get parts of Chrome Sync to compile on OS X.
Fixes include:
- Added missing definitions for some static const class variables.
- Added some missing dependencies.
- Marked some Windows-only dependencies as such.
- Added stub files for some platform-specific classes.
BUG=none
TEST=Put through trybots.
Review URL: http://codereview.chromium.org/266065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a severely pared down version of webplugin_delegate files
that are not currently used to create any instances.
Also adds calls for render APIs that remain to be
connected to the impelementation. The function pointers are
returned by NPN_GetValue calls with new enumerated values.
I have also added Nicholas' NPEvent definitions.
These changes are to permit further collaboration between
sehr, brettw, and cpu.
Review URL: http://codereview.chromium.org/270024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/264026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23251
TEST=none
Review URL: http://codereview.chromium.org/261043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add high res timer class for mac (we might eventually replace all timer classes with Chrome ones)
- Define POSIX for OS==mac where needed
- Add new liens at the end of some files since otherwise they produce errors on Mac
- Rearrange initializer list of constructors to match declaration order in header; these become warning as error.
- Some chrome.gyp magic
At this point the code compiles but doesn't link due to some missing code on Mac like SSL stuff. But
I thought this was a good check point.
Note that chrome.gyp magic might change in future.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NPN_GetAuthenticationInfo. With these NPAPI functions there's no need to simulate being in Firefox and implement NPN_GetValue for NPNVserviceManager.
TEST=run manual test that Ken added in test\data\plugin over http
Review URL: http://codereview.chromium.org/251101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
heap's freelists
Keeps track of the number of reserved but not committed pages in the freelist and uses that to calculate a waste metric, which is the ratio of committed pages vs pages used by the application. This is exposed in the GetStats() call (which is used for about:tcmalloc) and through GetNumericalProperty() in MallocExtension.
BUG=none
TEST=open about:tcmalloc and monitor 'WASTE' columns while using the browser
Review URL: http://codereview.chromium.org/251065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/243095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GLEW's bootstrapping sequence on both X11 and Windows platforms to
avoid linking against libGL.so.1 directly due to
http://crbug.com/16800 . Made GLEW's inclusion of glu.h optional.
Tested on Linux, Mac and Windows.
BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)
Review URL: http://codereview.chromium.org/258024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/206021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
With TCMalloc now being more conservative about commitment, this change
will reenable it as the default allocator.
r=mbelshe,jamesr
Review URL: http://codereview.chromium.org/246089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This changes to decommitting in all paths through the
page_heap delete method (which adds spans to the free lists).
r=mbelshe,jamesr
Review URL: http://codereview.chromium.org/255067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
try servers:
Set the LITE runtime optimization flag in sync.proto.
This generates c++ code without support for protobuf reflections, and
shaves 175000 bytes off of the final release size of syncapi.dll.
Review URL: http://codereview.chromium.org/242133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used the GPU to vertically flip the framebuffer. Updated GLEW to use
standard dlopen / dlsym rather than deprecated mach-o/dyld functions;
updated README.chromium.
BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)
Review URL: http://codereview.chromium.org/256037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23602
BUG=13907
1. FFmpeg binaries are copied to TestShell.app/Contents/MacOS
2. Load media_*.png for drawing the controls
Review URL: http://codereview.chromium.org/248042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This generates c++ code without support for protobuf reflections, and
shaves 175000 bytes off of the final release size of syncapi.dll.
BUG=none
TEST=tested sync interactively with two clients.
Review URL: http://codereview.chromium.org/249034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Split out the fts2 changes a little.
BUG=NONE
TEST=Applied the patches in order to check for mistakes.
Review URL: http://codereview.chromium.org/243068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Note which sqlite version we are based off.
- Note some prerequisite packages for running the tests.
- Note that a couple of tests fail.
BUG=n/a
TEST=n/a
Review URL: http://codereview.chromium.org/257016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I got this change approved to try out earlier, and landed it. I rolled
it back (to be conservative) after I got a chromebot run started. Since
that bot run didn't show any giant problems, this will re-land the
change, so we can see how users (such as on a dev channel release) do
with this allocator.
This is really experimental... but it will give us some info to make a
better decision between ongoing tuning of TCMalloc and at least
temporarilly using JEMalloc.
tbr=mbelshe
Review URL: http://codereview.chromium.org/256024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I wanted to see how the chromebot would do with JEMalloc.
I just checked it in, and after a chrome-bot run kicks off, I'll land
this effectively reverting rev 27702 back to using TCMalloc.
tbr=mbelshe
Review URL: http://codereview.chromium.org/242092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=jamesr,mbelshe
Review URL: http://codereview.chromium.org/244055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a landing of a patch provided by antonm. See:
http://codereview.chromium.org/235022
Also included change to browser_about_handler.cc to fix build, and I set
TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this
was an inadvertent rollback element).
r=antonm
Review URL: http://codereview.chromium.org/257009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out-of-bounds reads and writes.
Apologies for the size of the change but once I got cranking, it was about
half a day to clean up most of the memory errors.
This should not conflict with the in-progress sqlite-3.6.18 upgrade. I diffed
sqlite-3.6.1 vs. sqlite-3.6.18 and the only changes to fts2.c were two spelling
corrections in comments.
These changes are not whimsical -- they do map to crashes we are seeing
in the wild, e.g.
1) Crash in allocator just after leafReaderStep:
http://crash/reportdetail?reportid=303de6d80936c11d
2) Crash in memcpy in leafReaderStep:
http://crash/reportdetail?reportid=6b2c65459042e67c
3) Crash in memcpy in interiorReaderStep:
http://crash/reportdetail?reportid=9f7ba5c321846302
4) Crash in loop in dlrStep trying to read past end of buffer:
http://crash/reportdetail?reportid=61b2eb58397913b2
In addition, this will give relief to users who have (for whatever root cause)
persistent corruption in their databases. Once you get into that state, Chrome
might be unlaunchable or it might crash multiple times per day.
There's a small chance this might help with our biggest crasher, as certain
types of corrupt database could corrupt memory rather than crashing immediately.
BUG=NONE
TEST=Running with tricked out build with assert()s to check for false positives.
Review URL: http://codereview.chromium.org/216026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(pwicks86@gmail.com).
TEST=Use OCMock in a test
BUG=NONE
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled in the build. Change ENABLE_3D_CANVAS to 1 in
src/third_party/WebKit/WebKit/chromium/features.gypi and regenerate
project files to compile. Current code is Windows-specific and
requires the sandbox to be disabled. Follow-on work will add ports to
other platforms and eventually work with the sandbox enabled.
This CL follows https://bugs.webkit.org/show_bug.cgi?id=29664 .
BUG=http://code.google.com/p/chromium/issues/detail?id=21852
TEST=none (runs preexisting WebGL layout tests; more coming)
Review URL: http://codereview.chromium.org/219001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
logging.h to suppress the definition of LOG() and friends unless
explicitly requested. Fix gyp paths to overrides files.
Review URL: http://codereview.chromium.org/225001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The intent is to fix a link error that seems to happen when two
compilation units share a filename: there is another constants.cc in
p2p/base. Touch xmppconstants.h to work around a git cl upload bug.
Review URL: http://codereview.chromium.org/244010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
get it from the build/build_config.h.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/248004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/245006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I asked dannyb@, he was ok with that as long as we put it somewhere into third_party. The code will be used e.g. in the search engine manager, the task manager and maybe in the frozen renderer dialog.
I copied the files from /Developer/Examples/AppKit/DragNDropOutlineView on a Leopard system (and copied the license notice from the m file to the h file).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/231026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prevent fragmentation
Actually on Windows VirtualAlloc'ated address might have bigger alignment than reported by SYSTEM_INFO.dwPageSize, see SYSTEM_INFO.dwAllocationGranularity.
As coalescing of spans in tcmalloc requires that those spans are physically adjacent, using smaller alignment inhibited coalescing. Additional benefit is we now
require ways less memory at least in some case.
Also adds assert()s for alignment values that would lead to pathological virtual address space waste. No current callers pass in alignment values other than kPageSize and it's unlikely anyone will.
Original patch and discussion was at http://codereview.chromium.org/235003
Patch by: antonm@chromium.org
BUG=22701
TEST=Manually checked test page that did 10m XHR. Memory use goes from >2GB and a crash to 102MB. Membuster shows the change is roughly within noise and possibly a very slight regression ( <<5% ).
Review URL: http://codereview.chromium.org/222028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22926
TEST=still builds
Review URL: http://codereview.chromium.org/231020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
compiler.
BUG=22635
TEST=none
Review URL: http://codereview.chromium.org/231010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/209058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"...may be suffering from what we in the soft sciences call 'Obsessive
Compulsive Disorder,' or the 'The O.C. Disorder.'"
Here's what we're doing:
mkdir OCMock
svn add OCMock
for i in * ; do
if [ "${i}" != "OCMock" ] && [ "${i}" != "README.chromium" ] ; then
svn move "${i}" OCMock
fi
done
and make the SVN URL in README.chromium a tiny bit more specific.
Review URL: http://codereview.chromium.org/220017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/216025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/207024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bugfixes:
1) calling the new handler would return true when exceptions
were disabled. In Chrome's case, this didn't matter,
because we use a handler which forces a crash. However,
if you use a different handler that doesn't crash, this
causes a loop - forever calling the new handler. Return
false instead as there is no other way to break the loop.
2) recalloc() was broken. It was zeroing the buffer on
recalloc calls, which is incorrect.
testing:
I took a set of tests from tcmalloc and applied them into a
new unittest. The new unittest can test all allocators
used by the allocator-shim. I included the atomic tests
in here, simply because it was easy to do, and it seemed
it could prove useful for cross platform testing. Overall,
I'd say these are a sanity test, and not a comprehensive test.
BUG=none
TEST=tcmalloc_unittests.cc
Review URL: http://codereview.chromium.org/213030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26651 0039d316-1c4b-4281-b951-d872f2087c98
|