summaryrefslogtreecommitdiffstats
path: root/third_party
Commit message (Collapse)AuthorAgeFilesLines
* Enable TCMalloc doubly-linked freelist in release buildsBUG=NoneTEST=Nonejschuh@chromium.org2011-10-132-3/+6
| | | | | | Review URL: http://codereview.chromium.org/8242017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105312 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build with system yasm.phajdan.jr@chromium.org2011-10-121-2/+7
| | | | | | | BUG=100078 Review URL: http://codereview.chromium.org/8243012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105149 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gps.h license issue, by deleting itjoth@chromium.org2011-10-102-656/+5
| | | | | | | | | | | BUG=98132,99326 TEST=used gpsfake (from lucid package 2.92) and opened maps.google.com/maps/m Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104481 Review URL: http://codereview.chromium.org/8171006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104716 0039d316-1c4b-4281-b951-d872f2087c98
* Add back in file drover failed to restore in r104482joth@chromium.org2011-10-071-0/+651
| | | | | | | | | | BUG= TEST= TBR=bulach@chromium.org Review URL: http://codereview.chromium.org/8206001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104484 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 104481 - Fix gps.h license issue, by deleting itjoth@chromium.org2011-10-071-5/+5
| | | | | | | | | | | | BUG=98132,99326 TEST=used gpsfake (from lucid package 2.92) and opened maps.google.com/maps/m Review URL: http://codereview.chromium.org/8171006 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/8199006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104482 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gps.h license issue, by deleting itjoth@chromium.org2011-10-072-656/+5
| | | | | | | | | BUG=98132,99326 TEST=used gpsfake (from lucid package 2.92) and opened maps.google.com/maps/m Review URL: http://codereview.chromium.org/8171006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104481 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the executable permission from some files in third_party/psutil.imasaki@google.com2011-10-072-0/+0
| | | | | | Review URL: http://codereview.chromium.org/8183009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104435 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property on class_diagram.pngnsylvain@chromium.org2011-10-071-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104430 0039d316-1c4b-4281-b951-d872f2087c98
* Update third_party/psutil and fix the licence issue with it.imasaki@google.com2011-10-0754-2351/+6608
| | | | | | | | | BUG=98456 TEST=None Review URL: http://codereview.chromium.org/8159001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104425 0039d316-1c4b-4281-b951-d872f2087c98
* Catch some "easy to spot" double frees in TCMallocjar@chromium.org2011-10-052-2/+17
| | | | | | | | | | | | | This will only work when the double frees happen to be close enough in time, and both happen on the same thread... ...but it should have almost zero cost to do the check. r=jschuh BUG=75921 Review URL: http://codereview.chromium.org/8000001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104188 0039d316-1c4b-4281-b951-d872f2087c98
* Recognize Apple licenses.phajdan.jr@chromium.org2011-10-032-7/+21
| | | | | | | | BUG=98114, 98115 Review URL: http://codereview.chromium.org/8085016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103729 0039d316-1c4b-4281-b951-d872f2087c98
* Add license text to files that were missing it in third_party/hyphen.rolandsteiner@chromium.org2011-10-035-265/+446
| | | | | | | | | BUG=98136 TEST=none (no code change) Review URL: http://codereview.chromium.org/8071019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103685 0039d316-1c4b-4281-b951-d872f2087c98
* Make the license tools recoginze the dual licensemichaelbai@chromium.org2011-10-012-4/+17
| | | | | | | | | | BUG=98116 TEST= Review URL: http://codereview.chromium.org/8094004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103594 0039d316-1c4b-4281-b951-d872f2087c98
* leveldb should be able to handle non-ascii db pathskinuko@chromium.org2011-09-301-5/+16
| | | | | | | | | BUG=94314 TEST=manually tested with --user-data-dir=<non_latin_path> option Review URL: http://codereview.chromium.org/8056003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103424 0039d316-1c4b-4281-b951-d872f2087c98
* Include full license text in speex_types.h to get the license check script ↵satish@chromium.org2011-09-292-12/+16
| | | | | | | | | | pass this file. BUG=98466 Review URL: http://codereview.chromium.org/8077003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103364 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused qcms library.phajdan.jr@chromium.org2011-09-2911-3265/+0
| | | | | | | BUG=98460 Review URL: http://codereview.chromium.org/8079005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103316 0039d316-1c4b-4281-b951-d872f2087c98
* Rolls cacheinvalidation forward to @143. (The only C++ changes are the ↵ghc@google.com2011-09-281-3/+4
| | | | | | | | license fixes.) Review URL: http://codereview.chromium.org/8037054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103074 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more files (needed by webrtc/peerconnection) to libjingle targets.ronghuawu@google.com2011-09-271-3/+70
| | | | | | | | TEST=Unittests Review URL: http://codereview.chromium.org/8051017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103045 0039d316-1c4b-4281-b951-d872f2087c98
* Roll sfntly to r98arthurhsu@chromium.org2011-09-262-49/+75
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8037029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102795 0039d316-1c4b-4281-b951-d872f2087c98
* Roll LevelDB 47:51, add memenv to gypi.hans@chromium.org2011-09-262-1/+4
| | | | | | | | | | | | This picks up some minor fixes and adds support for in-memory databases. BUG=92051 TEST=everything builds, current tests pass Review URL: http://codereview.chromium.org/8037024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102759 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the third-party tool: lcov-v1.9philmarti@google.com2011-09-2335-0/+22458
| | | | | | | | | Pristine condition, original packaging ! Added just README.chromium and LICENSE files Review URL: http://codereview.chromium.org/7926007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102477 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude ffmpeg from the build when building for Android.peter@chromium.org2011-09-231-3/+4
| | | | | | | | | | | | | | | | Conditionalize the ffmpeg dependency and exclude files which rely on it for the media and media_unittest targets. Disable the ffmpeg_unittests, ffmpeg_tests and media_bench for Android targets as they require it. This change also conditionalizes the inclusion of yasm_compile.gyp, as yasm is only used for the ia32 and x86 target architectures. BUG= TEST= Review URL: http://codereview.chromium.org/7977023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102474 0039d316-1c4b-4281-b951-d872f2087c98
* Speed up check_licenses by another 30% by scanning less files.phajdan.jr@chromium.org2011-09-222-0/+19
| | | | | | | | | | This improves run time from ~3 minutes to ~2 minutes for me locally. BUG=28291 Review URL: http://codereview.chromium.org/7974012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102363 0039d316-1c4b-4281-b951-d872f2087c98
* Make check_licenses about 5x faster.phajdan.jr@chromium.org2011-09-222-56/+97
| | | | | | | | | | | I've used a profiler and removed code that takes long time bug we don't use, and optimized several regular expressions. BUG=28291 Review URL: http://codereview.chromium.org/7988008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102307 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'settings' type from gyp filesevan@chromium.org2011-09-227-7/+7
| | | | | | | | | | | It is not actually supported by gyp; the fact that it works is a bug that I am working on fixing. BUG=96629 Review URL: http://codereview.chromium.org/7889051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102306 0039d316-1c4b-4281-b951-d872f2087c98
* Make isimpledom write shared generated files to SHARED_INTERMEDIATE_DIRrsleevi@chromium.org2011-09-221-18/+11
| | | | | | | | | | BUG=97186 TEST=none Review URL: http://codereview.chromium.org/7973006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102254 0039d316-1c4b-4281-b951-d872f2087c98
* Make iaccessible2 write shared generated files to SHARED_INTERMEDIATE_DIRrsleevi@chromium.org2011-09-221-15/+12
| | | | | | | | | | BUG=97186 TEST=none Review URL: http://codereview.chromium.org/7971008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102247 0039d316-1c4b-4281-b951-d872f2087c98
* Enable tcmalloc validation by default in debug buildsjamesr@chromium.org2011-09-211-3/+5
| | | | | | | | | | BUG=none TEST= Review URL: http://codereview.chromium.org/7976011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102083 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_ptr.hakalin@chromium.org2011-09-186-6/+6
| | | | | | | | | | | Fix remaining users to use base/memory/scoped_ptr.h. BUG= TEST= Review URL: http://codereview.chromium.org/7930009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix building libxml for Androidpeter@chromium.org2011-09-181-2/+2
| | | | | | | | | | | libxml should be built with _REENTRANT defined when building for Android, as this will enable threading. BUG= TEST= Review URL: http://codereview.chromium.org/7926009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101702 0039d316-1c4b-4281-b951-d872f2087c98
* mac make: Fix build.thakis@chromium.org2011-09-161-0/+1
| | | | | | | | | | | | This was broken by http://src.chromium.org/viewvc/chrome?view=rev&revision=101378 BUG=none TEST=mac make build works again TBR=pkasting Review URL: http://codereview.chromium.org/7918016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101486 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth attempt at the following. Unreviewed, this was originally reviewed ↵pkasting@chromium.org2011-09-152-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | in http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7903016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101378 0039d316-1c4b-4281-b951-d872f2087c98
* [SQLite] Hack to touch page cache to debug slow connection close.shess@chromium.org2011-09-142-0/+106
| | | | | | | | | | | | | | | | | | The shutdown-monitor has noted cases where sqlite3_close() is taking a very long time to finish. In reviewing the code, writes are committed before the close is called, so there should be almost no I/O involved (excepting perhaps unlocking the file?). One hypothesis is that the SQLite page cache, which is LRU, may have very old pages which have been paged out. This change touches them all, so if they are paged out the crash should move to this code. BUG=95527 TEST=Monitor crash in bug, see if it changes. Review URL: http://codereview.chromium.org/7891025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101034 0039d316-1c4b-4281-b951-d872f2087c98
* Desist libxml from continuing the parse after a SAX callback has stopped thecevans@chromium.org2011-09-132-4/+13
| | | | | | | | | | | | parse. Attempt 2 -- now with less compile fail on Mac / Clang. BUG=95465 TBR=cdn TEST=covered by existing tests under ASAN Review URL: http://codereview.chromium.org/7892003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100953 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100883 - Desist libxml from continuing the parse after a SAX callback ↵ukai@chromium.org2011-09-132-13/+4
| | | | | | | | | | | | | | | has stopped the parse. BUG=95465 TEST=covered by existing tests under ASAN Review URL: http://codereview.chromium.org/7875008 TBR=cevans@chromium.org Review URL: http://codereview.chromium.org/7886003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100884 0039d316-1c4b-4281-b951-d872f2087c98
* Desist libxml from continuing the parse after a SAX callback has stopped thecevans@chromium.org2011-09-132-4/+13
| | | | | | | | | | parse. BUG=95465 TEST=covered by existing tests under ASAN Review URL: http://codereview.chromium.org/7875008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100883 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: check in Debian's licensecheck utility.phajdan.jr@chromium.org2011-09-134-0/+964
| | | | | | | | | | | There are some custom patches to recognize more license headers, most of them are upstreamable and I'm going to submit them upstream. BUG=28291 Review URL: http://codereview.chromium.org/7875009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100816 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream Android change for libeventmichaelbai@google.com2011-09-125-0/+548
| | | | | | | | | | | Add proper config for Android to libevent. Enable libevent to compile without needing __linux__. BUG= TEST= Review URL: http://codereview.chromium.org/7866018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100742 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-099-39/+359
| | | | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. By default flag is only set in Debug builds. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99515 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100074 Review URL: http://codereview.chromium.org/7671034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100525 0039d316-1c4b-4281-b951-d872f2087c98
* Add a copy of the SMHasher library. MurmurHash3 will be used by ↵bryner@chromium.org2011-09-093-0/+51
| | | | | | | | | | | | | | SafeBrowsing phishing detection. We'll be modifying the page_words field in ClientSideModel with murmurhash3's of the words, rather than SHA-256 hashes, since SHA-256 is fairly expensive to compute. Note that on a murmurhash3 hit, we'll still do a SHA-256 check against page_terms, so this will not introduce term collisions. BUG=none TEST=none Review URL: http://codereview.chromium.org/7848010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100347 0039d316-1c4b-4281-b951-d872f2087c98
* OOB read in tibetan_nextSyllableBoundarybashi@chromium.org2011-09-082-1/+14
| | | | | | | | | | | | Avoid refering tibetanForm table when the character is out of its range. BUG=95563 TEST=manually tested with ASAN Review URL: http://codereview.chromium.org/7841023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100106 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100074 - tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-089-359/+39
| | | | | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99515 Review URL: http://codereview.chromium.org/7671034 TBR=bxx@chromium.org Review URL: http://codereview.chromium.org/7845012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100087 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-089-39/+359
| | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99515 Review URL: http://codereview.chromium.org/7671034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100074 0039d316-1c4b-4281-b951-d872f2087c98
* Use precompiled headers for most large projects where the .gyp filejoi@chromium.org2011-09-075-0/+15
| | | | | | | | | | | | | | is not a third party file. On my machine, this speeds up a full recompile of the 'chrome' target in Debug mode by about 18%. BUG=none TEST=it builds, existing tests pass Review URL: http://codereview.chromium.org/7706011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99949 0039d316-1c4b-4281-b951-d872f2087c98
* Adding yasm_include.gypi to reuse rules for compiling assembly fileshclam@chromium.org2011-09-061-0/+97
| | | | | | | | | | | | There are a couple spots where we use YASM and this change is a start to organize the usage of YASM in chromium tree. BUG=None TEST=None Review URL: http://codereview.chromium.org/7800039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99751 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 99515 - tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-039-359/+39
| | | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. BUG=None TEST=None Review URL: http://codereview.chromium.org/7671034 TBR=bxx@chromium.org Review URL: http://codereview.chromium.org/7834009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99520 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-039-39/+359
| | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. BUG=None TEST=None Review URL: http://codereview.chromium.org/7671034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99515 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed stencil Test example. Writing to stencil buffer was getting disabled ↵alokp@chromium.org2011-08-312-0/+2
| | | | | | | | after the first frame. Review URL: http://codereview.chromium.org/7740058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99035 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 98885 - Third attempt at the following. Unreviewed, this was ↵rsleevi@chromium.org2011-08-312-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | originally reviewed in http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7804001 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7778035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98917 0039d316-1c4b-4281-b951-d872f2087c98
* Third attempt at the following. Unreviewed, this was originally reviewed in ↵pkasting@chromium.org2011-08-302-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/7550002 . Clean up SSL false start blacklist code. Numerous changes, including: * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7804001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98885 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 02:25:04 +0000