| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
in when libpeerconnection is built as a shared library and component==static_library. This is to support the case when chrome is using tcmalloc. Libjingle currently has many cases of using stl types in interfaces (strings and vectors), so the allocator for these objects must be the same when crossing binary boundaries.
BUG=226423
Review URL: https://codereview.chromium.org/13685020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Autogenerated with:
for a in $(git ls-files | grep \\.isolate); do tools/swarm_client/isolate_merge.py $a -o $a; done
content/content_browsertests.isolate failed to be converted automatically.
NOTRY=true
TBR=csharp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/13654003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/13473015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I set DYLIB_INSTALL_NAME_BASE to be @loader_path/Libraries and not @loader_path/../Libraries since the framework sits in the parent folder of the Libraries folder.
Review URL: https://codereview.chromium.org/13237002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
On a particular day, 2.3% of failing Env calls were LockFile, which is only called while opening a database. A LockFile failure results directly in a directory deletion in IDB.
BUG=225051
Review URL: https://chromiumcodereview.appspot.com/13460007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=225051
Review URL: https://chromiumcodereview.appspot.com/13084012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
third_party/harfbuzz-ng/src/hb-blob.cc.
BUG=225651
TBR=jshin@chromium.org
Review URL: https://codereview.chromium.org/13442002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses the SQLite pager layer to fetch a leaf node and read the data
from it, returning the data as the results from a query against a
recover table.
This CL should cause no changes to Chromium, as it does not get compiled.
BUG=109482
TEST=SQLite test suite.
Review URL: https://chromiumcodereview.appspot.com/13196005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old revision: 34e6c3e3e452bdf6f93df565a70453a6e74d4c6e
New revision: f872a17462a75a3493623747bf3a3fbe54556c7b
What's new:
- A lot of Indic shaping bugs as well as a work-around for bugs in
FreeSans (Devanagari)
- New Win8-style Myanmar shaper
- New shaper for Tai Tham, Chan, New Tai Lue
See NEWS file for more details.
While I'm at this, I also 'fixed' README.chromium to make the copyright
information show up in about:credits page.
Two tests requiring rebaselines (khmer-selection and danda-space) are added to
the list of expected failure until they're rebaselined.
See also http://webkit.org/b/113450
BUG=chromium:96143
TEST=See comment #5 in the bug.
TBR=cpu
Review URL: https://chromiumcodereview.appspot.com/12438036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All bucket_ids in MMAP_LIST were wrongly 0.
This change fixes the issue by changing the scope and the oparation order.
It also adds a description for SnapshotMaps().
BUG=181517
Review URL: https://chromiumcodereview.appspot.com/13299002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
called to compress the text and make it more effective to detect the language. This function included a bug to produce an invalid UTF-8 byte sequence. It affected that the produced bytes was passed to other functions, and sometimes buffer overflow happened. This patch fixes this problem not to produce such these bytes.
This way is suggested by dsites@, a CLD developer.
Note: The input of CheapSqueezeInplace should end with 4 characters, which consists of 3 space characters and the NUL, so the boundary error would not happen.
BUG=176719
TEST=Unit Test with ASAN
Review URL: https://chromiumcodereview.appspot.com/12525006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/13252005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I am trying to land additional changes to recover.c, but something
about it is giving the code-review system fits. I think it's the
formfeeds. Making a copy of the file without formfeeds so that I can
continue the review.
NOTE: Neither file is compiled on any platform. Not even referenced
from any gyp file.
BUG=none
TBR=cmp@chromium.org
Review URL: https://codereview.chromium.org/13245004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From the man page:
The function fflush() may also fail and set errno for any of the errors specified for write(2).
write can fail with EINTR.
BUG=222266
Review URL: https://chromiumcodereview.appspot.com/13261002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bucket_id in MMAP_LIST was wrong (only 0).
This change fixes the issue by changing the scope and the oparation order.
BUG=181517
TBR=glider@chromium.org
Review URL: https://codereview.chromium.org/12681013
TBR=dmikurube@chromium.org
Review URL: https://codereview.chromium.org/13259003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The x32 logic for the size of Atomic64 handles NaCL, but misses
the Linux case. Check the standard __ILP32__ to handle that too.
Upstream tracker:
https://code.google.com/p/protobuf/issues/detail?id=474
BUG=chromium-os:36866
TEST=compiled the code for x86_64 (64bit) & x86_64 (x32)
R=darin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12380082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bucket_id in MMAP_LIST was wrong (only 0).
This change fixes the issue by changing the scope and the oparation order.
BUG=181517
TBR=glider@chromium.org
Review URL: https://codereview.chromium.org/12681013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Data shows that some calls are first succeeding even at 500ms.
BUG=222853
Review URL: https://chromiumcodereview.appspot.com/12567024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are already pulling in the system ashmem via other system libraries,
so compiling a second copy into chrome causes linker issues. Use the
system version in Chromium as well when building WebView as part of the
Android build.
BUG=157326
Review URL: https://chromiumcodereview.appspot.com/12674026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=brettw@chromium.org,cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12502025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
%lld was generating negative values.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12960003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes limited changes to minimize the likelyhood of breaking
dependent scripts.
NOTRY=True
TBR=brettw@chromium.org
BUG=180587
TEST=ran run_command.RunOnce with a timeout of 0.
Review URL: https://codereview.chromium.org/13047009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove unused files
- Update license description
- Remove them from suppression list
BUG=98120
TEST=tools/checklicenses/checklicenses.py third_party/cld
Review URL: https://codereview.chromium.org/12676028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
build still has problems with content_browsertests.
TBR=mallinath@chromium.org
Review URL: https://codereview.chromium.org/12880018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
libjingle_webrtc contains all the webrtc parts except for the media engine implementation. The media engine implementation stays in libpeerconnection and will be built as a shared library when component==shared_library. Since libjingle_webrtc contains the code that depends on libpeerconnection, those targets that previously only depended on libpeerconnection have been updated to include on libjingle_webrtc as well.
TBR=darin
Review URL: https://codereview.chromium.org/12965010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
adds metadata (XMP/EXIF), ICC profile and animation support to the format.
BUG=https://bugs.webkit.org/show_bug.cgi?id=112761
TEST=build,webkit layout
TBR=cpu
Review URL: https://chromiumcodereview.appspot.com/12942006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12939011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Reland libjingle.gyp changes.
> The changes are the same as in the previous review:
> https://codereview.chromium.org/12457027/
>
> I had to revert due to build problems but eventually tracked
> them down to chromeos dependencies in sync. For 'sync', this
> is a problem for shared_library builds but not otherwise.
> For sync_unit_tests, this is a problem since sync_unit_tests
> is always built as an executable.
>
> Previously these problems were masked since the dependencies
> were being pulled in via libjingle.
>
> TBR=ronghuawu,akalin
>
> Review URL: https://codereview.chromium.org/12930010
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/13009009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The changes are the same as in the previous review:
https://codereview.chromium.org/12457027/
I had to revert due to build problems but eventually tracked
them down to chromeos dependencies in sync. For 'sync', this
is a problem for shared_library builds but not otherwise.
For sync_unit_tests, this is a problem since sync_unit_tests
is always built as an executable.
Previously these problems were masked since the dependencies
were being pulled in via libjingle.
TBR=ronghuawu,akalin
Review URL: https://codereview.chromium.org/12930010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was found by experimenting with a new Clang warning.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12662026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Reland libjingle.gyp refactoring change.
>
> Original description (from https://codereview.chromium.org/12457027/):
> Refactor libjingle and libpeerconnection targets.
> I'm moving most of the source files back to the libjingle target since the
> current splitting doesn't work for all targets that currently rely on libjingle.
> The webrtc core libs are still only in the libpeerconnection target, and
> require the enable_webrtc gyp variable to be be set.
>
> I'm also adding a gyp variable to the libjingle target to support dependency
> injection as is supported for libpeerconnection.
>
> TBR=ronghuawu@chromium.org
>
> Review URL: https://codereview.chromium.org/12967005
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/13009007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original description (from https://codereview.chromium.org/12457027/):
Refactor libjingle and libpeerconnection targets.
I'm moving most of the source files back to the libjingle target since the
current splitting doesn't work for all targets that currently rely on libjingle.
The webrtc core libs are still only in the libpeerconnection target, and
require the enable_webrtc gyp variable to be be set.
I'm also adding a gyp variable to the libjingle target to support dependency
injection as is supported for libpeerconnection.
TBR=ronghuawu@chromium.org
Review URL: https://codereview.chromium.org/12967005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 189990 - re-re-land of "Refactor libjingle and libpeerconn..."
> The previous attempt failed because libjingle hadn't been rolled yet. Still waiting on trybots a day later.
>
> > > > > Refactor libjingle and libpeerconnection targets.
> > > > > I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.
> > > > >
> > > > > I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.
> > > > >
> > > > > TBR=darin
> > > > >
> > > > > Review URL: https://codereview.chromium.org/12457027
> > > >
> > > > TBR=tommi@chromium.org
> > > > Review URL: https://codereview.chromium.org/12662028
>
> TBR=tommi@chromium.org
> Review URL: https://codereview.chromium.org/12891005
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/12512017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous attempt failed because libjingle hadn't been rolled yet. Still waiting on trybots a day later.
> > > > Refactor libjingle and libpeerconnection targets.
> > > > I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.
> > > >
> > > > I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.
> > > >
> > > > TBR=darin
> > > >
> > > > Review URL: https://codereview.chromium.org/12457027
> > >
> > > TBR=tommi@chromium.org
> > > Review URL: https://codereview.chromium.org/12662028
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/12891005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added a histogram to see how long successes actually take.
BUG=222853
Review URL: https://codereview.chromium.org/12674046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Reland 18980
> "Revert 189802 "Refactor libjingle and libpeerconn..."
>
> > Revert 189802 "Refactor libjingle and libpeerconnection targets."
> > For some reason the "Linux Builder (dbg)(32)" bot is failing (and not other linux bots):
> >
> > lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::~WebRtcVideoEngine()'
> > lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::GetVideoCapturer() const'
> > lib/libsync.so: undefined reference to `cricket::WebRtcVoiceEngine::RegisterProcessor(unsigned int, cricket::VoiceProcessor*, cricket::MediaProcessorDirection)'
> > lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::SetOptions(int)'
> > lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::Terminate()
> > ...etc
> >
> > > Refactor libjingle and libpeerconnection targets.
> > > I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.
> > >
> > > I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.
> > >
> > > TBR=darin
> > >
> > > Review URL: https://codereview.chromium.org/12457027
> >
> > TBR=tommi@chromium.org
> > Review URL: https://codereview.chromium.org/12662028
>
> TBR=tommi@chromium.org
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/12902048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Revert 189802 "Refactor libjingle and libpeerconn..."
> Revert 189802 "Refactor libjingle and libpeerconnection targets."
> For some reason the "Linux Builder (dbg)(32)" bot is failing (and not other linux bots):
>
> lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::~WebRtcVideoEngine()'
> lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::GetVideoCapturer() const'
> lib/libsync.so: undefined reference to `cricket::WebRtcVoiceEngine::RegisterProcessor(unsigned int, cricket::VoiceProcessor*, cricket::MediaProcessorDirection)'
> lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::SetOptions(int)'
> lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::Terminate()
> ...etc
>
> > Refactor libjingle and libpeerconnection targets.
> > I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.
> >
> > I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.
> >
> > TBR=darin
> >
> > Review URL: https://codereview.chromium.org/12457027
>
> TBR=tommi@chromium.org
> Review URL: https://codereview.chromium.org/12662028
TBR=tommi@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/12729037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason the "Linux Builder (dbg)(32)" bot is failing (and not other linux bots):
lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::~WebRtcVideoEngine()'
lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::GetVideoCapturer() const'
lib/libsync.so: undefined reference to `cricket::WebRtcVoiceEngine::RegisterProcessor(unsigned int, cricket::VoiceProcessor*, cricket::MediaProcessorDirection)'
lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::SetOptions(int)'
lib/libsync.so: undefined reference to `cricket::WebRtcVideoEngine::Terminate()
...etc
> Refactor libjingle and libpeerconnection targets.
> I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.
>
> I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.
>
> TBR=darin
>
> Review URL: https://codereview.chromium.org/12457027
TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/12662028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set.
I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection.
TBR=darin
Review URL: https://codereview.chromium.org/12457027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was already fixed upstream.
Found by experimenting with a new Clang warning.
BUG=none
TBR=cpu
Review URL: https://codereview.chromium.org/12952004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was already fixed upstream.
Found by experimenting with a new Clang warning.
BUG=none
TBR=cpu
Review URL: https://codereview.chromium.org/12854004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes are required to build with libcxx.
R=rsimha@chromium.org,brettw@chromium.org
TBR=cpu@chromium.org
BUG=178409
Review URL: https://codereview.chromium.org/12854003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=178409
R=battre@chromium.org,thakis@chromium.org
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/12951002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=222387
TEST=unit tests crashes less
Review URL: https://chromiumcodereview.appspot.com/12965006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This file has been obsolete since checkdeps moved from
using "skip_subtree_includes" to using "skip_child_includes." third_party/ is
already listed as a child include to be skipped in src/DEPS.
Review URL: https://chromiumcodereview.appspot.com/12956002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of our local changes to tcmalloc is logic to reject all
allocations above a certain size. (At least those via malloc and so
on.) The check for that doesn't need to be on the hot path. Most
allocations are small and there is a special case for that already.
If that special case applies then we don't need to check if the
allocation is gigantic.
This is a performance tuning change. It doesn't affect functionality.
To evaluate this change I ran 3 page cyclers: bloat, dhtml, and
morejs. I used ChromeOS on the Samsung 550. I ran 30 trials; a few
randomly failed, but I got close to 30 "before" and "after" results
for each of those 3 tests.
Results in order of p-value were:
Bloat 0.3% faster, p=0.02
DHTML 0.3% faster, p=0.46
MoreJS 0.1% faster, p=0.82
This looks like a useful gain, but it's small, as one would expect.
BTW I'm trusting the compiler to rewrite
(x < (constant0)) && (x < (constant1))
to
(x < (the smaller of the two constants))
I checked the generated code, and it looks good (at least on the
ChromeOS toolchain for Samsung 550).
BUG=111726
TEST=none
R=jar
Review URL: https://chromiumcodereview.appspot.com/12572005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=222047
TEST=no visible changes
Review URL: https://chromiumcodereview.appspot.com/12474010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use of StringPrintf now requires prefixing with base:: or a per-scope using directive
TBR'd:
abodenha: chrome/service
brettw: content, third_party, webkit
darin: base, chrome/browser, chrome/renderer
dgarret: courgette
enne: cc
fischmann: media
gbillock: sql
joi: google_apis,components
rsleevi: net, crypto
sky: chrome/test
thestig: printing, chrome/common,
tsepez: ipc
wez: remoting
yfriedman: testing/android
NOTRY=true
R=brettw@chromium.org
TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12767006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for libpeerconnection.
Review URL: https://chromiumcodereview.appspot.com/12432022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188706 0039d316-1c4b-4281-b951-d872f2087c98
|