summaryrefslogtreecommitdiffstats
path: root/tools/android/checkstyle
Commit message (Collapse)AuthorAgeFilesLines
* Remove all the imports only needed for jni generator.aurimas2015-06-241-4/+2
| | | | | | | | | | | | - Enable checkstyle for unneeded imports. - Move VideoCaptureFormat to its own class. - Add java lang classes to jni_generator.py BUG=424792 Review URL: https://codereview.chromium.org/1205653004 Cr-Commit-Position: refs/heads/master@{#336014}
* Enable NeedsBraces check and fix some checkstyle issues.aurimas2015-04-031-2/+4
| | | | | | | | | | | NeedBraces will now check for {} in if, while, and for statements. It will still allow one line inline statements. BUG=None Review URL: https://codereview.chromium.org/1054203002 Cr-Commit-Position: refs/heads/master@{#323823}
* Update Checkstyle library from 6.1 to 6.5Aurimas Liutikas2015-04-021-1/+1
| | | | | | | | | | | | | | | | | Relevant changes: - New allowSingleLineStatement property for NeedBraces check to allow one-line statements. - New option to Indentation to avoid C style. See full release notes here: http://checkstyle.sourceforge.net/releasenotes.html BUG=None R=newt@chromium.org Review URL: https://codereview.chromium.org/1055973002 Cr-Commit-Position: refs/heads/master@{#323564}
* Allow use of checkstyle outside of main PRESUBMIT.pydavileen2015-01-201-3/+4
| | | | | | | | | | | | | | | This commit allows the use of checkstyle outside of the main PRESUBMIT script in src. Since checkstyle can possibly be called from a subfolder of src the absolute path to the java files are used instead of relative to src. We also honor the EXCLUDED_PATH blacklist for Java files. BUG=446633 Review URL: https://codereview.chromium.org/839583006 Cr-Commit-Position: refs/heads/master@{#312287}
* Fix a bunch of Java Checkstyle issues.aurimas2014-11-201-4/+15
| | | | | | | | | BUG=318404 TBR=samuong@chromium.org Review URL: https://codereview.chromium.org/744453002 Cr-Commit-Position: refs/heads/master@{#305047}
* Add exceptions for lineLength for URLs.Aurimas Liutikas2014-11-191-1/+1
| | | | | | | | | BUG=None R=newt@chromium.org Review URL: https://codereview.chromium.org/740643002 Cr-Commit-Position: refs/heads/master@{#304742}
* Roll to Checkstyle 6.1.Aurimas Liutikas2014-11-191-1/+1
| | | | | | | | | | | | | | Updating to get performance improvements in 6.1 Detailed release notes: http://checkstyle.sourceforge.net/releasenotes.html BUG=None R=newt@chromium.org Review URL: https://codereview.chromium.org/737963002 Cr-Commit-Position: refs/heads/master@{#304735}
* Enable separatorWrap module in CheckStyle and fix all the issues.aurimas2014-10-221-0/+10
| | | | | | | | | BUG=318404 TBR=boliu@chromium.org,mef@chromium.org,zea@chromium.org,kollas@chromium.org Review URL: https://codereview.chromium.org/672533002 Cr-Commit-Position: refs/heads/master@{#300753}
* Enable OperatorWrap check as a warning for Java presubmit.aurimas2014-10-211-0/+11
| | | | | | | | | | There are currently 1072 violations of this check in chromium codebase. BUG=318404 Review URL: https://codereview.chromium.org/650693003 Cr-Commit-Position: refs/heads/master@{#300563}
* Roll to Checkstyle 5.9 and enable Indentation check.aurimas2014-10-203-3/+5
| | | | | | | | | | | | | | | | | Release notes for Checkstyle 5.9 http://checkstyle.sourceforge.net/releasenotes.html The most important part is all the fixes for Indentation check that allows us to finally enable it for presubmit. Also adding OWNERS file to checkstyle directory. BUG=318404 TBR=yfriedman@chromium.org Review URL: https://codereview.chromium.org/661153003 Cr-Commit-Position: refs/heads/master@{#300353}
* Fix Java Checkstyle issues.Aurimas Liutikas2014-10-141-0/+3
| | | | | | | | | | | | | | After this change we are down to: - 3 redundant import warnings (due to JNI generator) - 69 JavaDoc warnings BUG=318404 R=agl@chromium.org, blundell@chromium.org, boliu@chromium.org, lambroslambrou@chromium.org, nyquist@chromium.org, qinmin@chromium.org, rmcilroy@chromium.org, tedchoc@chromium.org TBR=yfriedman@chromium.org Review URL: https://codereview.chromium.org/652603004 Cr-Commit-Position: refs/heads/master@{#299540}
* Make checkstyle PRESUBMIT use warnings and errors annotations.aurimas2014-10-142-38/+39
| | | | | | | | | BUG=318404 R=maruel@chromium.org Review URL: https://codereview.chromium.org/652433004 Cr-Commit-Position: refs/heads/master@{#299513}
* Update Checkstyle to version 5.8Aurimas Liutikas2014-10-101-1/+1
| | | | | | | | | | | | Changes in 5.8 are described here: http://checkstyle.sourceforge.net/releasenotes.html BUG=318404 R=yfriedman@chromium.org Review URL: https://codereview.chromium.org/644133002 Cr-Commit-Position: refs/heads/master@{#299207}
* [Checkstyle] Fix misc style issues in Java files.aurimas2014-09-251-2/+5
| | | | | | | | | BUG=318404 TBR=zea@chromium.org,mkosiba@chromium.org Review URL: https://codereview.chromium.org/600983002 Cr-Commit-Position: refs/heads/master@{#296734}
* [Checkstyle] Enable boolean simplification and empty expression checks.aurimas2014-09-201-0/+9
| | | | | | | | | | | Fix up some issues along the way. BUG=318404 TBR=nyquist@chromium.org,boliu@chromium.org Review URL: https://codereview.chromium.org/587893002 Cr-Commit-Position: refs/heads/master@{#295884}
* [Checkstyle] Enable left and right curly checks in Java.Aurimas Liutikas2014-09-191-2/+2
| | | | | | | | | BUG=318404,320774 R=newt@chromium.org Review URL: https://codereview.chromium.org/582303002 Cr-Commit-Position: refs/heads/master@{#295639}
* [Checkstyle] Enable additional name checks for Java.Aurimas Liutikas2014-09-041-5/+16
| | | | | | | | | | | | | | | Start checking the following names: - Method names - Method parameter names - Local variables BUG=318404 TRB=qinmin@chromium.org R=boliu@chromium.org, qinmin@chromium.org, tedchoc@chromium.org Review URL: https://codereview.chromium.org/543553002 Cr-Commit-Position: refs/heads/master@{#293354}
* [Android checkstyle] Allow underscores in package names.newt2014-08-301-2/+2
| | | | | | Review URL: https://codereview.chromium.org/517403002 Cr-Commit-Position: refs/heads/master@{#292730}
* [Checkstyle] Fix checkstyle path for non src/ repos.aurimas@chromium.org2014-08-141-1/+8
| | | | | | | | | | BUG=318404 NOTRY=true Review URL: https://codereview.chromium.org/472503003 Cr-Commit-Position: refs/heads/master@{#289422} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289422 0039d316-1c4b-4281-b951-d872f2087c98
* Add and start using Checkstyle 5.7aurimas@google.com2014-08-121-2/+5
| | | | | | | | | | | | | | Start including Checkstyle 5.7 binary to use for Java style presubmit checks. BUG=318404 NOTRY=true R=brettw@chromium.org, yfriedman@chromium.org Review URL: https://codereview.chromium.org/451313002 Cr-Commit-Position: refs/heads/master@{#289117} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289117 0039d316-1c4b-4281-b951-d872f2087c98
* [Checkstyle] Update static variable and constant names to match style guides.aurimas@chromium.org2014-08-081-1/+2
| | | | | | | | | | | | | | - Static field names start with s. - static final fields (constants) are ALL_CAPS_WITH_UNDERSCORES. http://source.android.com/source/code-style.html#follow-field-naming-conventions BUG=318404 TBR=qinmin Review URL: https://codereview.chromium.org/455523002 Cr-Commit-Position: refs/heads/master@{#288416} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288416 0039d316-1c4b-4281-b951-d872f2087c98
* [Checkstyle] Update class member variable names to match style guides.aurimas@chromium.org2014-08-081-0/+1
| | | | | | | | | | | | - Non-public, non-static field names start with m. http://source.android.com/source/code-style.html#follow-field-naming-conventions BUG=318404 Review URL: https://codereview.chromium.org/452613002 Cr-Commit-Position: refs/heads/master@{#288299} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288299 0039d316-1c4b-4281-b951-d872f2087c98
* Update Java checkstyle naming convention for static final fields.newt@chromium.org2014-01-071-1/+2
| | | | | | | | | | | | | | | | | | | Static final fields can either be "true" constants, e.g. static final int HEIGHT_PX = 30; static final String TAG = "MyClass" or can have mutable state or not "feel" like a constant, e.g. static final AtomicInteger sNextId; static final Runnable sSuspendTask; This allows either naming convention, FIELD_NAME or sFieldName, at the programmer's discretion. NOTRY=true Review URL: https://codereview.chromium.org/112023009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243316 0039d316-1c4b-4281-b951-d872f2087c98
* Adding Java style presubmit check.aurimas@chromium.org2013-12-101-0/+59
| | | | | | | | BUG=320711 Review URL: https://codereview.chromium.org/110773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239824 0039d316-1c4b-4281-b951-d872f2087c98
* Enable PRESUMIT checks for ModifierOrder, ImportOrder and Trailing Whitespace.aurimas@google.com2013-12-031-5/+10
| | | | | | | | R=newt@chromium.org Review URL: https://codereview.chromium.org/102603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238488 0039d316-1c4b-4281-b951-d872f2087c98
* Make the license header check an error for PRESUBMIT.aurimas@chromium.org2013-12-031-0/+1
| | | | | | | | NOTRY=true Review URL: https://codereview.chromium.org/100183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238275 0039d316-1c4b-4281-b951-d872f2087c98
* Update checkstyle rules.aurimas@chromium.org2013-11-221-0/+1
| | | | | | | | | | | | Allow imports even if it used only for Javadoc. Making dtrainor@ happy. BUG=318404 NOTRY=true Review URL: https://codereview.chromium.org/79423005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236699 0039d316-1c4b-4281-b951-d872f2087c98
* Update checkstyle rules.aurimas@chromium.org2013-11-211-3/+6
| | | | | | | | | | | | | | - Change catching Exepction and Throwable as warnings. - Allow comments for EmptyBlocks - Allow empty methods and contructors. - Set using finalizer as a warning. BUG=318404 NOTRY=true Review URL: https://codereview.chromium.org/81903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236630 0039d316-1c4b-4281-b951-d872f2087c98
* Add a checkstyle rule for Copyright header.shashishekhar@chromium.org2013-11-211-0/+3
| | | | | | | | | Make sure that a Java file has Chromium copyright header. BUG=318404 Review URL: https://codereview.chromium.org/80053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236481 0039d316-1c4b-4281-b951-d872f2087c98
* Fix codestyle issue with curly-brace in annotationsaurimas@chromium.org2013-11-191-1/+1
| | | | | | | | | | | | Removing LCURLY and RCURLY from WhitespaceAround rule as it is already covered by LeftCurly and RightCurly. BUG=320774 NOTRY=true Review URL: https://codereview.chromium.org/62803012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235911 0039d316-1c4b-4281-b951-d872f2087c98
* Added checkstyle configuration file.apiccion@chromium.org2013-11-131-0/+144
* Added checkstyle configuration file. Checkstyle checks Java code against our style guide. It integrates with Eclipse/Eclim or can be run as a standalone script. (See http://checkstyle.sourceforge.net/) BUG=318404 Review URL: https://codereview.chromium.org/68333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234774 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-25 07:33:19 +0000