| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With -a, memdump prints total print, app shared,
and other shared memory usage in KB. Example output:
pid private shared_app shared_other (KB)
15802 71292 36860 26512
15818 12636 36860 11568
Test with and without -a, with and without pids in
command-line, works as expected.
BUG=
Review URL: https://chromiumcodereview.appspot.com/16832005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows redirecting adb shell output directly to memreport.py without having
to do dos2unix, and be able to match end of line in regexps.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/16661004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove forwarding header
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16667019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15851009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
BUG=175002
Reland of 198820 and 298824
Original review = https://codereview.chromium.org/13165005
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/16392011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follow up from crrev.com/204357, it has now rolled downstream
so it's safe to remove the constant.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/15839006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the 'memdump' binary that dumps device memory information for a list
of processes and 'memreport.py' (executed on the host) used to process this
information.
Memdump is similar to /proc/<PID>/smaps except that it is multi-process aware.
For a list of processes (e.g. browser + renderer processes), it is able to
dinstinguish the memory pages that are mapped only in these processes from the
ones that are private or also mapped in external processes.
This is useful to gather high level memory usage information (e.g. heap size vs
code size) for any (non-instrumented) process.
R=bulach@chromium.org, digit@chromium.org, qsr@chromium.org
Review URL: https://codereview.chromium.org/15861023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There used not to be any way to unmap a previously forwarded port. Since
the host and device forwarder processes are kept alive during a whole test
suite, both the host and device ended up with an unnecessarily high amount of
unused open sockets. That is source of flakiness (e.g. too many opened file
descriptors).
This adds an UnmapDevicePort() method to the Python Forwarder wrapper class and
modifies the native forwarder2 to accept a negative port on the command line.
When a negative port is provided, the host forwarder tries to unmap that port
(that was mapped previously).
BUG=229685,239014
R=bulach@chromium.org, digit@chromium.org
Review URL: https://codereview.chromium.org/15008004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the use of a PID file that can cause flakiness while killing the
daemon due to corner cases (e.g. the daemon is still running but its PID file
was removed).
Instead the PID of the daemon process is now obtained through getsockopt().
BUG=229685
R=digit@chromium.org
Review URL: https://codereview.chromium.org/14727013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke both windows clobber and official builders' compile with this error:
771>Link:
771> Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and
object ..\..\..\build\Release\lib\gcp_portmon64.exp
771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86'
conflicts with target machine type 'x64'
771>
771>Build FAILED.
> Move FileEnumerator to its own file, do some refactoring.
>
> It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
>
> BUG=175002
> R=rvargas@chromium.org
>
> Review URL: https://codereview.chromium.org/13165005
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14824006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
BUG=175002
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/13165005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the component build, the device executable requires shared libraries
to run. When building, use build/android/native_app_dependencies.gypi
to copy the executable+libraries to a dist directory.
Then, in android_commands.py we need to copy that directory to the
device and specify LD_LIBRARY_PATH when running the executable.
NOTRY=true
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/14646030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Repurposes the gyp scripts for processing native libraries for an apk and use them for a native library (i.e. forwarder).
Additionally, adjusts the forwarder python script to set LD_LIBRARY_PATH when invoking the forwarder.
BUG=158821
Review URL: https://chromiumcodereview.appspot.com/14322004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14272007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EnsureEndsWithSeparator used to check whether the file existed. This seems bad and unnecessary so I removed it.
I removed file_util::ContainsPath and used the existing file_util::IsParent instead. The functions descriptions are the same but the implementations do slightly different things, which is worrying. The only non-test use of this function to worry about is content/browser/storage_partition_impl_map.cc. As far as I see, the requirements for this seem OK, but I'm not very familiar with this.
After some discussion with akalin, I changed sync/internal_api/sync_manager_impl.cc to be a DCHECK that the path is absolute rather than make it absolute. The old code relied on the behavior of the old function that the argument would be unchanged if the file didn't exist, and this (possibly relative) path would be used later. This behavior doesn't make a lot of sense, and it looks like now that the path is always absolute, so I replaced this call with a DCHECK.
BUG=
Review URL: https://codereview.chromium.org/13196006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=149661
Review URL: https://codereview.chromium.org/13862017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=70818
Review URL: https://codereview.chromium.org/13812005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=224879,223918
Review URL: https://chromiumcodereview.appspot.com/13470003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=169338
Review URL: https://chromiumcodereview.appspot.com/12733012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=cmp
BUG=169338
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12927008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=169338
Review URL: https://chromiumcodereview.appspot.com/12516013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=169338
Review URL: https://chromiumcodereview.appspot.com/12567013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=175186
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were using package_name as a unique name for naming output files and
directories. package_name was typically the same as _target_name or a
variation of it (like dropping _apk). Using _target_name instead means
we need to specify one less thing and it is (maybe?) guaranteed to be
unique.
TBR=brettw,joi,jar,fischman,zea,sky
BUG=
Review URL: https://chromiumcodereview.appspot.com/11308030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12217101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compiling the latest source tree with gcc 4.7.2 currently breaks at:
../../tools/android/forwarder2/socket.cc: In member function ‘int forwarder2::Socket::Read(void*, size_t)’:
../../tools/android/forwarder2/socket.cc:323:13: error: ‘read’ was not declared in this scope
../../tools/android/forwarder2/socket.cc:323:13: error: invalid type in declaration before ‘;’ token
[2269/11351] CXX obj/chrome/app/policy/gen...ettings_proto_compile.chrome_settings.pb.o
ninja: build stopped: subcommand failed.
It seems that 'tools/android/forwarder2/socket.cc' needs '#include <unistd.h>.
Review URL: https://chromiumcodereview.appspot.com/11896088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This binary is upstreamed from the internal android tools repo. It compiles,
but I have not tested it. Rather than pinging the tcp echo service, we
should modify the host side component of forwarder2 to respond
directly.
BUG=170213
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12077015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No code changes.
R=yfriedman@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/12102003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Use pylib constants instead.
Review URL: https://codereview.chromium.org/11967019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds dependencies on Android tools (port forwarder and md5 util used
for conditional file pushes) required to run native unittests APKs to the APKs
targets.
BUG=161257
Review URL: https://chromiumcodereview.appspot.com/11597008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This lets device_forwarder run in non-root when it was previously run in root
without removing its PID file.
Review URL: https://chromiumcodereview.appspot.com/11478046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the following error when using sharding:
[ERROR:daemon.cc] Daemon already running (PID file already locked)
Caught unexpected SIGCHLD
Daemon died unexpectedly with status 1.
[ERROR:daemon.cc] Could not connect to daemon's Unix Daemon socket.
Multiple processes/threads can invoke host_forwarder concurrently. When
host_forwarder is invoked, the process forks to create a daemon if it can't
connect to the Unix Domain Socket. In case sharding is used, this can lead to
concurrent processes forking at the same time and trying to acquire a file
system lock concurrently. The case where a child process was trying to acquire
an already acquired file lock was previously treated as an error. In that case
the child process now exits successfully assuming that another daemon was
successfully spawned concurrently.
BUG=163036
Review URL: https://codereview.chromium.org/11413221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the timeout used to connect to the daemon's Unix Domain Socket. In case
the daemon was just spawned it can easily take a few hundred milliseconds on
the device before it binds the socket.
The same timeout is now also used when killing the daemon.
Review URL: https://chromiumcodereview.appspot.com/11418151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11348213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This lets device_forwarder be controlled (started and killed) like
host_forwarder (see r167167).
This has the main benefit of moving the setup/tear down complexity from the
Python Forwarder wrapper code to the forwarder itself so that various clients
(including WebKit) can use forwarder2 more easily (e.g. no need to use pexpect
anymore (which is not available in WebKit)).
This implied a refactoring in the Daemon class so that its clients don't have
to duplicate the socket-related code.
Review URL: https://chromiumcodereview.appspot.com/11360248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11366229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes forwarder2 to support both test-server spawner and HTTP server
forwarding.
The main issue was that the device_forwarder was killed when instantiating a
second Forwarder (Python object).
Test server based unit tests require two device-to-host redirections, one for
the test server spawner and one for the HTTP server.
The port used by the HTTP server is allocated dynamically which means that we
can't know the full forwarding configuration before we spawn a HTTP server
(through the test server spawner).
This CL changes the forwarder to let it forward new ports while it is running
by making host_forwarder a daemon. This is similar to how ADB works.
This also means that a single host_forwarder process (daemon) can now handle
multiple devices.
BUG=146979
Review URL: https://chromiumcodereview.appspot.com/11269036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=137569
Review URL: https://codereview.chromium.org/11361125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The java files had the issue that findbugd plugin need to find out, they
compiled with the same configuration as chrome for android's.
- The run_findbugs_plugin_tests.py runs the findbugs against the above Java
classes, and expects to find the same issues as those in expected_result.txt.
BUG=143971, 157970
Review URL: https://chromiumcodereview.appspot.com/11343057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111541
R=bulach@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11275079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
FindBugs plugin to detect synchronized method and synchronized this.
BUG=143971
Review URL: https://codereview.chromium.org/11263050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11345006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to be used in our test framework.
BUG=146502
content/ changes are trivial so I am adding a TBR.
TBR=avi
Review URL: https://chromiumcodereview.appspot.com/11148018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This message is used as a barrier in the Python script. It could be printed
before the Unix Domain Socket initialization failed.
Although the device controller can still fail later it seems safer that way.
Review URL: https://chromiumcodereview.appspot.com/11087006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a DRAFT change.
I will polish it after running all the tests.
It worked for the integration tests.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10957052
TBR=felipeg@chromium.org
Review URL: https://codereview.chromium.org/10977050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a DRAFT change.
I will polish it after running all the tests.
It worked for the integration tests.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10957052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Dynamically allocated port is necessary for running the net_unittests.
Also fixes a bug in Socket::Connect() where we forgot to wait for the notifier_fd using a select, and it was causing the forwarder to be stuck when the connection didn't complete (it did not have a timeout).
BUG=146502
Review URL: https://chromiumcodereview.appspot.com/10957043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The big picture CL can be seem here: https://chromiumcodereview.appspot.com/10918057/
BUG=146502
Review URL: https://chromiumcodereview.appspot.com/10908215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=143114
Looks like this was a regression after: https://chromiumcodereview.appspot.com/10867008/
Review URL: https://chromiumcodereview.appspot.com/10911259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156462 0039d316-1c4b-4281-b951-d872f2087c98
|