summaryrefslogtreecommitdiffstats
path: root/tools/auto_bisect
Commit message (Collapse)AuthorAgeFilesLines
...
* Renamed AddDepot to SetDepotDir as it's also used for updating dirsergiyb2014-10-241-7/+8
| | | | | | | | | R=prasadv@chromium.org,qyearsley@chromium.org CC=ojan@chromium.org Review URL: https://codereview.chromium.org/666333005 Cr-Commit-Position: refs/heads/master@{#301177}
* Print author email address instead of author name under CL info.prasadv2014-10-241-6/+2
| | | | | | | | | BUG=418796 NOTRY=true Review URL: https://codereview.chromium.org/671233003 Cr-Commit-Position: refs/heads/master@{#301138}
* Rename and refactor DownloadCurrentBuild and related functions.qyearsley2014-10-241-55/+100
| | | | | | | | | | | | | | | | | | This CL renames a couple functions in order to try to more accurately reflect what they do: BuildCurrentRevision -> _ObtainBuild DownloadCurrentBuild -> _DownloadAndUnzipBuild This CL breaks two sub-functions out of DownloadCurrentBuild: _WaitForBuildDownload _UnzipAndMoveBuildProducts Note: Later, I plan to replace _GetBuildArchiveForRevision with fetch_build.FetchBuild, and possibly change _UnzipAndMoveBuildProducts so that it doesn't do unzipping, since unzipping is done in fetch_build.FetchBuild. Either that, or make it so that unzipping isn't done in that function. BUG= Review URL: https://codereview.chromium.org/664793002 Cr-Commit-Position: refs/heads/master@{#301029}
* Re-applying reverted changes plus fix. ConfidenceScore now takes flatrobertocn2014-10-234-27/+178
| | | | | | | | | | | | | | | lists and the previously offending code now checks whether the lists need to be flattened before being passed to the function. BUG=422727 Review URL: https://codereview.chromium.org/644323002 Cr-Commit-Position: refs/heads/master@{#300196} Review URL: https://codereview.chromium.org/665893003 Cr-Commit-Position: refs/heads/master@{#300953}
* Refactored auto_bisect bot:sergiyb2014-10-228-1037/+1271
| | | | | | | | | | | | | | - Extracted BisectPrinter, which contains everything related to printing - Extracted BisectState and RevisionState, which represent bisect-in-progress - Rewrote BisectResults - in particular split up GetRevisionDict, which is now its constructor - Added tests for BisectResults, fixed bugs in _FindOtherRegressions - Added tests for BisectState R=qyearsley@chromium.org Review URL: https://codereview.chromium.org/664753002 Cr-Commit-Position: refs/heads/master@{#300677}
* Rename and refactor PostBuildRequestAndWait.qyearsley2014-10-221-24/+32
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/667453004 Cr-Commit-Position: refs/heads/master@{#300603}
* Fix auto-bisect presubmit so that it checks config files again.qyearsley2014-10-221-9/+8
| | | | | | | | | | | | When I changed this PRESUBMIT.py in http://crrev.com/292434, I didn't properly test it, so it hasn't actually been checking auto_bisect/bisect.cfg as it was supposed to. This change makes so that the files listed in the CONFIG_FILES list here will be checked (including run-perf-test.cfg, even though it's outside of the auto_bisect directory). BUG= Review URL: https://codereview.chromium.org/669543002 Cr-Commit-Position: refs/heads/master@{#300598}
* Fix mistake in crrev.com/650223005.qyearsley2014-10-201-1/+1
| | | | | | | | | | This was the 2nd breaking mistake in that one CL. Note: oth mistakes were not caught by unit tests or by running a bisect try job once before submitting. BUG=425173 Review URL: https://codereview.chromium.org/662403003 Cr-Commit-Position: refs/heads/master@{#300303}
* Revert of Requiring confidence in initial regression range before bisecting. ↵prasadv2014-10-202-110/+4
| | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:110001 of https://codereview.chromium.org/644323002/) Reason for revert: Bisect is broken because the ConfidenceScore expects list of list, but here only list is passed. http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/693/steps/Running%20Bisection/logs/stdio Original issue's description: > Requiring confidence in initial regression range before bisecting. > > BUG=422727 > > Committed: https://crrev.com/4436048a948a2010062d3c6a171775d9389fd732 > Cr-Commit-Position: refs/heads/master@{#300196} TBR=qyearsley@chromium.org,chrisphan@chromium.org,tonyg@chromium.org,robertocn@chromium.org NOTREECHECKS=true NOTRY=true BUG=422727 Review URL: https://codereview.chromium.org/661393003 Cr-Commit-Position: refs/heads/master@{#300280}
* Requiring confidence in initial regression range before bisecting.robertocn2014-10-182-4/+110
| | | | | | | | BUG=422727 Review URL: https://codereview.chromium.org/644323002 Cr-Commit-Position: refs/heads/master@{#300196}
* Implementing direction_of_improvementrobertocn2014-10-172-24/+118
| | | | | | | | BUG=418690 Review URL: https://codereview.chromium.org/645263002 Cr-Commit-Position: refs/heads/master@{#300167}
* telemetry: remove run_measurment script.ernstm2014-10-161-3/+3
| | | | | | | | | R=dtu@chromium.org,nednguyen@chromium.org,tonyg@chromium.org BUG=423563 Review URL: https://codereview.chromium.org/655563007 Cr-Commit-Position: refs/heads/master@{#299968}
* Refactor source_control.py and add a test.qyearsley2014-10-165-304/+340
| | | | | | | | | | | | | | | | | | | | | | Originally, Simon made SourceControl a class becaused we expected to add a SvnSourceControl subclass which implemented the same methods in different ways. However, after the git transition we're fairly sure that we don't want to do this. So, all of the functions in the SourceControl class can be made top-level functions that don't need a "self" argument. This way, there's no need to pass around a bogus SourceControl object; the functions can be called directly. I also added tests for some methods that seemed relatively testable. PTAL and give suggestions :-) BUG= Review URL: https://codereview.chromium.org/650223005 Cr-Commit-Position: refs/heads/master@{#299851}
* Split RmTreeAndMkDir into two separate functions (refactoring).qyearsley2014-10-161-27/+24
| | | | | | | | | | | | The function RmTreeAndMkDir did two different things depending on a boolean flag that was passed to it. This CL splits it into two functions so that each function only takes one argument and does one thing. BUG= Review URL: https://codereview.chromium.org/645383002 Cr-Commit-Position: refs/heads/master@{#299815}
* Use new gclient config to pull V8 bleeding edge revisions.prasadv2014-10-101-1/+3
| | | | | | | | | BUG=422386 NOTRY=true Review URL: https://codereview.chromium.org/648783002 Cr-Commit-Position: refs/heads/master@{#299190}
* Delete index.lock files before checking out master branch.prasadv2014-10-091-3/+4
| | | | | | | | | BUG=421971 NOTRY=true Review URL: https://codereview.chromium.org/640733004 Cr-Commit-Position: refs/heads/master@{#298978}
* Using commit position instead of commit time to check revision order prior ↵robertocn2014-10-081-11/+6
| | | | | | | | | | to starting bisect. BUG=400865 Review URL: https://codereview.chromium.org/637693002 Cr-Commit-Position: refs/heads/master@{#298614}
* Adding non-blank leading characters to these lines to prevent the automatic ↵robertocn2014-10-031-3/+3
| | | | | | | | trimming that skews the scissor ascii. Review URL: https://codereview.chromium.org/627823002 Cr-Commit-Position: refs/heads/master@{#298122}
* Trigger build request using git try instead of try_job_http on bisect botsprasadv2014-10-023-104/+320
| | | | | | | | | | | | | Bisect builders fail to apply patches sent via try_job_http, because of this we were not able to build revisions with DEPS patches. Now we are using "git try" instead to trigger build request on bisect builders. BUG=411418 NOTRY=true Review URL: https://codereview.chromium.org/607803005 Cr-Commit-Position: refs/heads/master@{#297918}
* Add a module to fetch builds from different types of builders.qyearsley2014-10-015-48/+559
| | | | | | | | | | | | | | | | | | | | | | | | | | | This module and its contents will replace the following functions and methods in bisect-perf-regression.py: Most of DownloadCurrentBuild GetBuildArchiveForRevision GetRemoteBuildPath GetGSRootFolderName GetZipFileName FetchFromCloudStorage ExtractZip MaybeMakeDirectory In this module, we want to be able to support downloading from different places with possibly different naming conventions in a clean way. As-is, this module works for downloading and extracting full builds that are archived by the builders on the main waterfall. Example invocation: $ python fetch_build.py full 9f11d3bc7c31cc4c10efa15e4bfddf12705908ed outdir BUG=402669 Review URL: https://codereview.chromium.org/548233002 Cr-Commit-Position: refs/heads/master@{#297669}
* Add commit position to bisect result output.chrisphan2014-09-301-16/+26
| | | | | | | | | | | | Resubmitting: https://codereview.chromium.org/580293002/ Reason: bisect-perf-regression.py was renamed. BUG= Review URL: https://codereview.chromium.org/617963003 Cr-Commit-Position: refs/heads/master@{#297503}
* Shortening thank you message for a cleaner output.robertocn2014-09-302-18/+11
| | | | | | | | | | Also, restoring ttest constants to original values in ttest_test. BUG=404088 Review URL: https://codereview.chromium.org/616903003 Cr-Commit-Position: refs/heads/master@{#297457}
* Refactored bisect results dicts into a separate classsergiyb2014-09-264-314/+429
| | | | | | | | R=qyearsley@chromium.org Review URL: https://codereview.chromium.org/554283003 Cr-Commit-Position: refs/heads/master@{#297006}
* Do not actually remove trees when testing bisect in dry-run modesergiyb2014-09-261-6/+13
| | | | | | | | R=qyearsley@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/584853002 Cr-Commit-Position: refs/heads/master@{#296994}
* Move bisect-perf-regression.py into auto_bisect directory.qyearsley2014-09-266-16/+3731
| | | | | | | | | | | | The purpose of this is to continue gathering all the related code together, and to make it easier to run pylint/tests for the main module which still contains most of the code. After doing this, pylint and the tests caught a couple of things -- one unused variable name, and after the script changed directory, some of the paths had to be modified as well. BUG= Review URL: https://codereview.chromium.org/564663002 Cr-Commit-Position: refs/heads/master@{#296847}
* Follow-up to crrev.com/583793002 -- check if goma_dir is None.qyearsley2014-09-241-2/+4
| | | | | | | | BUG=394990 Review URL: https://codereview.chromium.org/593253002 Cr-Commit-Position: refs/heads/master@{#296312}
* Properly escape goma dir on windows. Fixes errors in goma path.sullivan2014-09-191-1/+2
| | | | | | | | BUG=394990 Review URL: https://codereview.chromium.org/583793002 Cr-Commit-Position: refs/heads/master@{#295704}
* Refactoring and other minor corrections:sergiyb2014-09-181-1/+0
| | | | | | | | | | | | - Corrected handling of the BISECT_MODE_RETURN_CODE when using BisectOptions.FromDict. - Refactored code to avoid parsing metrics when bisect is running in BISECT_MODE_RETURN_CODE. - Other minor corrections. R=qyearsley@chromium.org Review URL: https://codereview.chromium.org/568423002 Cr-Commit-Position: refs/heads/master@{#295436}
* Make correction to grep pattern to grab git hash for given commit position.prasadv2014-09-111-1/+1
| | | | | | | | | | | | Note that the pattern used to check commit position appears two times in reverted CL, therefore match the pattern at begining of the line BUG=413365,412054 NOTRY=true Review URL: https://codereview.chromium.org/564873003 Cr-Commit-Position: refs/heads/master@{#294463}
* Replace "git svn" with "git footers" commands to get commit position or svn ↵prasadv2014-09-101-27/+11
| | | | | | | | | | | revision. BUG=391109 NOTRY=true Review URL: https://codereview.chromium.org/552013008 Cr-Commit-Position: refs/heads/master@{#294190}
* Bisect config params should alway be empty.prasadv2014-09-041-11/+7
| | | | | | | | | BUG= NOTRY=true Review URL: https://codereview.chromium.org/537413002 Cr-Commit-Position: refs/heads/master@{#293307}
* Use author name and email-id instead of committer information.prasadv2014-09-031-1/+1
| | | | | | | | | BUG=410064 NOTRY=true Review URL: https://codereview.chromium.org/530213003 Cr-Commit-Position: refs/heads/master@{#293073}
* In the presubmit for auto-bisect, run pylint and unit tests.qyearsley2014-09-015-0/+128
| | | | | | | | | | | | Note: This only runs pylint and tests for the auto_bisect directory (this was much simpler than picking and choosing particular files from the parent tools directory). I think the next step is to move bisect-perf-regression.py and related files into the auto_bisect directory. BUG= Review URL: https://codereview.chromium.org/529593002 Cr-Commit-Position: refs/heads/master@{#292833}
* Refactor SyncBuildAndRunRevision to remove deep nesting.qyearsley2014-08-291-7/+11
| | | | | | | | | | | | | I also propose to rename this function to just RunTest, because its purpose is to do everything necessary to obtain a build and run a test to get results, and it's a relatively important and high-level function. "Flat is better than nested." -- The Zen of Python, PEP 20. BUG= Review URL: https://codereview.chromium.org/484583002 Cr-Commit-Position: refs/heads/master@{#292661}
* Rename post_perf_builder_job.py -> request_build.pyqyearsley2014-08-291-1/+1
| | | | | | | | | | Any thoughts? BUG= Review URL: https://codereview.chromium.org/510203002 Cr-Commit-Position: refs/heads/master@{#292534}
* Remove codes related deleting Blink or WebKit repository while processing ↵prasadv2014-08-281-33/+1
| | | | | | | | | | | | | | revisions. If the script is switching between Blink and WebKit during bisect, over a year it's been only blink for chromium and we don't need these codes. BUG= NOTRY=true Review URL: https://codereview.chromium.org/513253003 Cr-Commit-Position: refs/heads/master@{#292476}
* Rename run-bisect-perf-regression.cfg -> auto_bisect/bisect.cfgqyearsley2014-08-282-8/+80
| | | | | | | | | | | | If this is submitted, then cl/74264031 should also be submitted so that the perf dashboard correctly makes patches. Any thoughts? BUG= Review URL: https://codereview.chromium.org/511043002 Cr-Commit-Position: refs/heads/master@{#292434}
* Fix git log command to while processing Commit position in SVNFindRev methodprasadv2014-08-281-1/+1
| | | | | | | | | BUG= NOTRY=true Review URL: https://codereview.chromium.org/511033002 Cr-Commit-Position: refs/heads/master@{#292285}
* Fix minor error in string formating while processing DEPS.prasadv2014-08-262-6/+24
| | | | | | | | | BUG=407662 NOTRY=true Review URL: https://codereview.chromium.org/504223003 Cr-Commit-Position: refs/heads/master@{#292027}
* Fix issues caused due to GitMigration.prasadv2014-08-262-5/+21
| | | | | | | | | BUG= NOTRY=True Review URL: https://codereview.chromium.org/503283002 Cr-Commit-Position: refs/heads/master@{#291909}
* Teach bisect script to resolve Cr-Commit-Positions.tonyg2014-08-251-2/+3
| | | | | | | | | | | | Multiple --grep args to git log use the OR operation. So this patch supports both old SVN revisions as well as newer commit positions. BUG=407291 NOTRY=True Review URL: https://codereview.chromium.org/470803009 Cr-Commit-Position: refs/heads/master@{#291757}
* Drop obsolete --git-deps parameter to gclient.szager2014-08-251-1/+1
| | | | | | | | | BUG=406935 R=cmp@chromium.org,iannucci@chromium.org Review URL: https://codereview.chromium.org/502863002 Cr-Commit-Position: refs/heads/master@{#291641}
* Quick spelling clean-up in the auto-bisect code.qyearsley2014-08-233-12/+13
| | | | | | | | | | Note: I prefer "try server" and "try bot" more than "tryserver" and "trybot" because that's what's used in the official documentation: http://dev.chromium.org/developers/testing/try-server-usage BUG= Review URL: https://codereview.chromium.org/468633005 Cr-Commit-Position: refs/heads/master@{#291579}
* Extract Builder and subclasses to separate module.qyearsley@chromium.org2014-08-152-118/+488
| | | | | | | | | BUG= Review URL: https://codereview.chromium.org/429763003 Cr-Commit-Position: refs/heads/master@{#290037} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290037 0039d316-1c4b-4281-b951-d872f2087c98
* Update comments in post_perf_builder_job.py + minor refactoring.qyearsley@chromium.org2014-08-111-118/+115
| | | | | | | | | BUG= Review URL: https://codereview.chromium.org/447773004 Cr-Commit-Position: refs/heads/master@{#288651} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288651 0039d316-1c4b-4281-b951-d872f2087c98
* Use Welch's t-test to calculate confidence scores in the bisect script.qyearsley@chromium.org2014-07-303-5/+338
| | | | | | | | BUG=383864 Review URL: https://codereview.chromium.org/413393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286438 0039d316-1c4b-4281-b951-d872f2087c98
* Move statistical functions to another module.qyearsley@chromium.org2014-07-292-0/+192
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/417013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286137 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanup and comments in bisect_utils.py.qyearsley@chromium.org2014-07-281-127/+141
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/411263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285925 0039d316-1c4b-4281-b951-d872f2087c98
* Extract SourceControl to module; extract common methods to bisect_utils.qyearsley@chromium.org2014-07-252-0/+442
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/418113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285639 0039d316-1c4b-4281-b951-d872f2087c98
* Make a directory in which to put bisect-related modules.qyearsley@chromium.org2014-07-105-0/+909
BUG= Review URL: https://codereview.chromium.org/359013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282209 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-30 10:47:23 +0000