| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/952943002
Cr-Commit-Position: refs/heads/master@{#320269}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The linker can let two symbols share the same memory space and then
it is wrong to count that memory space twice. Better to let each symbol
contribute with a proportional part of that symbol.
This only affects the explain_binary_size_delta program. The graphical
treeview will still use the full symbol size since it's valuable
information in that context.
BUG=
Review URL: https://codereview.chromium.org/397593007
Cr-Commit-Position: refs/heads/master@{#316844}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not in gcl, which probably these days nobody working on Chromium uses.
BUG=None
R=maruel@chromium.org
TBR=maruel@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/887033002
Cr-Commit-Position: refs/heads/master@{#314039}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting on a port to Windows. As the non-legacy path was added 8 months
ago, is it ok to remove the legacy one now?
R=bratell@opera.com, andrewhayden@chromium.org
BUG=441867
Review URL: https://codereview.chromium.org/797363002
Cr-Commit-Position: refs/heads/master@{#308395}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tool can be run with a preprocessed nm file as input and trying
to run a DWARF version check in that case won't work.
BUG=415084
R=andrewhayden@chromium.org
Review URL: https://codereview.chromium.org/573273002
Cr-Commit-Position: refs/heads/master@{#295443}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If symbols with the same name appeared in the same "file" (as in
'unknown file') then they collided and only the last such symbol was
remembered. This happened for me with string symbols where all
.L.str21 were in the ?? file.
Store a list of symbol sizes per symbol and file. If there are more
than one symbol size per symbol and file, compare them differently to
see what might have happened.
A bit hard to read code. I hope it won't have to be changed.
BUG=412335
R=andrewhayden@chromium.org
Review URL: https://codereview.chromium.org/551203004
Cr-Commit-Position: refs/heads/master@{#295033}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only text that will be sent through an HTML parser needs to be parsed.
Escaping more than that results in & and < and similar in the
output.
R=andrewhayden@chromium.org
BUG=412708
Review URL: https://codereview.chromium.org/562623002
Cr-Commit-Position: refs/heads/master@{#294176}
|
|
|
|
|
|
|
|
|
|
| |
R=primiano
BUG=
Review URL: https://codereview.chromium.org/399683004
Cr-Commit-Position: refs/heads/master@{#292999}
|
|
|
|
|
|
|
|
|
|
|
| |
By adding --pak out/Release/content_shell.pak at the command line
the contents of it will be added to the visual output.
BUG=370383
Review URL: https://codereview.chromium.org/380693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Doing some sorting and splitting of data to make large amounts
of changes easier to study.
BUG=
Review URL: https://codereview.chromium.org/375063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes the output of addr2line is ambiguous, example:
unicode.cc:0
and does not include the absolute path of the source file. This fix
is mostly a port of andrewhaydens solution to disambiguate the path.
BUG=
Review URL: https://codereview.chromium.org/339853004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's easy to have to have to click a few levels down (in my case down
into / -> home -> bratell -> src -> chromium -> src). Remove the part
that seems to be an unnecessary prefix by assuming that everything
above cwd is not interesting.
Review URL: https://codereview.chromium.org/303453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a bucket has too many thousand children the webapp (graph lib?)
hangs. Protect against the most common case by splitting up the
(No Path) section in chunks of 3000 symbols.
BUG=370377
Review URL: https://codereview.chromium.org/302443006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/321163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the debug data format is DWARF4 and binutils is not new enough
the output will be more or less useless (no files will be detected).
Detect that case early instead of having the user wait for many hours
for something that can't be used.
BUG=370378
Review URL: https://codereview.chromium.org/302633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of just throwing away everything if the user presses
Ctrl-c, write down whatever data we have to the disk. By asking for
the largest symbols first, it's sometimes possible to get a quite
good picture after only 10-15% of the total runtime.
BUG=377466
Review URL: https://codereview.chromium.org/305503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make the tests run for every commit to make sure tests and code
stay in sync and are both working.
BUG=
Review URL: https://codereview.chromium.org/296003007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The binary_size tool suit includes tools that are useful when trying
to reduce binary size of a program, and chromium related programs
in particular.
This commit (mostly written by andrewhayden@chromium.org for
Android but ported to generic Linux by bratell@opera.com) adds
a graphical HTML based output for run_binary_size_analysis.py.
In the generated web page it is possible to dynamically and
graphically browse the binary and each part of the source tree
is given a size that reflects its contribution to the binary size.
The run_binary_size_analysis tool is run on compiled binaries
with symbols and uses nm and addr2line to map parts of the
binary to source code. Since addr2line is slow the operation to map
binary symbols to source files takes a while but the output is
well worth it when shrinking programs. See its usage information
for details about how to run it.
This commit also includes the tool explain_binary_size_delta.py
(textual output) which can be used to understand why a binary
changed size and in what way. See its usage information for
details about how to run it.
There are many further improvements possible to to do on these tools.
Search the bug database for Label:Tools-BinarySize for suggestions.
BUG=339059
R=primiano@chromium.org,andrewhayden@chromium.org
Review URL: https://codereview.chromium.org/258633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/262743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/268533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/266633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/231803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/132233017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=
Review URL: https://codereview.chromium.org/119083006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245405 0039d316-1c4b-4281-b951-d872f2087c98
|