| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=159580
TBR=glider
Review URL: https://codereview.chromium.org/11418195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=thakis@chromium.org,glider@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11418110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This one is needed to switch ASan and TSan builds to -gline-tables-only, which is a huge binary size gain.
BUG=128544
Review URL: https://chromiumcodereview.appspot.com/11348066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings us up to the same version as the rest of Chromium.
Disable -Wasm-operand-widths until crbug.com/159452 is fixed.
BUG=159712, 156947, 159452
Review URL: https://chromiumcodereview.appspot.com/11371004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seems like a clobber might be enough to fix the issues caused by this CL.
Reverted because it is assumed to be the cause for multiple compile failures on mac and linux.
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020
TBR=pastarmovj@google.com
Review URL: https://codereview.chromium.org/11377023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverted because it is assumed to be the cause for multiple compile failures on mac and linux.
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That was the intention of https://codereview.chromium.org/10987050/ (see diff from
patch set 3 to 4), but it got lost when trying to get that CL through the trybots
(diff from patch set 7 to 8).
BUG=137569
TBR=eugenis
Review URL: https://codereview.chromium.org/11365091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137569
TEST=none
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/10987050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
about not putting OVERRIDE on virtual methods.
The WebTestRunner namespace is similar to the WebKit namespace in that its classes change often and are upstream in WebKit
Review URL: https://codereview.chromium.org/11339049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch co-authored with ilevy.
Logic:
$ANDROID_SDK_VERSION will fix dev and clank internal bots, which don't have android in path. It will also fix fyi bot, for now.
PWD matching 'android' will fix trybots
PWD matching 'Android' will keep FYI bot working if updateclang starts getting calling in update stage (if we start using gclient_env, like trybots do)
BUG=156947
Review URL: https://codereview.chromium.org/11232020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also includes r165962 and r165963 on mac to fix a build issue.
BUG=156005,151927
Review URL: https://codereview.chromium.org/11143020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10961005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Once this sticks, the setting can be removed entirely.
BUG=none
Review URL: https://codereview.chromium.org/10960007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=delete third_party/llvm-build and run gclient runhooks. should download clang
Review URL: https://codereview.chromium.org/10939014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp changes:
1493: Fix ninja generator to recognize the 'default_target' flag.
1494, 1495: ninja: Survive case-only file renames on case-insensitive filesystems.
1494 requires a one-time clobber-build on OS X.
Conveniently, clang rolls cause clobber builds,
so roll gyp at the same time as clang. (Change the
clobber logic to delete .d files too for this roll.
I'll undo this at the next roll.)
BUG=none
TBR=hans
Review URL: https://codereview.chromium.org/10939009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=113085
TBR=hans
Review URL: https://chromiumcodereview.appspot.com/10917180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=136863
Review URL: https://chromiumcodereview.appspot.com/10917004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IWYU in its current form doesn't work well, and this script
fell victim to bitrot due to being unused.
BUG=143643
Review URL: https://chromiumcodereview.appspot.com/10828383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also suppress two warnings in third_party targets.
gyp changes reviewed by willchan in
http://codereview.chromium.org/10832369/
BUG=141532,138571
TBR=hans,willchan
Review URL: https://chromiumcodereview.appspot.com/10827405
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The flag was there to make checking of inner classes optional
until all inner classes could be fixed.
We must still parse the flag until this has been rolled in and
plugin_flags.sh has been updated not to pass in the flag anymore.
BUG=136863
Review URL: https://chromiumcodereview.appspot.com/10837254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=139346,136863
Review URL: https://chromiumcodereview.appspot.com/10830276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Lets -Wunused-private-field find more stuff
* Fixes an ASan problem on precise
* Improves the plugin's handling of inner classes (off by default,
can be enabled with |-Xclang -plugin-arg-find-bad-constructs
-Xclang check-inner-classes|)
* Makes addr2line much faster on linux
* Fix for crash we saw on the valgrind bots after the last roll attempt
* The plugin now ignores cc/ by default
BUG=139346,139912
TBR=hans
Review URL: https://chromiumcodereview.appspot.com/10831219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chromium compositor code will be imported from WebKit into this directory
soon. Since it's WebKit style, it doesn't currently adhere to all of the clang
style checks. This adds a temporary exemption so we don't spam the heck out of
everyone while we clean things up.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10853012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=139346
Review URL: https://chromiumcodereview.appspot.com/10837031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Lets -Wunused-private-field find more stuff
* Fixes an ASan problem on precise
* Improves the plugin's handling of inner classes (off by default,
can be enabled with |-Xclang -plugin-arg-find-bad-constructs
-Xclang check-inner-classes|)
* Makes addr2line much faster on linux
BUG=139346
TBR=mark for base (the change was reviewed as part of https://chromiumcodereview.appspot.com/10833055/)
Review URL: https://chromiumcodereview.appspot.com/10825104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A follow-up to https://chromiumcodereview.appspot.com/10808078
This way, cleaning up existing style issues in inner classes doesn't
have to block a clang roll.
BUG=139346
Review URL: https://chromiumcodereview.appspot.com/10828057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10818027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parsed
It turns out that a CXXRecordDecl can change between the call to
HandleTagDeclDefinition and HandleTopLevelDecl. This happens in the
case of nested class declarations, causing us to fail to emit warnings
in some cases (see the test). See crbug.com/136863 for the full discussion.
BUG=136863
TEST=tools/clang/plugins/tests/test.sh
Review URL: https://chromiumcodereview.appspot.com/10808078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10735067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First clang roll in a few weeks, so lots of new stuff:
* better 'unused' warnings. Now catches e.g. "AutoLock(&lock);"
* better 'uninitialized' warnings
* template type eliding in diagnostics
* TLS attribute support
* New -Wunused-private-field warning (disabled for now)
* style plugin has better warning for implicit destructors
* method_iterator interface changed back to what it was, update plugin again
* Warn on member variable self assignments
BUG=135207
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10689041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the style-checker complains about an inline copy constructor
that the user didn't define, make the error message more descriptive.
Otherwise it would just say "this ctor is inline", and point to the
start of the class, which is very confusing.
BUG=97483
TEST=style plugin test
Review URL: https://chromiumcodereview.appspot.com/10720002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the Clang error that makes it a warning/error to derive from
base::RefCounted/RefCountedThreadSafe directly and have a public
destructor for Linux and Mac builds.
For ChromeOS builds, do not yet enable the warning, as it does not
yet build cleanly.
BUG=123295
TEST=it compiles
R=thakis
Review URL: https://chromiumcodereview.appspot.com/10414016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix the Clang version (it's 3.2 already) in the comments.
BUG=128314
Review URL: https://chromiumcodereview.appspot.com/10389165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Noteworth changes:
* http://llvm.org/viewvc/llvm-project?view=rev&revision=155808 changed the method_iterator interface, requiring minor plugin updates
* Bug where lots of <U+0000> were printed in warnings is fixed
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10316021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also includes new warnings in our style plugin, but those are
currently behind a flag and hence not active.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10155019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently behind a flag "-Xclang -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations"
BUG=115047
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10076002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::RefCounted or base::RefCountedThreadSafe.
Having public destructors is dangerous, as it allows the ref-counted object to be stack allocated and have references that attempt to outlive the stack, or to allow callers to explicitly delete it while references are still held. Both patterns result in use-after-free, hence their prohibition.
In doing so, update the Chromium plugin to be able to scan both headers and implementation files, and enable the public destructor check for both types with an optional flag ( -Xclang -plugin-arg-find-bad-constructs -Xclang skip-refcounted-dtors )
BUG=123295
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10005022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Interesting changes in this range:
* The tooling infrastructure landed. Not observable, but it makes it easier
to write clang tools.
* Honor -fno-pic, pie support
* Better diagnostics for several c++11 features
* Cross-compiler changes that hopefully make CrOs clang builds simpler
* Many LTO fixes
Also pick up a minor change to the style plugin: Instead of ignoring
problems below out/, it now ignores them below gen/ and geni/. This
should make it work better with custom build directories.
BUG=none
TEST=none
TBR=mark
Review URL: http://codereview.chromium.org/10081013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That way, the plugin doesn't show warnings for people who use
`build/gyp_chromium -Goutput_dir=out_foo` with ninja. With that,
it's possible to turn on the plugin by default on Linux I think (for
people who opt in to clang).
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10000002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New stuff:
* ObjC number, array, dict literals
* ASan fixes, visibility fixes (see bugs)
* (c++11: User-defined literals)
* -Wstring-plus-int
* Fix for a bug that made the previous previous roll not work with goma
* Fix for a code bloat regression that caused the previous roll to be reverted (fix in r153506)
* Includes r153550, which fixed an enum codegen trickiness added in r153383
BUG=114996,112539,119119
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9929001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused a ~250kB regression in ChromiumFramework size, reverting to get the tree
green.
---
New stuff:
* ObjC number, array, dict literals
* ASan fixes, visibility fixes (see bugs)
* (c++11: User-defined literals)
* -Wstring-plus-int
* Fix for a bug that made the last roll not work with goma
BUG=114996,112539,119119
TEST=none
Review URL: http://codereview.chromium.org/9836038
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9835085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New stuff:
* ObjC number, array, dict literals
* ASan fixes, visibility fixes (see bugs)
* (c++11: User-defined literals)
* -Wstring-plus-int
* Fix for a bug that made the last roll not work with goma
BUG=114996,112539,119119
TEST=none
Review URL: http://codereview.chromium.org/9836038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new version of Clang has problems with Goma. When the compile
goes via Goma it produces empty dependency files, which breaks
incremental builds because dependencies on header files are not
tracked correctly.
BUG=119119
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/9766009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New stuff:
* ObjC number, array, dict literals
* ASan fixes, visibility fixes (see bugs)
* (c++11: User-defined literals)
* -Wstring-plus-int
BUG=114996,112539
TEST=none
Review URL: http://codereview.chromium.org/9703027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9688015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exciting new stuff:
* Visibility fixes, which should make it possible to get the mac components build going eventually (with a bunch of chromium patches that I have locally)
* Lambda support
This also makes -Wempty-body catch more things, so https://chromiumcodereview.appspot.com/9570054/ disables that warning on two targets.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9557011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clang roll try jobs.
The subprocess module used to dup() stdin, but apparently that's no longer true. So dup it manually.
Patch from Jay Soffian <jaysoffian@gmail.com>!
BUG=none
TEST=Put a new clang revision in tools/clang/scripts/update.sh, send try job. Works.
Review URL: http://codereview.chromium.org/9430007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9401034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122668 0039d316-1c4b-4281-b951-d872f2087c98
|