| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1587683002 .
Cr-Commit-Position: refs/heads/master@{#369210}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1539373005/ )
Reason for revert:
The Mac OS 10.7 Debug Blink bot is hitting the regression mentioned in the CL while running several Blink unittests:
dyld: lazy symbol binding failed: Symbol not found: __ZNSt3__114basic_iostreamIcNS_11char_traitsIcEEEC2EPNS_15basic_streambufIcS2_EE
Referenced from: /Volumes/data/b/swarm_slave/work/isolated/runImpjEb/third_party/WebKit/Source/wtf/../../../../out/Debug/wtf_unittests
Expected in: /usr/lib/libc++.1.dylib
dyld: Symbol not found: __ZNSt3__114basic_iostreamIcNS_11char_traitsIcEEEC2EPNS_15basic_streambufIcS2_EE
Referenced from: /Volumes/data/b/swarm_slave/work/isolated/runImpjEb/third_party/WebKit/Source/wtf/../../../../out/Debug/wtf_unittests
Expected in: /usr/lib/libc++.1.dylib
Full output:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/26318/steps/steps/logs/stdio
Original issue's description:
> roll clang 255169:256316
>
> New:
> * /W4 in clang-cl enables -Wextra warnings
> * fix for link.exe /incremental build flakes
> * /Brepro suppresses timestamps for deterministic builds
> (doesn't work with link.exe /incremental)
>
> Note that this brings in a libc++ regression on Mac [1]: some of the
> symbols that are hidden symbols in the system libc++ in OS X 10.8
> are marked as "inline" in the headers shipped with this compiler --
> this means that binaries produced by this compiler might not run
> on OS X 10.8 if these calls don't get inlined (or, if the 10.8 SDK is
> used, they won't link). That's ok for us though because production
> builds on OS X statically link a newer libc++ with these symbols
> exported, the iOS bots run newer OS X versions than 10.8, and
> so do the Mac bots that do component builds (which use the
> system libc++) or asan builds. And soon we'll roll in r257193 which
> fixes this again.
>
> 1: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146428.html
>
> BUG=571691
> TBR=hans
>
> Committed: https://crrev.com/483df9304bb678dd50b435a41c063a3aed96d10f
> Cr-Commit-Position: refs/heads/master@{#368796}
TBR=hans@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=571691
Review URL: https://codereview.chromium.org/1575393003
Cr-Commit-Position: refs/heads/master@{#368900}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New:
* /W4 in clang-cl enables -Wextra warnings
* fix for link.exe /incremental build flakes
* /Brepro suppresses timestamps for deterministic builds
(doesn't work with link.exe /incremental)
Note that this brings in a libc++ regression on Mac [1]: some of the
symbols that are hidden symbols in the system libc++ in OS X 10.8
are marked as "inline" in the headers shipped with this compiler --
this means that binaries produced by this compiler might not run
on OS X 10.8 if these calls don't get inlined (or, if the 10.8 SDK is
used, they won't link). That's ok for us though because production
builds on OS X statically link a newer libc++ with these symbols
exported, the iOS bots run newer OS X versions than 10.8, and
so do the Mac bots that do component builds (which use the
system libc++) or asan builds. And soon we'll roll in r257193 which
fixes this again.
1: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160104/146428.html
BUG=571691
TBR=hans
Review URL: https://codereview.chromium.org/1539373005
Cr-Commit-Position: refs/heads/master@{#368796}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch also fixes a bug when the tool renamed expressions involving
nested name specifiers: given A::B::C, it incorrectly replaced `A` when
it should have replaced `C`.
BUG=none
Review URL: https://codereview.chromium.org/1557243002
Cr-Commit-Position: refs/heads/master@{#368445}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The script reads bytes from the HTTP connection until urllib returns EOF,
but that can apparently happen before all bytes have been received.
See e.g. https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/3381/steps/gclient%20runhooks%20%28with%20patch%29/logs/stdio
BUG=none
Review URL: https://codereview.chromium.org/1558993003
Cr-Commit-Position: refs/heads/master@{#367508}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/1554823002
Cr-Commit-Position: refs/heads/master@{#367222}
|
|
|
|
|
|
|
|
| |
Fix some small nits along the way.
Review URL: https://codereview.chromium.org/1554533002
Cr-Commit-Position: refs/heads/master@{#367109}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/1546323004/ )
Reason for revert:
Every tot bot should have cycled with this by now.
Original issue's description:
> Force clang/tot bots to do clobber builds of clang for a bit.
>
> Apparently cmake doesn't like it if the compiler changes like it did in
> https://codereview.chromium.org/1555443002/ without a clobber build.
>
> Since this might help with issue 569337 too (who knows), do it everywhere
> for a short while instead of just on linux.
>
> BUG=509739,569337
> TBR=hans
>
> Committed: https://chromium.googlesource.com/chromium/src/+/1c0fd1fac8ee649f5da00473e5d88565ea3ae930
TBR=hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509739,569337
Review URL: https://codereview.chromium.org/1554573002
Cr-Commit-Position: refs/heads/master@{#367065}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently cmake doesn't like it if the compiler changes like it did in
https://codereview.chromium.org/1555443002/ without a clobber build.
Since this might help with issue 569337 too (who knows), do it everywhere
for a short while instead of just on linux.
BUG=509739,569337
TBR=hans
Review URL: https://codereview.chromium.org/1546323004 .
Cr-Commit-Position: refs/heads/master@{#367029}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That way, the libstdc++ that's used by default should work on the bots.
Before this change, one had to pass --gcc-toolchain pointing to a precise-built
gcc when building linux clang binaries.
BUG=509739
TBR=hans@chromium.org
Review URL: https://codereview.chromium.org/1555443002 .
Cr-Commit-Position: refs/heads/master@{#367026}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/1549183002
Cr-Commit-Position: refs/heads/master@{#366885}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The clang tot bots only run update.py but don't build packages. Hence,
the ClangToTMacAsan bot didn't get the LC_ID_DYLIB for its runtime adjusted,
and when the tests are executed on swarming they try to find the asan runtime
in the llvm build directory instead of where swarming put it.
BUG=571145
TBR=hans@chromium.org
Review URL: https://codereview.chromium.org/1544193002 .
Cr-Commit-Position: refs/heads/master@{#366826}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This might help determine if the full LLVM builds are caused by
the llvm-build directory disappearing between builds.
BUG=569337
TBR=hans@chromium.org
Committed: https://crrev.com/dc8cdbb4066c7e9e8845376958f1af7bc12f2025
Cr-Commit-Position: refs/heads/master@{#366497}
Review URL: https://codereview.chromium.org/1545533002 .
Cr-Commit-Position: refs/heads/master@{#366531}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1545533002/ )
Reason for revert:
Broke the Android bots' gclient runhooks steps (e.g. https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20M%20(dbg)/builds/1934/steps/gclient%20runhooks/logs/stdio)
Your function should be os.makedirs(path) instead.
Original issue's description:
> update.py: Log directory creations.
>
> This might help determine if the full LLVM builds are caused by
> the llvm-build directory disappearing between builds.
>
> BUG=569337
> TBR=hans@chromium.org
>
> Committed: https://crrev.com/dc8cdbb4066c7e9e8845376958f1af7bc12f2025
> Cr-Commit-Position: refs/heads/master@{#366497}
TBR=hans@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=569337
Review URL: https://codereview.chromium.org/1542013002
Cr-Commit-Position: refs/heads/master@{#366502}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This might help determine if the full LLVM builds are caused by
the llvm-build directory disappearing between builds.
BUG=569337
TBR=hans@chromium.org
Review URL: https://codereview.chromium.org/1545533002
Cr-Commit-Position: refs/heads/master@{#366497}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handles:
- free functions (mostly)
- class fields
- constants and variables
BUG=none
Review URL: https://codereview.chromium.org/1523763002
Cr-Commit-Position: refs/heads/master@{#366054}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Though clang has a mode to automatically apply fixits and recompile with
the -Xclang -fixit-recompile flag, this doesn't work well with parallel
invocations of clang.
BUG=557422
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1538703002 .
Cr-Commit-Position: refs/heads/master@{#365957}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original implementation just replaced the entire text of x.Pass()
with std::move(x). Unfortunately, this doesn't work well with nested
invocations of Pass(), since `x` will not include the nested rewrite to
use std::move().
Instead, the tool is a bit more clever now: it inserts the text
`std::move(` before the expression and deletes the now-unnecessary text
`.Pass(`. This handles nested expressions well: it still fails for
chained calls to Pass(), but meh.
BUG=557422
Review URL: https://codereview.chromium.org/1534793004
Cr-Commit-Position: refs/heads/master@{#365913}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the script retry downloads a couple of times with exponential
back-off to reduce the risk of failing due to network flakes.
It also removes the historical behaviour of falling back to local builds
when it fails to download a pre-built binary. For users, that was a very
confusing error mode. For building locally, we have the --force-local-builds
flag.
BUG=569060
Review URL: https://codereview.chromium.org/1531003002
Cr-Commit-Position: refs/heads/master@{#365862}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently it's just a simple helper to avoid looking up the command
each time it's needed. In the future, this will be extended to also
perform Windows-specific munging of the compile DB for clang tools.
BUG=none
Review URL: https://codereview.chromium.org/1528633003
Cr-Commit-Position: refs/heads/master@{#365699}
|
|
|
|
|
|
|
|
| |
BUG=557422
Review URL: https://codereview.chromium.org/1524053002
Cr-Commit-Position: refs/heads/master@{#365694}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/1526173002
Cr-Commit-Position: refs/heads/master@{#365313}
|
|
|
|
|
|
|
|
| |
BUG=569337
Review URL: https://codereview.chromium.org/1523303002
Cr-Commit-Position: refs/heads/master@{#365273}
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix the empty_string build, which was used to verify the script
changes.
BUG=none
Review URL: https://codereview.chromium.org/1525673002
Cr-Commit-Position: refs/heads/master@{#365114}
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove built-in clang formatting, since git cl format does the same
thing and works everywhere.
BUG=none
Review URL: https://codereview.chromium.org/1519563005
Cr-Commit-Position: refs/heads/master@{#364814}
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/1517133002
Cr-Commit-Position: refs/heads/master@{#364638}
|
|
|
|
|
|
|
|
|
|
| |
Stale CMake cache files sometimes break the incremental build.
BUG=none
Review URL: https://codereview.chromium.org/1504273005
Cr-Commit-Position: refs/heads/master@{#364568}
|
|
|
|
|
|
|
|
| |
BUG=156590
Review URL: https://codereview.chromium.org/1504033010
Cr-Commit-Position: refs/heads/master@{#364385}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a small roll, picking up r255169 which
fixes the CFI build.
BUG=568248
Review URL: https://codereview.chromium.org/1516433003
Cr-Commit-Position: refs/heads/master@{#364360}
|
|
|
|
|
|
|
|
| |
BUG=535367
Review URL: https://codereview.chromium.org/1511973003
Cr-Commit-Position: refs/heads/master@{#364137}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1508403002/ )
Reason for revert:
Should work with CFI reverted.
Original issue's description:
> Revert of roll clang 254049:254793 (patchset #3 id:40001 of https://codereview.chromium.org/1507873002/ )
>
> Reason for revert:
> Speculative revert to see if this fixes link error on 'Google Chrome Linux x64'. Please see first comment on the revert CL for more info.
>
> Original issue's description:
> > roll clang 254049:254793
> >
> > This switches msan to the new ABI.
> >
> > It's also the first roll that used update.py instead of
> > update.sh to build the packages.
> >
> > It also changes package.py to bundle up libstdc++ on linux
> > unconditionally, and removes the --gcc-toolchain flag from
> > it (the auto-downloaded gcc should be good enough;
> > one fewer thing I can get wrong).
> >
> > BUG=565541
> >
> > Committed: https://crrev.com/3c862a1dff6cbe5f693ba788cdc71770d408e7b7
> > Cr-Commit-Position: refs/heads/master@{#363986}
>
> TBR=hans@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=565541
>
> Committed: https://crrev.com/af4e20d002ee9acc62854db5bd89f2aa14b2d419
> Cr-Commit-Position: refs/heads/master@{#364051}
TBR=hans@chromium.org,engedy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=565541
Review URL: https://codereview.chromium.org/1514573002
Cr-Commit-Position: refs/heads/master@{#364069}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1507873002/ )
Reason for revert:
Speculative revert to see if this fixes link error on 'Google Chrome Linux x64'. Please see first comment on the revert CL for more info.
Original issue's description:
> roll clang 254049:254793
>
> This switches msan to the new ABI.
>
> It's also the first roll that used update.py instead of
> update.sh to build the packages.
>
> It also changes package.py to bundle up libstdc++ on linux
> unconditionally, and removes the --gcc-toolchain flag from
> it (the auto-downloaded gcc should be good enough;
> one fewer thing I can get wrong).
>
> BUG=565541
>
> Committed: https://crrev.com/3c862a1dff6cbe5f693ba788cdc71770d408e7b7
> Cr-Commit-Position: refs/heads/master@{#363986}
TBR=hans@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=565541
Review URL: https://codereview.chromium.org/1508403002
Cr-Commit-Position: refs/heads/master@{#364051}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The GC plugin currently insists that a class that is declared as a
mixin instance (i.e., uses USING_GARBAGE_COLLECTED_MIXIN()) must also
declare its own local trace implementation override.
This is an unnecessary restriction to impose:
- if the class derives from one GarbageCollectedMixin<> instance,
it will have its virtual trace method in scope.
- if it inherits from multiple, ambiguity exists and the compiler
will already complain.
- if the class declares traceable members of its own, then not providing
a trace implementation that correctly handles these members will
be otherwise flagged as an error by the GC plugin.
Remove the static check from the plugin, along with adding a unit test
which verifies that the virtual trace is inherited as expected.
R=thakis,haraken
BUG=444565
Review URL: https://codereview.chromium.org/1504013004
Cr-Commit-Position: refs/heads/master@{#364001}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This switches msan to the new ABI.
It's also the first roll that used update.py instead of
update.sh to build the packages.
It also changes package.py to bundle up libstdc++ on linux
unconditionally, and removes the --gcc-toolchain flag from
it (the auto-downloaded gcc should be good enough;
one fewer thing I can get wrong).
BUG=565541
Review URL: https://codereview.chromium.org/1507873002
Cr-Commit-Position: refs/heads/master@{#363986}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's some typos in the logic to detect a record type as trivial
that make it always return the same result (nontrivial).
This fixes it and adds tests that depend on it working correctly.
The two errors are:
(1) TypeHasNonTrivialDtor's argument is a C++ record Type (struct/union/class),
not a pointer Type. As a result getPointeeCXXRecordDecl() will always return
null, causing this function to always return false.
(2) However, when TypeHasNonTrivialDtor returns false, we incorrectly count that
member as a non-trivial member.
So the net result is that everything counts as nontrivial.
Review URL: https://codereview.chromium.org/1455223002
Cr-Commit-Position: refs/heads/master@{#363599}
|
|
|
|
|
|
|
|
|
| |
BUG=557422
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1501103002 .
Cr-Commit-Position: refs/heads/master@{#363337}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WriteStampFile() has:
if not os.path.exists(os.path.dirname(STAMP_FILE)):
os.makedirs(os.path.dirname(STAMP_FILE))
with open(STAMP_FILE, 'w') as f:
STAMP_FILE currently is src/third_party/llvm/../llvm-build
If third_party/llvm-build exists but third_party/llvm doesn't, then
makedirs() line is executed, creates third_party/llvm, then goes to
third_party and attempts to create llvm-build. Since that already
exists, it throws.
If the "not exists, then makedirs" code is moved into a new function
that calls realpath() before the exists/makedirs calls, then the
makedirs() part works fine, but the open() call will fail since
that seems to try and visit each path component in order and
third_party/llvm doesn't exist.
As a workaround make sure no .. component is in STAMP_FILE for now,
to unblock a NaCl roll.
BUG=566150
R=hans@chromium.org
Review URL: https://codereview.chromium.org/1497383002 .
Cr-Commit-Position: refs/heads/master@{#363333}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1502453002
Cr-Commit-Position: refs/heads/master@{#363105}
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=thakis@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1492053005
Cr-Commit-Position: refs/heads/master@{#362955}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
date. (patchset #1 id:1 of https://codereview.chromium.org/1494883004/ )
Reason for revert:
Reverting didn't help.
Original issue's description:
> Revert of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1491203003/ )
>
> Reason for revert:
> This breaks Codesearch bots.
>
> Original issue's description:
> > Fix downloading LLVM Gold plugin in the case, when Clang is up to date.
> >
> > The script should download LLVM Gold plugin, if it's missing, even if the
> > main Clang toolchain is up to date. This change is to match update.py
> > functionality with the gone update.sh.
> >
> > BUG=464797,494442
> >
> > Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3
> > Cr-Commit-Position: refs/heads/master@{#362803}
>
> TBR=thakis@chromium.org,krasin@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=464797,494442
>
> Committed: https://crrev.com/9e37ffbe43c0b100bcc02f9faf648f11d86316c1
> Cr-Commit-Position: refs/heads/master@{#362938}
TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464797,494442
Review URL: https://codereview.chromium.org/1493283002
Cr-Commit-Position: refs/heads/master@{#362939}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
date. (patchset #1 id:1 of https://codereview.chromium.org/1491203003/ )
Reason for revert:
This breaks Codesearch bots.
Original issue's description:
> Fix downloading LLVM Gold plugin in the case, when Clang is up to date.
>
> The script should download LLVM Gold plugin, if it's missing, even if the
> main Clang toolchain is up to date. This change is to match update.py
> functionality with the gone update.sh.
>
> BUG=464797,494442
>
> Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3
> Cr-Commit-Position: refs/heads/master@{#362803}
TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464797,494442
Review URL: https://codereview.chromium.org/1494883004
Cr-Commit-Position: refs/heads/master@{#362938}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The script should download LLVM Gold plugin, if it's missing, even if the
main Clang toolchain is up to date. This change is to match update.py
functionality with the gone update.sh.
BUG=464797,494442
Review URL: https://codereview.chromium.org/1491203003
Cr-Commit-Position: refs/heads/master@{#362803}
|
|
|
|
|
|
|
|
|
| |
BUG=494442
R=hans@chromium.org
Review URL: https://codereview.chromium.org/1489223003 .
Cr-Commit-Position: refs/heads/master@{#362772}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove update.sh.
No intended behavior change.
BUG=494442
R=hans@chromium.org
Review URL: https://codereview.chromium.org/1490723004 .
Cr-Commit-Position: refs/heads/master@{#362738}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1489983002/ )
Reason for revert:
Should be better now.
Original issue's description:
> Revert of update.sh/py: Use cmake 3.2.2 instead of 3.1.0 (patchset #1 id:1 of https://codereview.chromium.org/1492593002/ )
>
> Reason for revert:
> Turned ClangToTMac and ClangToTiOS bots red. Probably just needs a clobber, will reland and check tomorrow.
>
> Original issue's description:
> > update.sh/py: Use cmake 3.2.2 instead of 3.1.0
> >
> > Doing a bootstrap build requires 3.2.2, so it seems nice if the
> > auto-downloaded cmake is able to do that. update.py unconditionally
> > downloads a cmake, while update.sh only does so if cmake is older
> > than 3.0. The update.py behavior seems better.
> >
> > (Fun fact: The mac 310 was actually 3.0.1 :-/)
> >
> > BUG=494442
> > R=hans@chromium.org
> >
> > Committed: https://crrev.com/7b52b4eab85b300c5b414aa32a8208bccea1be7e
> > Cr-Commit-Position: refs/heads/master@{#362506}
>
> TBR=hans@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=494442
>
> Committed: https://crrev.com/94daf30d5caa04a6efe3dd85f7e8a09e24f6ade8
> Cr-Commit-Position: refs/heads/master@{#362529}
TBR=hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=494442
Review URL: https://codereview.chromium.org/1492833002
Cr-Commit-Position: refs/heads/master@{#362704}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1492593002/ )
Reason for revert:
Turned ClangToTMac and ClangToTiOS bots red. Probably just needs a clobber, will reland and check tomorrow.
Original issue's description:
> update.sh/py: Use cmake 3.2.2 instead of 3.1.0
>
> Doing a bootstrap build requires 3.2.2, so it seems nice if the
> auto-downloaded cmake is able to do that. update.py unconditionally
> downloads a cmake, while update.sh only does so if cmake is older
> than 3.0. The update.py behavior seems better.
>
> (Fun fact: The mac 310 was actually 3.0.1 :-/)
>
> BUG=494442
> R=hans@chromium.org
>
> Committed: https://crrev.com/7b52b4eab85b300c5b414aa32a8208bccea1be7e
> Cr-Commit-Position: refs/heads/master@{#362506}
TBR=hans@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=494442
Review URL: https://codereview.chromium.org/1489983002
Cr-Commit-Position: refs/heads/master@{#362529}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing a bootstrap build requires 3.2.2, so it seems nice if the
auto-downloaded cmake is able to do that. update.py unconditionally
downloads a cmake, while update.sh only does so if cmake is older
than 3.0. The update.py behavior seems better.
(Fun fact: The mac 310 was actually 3.0.1 :-/)
BUG=494442
R=hans@chromium.org
Review URL: https://codereview.chromium.org/1492593002 .
Cr-Commit-Position: refs/heads/master@{#362506}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was used while bringing up the plugin on Windows, but it
is no longer used.
BUG=467287
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1486813002 .
Cr-Commit-Position: refs/heads/master@{#362269}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a translation unit contains only warnings, the GC plugin will issue
a warning diagnostic along with details/notes of the warnings encountered.
Have that warning be under the control of -Werror; the reason for not
having it as such up until now is that warnings have been far too plentiful
for the Blink codebase. This is no longer the case.
R=haraken,yutak,thakis
BUG=
Review URL: https://codereview.chromium.org/1481523005
Cr-Commit-Position: refs/heads/master@{#362128}
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Build compiler-rt out-of-tree on linux and mac
* Build android compiler-rt libs
* Download gold plugin for official linux builds
BUG=494442
Review URL: https://codereview.chromium.org/1475213002
Cr-Commit-Position: refs/heads/master@{#361930}
|