summaryrefslogtreecommitdiffstats
path: root/tools/clang
Commit message (Collapse)AuthorAgeFilesLines
* Warn on missing OVERRIDE/virtual everywhere, not just in header files.rsleevi@chromium.org2013-05-021-3/+1
| | | | | | | | | | This is only enabled for Linux (so far). BUG=115047 Review URL: https://chromiumcodereview.appspot.com/14696007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197788 0039d316-1c4b-4281-b951-d872f2087c98
* Remove support code that was used to pin asan to an older revision.thakis@chromium.org2013-04-301-49/+0
| | | | | | | | | | It's no longer needed. BUG=170629 Review URL: https://codereview.chromium.org/14568002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197404 0039d316-1c4b-4281-b951-d872f2087c98
* Unpin the Clang version used by the OS X bots.glider@chromium.org2013-04-231-1/+1
| | | | | | | | | | | | This CL only changes the Clang version to the one used by other bots. Code cleanup will be done separately. BUG=170629 TBR=thakis Review URL: https://codereview.chromium.org/12457022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195771 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 176256:179138thakis@chromium.org2013-04-221-1/+1
| | | | | | | | | | | | | | BUG=233709,234010 TBR=hans NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195220 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195379 Review URL: https://codereview.chromium.org/14169006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195632 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 195379 "roll clang 176256:179138"tapted@chromium.org2013-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | Numerous CrOS test failures: see http://crbug.com/234010 > roll clang 176256:179138 > > BUG=233709 > TBR=hans > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195220 > > Review URL: https://chromiumcodereview.appspot.com/14169006 TBR=thakis@chromium.org BUG=234010 Review URL: https://codereview.chromium.org/13871019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195429 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 176256:179138thakis@chromium.org2013-04-201-1/+1
| | | | | | | | | | | | BUG=233709 TBR=hans NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195220 Review URL: https://chromiumcodereview.appspot.com/14169006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195379 0039d316-1c4b-4281-b951-d872f2087c98
* Compiler error in Linux ChromiumOS (Clang dbg):rlp@chromium.org2013-04-191-1/+1
| | | | | | | | | | | | | | | | | | third_party/libyuv/source/row_posix.cc:1825:5: error: ran out of registers during register allocation "movdqa %[kShuffleMaskARGBToRGB24_0],%%xmm5 \n" ^ Revert 195220 - roll clang 176256:179138 BUG=none TBR=hans Review URL: https://chromiumcodereview.appspot.com/14169006 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/14365021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195231 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 176256:179138thakis@chromium.org2013-04-191-1/+1
| | | | | | | | | BUG=none TBR=hans Review URL: https://chromiumcodereview.appspot.com/14169006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195220 0039d316-1c4b-4281-b951-d872f2087c98
* Add url/ to banned_directories in clang style checker.tfarina@chromium.org2013-04-163-7/+23
| | | | | | | | | BUG=229660 R=thakis@chromium.org Review URL: https://codereview.chromium.org/14064011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194481 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the asan clang pinning does not pin the layout bots toothakis@chromium.org2013-04-101-2/+6
| | | | | | | | BUG=170629 Review URL: https://codereview.chromium.org/13999003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193425 0039d316-1c4b-4281-b951-d872f2087c98
* Remove C++11 usage from Clang tools.dcheng@chromium.org2013-04-092-7/+9
| | | | | | | | | | I guess I shouldn't have ignored the compiler warnings. BUG= Review URL: https://codereview.chromium.org/13904002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193023 0039d316-1c4b-4281-b951-d872f2087c98
* Add clang tool to rewrite scoped_array<T> to scoped_ptr<T[]>.dcheng@chromium.org2013-04-064-0/+160
| | | | | | | | BUG=171111 Review URL: https://codereview.chromium.org/13482006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192700 0039d316-1c4b-4281-b951-d872f2087c98
* Have run_tool.py automatically invoke clang-format-diff.py if available.dcheng@chromium.org2013-04-042-11/+24
| | | | | | | | | | | | | This makes for nicer code and removes the extra post-processing step. It also provides more granular warnings; simply returning the formatter across the entire diff will provide cryptic errors like missing { at line 540. BUG= Review URL: https://codereview.chromium.org/13605003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192359 0039d316-1c4b-4281-b951-d872f2087c98
* Return a non-zero exit code if compiler invocations failed.dcheng@chromium.org2013-04-041-1/+8
| | | | | | | | | | | This makes test_tool.py a little more user-friendly as a compile error in a test source file will actually display now. BUG= Review URL: https://codereview.chromium.org/13607002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192356 0039d316-1c4b-4281-b951-d872f2087c98
* Add std::wstring support to the empty string tool and update the tests.dcheng@chromium.org2013-04-033-2/+21
| | | | | | | | | BUG=none TEST=test_tool.py empty_string Review URL: https://codereview.chromium.org/13505002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191998 0039d316-1c4b-4281-b951-d872f2087c98
* Implement clang tool that converts std::string("") to std::string().dcheng@chromium.org2013-04-027-2/+706
| | | | | | | | | | This is intended to be a simple demo of the clang tools functionality. BUG= Review URL: https://codereview.chromium.org/12746010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191936 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 188113 "Revert 188080 "Add vm672-m1 (the new Mac ASan bui..."tbreisacher@chromium.org2013-03-141-1/+5
| | | | | | | | | | | | | | | | | | | | > Revert 188080 "Add vm672-m1 (the new Mac ASan builder) to the li..." > > This CL seems to be causing content_unittests flakiness on MAC ASAN Tests (1): http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Tests%20%281%29/builds/7515/steps/content_unittests/logs/stdio > > > Add vm672-m1 (the new Mac ASan builder) to the list of machines using pinned Clang version. > > > > BUG=170629 > > TBR=thakis > > Review URL: https://codereview.chromium.org/12729006 > > TBR=glider@chromium.org > Review URL: https://codereview.chromium.org/12545038 TBR=glider@chromium.org Review URL: https://codereview.chromium.org/12833010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188142 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 188080 "Add vm672-m1 (the new Mac ASan builder) to the li..."tbreisacher@chromium.org2013-03-141-5/+1
| | | | | | | | | | | | | | | This CL seems to be causing content_unittests flakiness on MAC ASAN Tests (1): http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Tests%20%281%29/builds/7515/steps/content_unittests/logs/stdio > Add vm672-m1 (the new Mac ASan builder) to the list of machines using pinned Clang version. > > BUG=170629 > TBR=thakis > Review URL: https://codereview.chromium.org/12729006 TBR=glider@chromium.org Review URL: https://codereview.chromium.org/12545038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188113 0039d316-1c4b-4281-b951-d872f2087c98
* Add vm672-m1 (the new Mac ASan builder) to the list of machines using pinned ↵glider@chromium.org2013-03-141-1/+5
| | | | | | | | | | Clang version. BUG=170629 TBR=thakis Review URL: https://codereview.chromium.org/12729006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188080 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 174965:176256thakis@chromium.org2013-03-081-1/+1
| | | | | | | | | | | | | | | | Changes (subset): * Fixes a bug with asan work on precise * strict_memcmp flag for asan * Tweaked symbol visibility computation in clang (worked with upstream to make sure the component build still works) BUG=177235 TBR=hans Review URL: https://chromiumcodereview.appspot.com/12446007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187059 0039d316-1c4b-4281-b951-d872f2087c98
* Update ndk sysroot to API level 14.leozwang@chromium.org2013-03-051-1/+1
| | | | | | | | | | | | Update ndk toolchain to api level 14 to make application to be able to setup SL_ANDROID_RECORDING_PRESET_VOICE_COMMUNICATION mode which was introduced in api level 14 in opensl. BUG=179926 Review URL: https://chromiumcodereview.appspot.com/12379078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186254 0039d316-1c4b-4281-b951-d872f2087c98
* Ship profile_rt with Clang.jfb@chromium.org2013-03-041-5/+8
| | | | | | | | | | | | | | | | | | | | | | NaCl's Mac coverage bots have been broken since the GCC upgrade, and it seems like this Apple GCC version has bugs that won't get fixed. As this week's NaCl sheriff I'll start migrating our NaCl Mac bots to use LLVM, which is what we build and ship with anyways. I therefore need LLVM's profile_rt library for the coverage bots, otherwise a Mac build will grab the system one which would be a Bad Thing. My change merely packages profile_rt so that the next Clang update has it. The update should be separate. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3283 R= thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/12388025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185970 0039d316-1c4b-4281-b951-d872f2087c98
* Add MemorySanitizer runtime to Clang tarball.eugenis@chromium.org2013-02-261-3/+3
| | | | | | | | | | | Does not require changes to update.sh, will build automatically when Clang is updated past r175737. Increases tarball size by 68Kb, ~0.3%. BUG=178409 Review URL: https://chromiumcodereview.appspot.com/12334089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184705 0039d316-1c4b-4281-b951-d872f2087c98
* Add FixItHints to the Chromium Clang plugin when missing virtual or OVERRIDErsleevi@chromium.org2013-02-225-21/+128
| | | | | | | | | | | | | | | | | | | | Add context-specific Clang FixItHints whenever the Chromium style checker plugin detects they're needed. These may be automatically applied by running with -Xclang -fixit This is added to the Chromium plugin, rather than Clang itself, because these are Chromium-specific warnings. Clang's cpp11-migrate extra tool looks to be gaining experimental support for adding "override" (not OVERRIDE, as used by Chromium), but that's intended as a general rewriting tool, not a compiler/style check. BUG=115047 Review URL: https://chromiumcodereview.appspot.com/12211104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183963 0039d316-1c4b-4281-b951-d872f2087c98
* Changed asan host detection to use short hostnamehinoka@google.com2013-02-151-4/+4
| | | | | | | | | | | mini11-a1.chrome.corp.google.com is actually mini11-a1.perf.chromium.org, but lets just use short hostnames (hostname -s) so that the domain doesn't matter. BUG=170629, 174873 Review URL: https://codereview.chromium.org/12285006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182815 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Clang 170392:174965.hans@chromium.org2013-02-151-1/+1
| | | | | | | | BUG=176319 Review URL: https://codereview.chromium.org/12259030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182694 0039d316-1c4b-4281-b951-d872f2087c98
* Clang update script: fix the hostname for the Mac ASan LKGR bots, for which ↵glider@chromium.org2013-02-151-1/+1
| | | | | | | | | | we have to use the pinned version of Clang. BUG=170629, 174873 TBR=thakis Review URL: https://codereview.chromium.org/12212212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182662 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 182241isherman@chromium.org2013-02-151-1/+1
| | | | | | | | | | | | | | | | This seems to have broken the Mac ASAN LKGR builders. For example: http://build.chromium.org/p/chromium.lkgr/builders/Mac%20ASAN%20Release/builds/1188/steps/compile/logs/stdio > Roll Clang r170392:r174491. > > BUG=174873, 170629 > > Review URL: https://codereview.chromium.org/12220089 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/12256052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182603 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Clang r170392:r174491.hans@chromium.org2013-02-131-1/+1
| | | | | | | | BUG=174873, 170629 Review URL: https://codereview.chromium.org/12220089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182241 0039d316-1c4b-4281-b951-d872f2087c98
* Replace seq invocation with 'jot -'. They don't have seq on Mac by default.glider@chromium.org2013-02-131-1/+4
| | | | | | | | | | Make sure on_asan_mac_host() always returns 1 on non-Darwin systems. BUG=170629, 174873 TBR=thakis Review URL: https://codereview.chromium.org/12256005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182201 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a syntax error which resulted in update.sh always using the old Clang.glider@chromium.org2013-02-131-5/+10
| | | | | | | | | | | Renamed --is-asan-mac-builder to --is-asan-mac-builder-hackfix per Nico's suggestion. Added more comments. BUG=170629, 174873 TBR=thakis Review URL: https://codereview.chromium.org/12255003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182175 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Roll Clang r170392:r174491."hans@chromium.org2013-02-131-1/+1
| | | | | | | | | | | | | | It turns out that r181918, which pinned the Clang revision on Mac ASan bots worked a little too well, pinning the version on *all* Mac bots. This reverts the Clang roll. We will then fix update.sh to get the Mac ASan pinning correct, and then re-land the roll. BUG=174873, 170629 Review URL: https://codereview.chromium.org/12256002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182173 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Clang r170392:r174491.hans@chromium.org2013-02-121-1/+1
| | | | | | | | | BUG=174873, 170629 Review URL: https://chromiumcodereview.appspot.com/12220089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182023 0039d316-1c4b-4281-b951-d872f2087c98
* Teach update.sh how to optionally install clang-tools-extra.dcheng@chromium.org2013-02-121-0/+15
| | | | | | | | | | | clang-tools-extra contains several useful utilities for refactoring such as clang-format and (eventually) clang-format-diff.py. BUG=none Review URL: https://codereview.chromium.org/12213081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181992 0039d316-1c4b-4281-b951-d872f2087c98
* Add mini11-a1 (Mac ASan LKGR) to the list of hosts building Mac ASan ↵glider@chromium.org2013-02-121-0/+6
| | | | | | | | | binaries (those hosts should use a fixed Clang version) BUG=170629, 174873 Review URL: https://codereview.chromium.org/12207126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181927 0039d316-1c4b-4281-b951-d872f2087c98
* Pin Clang revision to r170392 for ASan Mac builders.glider@chromium.org2013-02-121-0/+27
| | | | | | | | | | This temporary change introduces the --is-asan-mac-builder flag and a blacklist of OSX hosts building ASan on the Chromium waterfall. If either the flag is set or `uname -n` is in the list, older Clang is used. BUG=170629,174873 Review URL: https://codereview.chromium.org/12210139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181918 0039d316-1c4b-4281-b951-d872f2087c98
* Make it easier to build new tools for Clang.dcheng@chromium.org2013-02-121-12/+17
| | | | | | | | | | | | | | The update script can now be easily updated to build new Chrome-specific clang tools. The intended use for this is to make it easier to write tools based on LibTooling to do large-scale refactorings across the entire Chrome codebase. BUG=none Review URL: https://chromiumcodereview.appspot.com/12223047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181870 0039d316-1c4b-4281-b951-d872f2087c98
* When building Clang for Mac, make LC_ID_DYLIB of the ASan dynamic runtime to ↵glider@chromium.org2013-02-111-0/+7
| | | | | | | | | be relative to @executable_path. BUG=170629 Review URL: https://codereview.chromium.org/11946043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181724 0039d316-1c4b-4281-b951-d872f2087c98
* Warn for non-virtual protected destructors of RefCounted classesjamesr@chromium.org2013-02-024-79/+104
| | | | | | | | | | This would catch bugs like crbug.com/171760 BUG= Review URL: https://codereview.chromium.org/12061005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180222 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Chromium style checker plugin so that it canrsleevi@chromium.org2013-02-015-79/+424
| | | | | | | | | | | | | | | | scan the entire public class hierarchy for ref-counting problems. This is to detect situations where a RefCounted type implements some Delegate-type class and the Delegate may be directly deleted, even if the RefCounted type may not be. Also removed unused flag -skip-refcounted-dtors while here BUG=123295 TEST=tools/clang/plugins/tests/test.sh Review URL: https://chromiumcodereview.appspot.com/10407057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180077 0039d316-1c4b-4281-b951-d872f2087c98
* roll clang 169803:170392thakis@chromium.org2012-12-211-1/+11
| | | | | | | | | | | | Also let the update script clobber nacl untar stamp files, so that no clobber builds are needed after clang rolls. BUG=159793 TBR=hans Review URL: https://codereview.chromium.org/11644047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174285 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Clang 168474:169803.hans@chromium.org2012-12-132-2/+3
| | | | | | | | | BUG=165895 Review URL: https://chromiumcodereview.appspot.com/11572012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172949 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Clang 167488:168474.hans@chromium.org2012-12-041-1/+1
| | | | | | | | | BUG=163104 Review URL: https://chromiumcodereview.appspot.com/11412302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171017 0039d316-1c4b-4281-b951-d872f2087c98
* Whitelist QuadF from ChromeClassTester checksjamesr@chromium.org2012-12-041-0/+4
| | | | | | | | | | | | There's a measurable (2.3-3%) perf improvement from inlining QuadF's dtor and ctor, even though FindBadConstructs thinks it's too large. BUG= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11280279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170868 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few -faddress-sanitizer stragglers.thakis@chromium.org2012-11-271-1/+1
| | | | | | | | | BUG=159580 TBR=glider Review URL: https://codereview.chromium.org/11418195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169797 0039d316-1c4b-4281-b951-d872f2087c98
* Download prebuilt llvm binary if tsan=1 or asan=1 defined in GYP_DEFINESukai@chromium.org2012-11-211-1/+2
| | | | | | | | | | R=thakis@chromium.org,glider@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/11418110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168994 0039d316-1c4b-4281-b951-d872f2087c98
* Add llvm-symbolizer to the list of binaries shipped with the Chromium-built LLVMglider@chromium.org2012-11-201-0/+1
| | | | | | | | | | This one is needed to switch ASan and TSan builds to -gline-tables-only, which is a huge binary size gain. BUG=128544 Review URL: https://chromiumcodereview.appspot.com/11348066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168755 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Clang for the Android port 163674:167488.hans@chromium.org2012-11-071-7/+1
| | | | | | | | | | | | | This brings us up to the same version as the rest of Chromium. Disable -Wasm-operand-widths until crbug.com/159452 is fixed. BUG=159712, 156947, 159452 Review URL: https://chromiumcodereview.appspot.com/11371004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166479 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 166369 - Revert 166365 - roll clang 165787:167488pastarmovj@google.com2012-11-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Seems like a clobber might be enough to fix the issues caused by this CL. Reverted because it is assumed to be the cause for multiple compile failures on mac and linux. Fixes crash in arm codegen. Doesn't warn on -Wno-arc-abi. Nicer diagnostics for nested macro instantiations. Includes asan support for android on linux (shout if you need that on mac). Fixes issue with debug information in .S files. Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files) BUG=159712,159452,159475,159502,159598,59580 TBR=hans Review URL: https://codereview.chromium.org/11361133 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/11377020 TBR=pastarmovj@google.com Review URL: https://codereview.chromium.org/11377023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166405 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 166365 - roll clang 165787:167488pastarmovj@google.com2012-11-071-1/+1
| | | | | | | | | | | | | | | | | | | | | Reverted because it is assumed to be the cause for multiple compile failures on mac and linux. Fixes crash in arm codegen. Doesn't warn on -Wno-arc-abi. Nicer diagnostics for nested macro instantiations. Includes asan support for android on linux (shout if you need that on mac). Fixes issue with debug information in .S files. Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files) BUG=159712,159452,159475,159502,159598,59580 TBR=hans Review URL: https://codereview.chromium.org/11361133 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/11377020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166369 0039d316-1c4b-4281-b951-d872f2087c98