| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Now that blocks cannot be used as statements, they no longer need to
worry about constructing implicit scopes for execution. Instead,
execution can always occur directly in the enclosing scope, and
ExecuteBlockInScope callers can simply use Execute instead.
BUG=434519
Review URL: https://codereview.chromium.org/1016683002
Cr-Commit-Position: refs/heads/master@{#321002}
|
| |
|
|
|
|
| |
Review URL: https://codereview.chromium.org/818033005
Cr-Commit-Position: refs/heads/master@{#309483}
|
| |
|
|
|
|
| |
Review URL: https://codereview.chromium.org/610293003
Cr-Commit-Position: refs/heads/master@{#297508}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update help for cflags to reference new escaping behavior. We now escape spaces. The main reason it didn't do this before was pkg-config integration, but we now have specialized scripts to wrap pkgconfig.
Improve error message when a label doesn't match. This is a common one to run into.
Add the origin when a load fails. Previously if you mistyped a label in a dependency you would get a message about the file not loading but no location, which made it very hard to track down. This plumbs through the original location to the actual load.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/318383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
Old design: item_tree manages dependency resolution, target_manager creates and hooks up the target dependencies, and the toolchain manager does all kinds of crazy ordering and loading stuff on every thread. There is lots of locking every time the dependency tree is modified.
This patch completely deletes the toolchain manager, item tree, item node, and target manager.
The new design is that the build files are executed on background threads, but then they come back to the main thread which assembles the dependency tree and schedules other file loads. This eliminates almost all locking and a lot of complexity.
The Loader now manages loading the different build files in the correct context, and managing dependencies (loading the build config first, for example). The Builder manages the dependency tree and requests that the Loader load files that it encounters references to.
This simpler design reduces non-test code by ~350 lines. In the current gn build, lock acquisitions go down from 1808 to 116 and it saves about 20ms wall clock time (8% faster). This is a bit deceiving, though, because most of the time is spent on pkg-config which is constant. It speeds up running individual build files by 1000-1500%.
The work of putting the tree together that used to take up this time inside locks is now transferred to the main thread, which looks like it is *sometimes* a bottleneck. This should be easier to optimize in the future, though.
Other tweaks:
- I fixed cycle finding
- Directories look prettier on Windows using the "desc" command
- Tracing output now includes the main thread and marks it as such
- I updated the base BUILD.gn file for the more recent tree.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/56433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234032 0039d316-1c4b-4281-b951-d872f2087c98
|
