summaryrefslogtreecommitdiffstats
path: root/tools/grit
Commit message (Collapse)AuthorAgeFilesLines
* Removing grit from Chrome repo, and bringing it back in from itsjoi@chromium.org2011-09-23184-26440/+0
| | | | | | | | | | | now-separate open source project via DEPS. BUG=97420 TEST=existing Review URL: http://codereview.chromium.org/7994005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102483 0039d316-1c4b-4281-b951-d872f2087c98
* Allow non-absolute path for variables. This fixes grit to do variablejoi@chromium.org2011-09-224-7/+10
| | | | | | | | | | | | | substitution in the resource_ids file correctly when it is invoked by ninja (which uses a relative path for this, whereas our gyp-generated make files use an absolute path). BUG=97420 TEST=this builds: ninja -C out/Debug chrome_extra_resources Review URL: http://codereview.chromium.org/7995013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102327 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare for moving grit to its own open-source project.joi@chromium.org2011-09-229-32/+270
| | | | | | | | | | | | | | | | | | | | This involved: - Removing a grit->Chrome dependency that had been added in a unit test; - Moving the very project-specific resource_ids file to not sit in the same directory as the grit files (albeit in a hacky way; will fix this better later as per TODOs in code); and - Removing the hard-coding of "project base dir is two directories up from grit.py" and instead making that a parameter of resource_ids (as per TODO in code, this should later move to be a parameter of the .grd file). Also fixed a minor bug in relpath in misc.py, and fixed line length in grd_runner.py. The next steps will be to copy the tools/grit folder into http://code.google.com/p/grit-i18n, then in a single commit delete tools/grit from the Chrome repo and add it back in via DEPS. Follow-up fixes will address some of the TODOs, and later fixes will generalize a few things and add some features available in a different version of grit. BUG=97420 TEST=trybots should catch any breakage here Review URL: http://codereview.chromium.org/7976026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102276 0039d316-1c4b-4281-b951-d872f2087c98
* Don't add "lable" elements to "decimalTextBox" elements in ADML but only the ↵markusheintz@chromium.org2011-09-202-5/+2
| | | | | | | | | | | | plain lable text. BUG=97047 TEST=adml_writer_unittests.py Review URL: http://codereview.chromium.org/7935014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101965 0039d316-1c4b-4281-b951-d872f2087c98
* Updated *.pak file format to support both UTF8 and UTF16adriansc@chromium.org2011-09-194-35/+65
| | | | | | | | | | | | | | | | | Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101213 Review URL: http://codereview.chromium.org/7744017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101846 0039d316-1c4b-4281-b951-d872f2087c98
* This broke lots of layout tests on OSX.levin@chromium.org2011-09-154-65/+35
| | | | | | | | | | | | | | | | | | | | | | | | See this link for the failure list: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/dom/HTMLTextAreaElement/reset-textarea.html,fast/dom/isindex-001.html,fast/dom/isindex-002.html,fast/forms/blankbuttons.html,fast/forms/box-shadow-override.html,fast/forms/button-default-title.html,fast/forms/file-input-direction.html,fast/forms/hidden-input-file.html,fast/forms/input-appearance-height.html,fast/forms/input-file-re-render.html,fast/forms/input-first-letter.html,fast/forms/isindex-placeholder.html,fast/forms/text-style-color.html,fast/forms/validation-message-appearance.html,fast/html/details-no-summary1.html,fast/html/details-no-summary2.html,fast/html/details-no-summary3.html,fast/html/details-no-summary4.html,fast/html/details-remove-summary-1-and-click.html,fast/html/details-remove-summary-1.html,fast/html/details-remove-summary-4-and-click.html,fast/html/details-remove-summary-4.html,fast/html/keygen.html,tables/mozilla/bugs/bug39209.html,tables/mozilla/bugs/bug4429.html,fast/forms/005.html,fast/forms/input-file-label.html,fast/invalid/residual-style.html,fast/parser/fragment-parser.html,fast/replaced/table-percent-height-text-controls.html,html5lib/runner.html,http/tests/misc/isindex-with-no-form-base-href.html,http/tests/misc/isindex-with-no-form.html Revert 101213 - Updated *.pak file format to support both UTF8 and UTF16 Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973 Review URL: http://codereview.chromium.org/7744017 TBR=adriansc@chromium.org Review URL: http://codereview.chromium.org/7890060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101224 0039d316-1c4b-4281-b951-d872f2087c98
* Updated *.pak file format to support both UTF8 and UTF16adriansc@chromium.org2011-09-154-35/+65
| | | | | | | | | | | | | | | | Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973 Review URL: http://codereview.chromium.org/7744017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101213 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100973 - Updated *.pak file format to support both UTF8 and UTF16dhollowa@chromium.org2011-09-144-65/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromeframe tests started failing with this, see: http://build.chromium.org/p/chromium/builders/Chrome%20Frame%20Tests%20%28ie6%29/builds/14472/steps/chrome_frame_tests/logs/stdio http://build.chromium.org/p/chromium/builders/Chrome%20Frame%20Tests%20%28ie7%29/builds/14446/steps/chrome_frame_tests/logs/stdio http://build.chromium.org/p/chromium/builders/Chrome%20Frame%20Tests%20%28ie8%29/builds/14187/steps/chrome_frame_tests/logs/stdio FullTabDownloadTest.TopLevelPostReissueFromChromeFramePage: Did not complete. [----------] 2 tests from FullTabDownloadTest [ RUN ] FullTabDownloadTest.CF_DownloadFileFromPost [ OK ] FullTabDownloadTest.CF_DownloadFileFromPost (16 ms) [ RUN ] FullTabDownloadTest.TopLevelPostReissueFromChromeFramePage [712:3268:0913/153614:1242640:INFO:chrome_frame_test_utils.h(89)] chrome_frame_test::HungCOMCallDetector::~HungCOMCallDetector [712:3268:0913/153614:1242640:INFO:navigation_test.cc(753)] Not running test on Vista with IE7 [712:3268:0913/153614:1242656:INFO:chrome_frame_test_utils.h(85)] chrome_frame_test::HungCOMCallDetector::HungCOMCallDetector Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Review URL: http://codereview.chromium.org/7744017 TBR=adriansc@chromium.org Review URL: http://codereview.chromium.org/7891028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101004 0039d316-1c4b-4281-b951-d872f2087c98
* Updated *.pak file format to support both UTF8 and UTF16adriansc@chromium.org2011-09-134-35/+65
| | | | | | | | | | | | | | Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Review URL: http://codereview.chromium.org/7744017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100973 0039d316-1c4b-4281-b951-d872f2087c98
* Merged duplicate functions from tools/data_pack into the ↵adriansc@chromium.org2011-09-093-6/+98
| | | | | | | | | | | | | | grit/format/data_pack class. Marked tools/data_pack directory for removal when the dependency in third_party file WebKit.gyp has been updated to point to grit. BUG=none TEST=builds Review URL: http://codereview.chromium.org/7795057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100504 0039d316-1c4b-4281-b951-d872f2087c98
* Only put the chrome frame resources in the locale dlls.tony@chromium.org2011-08-261-1/+7
| | | | | | | | | | | | | | | Chrome Frame needs 2 dialogs and an icon in the locale dlls. The rest of the strings and resources can be pulled from the locale pak files. This also removes the icon from the pak files and moves them into the dlls. BUG=94362 Review URL: http://codereview.chromium.org/7766007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98513 0039d316-1c4b-4281-b951-d872f2087c98
* Make bubble_border use resources under ui/resources.saintlou@chromium.org2011-08-161-0/+7
| | | | | | | | | | | This issue was originally http://codereview.chromium.org/7584007/ BUG=none TEST=none Review URL: http://codereview.chromium.org/7663001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97054 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 96817 - make bubble_border to use resources under ui/resources.georgey@chromium.org2011-08-151-7/+0
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7584007 TBR=saintlou@chromium.org Review URL: http://codereview.chromium.org/7648040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96849 0039d316-1c4b-4281-b951-d872f2087c98
* make bubble_border to use resources under ui/resources.saintlou@chromium.org2011-08-151-0/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7584007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96817 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the length field from the index entries in data pack files.tony@chromium.org2011-08-112-8/+15
| | | | | | | | | | | | | | | After the last index entry, we put an extra entry (id of 0, offset pointing to where the next entry would start) so we can compute the size of the last index entry. This saves 4 bytes per item in data pack files, which is about 10k per locale pak file. When compressed, this saves about 237k. BUG=76285 Review URL: http://codereview.chromium.org/7604012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96415 0039d316-1c4b-4281-b951-d872f2087c98
* Update the .pak file format to version 2: Make resource ids 16bittony@chromium.org2011-08-042-7/+8
| | | | | | | | | | | | | | | values instead of 32bit values. On gzip compressed locales files, this saves 17k total. Bump the cached theme pak version so the caches get rebuilt. BUG=76285 TEST=Covered by unit tests and manually tested installing themes. Review URL: http://codereview.chromium.org/7555003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95487 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 95480 - Abstract fullscreen exit bubble logic to bring Linux's ↵tony@chromium.org2011-08-042-8/+7
| | | | | | | | | | | | | | | | behaviour in line with Windows. I committed with the wrong change description-- This has nothing to do will fullscreen exit bubble, it has to do with data pak files). Review URL: http://codereview.chromium.org/7549005 TBR=tony@chromium.org Review URL: http://codereview.chromium.org/7575017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95482 0039d316-1c4b-4281-b951-d872f2087c98
* Abstract fullscreen exit bubble logic to bring Linux's behaviour in line withtony@chromium.org2011-08-042-7/+8
| | | | | | | | | | | Windows. BUG=30743 TEST= Review URL: http://codereview.chromium.org/7549005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95480 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some grit related dependencies.tony@chromium.org2011-07-291-27/+44
| | | | | | | | | | | | | | | | | | | | | 1) Use grit_action.gypi for devtools_frontend_resources. The grd file is not generated so we should use the gypi. 2) Have devtools_resources depend on the grit source files. This grd file is generated, so we can't run grit_info.py on it at gyp time. I've modified grit_info.py --inputs to take no arguments to just list out all the grit source files. This will at least cause us to rebuild properly if there is a change to grit. BUG=none TEST=Compile resources.pak and make sure there are no spurious rebuilds. Touch a grit source file and make sure that devtools_frontend_resources and devtools_resources rebuild. Review URL: http://codereview.chromium.org/7493084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94792 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove profile and url context dependencies from remote debugging ↵pfeldman@chromium.org2011-07-281-1/+1
| | | | | | | | | | | server. BUG= TEST= Review URL: http://codereview.chromium.org/7492065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94458 0039d316-1c4b-4281-b951-d872f2087c98
* Adding fake bidi generationofri@google.com2011-07-244-86/+198
| | | | | | | | | | BUG=73052 TEST=NONE Review URL: http://codereview.chromium.org/7246008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93821 0039d316-1c4b-4281-b951-d872f2087c98
* Rename app_strings to ui_strings.tfarina@chromium.org2011-07-071-1/+1
| | | | | | | | | | | BUG=72317 TEST=None R=rsesek@chromium.org, tony@chromium.org Review URL: http://codereview.chromium.org/7210060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91704 0039d316-1c4b-4281-b951-d872f2087c98
* Expose list of all running shared workers at chrome://workersyurys@chromium.org2011-07-041-0/+3
| | | | | | | | | | | This page will be used for opening DevTools window for shared workers. BUG=None TEST=None Review URL: http://codereview.chromium.org/7250004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91470 0039d316-1c4b-4281-b951-d872f2087c98
* Change grit to depend on test data in the main repository.joi@chromium.org2011-06-3066-55/+6449
| | | | | | | | | | | | BUG=82636 TEST=python tools/grit/grit.py unit Initial commit r91161, turned three bots red. Reverted r91165. Investigation shows only clobber is needed. Review URL: http://codereview.chromium.org/7269003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91170 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 91161 - Change grit to depend on test data in the main repository.joi@chromium.org2011-06-3066-6449/+55
| | | | | | | | | | | | BUG=82636 TEST=python tools/grit/grit.py unit Review URL: http://codereview.chromium.org/7269003 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/7285006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91165 0039d316-1c4b-4281-b951-d872f2087c98
* Change grit to depend on test data in the main repository.joi@chromium.org2011-06-3066-55/+6449
| | | | | | | | | BUG=82636 TEST=python tools/grit/grit.py unit Review URL: http://codereview.chromium.org/7269003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91161 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/resources/* to ui/resources/ directory.tfarina@chromium.org2011-06-291-1/+1
| | | | | | | | | | | BUG=72317 TEST=None R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7253057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91010 0039d316-1c4b-4281-b951-d872f2087c98
* Wholesale move of debugger sources to content.joi@chromium.org2011-06-291-1/+1
| | | | | | | | | | | | | | | | | Other references are modified only to point to the new location. Follow-up changes will move build rules for the debugger into content. This adds a somewhat permissive DEPS file to content/browser/debugger. Follow-up work will whittle that down to zero dependencies on chrome/. BUG=84078 TEST=existing Review URL: http://codereview.chromium.org/7274031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90912 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome://quota-internals/ resourcestzik@chromium.org2011-06-271-0/+3
| | | | | | | | | | | | | (split from issue 7038034) BUG=84397 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90447 Review URL: http://codereview.chromium.org/7053009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90623 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90447 - Add chrome://quota-internals/ resourcestzik@chromium.org2011-06-241-3/+0
| | | | | | | | | | | | | | (split from issue 7038034) BUG=84397 TEST=None Review URL: http://codereview.chromium.org/7053009 TBR=tzik@chromium.org Review URL: http://codereview.chromium.org/7259007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90451 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome://quota-internals/ resourcestzik@chromium.org2011-06-241-0/+3
| | | | | | | | | | | (split from issue 7038034) BUG=84397 TEST=None Review URL: http://codereview.chromium.org/7053009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90447 0039d316-1c4b-4281-b951-d872f2087c98
* Fix string-enums in ADMX templatesgfeher@chromium.org2011-06-175-57/+73
| | | | | | | | | BUG=86141 TEST=verify that the value of ProxyMode set via the ADMX template is correctly reflected in about:net-internals Review URL: http://codereview.chromium.org/7155025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89473 0039d316-1c4b-4281-b951-d872f2087c98
* Add is_linux, is_win, is_macosx, and is_posix to the list oftony@chromium.org2011-06-151-6/+13
| | | | | | | | | | | | | variables provided to grit <if> conditions. This simplifies many of the existing conditions and I've gone ahead and made some changes in generated_resources.grd to demonstrate this. BUG=86082 TEST=Manual, everything still compiles. Review URL: http://codereview.chromium.org/7111056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89264 0039d316-1c4b-4281-b951-d872f2087c98
* grit_info: Explicitly make __file__ relative to the current directory.thakis@chromium.org2011-05-251-1/+84
| | | | | | | | | | | | | | | | __file__ is relative if grit_info is called like `python ../tools/grit/grit_info.py`, but not if it's invoked from python code like `import grit_info; grit_info.DoMain()`. And that confuses the xcode project generator, which will complain about hash collisions if these paths are serialized in absolute form. BUG=82230 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86551 Review URL: http://codereview.chromium.org/7066030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86647 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86551 (turns out testers run `gclient sync` as well, and there are ↵thakis@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | | | | | | | 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) - grit_info: Explicitly make __file__ relative to the current directory. __file__ is relative if grit_info is called like `python ../tools/grit/grit_info.py`, but not if it's invoked from python code like `import grit_info; grit_info.DoMain()`. And that confuses the xcode project generator, which will complain about hash collisions if these paths are serialized in absolute form. BUG=none TEST=none Review URL: http://codereview.chromium.org/7066030 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/6992052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86557 0039d316-1c4b-4281-b951-d872f2087c98
* grit_info: Explicitly make __file__ relative to the current directory.thakis@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | | __file__ is relative if grit_info is called like `python ../tools/grit/grit_info.py`, but not if it's invoked from python code like `import grit_info; grit_info.DoMain()`. And that confuses the xcode project generator, which will complain about hash collisions if these paths are serialized in absolute form. BUG=none TEST=none Review URL: http://codereview.chromium.org/7066030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86551 0039d316-1c4b-4281-b951-d872f2087c98
* Start generating translated policy templatesgfeher@chromium.org2011-05-242-1/+5
| | | | | | | | | | | | | | -Add output nodes of translations into policy_templates.grd. -Copy translated string tables into the Mac bundle. -Work around the problem that the zip tool would get too long command-line arguments if all the translated templates were enumerated as arguments. -Fix importing of UTF-8 strings into the template generator BUG=61779 TEST=Check that there are translated adml, adm and html files in policy_templates.zip. Review URL: http://codereview.chromium.org/6969064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86476 0039d316-1c4b-4281-b951-d872f2087c98
* Added resources.abodenha@google.com2011-05-181-0/+3
| | | | | | | | | | | | | | | Virtual_driver_setup now has localization support. All dlls and exes now have a version resource. Common (untranslated) strings are now pulled from a common resource file. Installer and port monitor now have separate .gyp files. Still to do: Integrate with TC and add all languages. BUG= TEST= Review URL: http://codereview.chromium.org/6930019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85825 0039d316-1c4b-4281-b951-d872f2087c98
* grit: Don't parse <messages> and children in --inputs and --outputs mode.thakis@chromium.org2011-05-142-16/+35
| | | | | | | | | | | | | | | | This speeds up `gclient runhooks` by 2 seconds (~10%) on my system. `gclient runhooks` runs grit_info in inputs and outputs mode about 20 times each. Interestingly, the speedup comes from making a single invocation each about 1s faster (for the grd file that contains almost all our strings). BUG=82230 TEST=None Review URL: http://codereview.chromium.org/6973066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85374 0039d316-1c4b-4281-b951-d872f2087c98
* grit: When gathering input files, don't do full inlining.thakis@chromium.org2011-05-141-5/+26
| | | | | | | | | | | This speeds up `gclient runhooks` by 0.5s (2.5%) on my machine. BUG=82230 TEST=none Review URL: http://codereview.chromium.org/7015063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85373 0039d316-1c4b-4281-b951-d872f2087c98
* grit: Split the main() function into a pure DoMain() and an impure part.thakis@chromium.org2011-05-141-8/+13
| | | | | | | | | | | | | | | This allows gyp to call grit_info.DoMain() directly, without having to go through the trouble of launching grit_info in a subprocess (but that will happen in a different CL, in gyp land). No intended functionality change. BUG=82230 TEST=none Review URL: http://codereview.chromium.org/6973068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85372 0039d316-1c4b-4281-b951-d872f2087c98
* Pre-requisites needed before applying content-security-policy to the HTML ↵tsepez@chromium.org2011-05-131-0/+3
| | | | | | | | | | | | | | | | | | | | options page. CSP is a second line of defense in case someone introduces an XSS in one of these pages. The changes to jstemplate_builder are to allow the template scripts to be served as resources where possible, and to return JS as well as HTML in the one case where the script is to be dynamically generated. The other changes are to combine the options javascript files into a single large file resource and to serve it from under chrome://settings. This satisfies the "no inline" rule and options.html can script src="" it. I did put one file into the /shared directory, since it is a companion to a piece of pre-existing template code alread in that directory. TEST=chrome://settings page loads properly. Review URL: http://codereview.chromium.org/7003007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85322 0039d316-1c4b-4281-b951-d872f2087c98
* There is a patch for new resource pak for devtools tab selection page.loislo@chromium.org2011-05-061-1/+5
| | | | | | | | | | | | | | | | | | We have a generated tab selection page for remote debugging. It is quite simple and needs to be extended for better discoverability and nice view. I've splitted it into three parts. Generated one with the list of tabs available for debugging and two static files devtools_frontend.css and devtools_frontend.js It was decided to keep these two files separately from the rest of the devtools files. The first reason: tab selection page can be platform specific. The second reason: main devtools files can be stored in the cloud. BUG=none TEST=none Review URL: http://codereview.chromium.org/6912023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84419 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure grit unittests run on presubmit.tony@chromium.org2011-05-043-14/+10
| | | | | | | | | | | Previously, the return code was always 0 so the tests were always passing. Actually return an error code now. Also fix some tests that regressed in r83897 and r78357. Review URL: http://codereview.chromium.org/6929016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84099 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84081 due to internal failure - grit: Completely ignore the ↵sadrul@chromium.org2011-05-041-3/+0
| | | | | | | | | | | | | | 'if'-nodes that do not evaluate to true. BUG=none TEST=builds work fine Review URL: http://codereview.chromium.org/6911026 TBR=sadrul@chromium.org Review URL: http://codereview.chromium.org/6932016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84097 0039d316-1c4b-4281-b951-d872f2087c98
* grit: Completely ignore the 'if'-nodes that do not evaluate to true.sadrul@chromium.org2011-05-041-0/+3
| | | | | | | | | BUG=none TEST=builds work fine Review URL: http://codereview.chromium.org/6911026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84081 0039d316-1c4b-4281-b951-d872f2087c98
* expand CSS attributes for which we inline imagesestade@chromium.org2011-05-031-1/+3
| | | | | | | | | | | I need this for -webkit-mask-image BUG=none TEST=manual (ntp most visited pins, g-button-basic [only accessible via inspector], etc.) Review URL: http://codereview.chromium.org/6909038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83984 0039d316-1c4b-4281-b951-d872f2087c98
* When grit flattens resources, make it include the name of the resourcetony@chromium.org2011-05-032-7/+7
| | | | | | | | | | (the IDR_ value) in the filename so we don't have naming clashes. BUG=69633 Review URL: http://codereview.chromium.org/6910005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83897 0039d316-1c4b-4281-b951-d872f2087c98
* Fix HTML/CSS image inlining broken by r83644 (it was matching ↵mihaip@chromium.org2011-05-031-1/+1
| | | | | | | | | | | background-image, but not background). BUG=81071 TEST=icon at top of bookmark manager appears Review URL: http://codereview.chromium.org/6889017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83824 0039d316-1c4b-4281-b951-d872f2087c98
* Switch web store promo button image to have an alpha channel,mihaip@chromium.org2011-04-301-2/+2
| | | | | | | | | | | | | | | | | so that it blends in with non-white NTP backgrounds. Since the current markup doesn't handle alpha channels well (the different sections overlap), redo it to use border-image. Also makes the button not wrap for longer label names. BUG=80233,80810 TEST=tried with non-default themes R=arv@chromium.org Review URL: http://codereview.chromium.org/6905089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83644 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 05:14:37 +0000