| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile works again (not sure why it was only failing for me and a few others)
Review URL: http://codereview.chromium.org/3018006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to control resource id assignment across all grd
files so we can avoid id collisions.
BUG=48625
Review URL: http://codereview.chromium.org/2961002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rc_all outputs.
This fixes a bug where the code to flatten an html file was in
the rc_all output step. So if a data_package output came before
the rc_all output in the grd file, we would get a build error.
Just refactor the code to flatten for both output types (but only
flatten once).
BUG=48253
TEST=build completes succesfully
Review URL: http://codereview.chromium.org/2889001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed ChromeOS-specific sub-pages from options by using the newly added if tag. Changed <!--include file="..."--> tag to <include src="...">.
BUG=chromium-os:4450
TEST=make sure that chromeos specific pages don't show in chrome:options for other platforms
Review URL: http://codereview.chromium.org/2872028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47881
TEST=Unit tests
Review URL: http://codereview.chromium.org/2805050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed grit to support generic <!--include file="..."--> tag in html files to support the scenario above.
TEST=make sure chrome:options page still shows correctly
BUG=chromium-os:4429
Review URL: http://codereview.chromium.org/2835009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We don't use this yet, but the plan is to move everything in the resources directory into here.
BUG=42770
Review URL: http://codereview.chromium.org/2667001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add "pp_if", "pp_ifdef" support to xtb's <if> expr;
- Use that to specify a wider width for options dialog for ChromeOS on it and da;
BUG=none
TEST=Verify options dialog tab headers are not truncaated on ChromeOS for it and da.
Review URL: http://codereview.chromium.org/2655003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The two rc unittests are failing because it appears the data
files checked into svn don't match. It's easier to change the
tests because the data is in a different (internal only) repo.
AFAICT, this has been broken forever.
The other fix is because a test became more correct after
r43930, but the test was passing anyway.
Review URL: http://codereview.chromium.org/2131013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this refactoring is to allow splitting the different parts of the NTP into different reusable components.
BUG=None
TEST=Manually
Review URL: http://codereview.chromium.org/1695022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
caps, numbers and underscores.
BUG=37254
Review URL: http://codereview.chromium.org/1527013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a chromium build, this should produce no output. For official
builds, we print warnings about untranslated strings.
This is the first step in trying to have grit produce useful
warning messages.
BUG=39417
Review URL: http://codereview.chromium.org/1518018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
deprecating 'he' in favor of 'iw'.
Review URL: http://codereview.chromium.org/1332001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use_name_for_id=true set. We want to ignore the nodes that
don't apply for this platform.
Fixing on trunk first then will copy to the 306 branch with drover.
BUG=32868
Review URL: http://codereview.chromium.org/552176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
used. This fixes a bug were we skip numbers in a header file.
Review URL: http://codereview.chromium.org/233004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
long since been replaced by generated files from gyp.
Review URL: http://codereview.chromium.org/213013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously headers were handled differently only as an optimization.
This thwarts vstudio + gyp.
Adding a grit_info python stub so that gyp can get an accurate list of
inputs and outputs from a grd file. Currently only using it for the inputs,
because there's no good way in gyp to have rules invoke a !@( expansion
once per rule instance.
This change will over-specify dependencies for these modules,
but it will at least not under-specify them anymore.
BUG=24836
TEST=None
Review URL: http://codereview.chromium.org/197007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
grit to replace \n to actual new lines in data pack files.
Windows' MessageBox automatically converts \n to a new line, but
GTK+ doesn't.
BUG=20943
Review URL: http://codereview.chromium.org/196007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mnaganov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
until mgr agreeement.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
WebKit Inspector is localized using a JS file containing the following map:
localizedStrings[<english text>] = <translated text>;
Review URL: http://codereview.chromium.org/164066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
only supports checking the OS, but we can add more information if
necessary.
BUG=16884
Review URL: http://codereview.chromium.org/159148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
try:-finally: so builds will work without forced upgrades to Python 2.5.
BUG=12818
TEST=successful build
Review URL: http://codereview.chromium.org/140005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
One visible change: new tab page has Google icon, not Chromium.
Gyp doesn't have a set environment variable facility; hence the
addition of a command line option to grit.
Review URL: http://codereview.chromium.org/113974
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_resources and chrome_strings was continually
rebuilding because it depended on the .h file, but the .h file
doesn't get written if there are no changes. The .pak file
always gets written.
Review URL: http://codereview.chromium.org/115035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/109051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resource only changes to rebuild lots of stuff on Mac and Linux,
but since most of this is happening on Windows anyway, only
optimize for Windows.
This should make second builds faster since all the dependencies
are up to date.
Review URL: http://codereview.chromium.org/99265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These won't get gated live without a change to all.gyp, so landing them separately.
Review URL: http://codereview.chromium.org/100146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a mapping for all the entries in the
theme_resources.grd file and adds a static method for querying
the mapping.
BUG=10639
Review URL: http://codereview.chromium.org/92085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- We don't need to print the copyright every time we run.
- Don't print empty lines when there are no warnings.
Review URL: http://codereview.chromium.org/67085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
history.
It also adds code to inline the resources for <link rel="icon"> elements
BUG=9805
Review URL: http://codereview.chromium.org/66041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The generated header files had the wrong paths specified in the vcproj files.
- Have the .h files generate to a temp file and overwrite the real .h files if they changed from the last run. This prevents recompiling when only a resource is changed.
- Change the output file to the .rc file because otherwise the vcproj file would recompile every time because the .h file wasn't changing. Since the .rc file gets written all the time, this isn't a problem.
On a side note, you still have to re-link to get the resources in chrome.dll. I imagine if you turn on incremental linking, this would be pretty fast.
BUG=7967
Review URL: http://codereview.chromium.org/53028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
The old locale_settings*.rc files would #include the google_strings.rc or chromium_strings.rc. Instead, I added it to the vcproj file using $(CHROMIUM_BUILD) to grab the right file. This required changing the output names in the grd files.
TBR=deanm
Review URL: http://codereview.chromium.org/39152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remove one assert as it's not correct
BUG=8298,8299
Review URL: http://codereview.chromium.org/40073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
files from the tree."
Revert "window_ is null during BrowserWindow creation. Assume full screen"
Revert "Move SupportsWindowFeature from BrowserView to Browser so"
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the tree.
I made a small change to grit so we can use our resource ID as the translation ID making it a bit easier to read.
I also used a script to convert the existing .rc files to .xtb files.
Review URL: http://codereview.chromium.org/28327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This lets the child process exit even if there are errors and causes
the main scons process to identify these errors as build failures.
Review URL: http://codereview.chromium.org/28282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
platform.
Review URL: http://codereview.chromium.org/28237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
included in data pack files.
Review URL: http://codereview.chromium.org/28222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
bug=8139
Review URL: http://codereview.chromium.org/28225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable the scons code that walks a grd file and adds its dependencies as
build dependencies. This requires that all our dependencies are files in our
source tree (which is what motivated getting rid of the tld data as a
generated resource). I had to fix up the terms of service for this.
Also remove some code that disabled .pak file generation on windows which was
broken because it couldn't find the tld data.
Review URL: http://codereview.chromium.org/28194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10446 0039d316-1c4b-4281-b951-d872f2087c98
|