| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=61054
TEST=PListWriterUnittest.*,PListStringsWriterUnittest.*
Review URL: http://codereview.chromium.org/4318001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix filtering of single (non-groupped) policies by platforms.
BUG=56531
TEST=JsonWriterUnittest.*,PolicyTemplateGeneratorUnittest.testPolicyFiltering
Review URL: http://codereview.chromium.org/4164006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58498
TEST=none
Review URL: http://codereview.chromium.org/4175001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57528
TEST=run tests
Review URL: http://codereview.chromium.org/3628001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
referring you to the help, but if you don't provide a tool at all it would just fail.
Review URL: http://codereview.chromium.org/3549016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add Chromium vs Google Chrome clarification at the beginning of the generated policy documentation and remove ADM outputs with pseudo-translations.
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/3605003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context menu.
o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.
BUG=54731
TEST=NONE
patch from issue 3419010
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60997
Reverted: http://crrev.com/61000
Review URL: http://codereview.chromium.org/3453029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
options in each apps context menu.
o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.
BUG=54731
TEST=NONE
patch from issue 3419010
Review URL: http://codereview.chromium.org/3453029
TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/3517004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context menu.
o Updated some comments that were using the outdated NOTIFY_PREF_CHANGED notification.
o Make LAUNCH_PINNED the default type returned by ExtensionPrefs if it does not already exist.
o Some minor refactoring within the code to reduce duplication.
BUG=54731
TEST=NONE
patch from issue 3419010
Review URL: http://codereview.chromium.org/3453029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Order policies alphabetically for all the generated templates.
Show group descriptions in the generated documentation.
BUG=56358,56654
TEST=DocWriterUnittest.testAddPolicySection,DocWriterUnittest.testAddPolicyRow, PolicyTemplateGenerator.testSorting
Review URL: http://codereview.chromium.org/3431031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file.
BUG=57025
TEST=Current unit-tests need to pass.
Review URL: http://codereview.chromium.org/3390031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
policies to "policy" element. This will fix issue 55722 for ADMX/ADML policy templates.
BUG=55722
TEST=admx_writer_unittest.py, adml_writer_unittest.py
Review URL: http://codereview.chromium.org/3439011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the old model each policy had to be in a group, and messages could be inherited from groups to policies.
In the new model single policies does not have to be in groups and there is no inheritance of messages across policies/groups. Instead of that, policies have now two captions for different purposes. (Documented in policy_templates.json.) This is a more simple concept.
BUG=55722,56512
TEST=covered by policy template generator unit tests
Review URL: http://codereview.chromium.org/3454017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
policy_generator.py to the template_writer.py.
This is the first CL in a couple of refactoring steps.
BUG=56512
TEST=Current tests need to pass
Review URL: http://codereview.chromium.org/3496001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary because the Windows Group Policy editor does not support setting a list to empty, but if the list is in a separate policy, then it can be set to disabled or not configured.
BUG=55722
TEST=AdmWriterUnittest.*
Review URL: http://codereview.chromium.org/3436013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the .json and .grd description of the policies to generate HTML markup that can be uploaded straight to dev.chromium.org.
BUG=54712
TEST=DocWriterUnittest.*
Review URL: http://codereview.chromium.org/3452006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The annotations include a list of supported platforms for each policy. Depending on this, only the supported policies are written for each template type.
BUG=54665
TEST=PolicyTemplateGeneratorUnittest.testPolicyFiltering, {Adm,Plist,PlistStrings}WriterUnittest.testNonSupportedPolicy, {Admx,Adml}WriterUnittest.testPlatform
Review URL: http://codereview.chromium.org/3303027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=54376
TEST=admx_writer_unittest.py
adml_writer_unittest.py
Review URL: http://codereview.chromium.org/3290018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
json and grd files that are used to generate the policy templates.
Added matching constants for the policy elements to the policy_constants files.
Added support for a new template value, $3, that represents the Chrome Frame product name in policy templates.
TEST=none
BUG=29349
Review URL: http://codereview.chromium.org/3325011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Set the Chrome policy registry keyname to "Software\\Policies\\Google\\Chrome" for ADM output. Move all such constant strings to a common place for ADM, ADMX and plist output. (So that such bugs will be harder to overlook next time.)
BUG=54630
TEST=manual + grit/format/policy_templates/writer/*
Review URL: http://codereview.chromium.org/3299009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this fix, <message> elements with use_name_for_id attribute,
inside <if expr='pp_ifdef(...)'> were falling back to English,
because defines information was not present when evaluating conditions.
TEST=wrote and ran testUseNameForIdAndPpIfdef (python grit.py unit). There were failing tests before this change, and this change did not increase the number of failing tests. Also confirmed that http://codereview.chromium.org/3275008/show worked fine with this patch.
BUG=54360
Review URL: http://codereview.chromium.org/3335003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PListStringsWriter.
BUG=53953
TEST=adm_writer_unittest.py, plist_strings_writer_unittest.py
Review URL: http://codereview.chromium.org/3214014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add unit tests to adm_writer, clean up other writer unit tests and fix list policies generated by adm_writer. (Move KEYNAME into the PART structure.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3284006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53315
TEST=manual
Review URL: http://codereview.chromium.org/3162030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Writer for plist manifest and string table files, and custom strings for the Mac templates.
BUG=49316
TEST=plist_writer_unittest.*, plist_strings_writer_unittest.* (grit)
Review URL: http://codereview.chromium.org/3116027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the policy template generator in preparation for the Mac manifest and Windows ADMX output files. Replace dictionaries with lists in the input JSON file so that sequence of elements is preserved. Add a list data type for policies, and add extension whitelist/blacklist policy. Split homepage policy group into two.
Previous CL: http://codereview.chromium.org/3068012/show.
BUG=49316
TEST=tools/grit/grit/format/policy_templates/policy_template_generator.py and manual testing of output .adm files
Review URL: http://codereview.chromium.org/3191021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make it possible to enclose <output> nodes in <if> conditional, therefore it becomes possible to generate different files from .grd files depending on the platform.
BUG=none
TEST=IfNodeUnittest.testIffynessWithOutputNodes (in grit)
Review URL: http://codereview.chromium.org/3155033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first iteration of my work on the policy MCX/ADM/ADMX/HTML generator. I added chrome/app/policy/policy_templates.grd and a grit extension that parses this file and chrome/app/policy/policy_templates.json and then generates the en-US version of chrome.adm from them. The infrastructure is already in place for other languages and output formats.
BUG=49316
TEST=policy_template_generator_unittest.py and manual tests of chrome.adm
Review URL: http://codereview.chromium.org/3068012
Patch from Gabor Feher <gfeher@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50804
Review URL: http://codereview.chromium.org/3074022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=see unittest
Review URL: http://codereview.chromium.org/3058012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile works again (not sure why it was only failing for me and a few others)
Review URL: http://codereview.chromium.org/3018006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to control resource id assignment across all grd
files so we can avoid id collisions.
BUG=48625
Review URL: http://codereview.chromium.org/2961002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rc_all outputs.
This fixes a bug where the code to flatten an html file was in
the rc_all output step. So if a data_package output came before
the rc_all output in the grd file, we would get a build error.
Just refactor the code to flatten for both output types (but only
flatten once).
BUG=48253
TEST=build completes succesfully
Review URL: http://codereview.chromium.org/2889001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed ChromeOS-specific sub-pages from options by using the newly added if tag. Changed <!--include file="..."--> tag to <include src="...">.
BUG=chromium-os:4450
TEST=make sure that chromeos specific pages don't show in chrome:options for other platforms
Review URL: http://codereview.chromium.org/2872028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47881
TEST=Unit tests
Review URL: http://codereview.chromium.org/2805050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed grit to support generic <!--include file="..."--> tag in html files to support the scenario above.
TEST=make sure chrome:options page still shows correctly
BUG=chromium-os:4429
Review URL: http://codereview.chromium.org/2835009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We don't use this yet, but the plan is to move everything in the resources directory into here.
BUG=42770
Review URL: http://codereview.chromium.org/2667001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add "pp_if", "pp_ifdef" support to xtb's <if> expr;
- Use that to specify a wider width for options dialog for ChromeOS on it and da;
BUG=none
TEST=Verify options dialog tab headers are not truncaated on ChromeOS for it and da.
Review URL: http://codereview.chromium.org/2655003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The two rc unittests are failing because it appears the data
files checked into svn don't match. It's easier to change the
tests because the data is in a different (internal only) repo.
AFAICT, this has been broken forever.
The other fix is because a test became more correct after
r43930, but the test was passing anyway.
Review URL: http://codereview.chromium.org/2131013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this refactoring is to allow splitting the different parts of the NTP into different reusable components.
BUG=None
TEST=Manually
Review URL: http://codereview.chromium.org/1695022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
caps, numbers and underscores.
BUG=37254
Review URL: http://codereview.chromium.org/1527013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a chromium build, this should produce no output. For official
builds, we print warnings about untranslated strings.
This is the first step in trying to have grit produce useful
warning messages.
BUG=39417
Review URL: http://codereview.chromium.org/1518018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
deprecating 'he' in favor of 'iw'.
Review URL: http://codereview.chromium.org/1332001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use_name_for_id=true set. We want to ignore the nodes that
don't apply for this platform.
Fixing on trunk first then will copy to the 306 branch with drover.
BUG=32868
Review URL: http://codereview.chromium.org/552176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
used. This fixes a bug were we skip numbers in a header file.
Review URL: http://codereview.chromium.org/233004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
long since been replaced by generated files from gyp.
Review URL: http://codereview.chromium.org/213013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously headers were handled differently only as an optimization.
This thwarts vstudio + gyp.
Adding a grit_info python stub so that gyp can get an accurate list of
inputs and outputs from a grd file. Currently only using it for the inputs,
because there's no good way in gyp to have rules invoke a !@( expansion
once per rule instance.
This change will over-specify dependencies for these modules,
but it will at least not under-specify them anymore.
BUG=24836
TEST=None
Review URL: http://codereview.chromium.org/197007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
grit to replace \n to actual new lines in data pack files.
Windows' MessageBox automatically converts \n to a new line, but
GTK+ doesn't.
BUG=20943
Review URL: http://codereview.chromium.org/196007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mnaganov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
until mgr agreeement.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24094 0039d316-1c4b-4281-b951-d872f2087c98
|