| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=99158,98967
TBR=jam
Review URL: http://codereview.chromium.org/8137025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=99166
TBR=asargent
Review URL: http://codereview.chromium.org/8142029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98967
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8120017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids leaking a GTK widget, I guess. I will never
fully grasp the GObject memory management model.
BUG=98568
TEST=removed suppression and ran the heapchecker
Review URL: http://codereview.chromium.org/8094013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98538
TEST=
Review URL: http://codereview.chromium.org/8083022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98568
TBR=derat@chromium.org
Review URL: http://codereview.chromium.org/8083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98538
TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/8071026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97879
TEST=FileSystemPathManagerTest.*
Review URL: http://codereview.chromium.org/8028023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=rogerta@chromium.org
BUG=88212
TEST=none
Review URL: http://codereview.chromium.org/8037030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97814
TEST=memory
Review URL: http://codereview.chromium.org/8036021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
will revert if it does.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8044010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins@chromium.org, georgey@chromium.org
BUG=75224
TEST=none
Review URL: http://codereview.chromium.org/8036010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=kinuko@chromium.org
BUG=97879
TEST=none
Review URL: http://codereview.chromium.org/8038009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds suppressions for Autofill Sync tests.
BUG=94026
TEST=Heapcheck goes green.
TBR=lipalani
Review URL: http://codereview.chromium.org/8043005
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/8043010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=timurrrr@chromium.org
BUG=97857
TEST=none
Review URL: http://codereview.chromium.org/8044007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=georgey@chromium.org,dhollowa@chromium.org,
BUG=96363
TEST=none
Review URL: http://codereview.chromium.org/8028009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds suppressions for Autofill Sync tests.
BUG=94026
TEST=Heapcheck goes green.
TBR=lipalani
Review URL: http://codereview.chromium.org/8043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=timurrrr@chromium.org
BUG=97857
TEST=none
Review URL: http://codereview.chromium.org/8043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bauerb@chromium.org
BUG=97814
TEST=none
Review URL: http://codereview.chromium.org/8030002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=akalin@chromium.org
BUG=97791
TEST=none
Review URL: http://codereview.chromium.org/8018015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=akalin@chromium.org
BUG=97791
TEST=none
Review URL: http://codereview.chromium.org/8015018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch by kalman@chromium.org
BUG=97511
TEST=
TBR=kalman@chromium.org
Review URL: http://codereview.chromium.org/7978053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch by kalman@chromium.org
BUG=97511
TEST=
TBR=kalman@chromium.org
Review URL: http://codereview.chromium.org/7976043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch by kalman@chromium.org.
BUG=97511
TEST=
TBR=kalman@chromium.org
Review URL: http://codereview.chromium.org/7980060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=kalman@chromium.org
BUG=97511
TEST=none
Review URL: http://codereview.chromium.org/7977038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When XmppConnection is deleted, its TaskPump member is not deleted immediately.
The destructor enqueues a task to the message loop to have it deleted later. A
comment in ~XmppConnection that explains why it does this.
In the unit tests, the TaskPump would get leaked because the message loop would
never get a chance to run that deletion task. This commit fixes the problem by
running all pending tasks on that message loop before we exit the test.
This commit removes the suppression for bug_80238. Issue 80238 hasn't been
seen for a while, so it's probably safe to remove. It's only relation to issue
79651 is that it happened in the same set of tests; the two issues probably had
different root causes.
This commit renames the suppression bug_79651, which is still necessary, but
isn't actually related to issue 79651. When I tried to remove it, I ran into
the issue now known as issue 96904. I've renamed the suppression to match the
issue it's actually suppressing.
Discussion of these changes can be found on the bug tracker, spread across the
pages for issues 79651, 80238 and 96904.
BUG=79651, 80238, 96904
TEST=InvalidationNotifierTest
Review URL: http://codereview.chromium.org/7919026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crbug.com is down so i'm suppressing without bugs for now.
I'll update the suppression with bug once filed.
TBR=qsr@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7981032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70236
TEST=heapcheck unit tests
Review URL: http://codereview.chromium.org/7885051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FilePathWatcher clears its delegates correctly since 22 April 2011 (http://src.chromium.org/viewvc/chrome?view=rev&revision=79029).
Verified locally that upon destruction of the singleton object PluginService the FilePathWatcherDelegate objects are getting deleted too.
BUG=70115,75917
TEST=valgrind and heapcheck should not report problems in PluginService->FilePathWatcher.
Review URL: http://codereview.chromium.org/7891009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=georgey
BUG=96363
TEST=none
Review URL: http://codereview.chromium.org/7891002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=96363
TEST=none
TBR=georgey
Review URL: http://codereview.chromium.org/7882001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=96295
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7844011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:90381
TEST=local
Review URL: http://codereview.chromium.org/7866038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=timurrrr@chromium.org
BUG=78505
TEST=heapcheck stays green
Review URL: http://codereview.chromium.org/7867021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When XmppConnection is deleted, its TaskPump member is not deleted immediately.
The destructor equeues a task to the message loop to have it deleted later. A
comment in ~XmppConnection that explains why it does this.
In the unit tests, the TaskPump would get leaked because the message loop would
never get a chance to run that deletion task. This commit fixes the problem
by running all pending tasks on that message loop before we exit the test.
BUG=80238,79651
TEST=InvalidationNotifierTest
Review URL: http://codereview.chromium.org/7863005
TBR=rlarocque@chromium.org
Review URL: http://codereview.chromium.org/7867024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When XmppConnection is deleted, its TaskPump member is not deleted immediately.
The destructor equeues a task to the message loop to have it deleted later. A
comment in ~XmppConnection that explains why it does this.
In the unit tests, the TaskPump would get leaked because the message loop would
never get a chance to run that deletion task. This commit fixes the problem
by running all pending tasks on that message loop before we exit the test.
BUG=80238,79651
TEST=InvalidationNotifierTest
Review URL: http://codereview.chromium.org/7863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug 39021 and bug 43775 are for ExtensionAPIClientTest, which was
deleted: http://codereview.chromium.org/2847008
Bug 54689 was for a test that was moved from a unit test to a browser
test: http://codereview.chromium.org/6291007
Bug 39007 seems to be a catch all for RenderViewTest, but there are
no remaining RenderViewTests in unit tests (they are now all browser_tests).
BUG=39021,39007,43775,54689
Review URL: http://codereview.chromium.org/7866003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
net::CookieMonster::CookieMonsterTask::InvokeCallback. Also widen a related suppression.
BUG=96066,96069
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7780010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) The stack has LegacyHTMLTreeConstructor in it. This code was deleted
months ago.
2) The test moved from a unit test to a browser test so it's no longer
covered by the memory bots.
3) The unit and test_shell steps of the current bot doesn't show this
suppression being hit.
BUG=46658
Review URL: http://codereview.chromium.org/7858016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AFAICT, this suppression isn't used on the bots and it passes locally
for me.
BUG=79377
Review URL: http://codereview.chromium.org/7859017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43779, 40877
TEST= Running "./tools/heapcheck/chrome_tests.sh -b out/Debug -t content --gtest_filter=ActiveNotificationTrackerTest.TestLookupAndClear" should not return memory leak.
Review URL: http://codereview.chromium.org/7789011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed unneeded suppressions
BUG=81782
TEST=none
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/7843001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=79794
TEST=none
Review URL: http://codereview.chromium.org/7809017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=garykac@chromium.org
BUG=94764
TEST=none
Review URL: http://codereview.chromium.org/7785002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=94687,76354
TEST=none
Review URL: http://codereview.chromium.org/7806004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=76354
TEST=none
Review URL: http://codereview.chromium.org/7763010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is pretty broad, but the leak is also pretty broad.
BUG=94195
TBR=zmo@chromium.org
Review URL: http://codereview.chromium.org/7748009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90369
TBR=altimofeev@chromium.org
Review URL: http://codereview.chromium.org/7720007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=86301
Review URL: http://codereview.chromium.org/7686021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
MessageLoopProxyTest.PostTaskAndReply_DeadReplyIfLoopDoesNotDelete*
BUG=86301
Review URL: http://codereview.chromium.org/7693024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97618 0039d316-1c4b-4281-b951-d872f2087c98
|