| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a 5 minute minimum delay enforced for released extensions
and a 0 minute delay enforced for extensions in development.
BUG=122821
TEST=Call chrome.experimental.alarms.create and verify that the alarm is delayed in the number of minutes passed in.
Review URL: http://codereview.chromium.org/10217018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
incorrectly
Files are now named like "file_name.h" instead of "fileName.h" or "file.name.h"
BUG=125669
TEST=All previous tests for the renamed files
This broke Linux and Linux64:
g++: out/Release/obj/gen/chrome/common/extensions/api/experimental.fontSettings.cc: No such file or directory
g++: no input files
make: *** [out/Release/obj.target/api/gen/chrome/common/extensions/api/experimental.fontSettings.o] Error 1
Review URL: http://codereview.chromium.org/10272021
TBR=cduvall@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10348005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Files are now named like "file_name.h" instead of "fileName.h" or "file.name.h"
BUG=125669
TEST=All previous tests for the renamed files
Review URL: http://codereview.chromium.org/10272021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JSON schema compiler now supports having strings as types.
Similar to http://crbug.com/122075
BUG=124771
TEST=cpp_type_generator_test.py
Review URL: http://codereview.chromium.org/10206034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition, removes a dummy field from the CreateOptions dictionary the Socket
API's IDL file.
R=miket@chromium.org,asargent@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10244008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The JSON schema compiler can now handle binary data as an
internal type.
BUG=123687
TEST=None
Review URL: http://codereview.chromium.org/10198005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=unit_tests --gtest_filter=*JsonSchema*
Review URL: http://codereview.chromium.org/10116015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the schema_bundle_generator will replace any double-quote character
with \", which only works if the quote is not already escaped in which case it
will escape the escaping backslash rendering the double-quote unescaped. This
patch makes sure that already-escaped double-quotes are not escaped again.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10108029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9996002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than at the model level. This gives us automatic nocompile of all
properties; previously not all were supported.
TEST=tools/json_schema_compiler/json_schema_test.py, unit_tests --gtest_filter=JsonSchemaCompiler*
Review URL: http://codereview.chromium.org/10108005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Changed the IDL parser to mine the Comment nodes, and process them for
parameter comments.
- Added hacks to the doc builder to parse the IDL files and spit out a
generated JSON file before running the generator.
BUG=no
TEST=no
Review URL: https://chromiumcodereview.appspot.com/10082038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also rename the 'refs' parameter to 'callbacks' to make the code a little bit
more clear, since 'refs' was only used to store callback information.
Matt noticed this bug after I landed
https://chromiumcodereview.appspot.com/10054039/
It turns out the the rest of the JSON compiler infrastructure doesn't actually
support arrays of functions, but at least the IDL will generate the right JSON
in this case.
BUG=none
TEST=included unit test should pass
Review URL: http://codereview.chromium.org/10080014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I realized we completely omitted array support with our initial IDl work. This
patch fixes that for 2 important cases, but doesn't yet add it in for
dictionary members (that can be a separate patch).
BUG=122875
TEST=Included unit tests should pass
Review URL: http://codereview.chromium.org/10054039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now the json schema compiler can only handle objects as types. This allows
the schema compiler to use arrays as types. For an example look at
browserAction.
BUG=122075
TEST=cpp_type_generator_test.py
Review URL: http://codereview.chromium.org/10022005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when populating.
BUG=122036
TEST=
Review URL: http://codereview.chromium.org/9966006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122224
TEST=Included unit test should compile and run.
Review URL: http://codereview.chromium.org/10032001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This lets us specify a type of 'object' or 'any' in IDL schemas, and optionally add
an 'instanceOf' annotation for object types that will get enforced in javascript in the same way
that the JSON schema's 'isInstanceOf' property is.
Also add some basic unit tests for IDL schemas in addition to unit tests of these new features.
BUG=119359
TEST=Included unit tests should compile and pass
Review URL: https://chromiumcodereview.appspot.com/9979014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code is largely borrowed from benwells' CL at
http://codereview.chromium.org/9968038/
but moves the code which maps camel case names (with possible abbreviations) to
unix style names into the existing UnixName method in model.py, so that we can
take advantage of it from everywhere we need a unix style name.
BUG=None
TEST=chrome, unit_tests, etc. should still compile
Review URL: http://codereview.chromium.org/9963066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
parameters after seeing the first optional one.
BUG=120569
TEST=no
Review URL: http://codereview.chromium.org/9837100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As I noted in the bug, these unit tests had gotten broken by some recent changes because they weren't being run automatically.
BUG=120308
TEST=(this is adding a presubmit test)
Review URL: https://chromiumcodereview.appspot.com/9865009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are necessary after the changes that went in with
crrev.com/129042 (http://codereview.chromium.org/9836078)
Update: also fix some fallout from crrev.com/129251
BUG=120481
TEST=(this is a test)
Review URL: https://chromiumcodereview.appspot.com/9866050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of sharing a single namespace internally for types, makes
json_schema_compiler treat types as their fully-qualified selfs. This allows
two different namespaces to have types with the same name, and to be able to
reference the others' types by a fully-qualified name. This change also causes
namespaces to not be added twice to their CppTypeGenerators.
BUG=119954
TEST=none
Review URL: http://codereview.chromium.org/9834088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since fields are generated as simple structure elements the schema compiler
must output the full definitions for structures that are depended-upon before
the structures that depend upon them. This patch also causes same-namespace
forward struct delcarations to be emitted to resolve circular dependencies and
optional-property dependencies in generated code.
BUG=119911
TEST=none
Review URL: http://codereview.chromium.org/9836078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were broken by some of our recent changes, thus highlighting the need
to get them running in an automated fashion. For now, I've fixed them and
done a couple of performance tweaks to speed them up dramatically (30s -> 0.1s).
BEFORE
------
cpp_type_generator_test.py
real 0m29.787s
model_test.py
real 0m27.287s
AFTER
-----
cpp_type_generator_test.py
real 0m0.151s
model_test.py
real 0m0.117s
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9834063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This resolves the issue where a dictionary/object field named 'value' would
lead to compilation errors due to the a local in ToValue also named 'value'
masking the underlying field.
BUG=119899
TEST=none
Review URL: http://codereview.chromium.org/9837078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=118144
TEST=unit_tests --gtest_filter=ExtensionAPI.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128434
Review URL: http://codereview.chromium.org/9677069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
breaking install tests.
TBR=kalman
Review URL: https://chromiumcodereview.appspot.com/9845007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=118144
TEST=unit_tests --gtest_filter=ExtensionAPI.*
Review URL: http://codereview.chromium.org/9677069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Python's String.capitalize() function ensures that only the first character in
the returned string is a captial. For multi-word extension functions this is
incorrect (e.g. "createContext" becomes "Createcontext"). This patch changes
the behaviour of schema_bundle_generator to only attempt to captialize the
first character of the function name.
BUG=119295
TEST=
Review URL: http://codereview.chromium.org/9818002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an incremental step towards fully IDL-specified API bindings. This
patch adds code which generates JSON based on IDL for the purpose of exposing
bindings to javascript.
BUG=119137
TEST=Code should compile and existing tests should pass.
Review URL: http://codereview.chromium.org/9774001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor extension_function_dispatcher to extract ExtensionFunctionRegistry.
This allows us to generate an additional code block that takes an ExtensionFunctionRegistry
and asks it to register generated API functions.
Then switch DnsResolve over to get registered this way.
Along the way, notice that DNSResolve is capitalized using an untenable style. Fix that.
Fixes since original 127159:
- change name of build rule to gen_bundle_api
- actually add per-file dependencies to .gyp (this was why clean builds
failed)
- change 'outputs' to match the emitted filename, fixing a needless
rebuild problem.
- split the top-level build action that was a part of
json_schema_compile.gypi, and include it only in api.gyp, thus fixing
the problem where json_schema_compiler_tests.gyp was asking it to create
outputs in the tools/json_schema_compiler_test directory, again causing
needless work during the build process.
BUG=none (essential plumbing work)
TEST=same as before.
Review URL: https://chromiumcodereview.appspot.com/9716003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionFunctionRegistry. This allows us to generate an additional code block that takes an ExtensionFunctionRegistry and asks it to register generated API functions.
Then switch DnsResolve over to get registered this way.
Along the way, notice that DNSResolve is capitalized using an untenable style. Fix that.
BUG=none (essential plumbing work)
TEST=same as before
Review URL: http://codereview.chromium.org/9666059
TBR=miket@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9701105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to generate an additional code block that takes an ExtensionFunctionRegistry and asks it to register generated API functions.
Then switch DnsResolve over to get registered this way.
Along the way, notice that DNSResolve is capitalized using an untenable style. Fix that.
BUG=none (essential plumbing work)
TEST=same as before
Review URL: http://codereview.chromium.org/9666059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=code still builds
Review URL: http://codereview.chromium.org/9633001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=calamity@chromium.org
BUG=116580
TEST=JsonSchemaCompilerAdditionalPropertiesTest.ReturnAdditionalPropertiesResultCreate
Review URL: https://chromiumcodereview.appspot.com/9633018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/9623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Extend .gyp to pass certain .idl files to compiler.py.
- Implement a translator taking IDL parser output and creating
a schema that the JSON compiler recognizes.
- Convert one API to IDL using asargent's JSON cat JSON-to-IDL
converter, and adapt API's implementation to use the newly generated
output.
TEST=no changes
BUG=none
Review URL: http://codereview.chromium.org/9600050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a script to remove comments from the extension api JSON files before
processing for the extension docs. We will now be able to comment in the JSON
files, and they should be much easier to read. Also added the license header
to all the JSON files.
BUG=114233
TEST=Put comments in one of the JSON files and remake the docs. They will make
with no problems.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124660
Review URL: http://codereview.chromium.org/9447090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a script to remove comments from the extension api JSON files before
processing for the extension docs. We will now be able to comment in the JSON
files, and they should be much easier to read. Also added the license header
to all the JSON files.
BUG=114233
TEST=Put comments in one of the JSON files and remake the docs. They will make
with no problems.
Review URL: http://codereview.chromium.org/9447090
TBR=cduvall@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9582013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a script to remove comments from the extension api JSON files before
processing for the extension docs. We will now be able to comment in the JSON
files, and they should be much easier to read. Also added the license header
to all the JSON files.
BUG=114233
TEST=Put comments in one of the JSON files and remake the docs. They will make
with no problems.
Review URL: http://codereview.chromium.org/9447090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support and tests for more json types. Also fixed a number of API jsons.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9491002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
new 'dependencies' property in the jsons. Refactored to avoid code duplication. Added tests for new features and where tests were lacking.
BUG=
TEST=unit_tests --gtest_filter=JsonSchemaCompiler*
Review URL: http://codereview.chromium.org/9456007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9481027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than iframes. It's a bit neater, and fixes the back button problem.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9466045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make the URL path reflect the navigation location.
- make the renderered file determined by the hashtag (which gives support for
things like going back/forward etc).
- make the chosen highlighter cached in localStorage for refreshes.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9452042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Python server that runs the compiler on a json and shows the compiled output.
Run with 'python tools/json_schema_compiler/previewserver.py [port]'.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9427027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
json_schema_compiler: add support for enum properties and tests for enums
BUG=
TEST=
Review URL: http://codereview.chromium.org/9424045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=calamity@chromium.org
BUG=None
TEST=
Review URL: https://chromiumcodereview.appspot.com/9425060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add tests for different json cases by compiling test jsons and running C++
tests against them. Also fixed bugs where tests failed, removed a dead flag and refactored for readability.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9415001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
match the compiler.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9423035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122725 0039d316-1c4b-4281-b951-d872f2087c98
|